- 20 Aug, 2019 40 commits
-
-
tby authored
To display zero-state local files, we need to get the right icon for the filetype. This adds a helper function to do that, which closely mirrors the extension->icon mapping in file_manager/common/js/file_type.js. Bug: 959679 Change-Id: Ib0b9b77a62843e1e84a6f0494dc234e0660fe9d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755564Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#688396}
-
Chinglin Yu authored
This fixes a shutdown race in destroying the JankMonitor instance that fails some tests intermittently. In JankMoitor::Destroy(), shutdown of MetricSource and the monitor thread happens concurrently, which may result in a race that the monitor timer is stopped in destroying the monitor thread and then restarted by a task running on UI or IO thread. Then the timer bound to the monitor thread is destroyed on the UI thread and fail the tests using JankMonitor. Fix the race by making the shutdown sequential: the monitor thread is destroyed after MetricSource is destroyed. Bug: 904785 Test: content unittest: JankMonitorShutdownTest.ShutdownRace Change-Id: Ic4073fa22670ca4532cba99f6e71fab5a93ea40e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753369Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688395}
-
Daniele Castagna authored
gl_copy_texture_CHROMIUM_unittest currently tests copies of 8x8 textures. When glCopySubTexture is used, the full texture is copied. This patch adds a test, GLCopyTextureCHROMIUMES3Test.BigTexture, that tests a copy of a 1080x1080 textures, additionally, when glCopySubTexture is used, there will be two copysubtexture copying two different subrects that cover the whole texture. This tests is for crrev.com/c/1730549. Bug: 991668 Test: The new test fails without crrev.com/c/1730549 Change-Id: I2dfecf35aff974a64deafef5d457960d81fa0a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735587 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#688394}
-
Hiroki Nakagawa authored
This class will be used for dedicated workers, too. Bug: 945673 Change-Id: I88ea5c8c8f61f3a4ccb61f89c7a960a34634b5a1 Tbr: hayato@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758027 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#688393}
-
Wei-Yin Chen (陳威尹) authored
Bug: 930970, 930965, 930972 Change-Id: I3b48baa250665d00eebe37bfff7b3b2e97b2f3b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757396Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#688392}
-
Ken Rockot authored
Updates the Preferences Service to support multiple independent clients (with independent observable pref concerns) to connect over the same PrefStoreConnector pipe. This is accomplished by adding an optional Token parameter to the Connect() message which browser code can provide to uniqueify an individual Connect call. The API change is temporary and can be removed once Prefs Service itself is pulled off of the Service Manager. Bug: 995404 Change-Id: Ib33378bcffb16a3742c67804d6778ba5633adc1d Tbr: hansberry@chromium.org Tbr: wutao@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761403 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#688391}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/df7093214c55..a44d67c6e809 git log df7093214c55..a44d67c6e809 --date=short --no-merges --format='%ad %ae %s' 2019-08-20 ehmaldonado@chromium.org depot_tools: Add python3 to win bootstrap. Created with: gclient setdep -r src/third_party/depot_tools@a44d67c6e809 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: None Change-Id: I2ea33714297e73d173ea1b184af3ab44f18a3359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761661Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688390}
-
Chinglin Yu authored
In ProfileProviderFeatureParamsTest, ScopedFeatureList is destroyed after exiting the test function, while ProfileProvider::Init() sets up each registered collectors on its own dedicated seqneuce. The collector might access FieldTrialList while ScopedFeatureList is destroyed, causing UAF. Fix by adding TestBrowserThreadBundle::RunUntilIdle() to finish the setup of collectors before destroying ScopedFeatureList. --gtest_repeat=1000 --gtest_break_on_failure Completes without crash. Bug: 994475 Test: gdb --args unit_tests --gtest_filter="ProfileProvider*.*" \ Change-Id: Id9b66d9cd0fae956a5bc59779c92ad0846f35196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757962Reviewed-by:Gabriel Marin <gmx@chromium.org> Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688389}
-
John Z Wu authored
Change-Id: Ie7190f73dc90de5bc99d5e9df5080df77035f109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761608Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#688388}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f2e04cc7654d..b779cee96613 Created with: gclient setdep -r src-internal@b779cee96613 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Id53ae88096c1286ea9114d794463ed395ada6922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761660Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688387}
-
Evan Stade authored
Use vector icon definitions (i.e. gfx::VectorIcon) instead of pre-painted images created from vector icons (i.e. gfx::Image). Bug: 989353 Change-Id: I448d3b470596b2e82dd44b2a961ee00e00cef1fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756848Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#688386}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id18c54a6736fa7cc338711ec9c6a882e5bb51bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761663Reviewed-by:
-
Yun Liu authored
Each test method only generates ONE coverage(.exec) file, so that there is no need to pull the whole directory out every time. The benefit is if no coverage data generated for some reason, it will raise and catch the exception for debug, instead of pulling an empty "coverage/" directory out. Bug: 843307 Change-Id: I5509cf2c4a99036ca2409602108cce9477af8d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742382Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#688384}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5f152f07455c..52a6a40535b0 git log 5f152f07455c..52a6a40535b0 --date=short --no-merges --format='%ad %ae %s' 2019-08-19 liyuqian@google.com Add savelayer_with_backdrop GM to benchmark Created with: gclient setdep -r src/third_party/skia@52a6a40535b0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: None Change-Id: I7daf6afb7d28db59b3162e405f88c829f13e80fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758668Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I32779e07a79d3fd59c00a1d313166eb39c2109c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760582Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#688382}
-
John Lee authored
The tab strip is touch device-only and tabs will be sized such that there is some indication that the tab strip is scrollable. This CL removes the visible scrollbar entirely but still allows the user to scroll. Bug: 989131 Change-Id: Ia12feba3d2ed866fb2f5f92bd2a267c4deb5f981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761470Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#688381}
-
Daniel Murphy authored
Change-Id: Ica9b2a128bad8d97983449ba560bfee5bee9e806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758713 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#688380}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1f288d915d10..939b6b1f1c56 git log 1f288d915d10..939b6b1f1c56 --date=short --no-merges --format='%ad %ae %s' 2019-08-19 dberris@chromium.org PinpointScheduler: Backwards compatibility for find_isolate Created with: gclient setdep -r src/third_party/catapult@939b6b1f1c56 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:988912 Change-Id: I5357f5c953b8b5799837be2dd5b9c03ef9ef71c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760686Reviewed-by:
-
Johannes Henkel authored
And fix the fallout. BUG=991325 Change-Id: I4ab49b139ec38b8c8f4557fd0d5c004e454fa419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750045 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#688378}
-
Ce Chen authored
The reason why we should apply demotion before dedup, is dedup will prefer suggestions with higher relevance (which might be on device, and remove its dup with lower relevance, which might be server side). Imagine this example: we have on device suggestions (and its relevance): sugg1(1100), sugg2(1099), sugg3(1098) and server suggestions sugg2(600), sugg4(599). Now the dedup will prefer sugg2(1099) and remove server side sugg2(600). Then after demotion, the final result list will be sugg4(599), sugg1(598), sugg2(597, which is from on device), sugg3(596), where the correct list should be sugg2(600, from server side), sugg4(599), sugg1(598), sugg3(597). Applying demotion first will ensure no on device suggestion has a higher relevance such that the example above will never happen. Bug: 925072 Change-Id: Ic1b8a2de1e602802b59d93e1971387f0ae7e67ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760685Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Ce Chen <cch@chromium.org> Cr-Commit-Position: refs/heads/master@{#688377}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Idea4138b8a18429a68a5c64e48da9051ebddc055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760864 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#688376}
-
Maggie Chen authored
Bug: 949839 Change-Id: I5939069144719c501209af3cda3b7693f61f8866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682315 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#688375}
-
Kent Tamura authored
Now IDR_AUDIO_SPATIALIZATION_T000_P000 is not defined on any platforms. This CL has no behavior changes. Bug: 983396 Change-Id: Ibb62eb16c949810ce7124f96db937d7072a8538a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760577Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#688374}
-
Tommy Steimel authored
This CL updates the GMC toolbar button's tooltip string from "Global Media Controls" to "Control your music, videos, and more" Bug: 991271 Change-Id: Ie2554ac6102421e7f12f80b2dc64c16f9eeb4f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758218Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#688373}
-
Bill Budge authored
- Adds a time histogram to measure how long deserializing a compiled Wasm module from the code cache takes. Bug: chromium:992991 Change-Id: Ia6b87f73f893350a50da554a25e2e36a55bb11df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761257Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#688372}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1c3b93db4826..f2e04cc7654d Created with: gclient setdep -r src-internal@f2e04cc7654d The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I3097fce9c2997fa96484d9b9ed06f0480376bcbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761425Reviewed-by:
-
Martin Kreichgauer authored
currently DCHECKs that the Windows authenticator only fails with (kKeyAlreadyRegistered is possible too, e.g.). Remove the DCHECK entirely because even if we got a correct list of errors now, it's prone to break with future changes to the authenticator or Windows, while not providing any obvious value. ChromeAuthenticatorRequestDelegate: :DoesBlockRequestOnFailure() InterestingFailureReason: :kUserConsentDenied. This is not correct Change-Id: Ic1a0b377480262585444b93c7edf5487e5e9def8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759288Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Cr-Commit-Position: refs/heads/master@{#688370}
-
Gayane Petrosyan authored
Bug: None Change-Id: I5a14fdd40764b3aeaf32f6080d942bc1b1466a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761227 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#688369}
-
Gayane Petrosyan authored
Fix the line height to take exactly as much space as the specified font. Otherwise, if it takes more space then vertical alignment doesn't work as button doesn't have enough height. Bug: 990956 Change-Id: I45746cc8cf6863acb58880b83fad3f41feba7abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761219Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#688368}
-
Gayane Petrosyan authored
Previously unused themes were uninstalled when no infobars were present. But now when themes can be reverted ChromeColorsService, counting infobars is not sufficient for preventing uninstall of necessary themes. This CL adds ThemeReinstaller class that will update the of number of existing reinstallers and will call RemoveUnusedThemes when there are no reinstallers left. This CL also removes ignore_infobars param from RemoveUnusedThemes as it is not relevant anymore. Bug: 985001, 991715 Change-Id: Ia3905ee2d8c5fb238c8d6a380d17ed9d3018e2a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757067Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#688367}
-
Peter Boström authored
require-corp.https.html version wasn't enough to disable. Sample failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/82507 TBR=tnagel@chromium.org Bug: chromium:626703, chromium:995129 Change-Id: Ic500ae18dab4d54b436bc0540af304e8406f5138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761516Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#688366}
-
Gyuyoung Kim authored
This CL converts |client_biding_| from mojo::Binding to mojo::Receiver. Then, the name is also changed to |client_receiver_|. Besides, this CL converts the type of |sensor_| to mojo::Remote as well. Bug: 955171 Change-Id: Ic7b14f718fe1229fb19a6f1fa68618f8707d2e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757953Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#688365}
-
John Z Wu authored
This is so it can be reused in other unittests. Change-Id: I752a5929e521d9cc24519a9d2d3a5a73bb0f6aef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757069Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#688364}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d41929adaddf..451ed2dbac83 git log d41929adaddf..451ed2dbac83 --date=short --no-merges --format='%ad %ae %s' 2019-08-19 tsepez@chromium.org Move some CPDFXFA_Widget specific methods out of CPDFSDK_Annot 2019-08-19 thestig@chromium.org Remove an impossible condition in CPDF_CMapParser::ParseWord(). Created with: gclient setdep -r src/third_party/pdfium@451ed2dbac83 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Ie1501e09262376ef751550c598a9cc88594c2c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761495Reviewed-by:
-
Sinan Sahin authored
Push back the expiry milestones of enable-android-night-mode, enable-android-web-contents-dark-mode, enable-revamped-context-menu and force-enable-home-page-button as the experiments are still ongoing. Bug: 995468, 995470 Change-Id: Idbe75661baf22d79d84c0ade9e07e9d025c19601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761160Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#688362}
-
Erik Chen authored
Change-Id: I64fc3fb04dd2e3e3f827f2c0a72917471ac0a403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761329Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#688361}
-
Malay Keshav authored
If the device scale factor of a layer changes while it is undergoing a transform animation, it may result in a crash. This is because during a device scale factor change operation, all transform animations are cancelled leading to a call being made to animation observers of the transform animation. The observers can then delete the layer or some other layer in the hierarchical traversal. This can result in a seg fault crash. Bug: 987300 Test: Added unit test for the crash. Change-Id: I8842e4b39daf59e4068497a3d662fda7f921b729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757126Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium a68d66fc. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I045f55a4e66cb085d1fda96107b84fd5030b71f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760419Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688359}
-
Chase Phillips authored
This replays the cache solution from CacheStorage implemented in https://crrev.com/c/1518592. Bug: 941118 Change-Id: Id3f41cb2abed2efe8ced2525b0122965b44e22e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759321Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#688358}
-
Olivier Li authored
Bug: 969139 Change-Id: I35d551b6bdb41b4e6bd7689120c21d9d683ad72f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733747 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#688357}
-
