GitLab

BUG=555865

Review-Url: https://codereview.chromium.org/2353053002
Cr-Commit-Position: refs/heads/master@{#419957}

This CL adds arrow-key navigation to the main history list and makes a
single history item tab-navigable by using cr.ui.FocusRow and
iron-list's tab index property.

BUG=623011
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2334553002
Cr-Commit-Position: refs/heads/master@{#419956}

De-virtualize ExtensionFunction::SendResponse() and contain all work in
a single SendResponseImpl()* method, which is private to
ExtensionFunction and can only be invoked through the Respond() methods.
This is a first step in isolating results_, error_, and the response
invocation in order to ensure consistent and clear results from
functions.

Update UIThreadExtensionFunction implementations that used SendResponse()
rather than Respond().

For compatibility, introduce SendResponse() methods on legacy
ExtensionFunction classes (ChromeUIThreadExtensionFunction and
AsyncExtensionFunction) which wrap around Respond(). As functions are
converted, this wrapper will go away.

Also remove the unused ExtensionFunction::OnRespondingLater().

*SendResponseImpl() instead of SendResponse() so that we don't have to
rename existing calls in legacy functions.

BUG=648275

Review-Url: https://codereview.chromium.org/2351823004
Cr-Commit-Position: refs/heads/master@{#419955}

Sticky position is a layout offset and should not be affected by transforms.

BUG=648683
TEST=LayoutBoxModelObjectTest.StickyPositionTransforms

Review-Url: https://codereview.chromium.org/2346383005
Cr-Commit-Position: refs/heads/master@{#419954}

Allows easy searching on the chrome://flags page.

BUG=647529

Review-Url: https://codereview.chromium.org/2335343010
Cr-Commit-Position: refs/heads/master@{#419953}

BUG=647371

Review-Url: https://codereview.chromium.org/2357023002
Cr-Commit-Position: refs/heads/master@{#419952}

This CL clears LifecycleObserver::m_context when LifecycleObserver::contextDestroyed gets called.
This means that LifecycleObserver::context() starts returning false after the context gets destroyed.

The new behavior makes a lot of more sense, but the problem is that some existing code is assuming that
LifecycleObserver::context() keeps returning the context even after the context gets destroyed.
This CL fixed the problematic code to make all layout tests pass, but I'm not sure if I've updated all of the problematic code
(because the coverage of the layout tests is not sufficient).
However, the worst thing that can happen is that code that had been assuming that LifecycleObserver::context()
returns a context even after the context gets destroyed will stop working (it may cause a null-deref crash).
I think the risk is low.

BUG=610176

Review-Url: https://codereview.chromium.org/2317483005
Cr-Commit-Position: refs/heads/master@{#419951}

This will allow us to use it for the computed CSSStylePropertyMap for CSS Typed OM.

BUG=545318

Review-Url: https://codereview.chromium.org/2349633002
Cr-Commit-Position: refs/heads/master@{#419950}

This CL prevents creating WebAPKs via the add-to-homescreen menu item:
- If the Web Manifest does not contain any icons
- If any URL in the Web Manifest contains a username and password

This makes the logic in add_to_homescreen_data_fetcher.cc match the logic in
app_banner_manager_android.cc

BUG=648491
TEST=None

Review-Url: https://codereview.chromium.org/2349263003
Cr-Commit-Position: refs/heads/master@{#419949}

This has been useful in my debugging, and could be useful to authors as well.

BUG=148757

Review-Url: https://codereview.chromium.org/2354873006
Cr-Commit-Position: refs/heads/master@{#419948}

SetCursor can crash in rare circumstances when no event has been
processed yet, but SetCursor is called by the client.
Adds line to initialize the cursor widget if it does not exist.

BUG=chromium:648724
TEST=none

Review-Url: https://codereview.chromium.org/2355953003
Cr-Commit-Position: refs/heads/master@{#419947}

This patch builds on [1] and adds position: sticky main thread scrolling
reasons to the blink and cc scroll property trees. Position: sticky
disables threaded scrolling because the compositor is not yet
able to update these.

Incremental updates are not yet possible but TODOs and tests have been
updated to ensure the main thread scroll reasons are recomputed.

[1] https://crrev.com/6da0810c8c2362fc73d911750400ccd5c33cd6ca
BUG=644514
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2353843002
Cr-Commit-Position: refs/heads/master@{#419946}

Updates Plugins => Flash in Options Content Settings.

Also updates the radio button text as:

HBD On
  Allow sites to run Flash
  Ask first before allowing sites to run Flash (recommended)
  Block sites from running Flash

HBD Off
  Allow sites to run Flash
  Detect and run only important Flash content (recommended)
  Block sites from running Flash

UI Approved. See bug.

BUG=622922
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2296073002
Cr-Commit-Position: refs/heads/master@{#419945}

Now we do not have any -intervention.html specific flakiness, but
still font-display.html and font-display-intervention.html are a little
flaky on Win7 platform probably due to the same reason.

BUG=571376, 564109

Review-Url: https://codereview.chromium.org/2358543002
Cr-Commit-Position: refs/heads/master@{#419944}

There is a race condition issue, the media router dialog will be closed
immediatly after gets the response for creating route. But we execute
javascript to choose sink on media router dialog, the dialog is closed
before the javascript results are sent back to C++ code, which causes
timeout.

The fix is to execute javascript to choose sink on media router dialog,
but don't wait to get the results.

BUG=637141

Review-Url: https://codereview.chromium.org/2352243002
Cr-Commit-Position: refs/heads/master@{#419943}

Set flags.

https://codereview.chromium.org/2359613002/

Use Cubic when kBBR option is specified.

Merge internal change: 133469673

https://codereview.chromium.org/2352043004/

Limit QUIC's Cubic CWND increases to 1/2 the bytes acked when in
congestion avoidance. Protected by ENABLED
FLAGS_quic_limit_cubic_cwnd_increase.

Merge internal change: 133421910

https://codereview.chromium.org/2351963005/

Close connection when packet generator is trying to add a frame which
alone cannot fit into a packet. Protected by ENABLED
FLAGS_quic_close_connection_on_huge_frames.

Merge internal change: 133419402

https://codereview.chromium.org/2351303003/

Print the QuicReceivedPacketManager's ack frame instead of the
QuicPacketGenerator's ack frame to print connection debug info and
remove QuicPacketGenerator's ack frame.  Small functional change to
print useful data.

The ack frame being printed previously was never used, so would always
be in the default initialized state.

Merge internal change: 133400163

https://codereview.chromium.org/2353123002/

Extra error logging for missing SCT.  Not flag protected.

Merge internal change: 133256313

https://codereview.chromium.org/2356873002/

Only inform QUIC's SentPacketManager of packets that are actually sent,
not those that failed to be sent.  Protected by
FLAGS_quic_only_track_sent_packets.

Merge internal change: 133209233

https://codereview.chromium.org/2353063002/

QUIC enable server push by default. Guarded by
FLAGS_quic_enable_server_push_by_default.

Enable server push by default for QUIC versions 35 and higher.

Also adds support so that push can be disabled using HTTP/2
SETTINGS_ENABLE_PUSH.

Merge internal change: 133188946

https://codereview.chromium.org/2350173005/

Use refcounted ownership for ValidateClientHelloResultCallback::Result

This CL switches ValidateClientHelloResultCallback::Result to use
refcounted ownership semantics.  This has no effect in current code, but
will be useful in solving some object lifetime issues as more codepaths
are asynchronized.

Change to refcounted ownership for
ValidateClientHelloResultCallback::Result.  No functional change beyond
this intended, not flag-protected.

Merge internal change: 133129391

https://codereview.chromium.org/2353763002/

Adds CryptoHandshakeMessage::HasStringPiece method.

Merge internal change: 133121236

https://codereview.chromium.org/2355493004/

Only close the QUIC connection after 5RTOs on the client side when the
5RTO connection option is present. Protected by ENABLED
FLAGS_quic_only_5rto_client_side.

For users with relatively short RTTs, the 5th RTO on the server side can
occur before the client sends a PING.  In networks with short NAT
timeouts, this causes the connection to be abruptly closed once the NAT
tunnel is re-opened by the client's PING, instead of receiving the
response.

Merge internal change: 133030062

https://codereview.chromium.org/2349373002/

Add method QuicBufferedPacketStore::DiscardPackets

This CL adds a method to QuicBufferedPacketStore to discard all packets
associated with a connection ID.  This functionality will be used where
a CHLO is followed by a bunch of packets which get buffered while the
CHLO is being processed by the stateless rejector logic. If the CHLO is
rejected, the dispatcher will want to drop the buffered packets without
processing them.

Added new method not yet called. No functional change, not
flag-protected.

Merge internal change: 132995934

https://codereview.chromium.org/2351673003/

Fix bizarro comment formatting

Merge internal change: 132917785

https://codereview.chromium.org/2346323003/

Deprecate FLAGS_quic_close_connection_on_packet_too_large.

Merge internal change: 132914520

https://codereview.chromium.org/2352803002/

Deprecate quic_simple_packet_number_length_2.

Merge internal change: 132911786

https://codereview.chromium.org/2354563003/

Deprecate FLAGS_quic_remove_v33_hacks.

Merge internal change: 132908836

https://codereview.chromium.org/2351813002/

Deprecate FLAGS_quic_do_not_send_ack_on_emsgsize.

Merge internal change: 132907311

https://codereview.chromium.org/2350863002/

Deprecate FLAGS_quic_postpone_multipath_flag_validation.

Merge internal change: 132904436

https://codereview.chromium.org/2354673002/

BUG=

Review-Url: https://codereview.chromium.org/2359503003
Cr-Commit-Position: refs/heads/master@{#419942}

If reads are cleared prior to suspend that does not guarantee that
no further read has been started (even when playback rate == 0) since
the renderers may be prerolling buffers.

The abort before suspend actually does nothing but cause additional
churn in some cases. Instead we should destroy the renderer and then
abort any stale state.

BUG=638018

Review-Url: https://codereview.chromium.org/2355173002
Cr-Commit-Position: refs/heads/master@{#419941}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/2ad289dbd9e6975d7348be8e84d30e24b924501f Switch NaCl SDK release builders from svn to git (sbc@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=648344

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2357813002
Cr-Commit-Position: refs/heads/master@{#419940}

This CL adds an implementation of GetLoadTimingInfo
in BidirectionalStreamQuicImpl. This is a part of the effort
to expose timing metrics to net embedders.

BUG=648346

Review-Url: https://codereview.chromium.org/2354653003
Cr-Commit-Position: refs/heads/master@{#419939}

This CL adds an implementation of GetLoadTimingInfo in
BidirectionalStreamSpdyImpl. This is a part of the effort to
expose timing metrics to net embedders.

BUG=648346

Review-Url: https://codereview.chromium.org/2356463002
Cr-Commit-Position: refs/heads/master@{#419938}

https://chromium.googlesource.com/skia.git/+log/e918417dc34c..4d450d24f5a7

$ git log e918417dc..4d450d24f --date=short --no-merges --format='%ad %ae %s'
2016-09-20 bungeman Remove SK_ADDING_src_ports_SkFontConfigInterface_cpp
2016-09-20 fmalita [SVGDom] Opacity optimization
2016-09-20 mtklein Blacklist serialize-8888 typefacerendering_pfaMac
2016-09-20 mtklein GN: fold :vulkan into :gpu.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=borenet@google.com

Review-Url: https://codereview.chromium.org/2354993004
Cr-Commit-Position: refs/heads/master@{#419937}

BUG=629009
R=tommycli@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2353513005
Cr-Commit-Position: refs/heads/master@{#419936}

This removes the external begin frame source setting and establishes
that the use output surface begin frame source is the only path
to providing begin frame sources.

This also removes all of the plumbing in the scheduler and the proxies
to pass along the external begin frame source in favor of just having
the CompositorExternalBeginFrameSource set it on the scheduler.

TBR=nyquist@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2324273002
Cr-Commit-Position: refs/heads/master@{#419935}

We cannot distinguish invalid email addresses
which web developers mistakenly specified.

BUG=638455

Review-Url: https://codereview.chromium.org/2339493002
Cr-Commit-Position: refs/heads/master@{#419934}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/9f0befafcd15..e979fa345e7e

$ git log 9f0befafc..e979fa345 --date=short --no-merges --format='%ad %ae %s'
2016-09-20 eakuefner [Dashboard] Simplify GuessMetric

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2356843003
Cr-Commit-Position: refs/heads/master@{#419933}

BUG=b:31295501

Review-Url: https://codereview.chromium.org/2351733002
Cr-Commit-Position: refs/heads/master@{#419932}

This allows pointer properties to be passed along with MouseEvents
to the PPAPI.

BUG=647045

Review-Url: https://codereview.chromium.org/2344693002
Cr-Commit-Position: refs/heads/master@{#419931}

arrow that is used in layout tests. This modification allows the
arrow to look the right size in different device scale factors when
using zoom-for-dsf. This is achieved by using a square drop down
arrow instead of a rectangular one. This logic is similar to what
the native theme engine uses.

BUG=640256
COMPONENT=Test Runners, Mock Web Theme Engine
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2340633002
Cr-Commit-Position: refs/heads/master@{#419930}

Some Latin keyboard apps use this function to check whether they need to
capitalize a letter at the current cursor. Delegating to TextUtil just as
BaseInputConnection#getCursorCapsMode() does.

BUG=648439

Review-Url: https://codereview.chromium.org/2349383004
Cr-Commit-Position: refs/heads/master@{#419929}

Revert of services/shell: Turn on sandboxing for mojo apps. (patchset #9 id:180001 of https://codereview.chromium.org/2338793003/ )

Reason for revert:
Causes a timeout on mash_browser_tests.

Original issue's description:
> services/shell: Turn on sandboxing for mojo apps.
>
> Turn on sandbox for mojo apps by default. Apps that need to run
> without a sandbox need to include 'shell:unsandboxed' in their
> capabilities in manifest for mojo:shell.
>
> Update manifests for mojo:ui, mojo:font_service, mojo:file_system,
> and mojo:leveldb services to include 'shell:unsandboxed'.
>
> BUG=645602, 646376
>
> Committed: https://crrev.com/43aa4f706d6020c93f11fa952d7f1d7a7337c570
> Cr-Commit-Position: refs/heads/master@{#419891}

TBR=rockot@chromium.org,ben@chromium.org,tsepez@chromium.org,sadrul@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=645602, 646376

Review-Url: https://codereview.chromium.org/2353783004
Cr-Commit-Position: refs/heads/master@{#419928}

BUG=638642

Review-Url: https://codereview.chromium.org/2319863005
Cr-Commit-Position: refs/heads/master@{#419927}

* Introduces an StoreUdpateResult object to carry the result of update in unique ptr.
* Propagates the changes to consumers of the store.
* Adds/Updates tests.

BUG=645522

Review-Url: https://codereview.chromium.org/2343743002
Cr-Commit-Position: refs/heads/master@{#419926}

TBR=michaelpg
BUG=644998

Review-Url: https://codereview.chromium.org/2350303004
Cr-Commit-Position: refs/heads/master@{#419925}

While implementing the views drag implementation, I had thought that you
didn't need to return this value, as nothing in views uses it. However,
it does get used in WebContents, so add it in.

BUG=614037

Review-Url: https://codereview.chromium.org/2349973010
Cr-Commit-Position: refs/heads/master@{#419924}

SkImage::MakeRasterCopy already does a copy, so there is no need to do another.

Review-Url: https://codereview.chromium.org/2348263005
Cr-Commit-Position: refs/heads/master@{#419923}

ContentViewCore holds selection rectangle in physical pixels,
thus making it indirectly dependent on DIP scale.

This CL changes it to DIP and does the necessary conversions
in Java layer. As a consequence the position of the paste popup
dialog is also passed from native layer in DIP.

BUG=620929

Review-Url: https://codereview.chromium.org/2352143002
Cr-Commit-Position: refs/heads/master@{#419922}

Downloads stuff:
* Add a function to DownloadManagerService that queries whether
  a MIME type is supported for display in Chrome.

* When opening a file via Download Home, query whether the file
  type is supported.  If so, send it to a new tab instead of
  Intenting out.

* Move Share and View intent code out to DownloadUtils and expose
  constants everywhere to allow this to happen.

* Removed periods from download notification Strings.

Custom Tab stuff:
* Added a "media viewer" intent extra that makes Custom Tabs
  opened by Download Home hide unnecessary menu items.

BUG=616324,648454

Review-Url: https://codereview.chromium.org/2343363005
Cr-Commit-Position: refs/heads/master@{#419921}

The expectations were eagerly removed because the test passed on Linux
Intel, but it still doesn't pass on Linux AMD and Linux Intel ANGLE

TBR=zmo@chromium.org
BUG=634525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
NOTRY=true

Review-Url: https://codereview.chromium.org/2356773002
Cr-Commit-Position: refs/heads/master@{#419920}

Previously, the layout tree and pixel dump could happen while the lifecycle
was dirty.

Review-Url: https://codereview.chromium.org/2352813004
Cr-Commit-Position: refs/heads/master@{#419919}

Decodes the results from the Contextual Cards section of the response to set
caption and thumbnail.

BUG=647041

Review-Url: https://codereview.chromium.org/2351283002
Cr-Commit-Position: refs/heads/master@{#419918}