- 07 Jan, 2021 40 commits
-
-
Alison Maher authored
To handle layout of OOF positioned elements inside a nested fragmentation context, we will delay layout of the OOFs until they've reached the outermost context, at which point they will get laid out inside the inner multicol in which their containing block was found. This change stores such inner multicols in the container builder and physical fragment as a means to propagate the associated inner multicols up to the outer context where their OOFs will be laid out. This change also adds logic to halt the propagation of OOF positioned fragmentainer descendants up the tree if we've reached a multicol. In this case, we would know that we are in a nested context, and any OOFs that have reached their containing block should remain in the inner multicol's physical fragment rather than continuing up the tree. See design doc for more details: https://docs.google.com/document/d/13Pn7SSJjzskg9kQ4jErzlJrj2j4zGBfNBFLEeDVENUU/edit?usp=sharing Note: The OOF elements inside a nested context are not yet getting laid out, which will cause related tests to crash. This will be addressed in follow-up changes. Bug: 1079031 Change-Id: I87399a67c6fc5021f3323afe8fae0b15e6e13eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612392 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#841140}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609988385-9c096aa1bc5d021f182b9150cd47fcb15e7461d7.profdata to chrome-win64-master-1610009713-6f95aef060564dd70c8d09ec603d31a9c7b42ed0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If22004de98c832154e26fb81d53f84f3223a0b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614189Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841139}
-
Kyle Horimoto authored
This reverts commit 3ece5c0f. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1163902 Original change's description: > Move crostini section under Advanced in settings. > > Bug: 1163003 > Change-Id: I9b2b439007c80bc0385128da4817ac001ee7eb0c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610407 > Auto-Submit: Nicholas Verne <nverne@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840920} TBR=khorimoto@chromium.org,nverne@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I77bde9769710657da5d0992728dd53006a83de2c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1163003, 1163902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615667 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#841138}
-
wutao authored
When ambient mode starts and exits, it will change the video visibility and update the video wake lock. For example, when a video is playing in browser, it will request a video wake lock to prevent screen dim and off. However, when we lock the screen while playing the video in an active tab, the ambient mode will start after several seconds. Ambient widget covers the fullscreen and change the browser visibility to not visible and release the video wake lock. After some time, screen is turned off and ambient mode exits. The browser visibility becomes visible again and acquire the video wake lock again and turn on the screen. The screen on event will start ambient mode in a few seconds again. To fix this bug, we set the opacity of the ambient widget to be translucent, which will not change the browser visibility and therefore the video wake lock. As long as the video wake lock is held, the ambient mode will not exit since there is no dim event. Bug: b/173806284 Test: manual Change-Id: I0bb7f3c8f6fdeb04d9831a85ffe97eeb769f3b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612386 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#841137}
-
Gavin Williams authored
Make whole row clickable to match the behavior of the More settings button. Bug: 1059779 Change-Id: Ia1da833b14cb835e090f3f37fb47faeef3c948be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613920Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#841136}
-
Jeffrey Kardatzke authored
BUG=1146646 TEST=Verified UI only shows hostname in dialog Change-Id: I80df7f5f0c5d582649e9cf30c9dfd00f65407d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615298 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Evan Stade authored
This required adding deps, which in turn created circular includes. To address this, the patch * moves settings_namespace.{cc,} into the //extensions/browser target * passes the task runner from GetExtensionFileTaskRunner() as a parameter into value store code Bug: 1158986 Change-Id: I91ae5c90d82c5cbe5eb1d2a62cd1dd65a003e74c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601640Reviewed-by:Erik Staab <estaab@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#841134}
-
rbpotter authored
The only valid use case involved the chrome://devices page, which has been removed. Bug: 1100748, 1162164 Change-Id: Ie1d62eecd00cec5e35fb76e7398c0ab40ea95b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585562Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1c3c93911966..e856b6bba826 2021-01-07 gbeaty@chromium.org Enable set_output_commit to be used with RevisionFallbackChain. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1141886,chromium:1159749 Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I5f92f9c4030573dc4cf825d76b0277554002152c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615180Reviewed-by:
-
Shane Fitzpatrick authored
calls. Instances found by searching for references to that field Fixed: 1162476 Change-Id: If64e74dd79e7c17859c3a7699e34abc497f9cc36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613358 Commit-Queue: Shane Fitzpatrick <shanefitz@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#841131}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/be0b3b7363a9..bdc3d3c60fa9 2021-01-07 johnstiles@google.com Simplify map of SPIR-V numeric constants. 2021-01-07 johnstiles@google.com Flatten nested vector constructors when emitting SPIR-V. 2021-01-07 johnstiles@google.com Implement getBVecComponent. 2021-01-07 csmartdalton@google.com Revert "Disable tessellation when we don't have indirect draw support" 2021-01-07 johnstiles@google.com Add getConstantBool as a sibling of getConstant(Int|Float). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1163441 Tbr: johnstiles@google.com Change-Id: I4cbdd09ef396746aa0ff0709b03e8baf93758597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614726Reviewed-by:
-
edchin authored
Bug: 1163074 Change-Id: I126b46a7ed308d6ab000f12206d1f050fd3e92d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615103 Commit-Queue: edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#841129}
-
Gavin Williams authored
Currently when a scan completes a PDF is created without checking if the scan was successful. This change checks to see if scan fails before attempting to create the PDF. Also |save_failed_| will be set when the PDF creation fails. Bug: 1059779 Change-Id: I84bf426e33da6840c13cce3195bfaa111ff7c6dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612053Reviewed-by:
-
Emily Stark authored
When a subframe main resource loads in spite of a certificate error (usually because the user has previously bypassed the same certificate error for a main frame load), Chrome downgrades the omnibox security UI to indicate that not all resources on the page are loaded securely. The browser test for this UI downgrade was flaky, which turned out to be because the check for a suframe certificate error occurred in Blink during document loading, and the notification to the browser process occasionally got dropped, presumably because of some race related to unloading the previous document. I didn't figure out the exact cause of the test flake because this logic better belongs in the browser process anyway; it was implemented pre-PlzNavigate, and now it makes more sense to simply check for subframe certificate errors in a navigation throttle, just like we do for mixed content. This CL therefore moves this certificate error check into MixedContentNavigationThrottle. A bit of extra plumbing is needed to ensure that URLLoader reports the SSLInfo on the response when there is a certificate error for a subframe main resource. URLLoader only reports the SSLInfo when needed on the response as an optimization (since SSLInfos can be quite large), and we're now adding a new scenario in which it's needed. But this additional SSLInfo reporting should be rare because it's only relevant when the user has clicked through a certificate error. The test was previously flaking reliably and I verified that it now passes 1000 times locally. Bug: 1106370 Change-Id: I64d323ca99ae0ab8262bbb1c1efce46a04f73eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606194 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#841127}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. Tbr: sky@chromium.org Bug: 1145565 Change-Id: I8a6c5867c2bc5e073245e1ee82aed43d44b47632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611553Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#841126}
-
Xiaohui Chen authored
Bug: None Change-Id: If207621ff75593d95028c02d89cb9a95d5777e7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615105 Auto-Submit: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Jeroen Dhollander authored
The OnDeviceAssistant feature was removed a while ago, but apparently I had forgotten the feature flag itself. I grepped and neither |OnDeviceAssistant| nor |marble| are mentioned in the ChromeOS code anymore, so I think I got it all this time. Bug: b/171307059 Test: compiled Change-Id: Iea7e3dd5a89483ec4f9ec71777b126faddb266d8 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612048 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
-
Rahul Goyal authored
This cl contains the set of changes required to show onboarding in a dialog for JITT. Also this cl shouldn't have any user facing changes. Bug: b/174445633 Change-Id: Ib52d3175e1713f573624c1af735aab93f6be1f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610091Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Rahul Goyal <goyalrahul@google.com> Cr-Commit-Position: refs/heads/master@{#841123}
-
Darin Fisher authored
Fixed: 1128971 Change-Id: Ifcf996108f169337e379f8bbcebc7bac87080539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597144 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#841122}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ac4d756a6626..47a632b2ab93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tmartino@google.com,clamy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1155160 Tbr: tmartino@google.com,clamy@google.com Change-Id: I89d9e5538cf92f5c1aa564a67223cc557681f0ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614771Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841121}
-
Sammie Quon authored
These were put on hold because the accelerators were added while capture mode was still being built. Bug: none Test: added tests Change-Id: I213e483edf450464a26d6c547deeb0f665ab9dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613355Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#841120}
-
cfredric authored
would also have been included due to SameSite rules. Bug: 1143756 Change-Id: I443a042e08ed0c091c65e55138c5ad0547a6f652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611946Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#841119}
-
Wei Li authored
Merge SMALL_SHADOW and BIG_SHADOW types into one STANDARD_SHADOW type as they are essentially same. Rename NO_SHADOW to NO_SHADOW_LEGACY as it is only needed to support bubbles on the legacy Win7 platform. We would remove it when win7 is no longer supported. Thus rename to NO_ASSETS to NO_SHADOW. After this change, bubble border shadow types boil down to just two usable types: STANDARD_SHADOW and NO_SHADOW. They represent standard (MD style) shadow and no shadow cases respectively. Fixed: 940027 Change-Id: Icbd18ca0092175aa1e1f53cd511b6c8a5edbc9f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591910Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#841118}
-
Ian Kilpatrick authored
From: https://github.com/w3c/csswg-drafts/issues/5713 Basically these tests stretch an image in one axis, and previously tested that the image should lose its aspect-ratio. When stretching in one axis, and when there is no size constraint in the other axis it should respect the aspect-ratio. Change-Id: Ic1374f50b4d561b3c38b94a4f60724f950e6513e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611567Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#841117}
-
Dale Curtis authored
We've disabled these on Windows and ChromeOS, so it's no surprise that we need to disable them on macOS as well. R=zmo Fixed: 1163111 Change-Id: I406e6ebd1d27da84964e46efb9582ce77f904dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613560Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#841116}
-
Peter Kvitek authored
This is a followup to http://crrev.com/c/2570447 that introduced extra check in OSCrypt::SetRawEncryptionKey() that is now removed. Bug: 1157539 Change-Id: I0d35502068958a93654565301d84ae04e4760272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596873Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#841115}
-
Owen Min authored
Enterprise.MachineLevelUserCloudPolicyEnrollment.* are now expired in June. Enterprise.CloudReporting* are set to expired in 1 year. Enterprise.CloudExtensionRequestUpdated expire date is bumped to Oct. Bug: 1160729, 1160730 Change-Id: I2c245f4a68e5c05a99a4255685eccb1e7ca253bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613464Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841114}
-
cfredric authored
These metrics are only updated for excluded cookies, and their values are whether or not SameParty was the only reason for excluding the cookie. Bug: 1143756 Change-Id: Icc35c59d47269e89f8f37515a7a86d6dc33d0591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611046Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8bf25fa0..d1da011f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I85e440bf284f23cf01907b6c0a1bc66a346cc16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614843Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841112}
-
Joshua Pawlicki authored
As far as I can tell, the actual header is no longer used anywhere. This completes decoupling the flapper targets from the build tree, so they are removed. Bug: 1064651 Change-Id: I18996e13c3dbf9df097b3b964e2b0d2113cfef1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613324Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Anthony LaForge <laforge@chromium.org> Reviewed-by:
-
Richard Townsend authored
The synchronous HTMLDocumentParser mode was incorrectly dispatching preloads for text/plain documents by interpreting their contents as HTML. This CL extends the HTMLDocumentParser's constructor, adds a new enum to disable this behaviour, and a Web Platform Test to show that the unintended prefetching no longer happens. Bug: 1160665 Change-Id: I07902d58e3bc06ce6ecc07c341e997846d6e5a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613008 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#841110}
-
ssid authored
The trace event data source is reset at the start of each test. By this time the test already created the task environment and could have active worker threads which try to add trace events. Move the destruction to the end of tests after the task environment shuts down. BUG=1137225 Change-Id: I54c477d7859161c24575bf9b2060f1eb723d699e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603417Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#841109}
-
Shengfa Lin authored
Use strip with preserve time option so that zipping the same ChromeDriver Linux binary does not generate a ZIP archive with different hash. Bug: chromedriver:3703 Change-Id: Ib978c491f7e398f0597a0dd9478408bdb60d3ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615100 Auto-Submit: Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#841108}
-
Connie Wan authored
This is a no-op for every non-test instance of AddToNewGroup except for here: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/extensions/api/tabs/tabs_api.cc;l=1844 So the editor bubble is still auto-opened in almost every case of creating a new group, except when it happens via an extension. Bug: 1106846 Change-Id: Ide379350893a5a5bc31e2ee653ceacac6c42560e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613786Reviewed-by:
Charlene Yan <cyan@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#841107}
-
Yu Han authored
Prior to this CL, controls-refresh text input is missing its border. The fix is to make sure property text_field.has_border is passed to native theme. This property is only used by form controls-refresh so it has no impact on existing text input. Bug: 1155397 Change-Id: I3cacd4d9550e10388b15122d7ff94a32ffa5e39d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612495Reviewed-by:
-
Alex Ilin authored
TBR: ntfschr@chromium.org Bug: 1163744 Change-Id: Iccf511d117156c6e449d4334ffcbe6cfed1ba3b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615018Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#841105}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/f88c00e45a2f..cbc14b10e623 2021-01-07 wl@gnu.org Fix ABI incompatibility. 2021-01-07 wl@gnu.org Fix typos from last commit. 2021-01-07 apodtele@gmail.com [dlg] Move the headers to include/dlg to simplify their use. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I5006517af70651ff1410f9c21cad6f9101b7c5f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614351Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#841104}
-
Xi Han authored
We disable StartSurfaceTest#testShow_SingleAsHomepage_BackButton__Instant_Return on Android o bots. The original CL description is: In this CL, we introduce a new flag "keepTab" for a Tab with launch type FROM_START_SURFACE. When this kind of Tab is selected from the carousel Tab switcher on the Start surface, or from grid tab switcher, the "keepTab" is set to be true. This guarantees the tab won't be auto deleted from the TabModel when the back button is tapped. More details see doc: https://docs.google.com/document/d/1mZXgQ0fi_b96vcwy1DkgWunl0FutkFwyt-7PrU-Pgjc/edit# Bug: 1155139,1163874 Change-Id: I2b0944c45a0273548d2da91a3def4db5c17f57e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614798Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#841103}
-
Julie Jeongeun Kim authored
This CL fixes up the issue caused by [1]. [1] https://crrev.com/c/2569167 Bug: 1163898, 1008939 TBR: rbpotter@chromium.org Change-Id: Ibfb19bc8f9d59a31ecb32f164deba610b0a32744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614249 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7c54d0e3efb6..ddb981175c35 2021-01-07 jacktfranklin@chromium.org Migrate component_docs/data_grid examples to TS files 2021-01-07 mathias@chromium.org Include .avif and .webp images in *.grd files 2021-01-07 tvanderlippe@chromium.org Enable no-implicit-coercion for all files 2021-01-07 tvanderlippe@chromium.org Enable no-implicit-coercion in front_end/ 2021-01-07 tvanderlippe@chromium.org Fix remaining no-implicit-coercion errors in front_end/ 2021-01-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2021-01-07 bmeurer@chromium.org [e2e] Disable another test to unblock the Chromium roll. 2021-01-07 patrick.brosset@microsoft.com Make sure rulers appear when needed 2021-01-07 tvanderlippe@chromium.org Fix no-implicit-coercion errors in front_end/ 2021-01-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-01-07 bmeurer@chromium.org [e2e] Temporarily disable test to unblock Chromium roll. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1082789,chromium:1144106,chromium:1159309,chromium:1161667,chromium:1161701 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I56f53f2ad0d050f7c2d9078ebf0f03a0332286e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614134Reviewed-by:
-
