GitLab

DisplayResourceProvider wasn't calling ResourceFence->Set(). Because of
this the fence wasn't signaled in SkiaRenderer::FinishDrawingQuadList()
when it is necessary. As result GpuMemoryBufferVideoFramePool kept
re-allocating new GPU memory buffers instead of reusing them. As result
the system would run out of memory very quickly when playing video.

Bug: 1001296
Change-Id: I390bfb63455b7e4b2bfa61717450d3f30bc05303
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790275
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694753}

The Memory Instrumentation service isn't available in unit_tests, this
add a check to verify that the service exists before trying to calling
it.

Change-Id: I6f4ceb28fe828b8229888bbff5d58a445051cd5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783304Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694752}

This reorders the construction sequence so that the created subtrees or
nodes are inserted after they've had their attributes (and other things)
set.

In the context of the bug referenced the interesting bit is setting the
is-fallback-image flag on the HTMLImageElement before inserting it.

Bug: 1000273
Change-Id: Ica4d7d50709c9338b4df6e3c4a4ce1f22d5c3924
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789811
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694751}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/components/omnibox.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

Edit: Revert changes to HQPPerfTestOnePopularURL which needs
      base::ThreadPool now.

R=jdonnelly@chromium.org

Bug: 891670
Change-Id: I625d146aca749921b09a9af2ec8ed68d355bcf10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786756
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694750}

This new functionality is hidden behind both a GN arg
(enable_run_ios_unittests_with_xctest) and a commandline switch
(--enable-run-unittests-with-xctest), in order to default it to off
until the bots are updated to properly run XCTest-based unittests.

The iOS test runner is updated to run in one of two modes.  When
--enable-run-unittests-with-xctest is false (the default), behavior is
unchanged; TestSuite::Run() calls UIApplicationMain(), then the
UIApplicationDelegate calls TestSuite::Run() again, which actually runs
the tests when invoked the second time.  When the switch is set to true,
the second invocation of TestSuite::Run() is made by our XCTestCase
subclass rather than by the application delegate.

Xcode provides the ability to run XCTests and XCUITests from the
commandline, but does not provide any other way to install and run an
app outside of this test-based workflow.  (We had an alternative that
used third party libraries, but they no longer work on iOS 13.)  This
makes it difficult to install and run GoogleTest-based tests on iOS
devices, since they run as a single self-contained application, but it
would not be practical to drop GoogleTest support on iOS.  Instead, we
are exploring invoking these tests via XCTest, which would allow us to
use Xcode's tooling but still run the same GoogleTest-based tests as on
other platforms.

BUG=635509

Change-Id: I26c67d9c7e16a744f43a20f2d8c5839ca8b3c31a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787593Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694749}

This change changes the const overload of Value::GetList() to return a
span<const Value> rather than a const std::vector<Value>&. This serves
two purposes:

1) It improves encapsulation, as returning a span allows for other list
   storages than std::vector.

2) It improves memory safety, since span<T>::operator[] CHECKs whether
   the passed in index is within bounds. std::vector<T>::operator[] does
   not do this.

A similar change will be applied to the mutable overload of
Value::GetList() in a follow-up CL.

TBR=blundell,stevenjb,reillyg,rohitrao,rsleevi

Bug: 646113, 990059
Change-Id: I0ee0d27b3b99f80b83c97acc2ca9efd4f5c81b6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786638
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694748}

This reverts commit b2b10c51.

Reason for revert: Causing test failures on Webkit Linux Leak.

Bug: 1002059

Original change's description:
> Make ScriptValue Traceable
> 
> We made ScriptValue Traceable to replace SharedPersistent
> with TraceWrapperV8Reference in a follow-up CL.
> 
> In this CL, most of the changes are just:
> - Replace Vector<ScriptValue> with HeapVector<ScriptValue> because
> ScriptValue has a Trace method.
> - Add a trace method for ScriptValue because ScriptValue is traceable.
> - Add a trace method for ScriptPromise because it has a ScriptValue.
> 
> We recommend you to mainly check
> - script_value.h where I add VectorTraits.
> - script_promise.h where I add VectorTraits.
> - v8_callback_function.py where I add a code to generate HeapVector.
> - v8_types.py
>  * Add ScriptValue and ScriptPromise to "is_traceable==True"
> which is used to generate Trace method for ScriptValue and ScriptPromise.
>  * Add ScriptValue and ScriptPromise to "is_gc_type==True"
> which is used to generate HeapVector instead of Vector.
> 
> Bug: 998994
> Change-Id: I595a87636464e9fbf30533373995b61c89e464b4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787483
> Commit-Queue: Rika Fujimaki <rikaf@google.com>
> Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
> Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Reviewed-by: Keishi Hattori <keishi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#694681}

TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org,keishi@chromium.org,kouhei@chromium.org,rikaf@google.com

Change-Id: I52e6298abaf785bba63ffcdd49c77308c603b0dd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 998994
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792866Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694747}

https://skia.googlesource.com/skia.git/+log/4f2674da4bbc..78fb80a2b328

git log 4f2674da4bbc..78fb80a2b328 --date=short --no-merges --format='%ad %ae %s'
2019-09-09 reed@google.com share private iterator/helpers for building paths

Created with:
  gclient setdep -r src/third_party/skia@78fb80a2b328

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=mtklein@google.com

Bug: None
Change-Id: I74fb7e29a97fa9806a8ee8d27930025cf98c985a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791791Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#694746}

*** Note: There is no behavior change from this patch. ***

This CL replaces calls to base::{Bind,BindRepeating} with calls to
base::BindOnce, and removes calls to base::AdaptCallbackForRepeating
when the returned base::RepeatingCallback is immediately converted
to a base::OnceCallback.

This CL was uploaded by git cl split.

R=jochen@chromium.org

Bug: 714018
Change-Id: Id5caaee0bd00721b4463880d6ba3c8121d533468
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778548
Auto-Submit: Yannic Bonenberger <contact@yannic-bonenberger.com>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694745}

CVC are detected with two types of heuristics:
1) CVC field is the field that contains the value used to unmask a server card.
2) CVC field is the field that contains a CVC-like value (3 or 4 digits) and it is not an expiratino year field. Learn more in |HeuristicallyFindCVCField|.

In order to distinguish (1) and (2), this CL set |properties_mask| to |KNOWN_VALUE| if (1).

TBR=koerber@chromium.org

Bug: 993704
Change-Id: Ifa475320cfe82fdec730d1547d3f551c0f717ba0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787783Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694744}

The test is already completely disabled on Mac.
Related tests were previously disabled in
https://chromium-review.googlesource.com/c/chromium/src/+/1792037

TBR: rego@igalia.com
Bug: 1001936
Change-Id: Iba8d8351123b446c7f8a76f6d4cbab6981a486d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792863Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694743}

This CL makes a paint worklet that uses a non-registered custom property
to be painted on the compositor thread.

Bug: 996723
Change-Id: I0d8afce0ba4008a585fcf83184a51782cc51af3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788319Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694742}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/content/renderer/media/webrtc.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

Edit: Revert changes to tests that use a ChildProcess
      (requires full TaskEnvironment)

R=sergeyu@chromium.org

Bug: 891670
Change-Id: I2b3cffbd2341f0d331f752542534ebcfe8254271
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786951
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694741}

TBR: ntfschr@chromium.org
Bug: 1001499
Change-Id: I9bcd4dd17b46485c9ff0ac788438059fcd281a39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791153
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694740}

https://webrtc.googlesource.com/src.git/+log/4d6b2691bd5d..ee3d995091da

git log 4d6b2691bd5d..ee3d995091da --date=short --no-merges --format='%ad %ae %s'
2019-09-09 nisse@webrtc.org New class VideoReceiver2, a trimmed-down vcm::VideoReceiver

Created with:
  gclient setdep -r src/third_party/webrtc@ee3d995091da

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: None
Change-Id: Ia3e4c3eef45328c551a9781d1e1b0e8e012edf86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792726Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#694739}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/components/content_settings.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=msramek@chromium.org

Bug: 891670
Change-Id: Icbf7ec34d5cec0751a115c88cddb1e57ad7afa64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786746
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694738}

See the attached bug for a screenshot.

Bug: 1002040
Change-Id: I3143aec972fe6cd172ab1de625d51c3e02159d4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790884Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#694737}

Add apks/ChromeModernPublic.aab to the known failure. This should turn
'Deterministic Android' and 'Deterministic Android (dbg)' back green.

.aab doesn't have effect at the moment, as --use-isolate-files is currently
passed in by the recipe. Add a note about eventually using gn directly.

Bug: 972075
Bug: 939984
Change-Id: Iccfbd7cc614fbfab441fa189a7d4eb0c086b97ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649142
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694736}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/ui/base/ime.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=yhanada@chromium.org

Bug: 891670
Change-Id: I33f045fb6999ffc600ca04255547512bd81861d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786748
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694735}

This CL converts DataPipeGetterPtr to new Mojo types.
It also updates traits which uses DataPipeGetterPtr.

Bug: 955171, 978694
Change-Id: I947fc8d4ce489f50045e2353db59445792deb6bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787659
Commit-Queue: Julie Kim <jkim@igalia.com>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694734}

This CL converts old Mojo types to the new Mojo types
in P2PSocketManager::StartNetworkNotifications function.

 - Apply pending_remote to the first arguement of
   StartNetworkNotifications.

Bug: 955171
Change-Id: I3d5900c322e40d36383ced855e4b60228e27925b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788419Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#694733}

Before this CL, the current session was saved when the page was loaded.
The page is loaded when the main frame has finished loading its content.
When there is a push state event, this callback isn't called.
This CL changes it to store the current session when the navigation is
finished, which happens when the item is committed.

Bug: 998563
Change-Id: Ibc77d38cf4e130477471161d28a4d6cb6c03365f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778483Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694732}

*** Note: There is no behavior change from this patch. ***

This CL replaces calls to base::{Bind,BindRepeating} with calls to
base::BindOnce, and removes calls to base::AdaptCallbackForRepeating
when the returned base::RepeatingCallback is immediately converted
to a base::OnceCallback.

This CL was uploaded by git cl split.

R=jochen@chromium.org

Bug: 714018
Change-Id: I6296434bcb2b82ebca81c06e84b3bd9d56fe40f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778551Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Auto-Submit: Yannic Bonenberger <contact@yannic-bonenberger.com>
Cr-Commit-Position: refs/heads/master@{#694731}

This CL converts BluetoothInternalsHandlerRequest in chrome to
the new Mojo type.

Bug: 955171
Change-Id: I5a04f8653dbc53022ff52171fc2569a373c5743e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788768
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694730}

With this CL, every time scheduer_tracked_features changes, if the
document has become uncacheable, we evict it from the BackForwardCache
(if it is in the cache).

Change-Id: Ic7a6693344687951c70d0e6d580f3ebb4a272fec
Bug: 996267
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784601Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Lowell Manners <lowell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694729}

TBR: liberato@chromium.org
Bug: 986021
Change-Id: I30aed42ffdeb612e0b7f3518b8b30026ccc73951
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790205Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694728}

Backport some tests in /services/resource_coordinator/memory_instrumentation to SingleThreadTaskEnvironment

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/services/resource_coordinator/memory_instrumentation.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

TBR=hjd@chromium.org

Bug: 891670
Change-Id: I80842200365e9839ec91af4e1550af6e7d976109
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786820Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694727}

Convert the implementation and all users of the
blink::mojom::DWriteFontProxy interface.

Bug: 955171, 978694
Change-Id: Ia2fd5c7b65b01bb62fb4d91978e8fb4881131c3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777803Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/master@{#694726}

This CL adds two methods to ResultsProcessor: for aggregating traces and
uploading artifacts. They do (almost) nothing so far, because the
corresponding work is done by Telemetry. Implementing full versions of the
methods will allow us to gradually transfer the responsibility for these
tasks from Telemetry to ResultsProcessor without major refactoring.

Bug: 981349
Change-Id: I5b2cb3f55dffe5f12e0e8ec0f3aaa1641e009f09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781152
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694725}

Bug: 1000202
Change-Id: I7a28746d4cb8eb785c96b4bcc51497adebe37ace
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787891Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694724}

https://android.googlesource.com/platform/external/perfetto.git/+log/7010f3a19670..e67138c9836d

git log 7010f3a19670..e67138c9836d --date=short --no-merges --format='%ad %ae %s'
2019-09-09 lalitm@google.com Merge "Use int64_t in sliced_protobuf_input_stream"

Created with:
  gclient setdep -r src/third_party/perfetto@e67138c9836d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I4a59fbdf0a7ef4ae07755cbdd85fac36d3ecb986
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792444Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#694723}

https://skia.googlesource.com/skia.git/+log/627d15588f4d..4f2674da4bbc

git log 627d15588f4d..4f2674da4bbc --date=short --no-merges --format='%ad %ae %s'
2019-09-09 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps

Created with:
  gclient setdep -r src/third_party/skia@4f2674da4bbc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=mtklein@google.com

Bug: None
Change-Id: Iaab7f69a901c4f5fc91cdea4c7c7a1b22177a5f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792443Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#694722}

This CL only introduces the class skeleton with empty implementation.

Follow up CLs will gradually provide implementation for the methods of
that class.

Change-Id: I617c076cf0f5a349361a7f1f910f094ceda7b4ff
Bug: 1002000
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789156
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694721}

Using wpt-import in Chromium 6e3e0232.
With Chromium commits locally applied on WPT:
1f146124 "[WPT/common/security-features] Remove {mixed-content,referrer-policy}-test-case.sub.js"
bfd6ddf8 "[WPT/common/security-features] Update subresource and redirection type names"
9d7721df "Strip the fragment directive and update scroll-to-text WPT"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com:
  external/wpt/web-nfc

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I37aa23fa13ea99fedb1da5e60864e0d7e95cad5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792642Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#694720}

The HTTP FOAS feature will be rolled out to 100% starting M77. Following
the advice in go/finch-best-practices this change enables the feature by
default ToT and deletes the Field Trial Testing config.

Bug: 914765
Change-Id: Ief6a62c17ebbcc8adf66ff7e1678c3ae02dfc124
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789228
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694719}

This CL converts old Mojo types to the new Mojo types
in DataReductionProxy interface.

 - Apply pending_remote to DataReductionProxyThrottleConfigObserver
   argument in AddThrottleConfigObserver.

Bug: 955171
Change-Id: I97e09e918f3ef206196d5f856b00a60b9e382650
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787762Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#694718}

If the user started the browser in incognito mode and
triggered a restart in regular mode, the browser was started
in the incognito mode. Similarly, if the user started in the
regular mode and triggered a restart in the incognito mode,
the browser was started in the regular mode.

The fix is to find the profile type that invoked the restart.
Then use this type to modify old switch arguments which are used
to create the new cmd line arguments for restart.

Bug: 999085
Change-Id: Ide6e86aabb90b5a333ec10ea23e3add62a3d0e34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789582Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Rohit Agarwal <roagarwal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694717}

This reverts commit 063da117.

Reason for revert: Test disabled, relanding.

Original change's description:
> Revert "[ios] Enable SlimNav and dependent features by default."
> 
> This reverts commit 7c516511.
> 
> Reason for revert: <INSERT REASONING HERE>
> 
> Original change's description:
> > [ios] Enable SlimNav and dependent features by default.
> > 
> > Tentatively enabling this by default for M79.
> > 
> > Bug: 789582
> > Change-Id: I030902ddbb1a19f5b49a847b727c439cfd10fcf9
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787885
> > Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> > Reviewed-by: Gauthier Ambard <gambard@chromium.org>
> > Reviewed-by: Eugene But <eugenebut@chromium.org>
> > Commit-Queue: Justin Cohen <justincohen@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#694620}
> 
> TBR=rohitrao@chromium.org,justincohen@chromium.org,eugenebut@chromium.org,gambard@chromium.org
> 
> Change-Id: Idb139bf5eed97036ccd2d0f26d331db77786b6e8
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 789582
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789152
> Reviewed-by: Yi Su <mrsuyi@chromium.org>
> Commit-Queue: Yi Su <mrsuyi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#694670}

TBR=rohitrao@chromium.org,justincohen@chromium.org,eugenebut@chromium.org,gambard@chromium.org,mrsuyi@chromium.org

Change-Id: Ia3470ee5f77a5171af99940b0efa32104cfdb873
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 789582, 1001965
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791266Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694716}

CI/try builders migrated:
- android-cronet-arm-dbg / android-cronet-arm-dbg
- android-cronet-arm-rel / android_cronet
- android-cronet-arm64-dbg
- android-cronet-arm64-rel
- android-cronet-asan-arm-rel
- android-cronet-kitkat-arm-rel
- android-cronet-lollipop-arm-rel
- android-cronet-marshmallow-arm64-perf-rel
- android-cronet-marshmallow-arm64-rel
- android-cronet-x86-dbg
- android-cronet-x86-rel
- android-incremental-dbg
- android-kitkat-arm-rel / android-kitkat-arm-rel
- android-mojo-webview-rel
- android-pie-arm64-dbg

Migration schedule:
https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0

Bug: 950413
Change-Id: I42b3f0a21846ea4b6d20b46ed9a8850b61f3d24e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780083
Commit-Queue: Simon Que <sque@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694715}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8629d82b7f98..f5102cee4165


Created with:
  gclient setdep -r src-internal@f5102cee4165

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I32300e5c13fa051d5cceadeb0ae01dc1a8dc8eca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791534Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#694714}