- 31 Jul, 2019 40 commits
-
-
John Abd-El-Malek authored
This is in preparation of removing ResourceRequestInfo which isn't needed anymore. Bug: 934009 Change-Id: I1f799afa6ddf2dc926898d6e18c92849f722ad12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726766Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#682562}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/896a6b4b220f..334a2b1fa8b9 git log 896a6b4b220f..334a2b1fa8b9 --date=short --no-merges --format='%ad %ae %s' 2019-07-31 treehugger-gerrit@google.com Merge "traced: add metatrace support via in-process producer (folding in LazyProducer)" Created with: gclient setdep -r src/third_party/perfetto@334a2b1fa8b9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I2537aa529677bccf638eee88c1cbe4e898fa7626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727579Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682561}
-
Pavel Yatsuk authored
The feature is tracked in crbug.com/955951. It is rolled out to dev/canary/beta. R=isherman@chromium.org Change-Id: I4f5c3c02b0dc088977e77561fbd29216b904939c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726819Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#682560}
-
Patrick Monette authored
This avoids an unnecessary char conversion now that the old blacklist code is no more. Bug: 986926 Change-Id: I80564b4680ac7b45941a913b335ba0d49adea6c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720123 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#682559}
-
Carlos Caballero authored
This translation unit is using THREAD_CHECKER but not including the header. Change-Id: Ifb594fe48ef0e9b08f80b3fc9898325f5c0d4f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725644 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#682558}
-
Olivier Yiptong authored
Adding review changes from https://chromium-review.googlesource.com/c/chromium/src/+/1692325 I prematurely hit the submit button. Bug: 968550 Change-Id: I52b85c70d5b47845a60398d1c453a118e1be5a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726660Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#682557}
-
Keith Lee authored
Change-Id: I3ccee265fb87f8ba62aa4b11932e752c2c4bdb5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727518Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Auto-Submit: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#682556}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 669ae3a7. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools jsbell@chromium.org: external/wpt/IndexedDB NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I1f415d856db43e5e9f18ad36603d60853f5c7e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726991Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682555}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4ed5b087f57f..5ae853a163e7 git log 4ed5b087f57f..5ae853a163e7 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 394c077f..bb33f8cf (682353:682476) Created with: gclient setdep -r src/third_party/webrtc@5ae853a163e7 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I24d88e2836e2a76dd0fd1acbfd2e3488398156f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726644Reviewed-by:
-
Tom Anderson authored
Ubuntu's top bar expects properties returned in the order they were requested. The returned properties have IDs associated with them, so ordering really shouldn't be necessary. Alas, keep them ordered to appease Unity. BUG=981201 R=thestig Change-Id: I2907c264cc4346a47aa6304f7302c6d58555c9cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716958 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#682553}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b63730a701a4..6b7089ee5024 Created with: gclient setdep -r src-internal@6b7089ee5024 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:987378,chromium:None,chromium:988998 Change-Id: Ibe73943e6270db708b24c65e00ba9c56f5757f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727576Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682552}
-
Xing Liu authored
This CL wraps all user action data into a struct, which loweres the difficulty for maintenance and simplifies the code. Also plumb the button id through the user action pipeline. Bug: 979770 Change-Id: I91b9e8c9d35ff413051d9cc937ef6c2283112464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717312Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#682551}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/35ad5221fb55..d08611b7a8dc git log 35ad5221fb55..d08611b7a8dc --date=short --no-merges --format='%ad %ae %s' 2019-07-30 jiawei.shao@intel.com Move all the implementations of Toggle to Toggles.cpp Created with: gclient setdep -r src/third_party/dawn@d08611b7a8dc The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I9776b0342f2ccf5c37acf82f78e6240aa3b7a2b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726647Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/245c002bc098..6980c4e0aef8 git log 245c002bc098..6980c4e0aef8 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 egdaniel@google.com Remove isConfigCopyable from GrCaps. 2019-07-30 fmalita@chromium.org [skottie] Safe div-by-zero in LevelsEffectAdapter::apply Created with: gclient setdep -r src/third_party/skia@6980c4e0aef8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I9ca1df013b4fd2e21f6be5c5bb71fb6f00953264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726645Reviewed-by:
-
Jeremy Chinsen authored
Currently the logic in PDFiumEngine::FillPageSides() for drawing the empty space below a page only handles single-up view. In two-up view, a page may be shorter than the one adjacent to it. In this case, the bottom gap must have height as tall as the difference in the adjacent pages' height. This CL changes FillPageSides() such that when |two_up_view_| is true, it calls draw_utils::GetBottomGapBetweenRects() with the current page and |dirty_in_screen|, computing the space of |dirty_in_screen| that is below the page, and finally drawing it as empty space. This allows FillPageSides() to properly draw the bottom empty space for a page in two-up view. Bug: 51472 Change-Id: Idd01fd959419fd8aebc2f70f514eb83ba61c160c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720792Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c39e7c7cc884..324bdfed0692 git log c39e7c7cc884..324bdfed0692 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 capn@google.com Use a finite maxSamplerLodBias limit Created with: gclient setdep -r src/third_party/swiftshader@324bdfed0692 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/138670766 Change-Id: Ia4a409c84d7cb4d204d514900226db05aab85dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726643Reviewed-by:
-
Miyoung Shin authored
This CL renames mojo to mojom in //media/capture/video/chromeos. media/capture/video/chromeos/mojo => media/capture/video/chromeos/mojom Bug: 806965 Change-Id: I2b739ea05a99a02e9654659ec2b04a309b8dc26b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724901Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#682546}
-
tby authored
This CL moves Roselle out of the search providers and into our ranking infrastructure. The logic for scoring apps is kept the same, but now happens in two different places: its time-based relevance score is still set in the AppSearchProvider but, if it is present in the ranker, the relevance is overridden by the ranker's score. Roselle is also used in the ArcAppShortcutsSearchProvider. Since we've finished the experiments ranking Arc app shortcuts and don't have plans to in the near future, this logic has been removed. Bug: 989350 Change-Id: I5c1e891508b669c5b91e7164e94af9fa7a6fbbaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694561 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#682545}
-
Theresa authored
We still need these to collect data for various experiments. Extends the following histograms to M82. - Settings.ShowHomeButtonPreferenceState - Settings.HomePageIsCustomized - Settings.ShowHomeButtonPreferenceStateChanged - Settings.GivenShowHomeButton_HomePageIsNewTabPage - Settings.ShowHomeButton BUG=986514,986515 Change-Id: Ie1e4156010a783e310997c2dded55816b8cde83d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727514Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#682544}
-
Miguel Casas authored
This CL adds a histogram for Media.MojoVideoDecoder.Decode; this is already tracked as an async trace, for the purpose of CrOs Tast, a histogram is needed.(This is basically the same case as crrev.com/c/1680764) Bug: 953253 Change-Id: I4cab76dd739f7b8196b29ec5870e141f04b1076c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725313Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#682543}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. OAuth2TokenService has been folded completely into ProfileOAuth2TokenService on https://crrev.com/c/1712560. So, it's not valid to comment OAuth2TokenService on the current codebase. This CL updates comments for OAuth2TOkenService with IdentityManager, the access token fetcher or OAuth2AccessTokenManager. Bug: 967598 Change-Id: I1aba6c57d8cc65063f12be512cece3404d602fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725222 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2ddb2cc3..79a5354d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic9ad500efd1806b331d56b5b2f71493d7975a8a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727170Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682541}
-
Tina Wang authored
Previously the omnibox icon will show and hide according to whether the user focuses on the omnibox. Now it won't hide when the user unfocuses the omnibox. There is a updated summary of how send tab to self omnibox icon shows and hides: - If showing: keep showing til the user start to edit the url. - If hidden: show if send tab to self feature is offered, omnibox is focused, and the url has not been edited. Bug: 978520 Change-Id: Id3f2a368a283c43f35dbe83847d593eba2498e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715511 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#682540}
-
Xing Liu authored
This CL catches an exception in PackageMetrics.getPackageStatsForAndroidO. The crash happens if (Binder.getCallingUid() != appInfo.uid). Currently we don't know the reason. Something tries to launch Chrome process in a remote process. Bug: 984761 Change-Id: If6186d9218fdde99be95c4ad8ec4da896abbba4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725473Reviewed-by:
-
Alex Cooper authored
This addresses feedback submitted to crrev.com/c/1725319 after it was submitted. Mainly around using exact equality for whole numbers and the math around a length of zero. Bug: 977703 Change-Id: Ia43f204a9f754077cda6bd74b2e901f724c7ee9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727571 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#682538}
-
Dominic Battre authored
This CL improves the readability of votes uploads: Before the CL, you would see "autofill_type: [51]". After the CL, you now see "autofill_type: [51/CREDIT_CARD_NAME_FULL]". If std::vector<std::string> elements are piped into the LogBuffer, these are automatically represented as a comma separated list in the output. R=kolos@chromium.org Bug: 928595 Change-Id: I68c917be57c5dbf32a7932235b8c52dc8916cf97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724521 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#682537}
-
Yuly Novikov authored
Start running tests on Win10 x64 Intel experimental bot. TBR=kbr Bug: 988833 Change-Id: Iadea428fd44ec07477c574d06d1cd8dc7d52890f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726758Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#682536}
-
Ian Wells authored
When sharing an offline page after opening it from Downloads Home, share the original URL if a content URI can't be generated. Also, on Android Q+, if the page's file path is already a content URI, share that directly. Bug: 985699 Change-Id: I53c2e6effb929a00c4e083206bce01338610dc02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713765Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#682535}
-
Angel Alvarez authored
Tweaks UI of Explore Sites Pages to conform with initial UI review feedback, including modification of the icon corner radius to conform with Android system UI guidelines. Bug: 977713, 989214 Change-Id: I4593587451fb2dd53ecfc7af367aa06f8bf7012c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717920Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Angel Alvarez <angelii@google.com> Cr-Commit-Position: refs/heads/master@{#682534}
-
Chris Harrelson authored
If the first parameter is nullptr, the second must be also, or else the code will try to dereference |ancestor|. Bug: 988960 Change-Id: I74ada6169a77c6dce08695abf5d94d3df3bc5176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726722Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#682533}
-
Michael Spang authored
Without flushing after calling XMapWindow, the window may never appear. Bug: 988915 Test: gn gen out/chromecast_rel --args='use_ozone=true is_chromecast=true' ninja -C out/chromecast_rel cast_shell ./out/chromecast_rel/cast_shell --ozone-platform=x11 Change-Id: I6f6f08d4baa981cdee78adfa0056fc51b83e6dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725243 Auto-Submit: Michael Spang <spang@chromium.org> Reviewed-by:Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#682532}
-
Robert Liao authored
This allows the HatsService to have multiple site IDs and specify what site ID to use. BUG=979530 Change-Id: I6b255a2ebe9cc1cb5e4b7ec10ab98f3f3b50c6dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711055Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#682531}
-
Joe DeBlasio authored
This CL adds an advanced section to the lookalike URL interstitial, updates the strings, and adds support for different descriptions for top site and engagement matches. The advanced section is hidden behind a feature param for now, so this CL has no immediately-user-visible change. Bug: 987359 Change-Id: Ic4ffb3610db7608de0adeb020b253caf8755e2ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717191Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#682530}
-
Tom Anderson authored
This is necessary for switching GlobalMenuBarX11 from gio to //dbus. GlobalMenuBarX11 lazily creates the history menu when it is opened, so we cannot call SetModel() because that would remove the menu and replace it with a new one. We need to update the menu in-place, which is now possible with MenuLayoutUpdated(). Also provided is MenuItemsPropertiesUpdated(), which avoids having to rebuild the entire menu tree if a single item becomes checked/unchecked, disabled/enabled, etc. BUG=981201 R=thestig Change-Id: I36397810ba38f16ef44206282203db16edfdd0c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720796 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#682529}
-
Jenna Himawan authored
Bug: 988044, 160194 Change-Id: Ieecb98d113d7a769aebf6be1a3694f1a2c1a5141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710773 Commit-Queue: Jenna Himawan <jhimawan@google.com> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
Patrick Noland authored
Also, add a flag that disables the InstantExtended limit on search suggestions. Bug: 974852 Change-Id: I9f3a443b89c83cc4fa958756e25448688d9e0370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725172 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#682527}
-
Kristi Park authored
Like placeholder text in input fields, this should not be selectable by users. Bug: 987948 Change-Id: I56d4586878bcd09fab1ba6186379305d3163dfae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726936 Commit-Queue: Kristi Park <kristipark@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Auto-Submit: Kristi Park <kristipark@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#682526}
-
Eric Stevenson authored
If a class is marked @MainDex and needed outside of the browser process then it's possible that a native method may be referenced outside of the browser process. Currently, this can cause problems for NativeMethods JNI interfaces on KitKat since the generated wrapper classes do not have the @MainDex annotation. This CL changes the JNI annotation processor to propagate @MainDex to generated native wrapper classes where necessary. Bug: 929661 Change-Id: I2f6e09475032550768ec3b03cc3b52519ba0dc3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726815 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#682525}
-
Avery Musbach authored
The present CL is just some simple code cleanup. Change-Id: Ica26c2b3f9bdfdd18a93debe1350db76f08760ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727369 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#682524}
-
Ken Rockot authored
The only services used in production ios code are the FilePatcher and Unzipper services, and these have been moved off of Service Manager. Identity service has no clients on ios so its support does not need to be maintained, and all other Service Manager usage was either only for test coverage, or nominal use of the InterfaceProvider API. The latter has been replaced with a new WebState::InterfaceBinder API which is roughly equivalent. The net result of this CL is the complete removal of all services/service_manager dependencies from ios/. Bug: 977637 Change-Id: I88ee321cf4fe58c550ac235de828ff93aa940f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725482 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#682523}
-
