GitLab

BUG=144577


Review URL: https://chromiumcodereview.appspot.com/11824010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175713 0039d316-1c4b-4281-b951-d872f2087c98

Adding a call to clear text composition on tap gestures and also changing
the places where the text updates get sent back to the browser.

BUG=167127


Review URL: https://chromiumcodereview.appspot.com/11741036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175712 0039d316-1c4b-4281-b951-d872f2087c98

4 tests are failing to run.
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/6093/steps/sandbox_linux_unittests/logs/stdio

They were passing on FYI bot but kicking until we figure out why they
are failing here.

BUG=166704
TBR=jln

Review URL: https://codereview.chromium.org/11826019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175711 0039d316-1c4b-4281-b951-d872f2087c98

BUG=150920
TEST=media_unittests pass


Review URL: https://chromiumcodereview.appspot.com/11642054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175710 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162081


Review URL: https://chromiumcodereview.appspot.com/11778042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175709 0039d316-1c4b-4281-b951-d872f2087c98

Android webview intercepts download in its resource dispatcher host delegate

BUG=


Review URL: https://chromiumcodereview.appspot.com/11821011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175708 0039d316-1c4b-4281-b951-d872f2087c98

This allows release (non-official) builds to have dchecks enabled.

BUG=


Review URL: https://chromiumcodereview.appspot.com/11644093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175707 0039d316-1c4b-4281-b951-d872f2087c98

Calls from other threads will be ignored. Currently the only DBus calls from other threads are for Geolocation. Supporting statistics gathering across multiple threads is unnecessary overhead that we don't currently need.

BUG=168134


Review URL: https://chromiumcodereview.appspot.com/11761015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175706 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11782024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175705 0039d316-1c4b-4281-b951-d872f2087c98

This adds a field trial for compressed swap.  Chrome OS picks the trial
group to be used, based on the HW address of the wifi controller.  Chrome
assigns a 100% probability to the group picked by Chrome OS.

BUG=chromium-os:37583
TEST=manually tested


Review URL: https://chromiumcodereview.appspot.com/11744024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175704 0039d316-1c4b-4281-b951-d872f2087c98

R=jsbell,dgrogan,Tom Sepez
BUG=161958


Review URL: https://chromiumcodereview.appspot.com/11791009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175703 0039d316-1c4b-4281-b951-d872f2087c98

TBR=cmp

Review URL: https://codereview.chromium.org/11825020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175702 0039d316-1c4b-4281-b951-d872f2087c98

Use "--crash-test" to generate a crash in the browser process and
check that it produces a Breakpad crash dump.

This is in preparation for compiling Breakpad into Linux Chromium by
default, so that I will be able to check that crash_dump_tester.py
finds crash dumps OK on Linux.

We extend crash_dump_tester.py to launch both 32-bit and 64-bit
versions of crash_service.exe on Windows, so that we can get crash
dumps from the 32-bit browser process even on 64-bit systems.  We
introduce the cleanups_funcs list to make this cleaner.

This is not the best place to put Breakpad tests, but Chrome doesn't
have any other adequate framework for testing Breakpad at the moment.

BUG=105778
TEST=nacl_integration

Review URL: https://codereview.chromium.org/11818007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175701 0039d316-1c4b-4281-b951-d872f2087c98

This is an initial implementation of an experimental extension which
enables apps using the appv2 API to request a transparent window
background through a new flag passed to chrome.app.window.create().

How to use:
  chrome.app.window.create('xeyes.html', {
      width: 500,
      height: 309,
      // Needs "experimental" permission in manifest.json
      transparentBackground: true
  });

Basic Demo: http://codewiz.org/pub/transparent-hello-world-app

Caveats:
 - Transparent windows have a grey bar below the window title, about
   30 pixels high. (http://crbug.com/152838)

BUG=125295
TEST=demo works

R=reveman@chromium.org,mpcomplete@chromium.org,sky@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10986092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175700 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11746025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175699 0039d316-1c4b-4281-b951-d872f2087c98

Our bash scripts were getting complicated an unwieldy. In this
commit I port the test logic into python, as a precursor to
moving the rest of the file.

I also move the step selection logic into python which offers the following advantages:
- Less files to maintain, easier to change something globally.
- Paves way to moving most factory_properties into 'slave_properties' argument I added.  This will let us change parameters like buildtype (make vs. ninja) without a waterfall restart.  This also moves configuration into a single place.

Also:
- Refactor test runners to not require envsetup.
- Adding test report step

BUG=153707,163476, 168518

Review URL: https://codereview.chromium.org/11666023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175698 0039d316-1c4b-4281-b951-d872f2087c98

1) show hover effect on rows
2) add placeholder resources for menu buttons
3) make clicks on rows pop up the suggestion menu

BUG=157273

Review URL: https://codereview.chromium.org/11785035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175696 0039d316-1c4b-4281-b951-d872f2087c98

Move sandbox_linux_unittests away from the FYI bots and enable them
by default.

BUG=166704
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11828008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175695 0039d316-1c4b-4281-b951-d872f2087c98

> cc: Implement DelegatingRender::drawFrame() method.
> 
> The method sends the render passes it is given to the parent compositor via
> the output surface. It should include a valid frame metadata with it.
> 
> Tests:
> DelegatingRendererTestDraw.runSingleThread
> DelegatingRendererTestDraw.runMultiThread
> DelegatingRendererTestResources.runSingleThread
> DelegatingRendererTestResources.runMultiThread
> 
> R=piman
> BUG=123444
> 
> Review URL: https://chromiumcodereview.appspot.com/11777025

TBR=danakj@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175694 0039d316-1c4b-4281-b951-d872f2087c98

This moves the GTK- and Views-specific code for alerting RenderWidgetHostView keypress listeners of keypress events into the shared method RenderWidgetHostImpl::ForwardKeyboardEvent() that all implementations bottleneck through.

Also updates RenderWidgetHostImpl::KeyPressListenersHandleEvent() to ignore events with the skip_in_browser flag set.

BUG=51644


Review URL: https://chromiumcodereview.appspot.com/11779035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175691 0039d316-1c4b-4281-b951-d872f2087c98

The method sends the render passes it is given to the parent compositor via
the output surface. It should include a valid frame metadata with it.

Tests:
DelegatingRendererTestDraw.runSingleThread
DelegatingRendererTestDraw.runMultiThread
DelegatingRendererTestResources.runSingleThread
DelegatingRendererTestResources.runMultiThread

R=piman
BUG=123444

Review URL: https://chromiumcodereview.appspot.com/11777025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175690 0039d316-1c4b-4281-b951-d872f2087c98

The script has to be aware of MIPS arch, so it can figure out that the libary
is for MIPS.

BUG= https://code.google.com/p/chromium/issues/detail?id=130022
TEST=make chrome


Review URL: https://chromiumcodereview.appspot.com/11819009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175689 0039d316-1c4b-4281-b951-d872f2087c98

cc: Map the clip_rect in the SharedQuadState to include the drawTransform of the hosting delegated renderer layer.

The clip rect is assuming that it draws to its old target space, but it will be
drawing to the target space of the delegated renderer layer, so adjust it
accordingly.

Tests:
cc_unittests:DelegatedRendererLayerImplTestSharedData.SharedData

BUG=123444
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11828011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175688 0039d316-1c4b-4281-b951-d872f2087c98

This re-enables several tests that were disabled, and
adds new expectations where they were missing before.
It also cleans up some tests by suppressing unnecessary
attributes, and makes the Mac "subrole" attribute hidden
by default since it's rarely useful.

The correctness of the output was determined by these specs:

HTML: http://www.w3.org/TR/html-aapi/
ARIA: http://www.w3.org/WAI/PF/aria-implementation/

BUG=165838
TBR=dtseng


Review URL: https://chromiumcodereview.appspot.com/11785038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175687 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=none
TEST=none

Review URL: https://codereview.chromium.org/11830015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175683 0039d316-1c4b-4281-b951-d872f2087c98

BUG=165783


Review URL: https://chromiumcodereview.appspot.com/11778051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175682 0039d316-1c4b-4281-b951-d872f2087c98

This change requires this WebKit patch: https://bugs.webkit.org/show_bug.cgi?id=104404

This change enables access to the guest's window's name attribute from the embedder <webview>. It also enables changes to the window name attribute from the embedder WebContents.

BUG=140316
Test=BrowserPluginHostTest.ChangeWindowName

Review URL: https://codereview.chromium.org/11554030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175681 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11824008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175679 0039d316-1c4b-4281-b951-d872f2087c98

The core problem is that the key that controls the execution of a protocol
HKEY_CLASSES_ROOT\<protocol>\Shell\Open\Command

Has changed, we expect the Default value to be a valid command like foo.exe %1
but this is no longer the case. This value can be empty and other values will
control what happens, for instance DelegateExecute.

This CL also whitelists the protocol, alternatively we could hardcode a meaniful
string to present to the user but that presents localization issues. We take the
same approach as IE and just launch the windows store if we see this protocol.

BUG=159096
TEST=see bug
Review URL: https://codereview.chromium.org/11316038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175678 0039d316-1c4b-4281-b951-d872f2087c98

The goal is just to make sure this code has test coverage, not to test
correctness. There was an issue in the past where the code that computed
the histograms crashed in debug mode, this will help prevent something like
that from landing in the future.

BUG=99504


Review URL: https://chromiumcodereview.appspot.com/11778045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175677 0039d316-1c4b-4281-b951-d872f2087c98

BUG=155221


Review URL: https://chromiumcodereview.appspot.com/11638053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175676 0039d316-1c4b-4281-b951-d872f2087c98

R=jhawkins@chromium.org
BUG=none


Review URL: https://chromiumcodereview.appspot.com/11773048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175675 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
TEST=Repro steps in bug #168746.
BUG=166348

Review URL: https://chromiumcodereview.appspot.com/11784036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175674 0039d316-1c4b-4281-b951-d872f2087c98

This will track Shill Device info, including Wifi access point data.

BUG=167987


Review URL: https://chromiumcodereview.appspot.com/11743006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175673 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168652


Review URL: https://chromiumcodereview.appspot.com/11788020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175672 0039d316-1c4b-4281-b951-d872f2087c98

Change the method to no longer write to both App GUIDs, just the one that matches the distribution of the caller. This means that GCAPI will only write to the Google Chrome product's client state key, and not to the Chrome Binaries.

Replace SetOmahaExperimentLabel in the GCAPI code with a more specific version, and have SetOmahaExperimentLabel perform the general clobber-write to the registry.

This is in preparation for future work in using the experiment_labels to transmit Chrome Variations.

BUG=160251


Review URL: https://chromiumcodereview.appspot.com/11280067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175671 0039d316-1c4b-4281-b951-d872f2087c98

Now it doesn't dismiss the item. When click happens in the toast, it will hide from the popup but remain in the center.

BUG=165576

Review URL: https://codereview.chromium.org/11778012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175669 0039d316-1c4b-4281-b951-d872f2087c98

> Omnibox: Make HistoryQuick provider not re-issue queries if |minimal_changes| is true
> 
> BUG=
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/11722020

I'm reverting this because it causes problems with backspace, at least when
certain field trials are enabled.  See
https://code.google.com/p/chromium/issues/detail?id=168725

We'll probably chose a different strategy to fix this in a better way (in
terms of how the code should work), but at least this puts the behavior
back to what people are used to.

BUG=168725
TBR=mpearson@chromium.org
Review URL: https://codereview.chromium.org/11820015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175668 0039d316-1c4b-4281-b951-d872f2087c98

Context menu button isn't useful for editing item and it casuses
a problem when displaying context menu on editing item.

BUG=76189

Review URL: https://codereview.chromium.org/11777026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175667 0039d316-1c4b-4281-b951-d872f2087c98

Host and NaCl builds currently use different headers which can cause
build problems.  This change moves the headers out of the toolchains
and instead all toolchains share the same set as the host builds.

NOTRY=true
BUG=168718
R=binji@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11825003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175666 0039d316-1c4b-4281-b951-d872f2087c98