GitLab

- Ensure moving the mouse off the accessibility tree causes the inspected node 
  to be scrolled back into view;
- Ensure that moving focus away and back to the tree re-focuses the inspected
  node, including if the tree pane is hidden and re-shown;
- Avoid hover highlight "sticking" to the node above/below the inspected node;
- Make the context menu for breadcrumbs work again;
- Make sure treeitem role and tabindex are on the same DOM node.

Bug: 560525
Change-Id: I27ced90eedc115fd93c9a65c8baefe87886c092e
Reviewed-on: https://chromium-review.googlesource.com/625500
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501212}

This is a temporal fix for the issue that non-Latin IMEs doesn't work.
The 'background.persistent' flag should be restored as soon as
possible after fixing the root cause of the issue.
Also, add some useful logs to debug the issue.

      chrome://inspect/#extensions.

Bug: 761714
Test: Manual. Confirm that the extension always appears on
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia0a12a33036919dc2bec213fd11b49d3b7b9d54f
Reviewed-on: https://chromium-review.googlesource.com/660938
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501211}

This reverts commit 3c6304c0.

Reason for revert: Doesn't compile on Mac.

Original change's description:
> Traffic annotation auditor and unittest updated.
> 
> The following changes were done:
>  1- Auditor adds a list of OSes that actively use each annotation to
>     annotations.xml, so that removing annotation from one OS and keeping
>     it in another would not result in marking it deprecated.
>  2- A script is added to tools/traffic_anntotation/scripts, to call all
>     scripts that update a give file when annotations.xml is modified, or
>     to run unittests that ensure these files are up to date.
>  3- 'test-only' switch added to Auditor. When this switch is present,
>     auditor only checks if annotations.xml is up to date and issues an
>     error it if is not. When switch is not specified, annotations.xml
>     may get updated and if so, the above mentioned script is called to
>     update downstream files.
>  4- Auditor will prevent use of deprecated unique ids.
>  5- Unittest checks that annotations.xml is loadable and its content are
>     valid.
>  6- Unittest calls the script mentioned in (2) to test if downstream
>     files are correctly updated.
> 
> Bug: 656607
> Bug: 690323
> Change-Id: I3cea4254dc4ff8bb2c31a8adc1ff5a7daf5006d7
> Reviewed-on: https://chromium-review.googlesource.com/645088
> Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
> Reviewed-by: Martin Šrámek <msramek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501206}

TBR=msramek@chromium.org,rhalavati@chromium.org

Change-Id: Id4c9b556ec5e93d7d5e4d0cd2bd60137811e663f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 656607, 690323
Reviewed-on: https://chromium-review.googlesource.com/662503Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501210}

Bug: 695939
Change-Id: I39a9e9ce3b030ec233a03912a3b55d25fffa46a4
Reviewed-on: https://chromium-review.googlesource.com/652208
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501209}

Bug: 757243
Tbr: xiyuan@chromium.org
Change-Id: Icc3358ecd4970fdfba9ee7783c3ef130506e3723
Reviewed-on: https://chromium-review.googlesource.com/662083Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501208}

- Move functionality for multiple Folder selection
- Move functionality for multiple URL selection
- Move functionality for multiple Folder / URL selection
- Eg tests for the same.

Bug: 695749
Change-Id: I5c64c6ddc10fb5e47e1fcd521afea9498f653ae4
Reviewed-on: https://chromium-review.googlesource.com/662538
Commit-Queue: Ramya Sharma <ramyasharma@chromium.org>
Reviewed-by: Marti Wong <martiw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501207}

The following changes were done:
 1- Auditor adds a list of OSes that actively use each annotation to
    annotations.xml, so that removing annotation from one OS and keeping
    it in another would not result in marking it deprecated.
 2- A script is added to tools/traffic_anntotation/scripts, to call all
    scripts that update a give file when annotations.xml is modified, or
    to run unittests that ensure these files are up to date.
 3- 'test-only' switch added to Auditor. When this switch is present,
    auditor only checks if annotations.xml is up to date and issues an
    error it if is not. When switch is not specified, annotations.xml
    may get updated and if so, the above mentioned script is called to
    update downstream files.
 4- Auditor will prevent use of deprecated unique ids.
 5- Unittest checks that annotations.xml is loadable and its content are
    valid.
 6- Unittest calls the script mentioned in (2) to test if downstream
    files are correctly updated.

Bug: 656607
Bug: 690323
Change-Id: I3cea4254dc4ff8bb2c31a8adc1ff5a7daf5006d7
Reviewed-on: https://chromium-review.googlesource.com/645088
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501206}

Using wpt-import in Chromium 285ef68a.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/1655

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-request

TBR=qyearsley@chromium.org

No-Export: true
Change-Id: I81465305dcd669eba7a88697ba3fb764fa5ce0d7
Reviewed-on: https://chromium-review.googlesource.com/662619
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501205}

This CL replaces native struct content::ServiceWorkerRegistrationOptions
with mojom struct blink.mojom.ServiceWorkerRegistrationOptions.

BUG=758151

Change-Id: Ic7142a0db0967fdb0e2c766f5b46d4ec1b4f66b4
Reviewed-on: https://chromium-review.googlesource.com/657257Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#501204}

Removing a constant now unused.

Bug: none
Change-Id: Icd6f33ab85d1d195d3c5a96bd1ebf85a45b9ed93
Tbr: tsepez
Reviewed-on: https://chromium-review.googlesource.com/661143Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501203}

1. Avoid multiple adjacent calls to MutableForPainting().
2. Avoid computing the containing composited layer unless
fragmentation is present.

Bug: 763901
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Icea7cdd99c23860f6d853a3dbfcb51f10e8dd24d
Reviewed-on: https://chromium-review.googlesource.com/660681
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501202}

crrev.com/c/515606 overly simplified table layout overflow which is
expected to cover all collapsed border overflows. The CL added all
visual overflow into layout overflow causing it to also unexpectedly
cover all contents overflows (e.g. shadow and outlines of descendants).

Fix the issue by just include collapsed border overflow.

Bug: 763337
Change-Id: I6c53afba3f00729a483588dfea46c86a8b78562a
Reviewed-on: https://chromium-review.googlesource.com/657815
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@opera.com>
Cr-Commit-Position: refs/heads/master@{#501201}

These callbacks would already be delivered by the similar scope inside the attribute
implementation. Methods already have only the inner scope.

Change-Id: I72bceec4d883d0dba5e93b2ec19156d3c88590e1
Reviewed-on: https://chromium-review.googlesource.com/662220Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501200}

Part 4/4 to replace these namespace qualifications.

TBR=dcheng@chromium.org

Bug: 763556
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I31d6c69d73111165fb1bd8294cd0fe4e18ce96bd
Reviewed-on: https://chromium-review.googlesource.com/662561
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501199}

Bug: 578345
Change-Id: I2b7754a63b3ae5eb2487362ca1e17331a0d68b4a
Reviewed-on: https://chromium-review.googlesource.com/662719Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501198}

This is done only if the ExperimentalAppBanners feature is enabled.

Also re-arranges the strings and guards in them the grd file instead of
in c++.

Bug: 629725
Change-Id: Iec496f5ee9c4729fdecc272223e66c5abd93a494
Reviewed-on: https://chromium-review.googlesource.com/658580
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501197}

Bug: 750997
Test: exo_unittests --gtest_filter=DataDeviceTest.*
Change-Id: I83c41477a945e363c70560595fe3a079ed62c2cb
Reviewed-on: https://chromium-review.googlesource.com/624767
Commit-Queue: Daichi Hirono <hirono@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501196}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6bdbb1f1..19769c12

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: Icc5b6f10e91b838a5163625ac022e8d2fb219120
Reviewed-on: https://chromium-review.googlesource.com/662221Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501195}

|ResolveTapDisambiguation| is left unused after
CVC. This CL cleans it up.

https: //crrev.com/c/630980 and should have been removed from
Change-Id: I3b35fa741b9ee14626b14b9d26a5d132cf68fa78
Reviewed-on: https://chromium-review.googlesource.com/657785Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501194}

Bug: 745385
Change-Id: I6592737458f684e65738ca45aa34a58d5e2ed8bd
Reviewed-on: https://chromium-review.googlesource.com/647955
Commit-Queue: Austin James Ahlstrom <aahlstrom@google.com>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501193}

This removes the obsolete tracked_objects:: qualification on
uses of Location in //base.

TBR=dcheng@chromium.org

Bug: 763556
Change-Id: Iffdbf067f65f6dbfe309413294b8ace2e8917617
Reviewed-on: https://chromium-review.googlesource.com/662597Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501192}

Major part of bindings/scripts/ use single quotes. This CL improves code
consistency.

Change-Id: Ic21c8117fd34c0e13ee64540211ebc6012116067
Reviewed-on: https://chromium-review.googlesource.com/662499Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501191}

BUG=749312

Change-Id: I71a3f2e8ff9dd26c5cb4e47605d8a3abda65a7f1
Reviewed-on: https://chromium-review.googlesource.com/658402
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501190}

Part 1/4 to replace these namespace qualifications.

TBR=dcheng@chromium.org
TBR=armansito@chromium.org for chromeos/network

Bug: 763556
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I06ec01e1805744a7bba244b35ed09ace7af3152a
Reviewed-on: https://chromium-review.googlesource.com/662560
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501189}

Move:
  build/scripts/{ => core/css}/make_media_feature_names.py
  core/{ => css }/MediaFeatureNames.h

Using the code_generator GN template and update include paths.

Bug: 732657
Change-Id: Id79b1eac6763cae908574eb26c480c7b27a8150e
Reviewed-on: https://chromium-review.googlesource.com/656860
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501188}

This patch fixes modal permission prompts to not appear for background
tabs on Android. Instead of having the BrowserView call into the
PermissionRequestManager on tab activation and so on, we just observe
the WasShown() and WasHidden() events.

Prompts may still show on Android when in the tab switcher, I hope to
address this in another patch.

Bug: 751025, 606138
Change-Id: Ie52ca6e5985334b807dd6aa91c9f1aca94846429
Reviewed-on: https://chromium-review.googlesource.com/597507Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501187}

Bug: 745385
Change-Id: I5a70b0b71dc56c74c9786892e87befedb5b3a6a6
Reviewed-on: https://chromium-review.googlesource.com/648906
Commit-Queue: Austin James Ahlstrom <aahlstrom@google.com>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501186}

* generate_event_interfaces.py:
 Generate identical *.json5 even with snake_case IDL input files.
 'name' field of the *.json5 should be "core/events/FooEvent" even after
the great mv.

* make_event_factory.py:
  Add --snake-case-input-files flag to generate #include for snake_case
  file names.

* config.gni and scripts.gni
 Move bindings_generate_snake_case_files flag to config.gni as
 "snake_case_source_files". The flag affects not only bindings but also
 scripts in Source/build/.

Bug: 760462
Change-Id: I0579e25c88a0039e77de2c3c54772f10d750636f
Reviewed-on: https://chromium-review.googlesource.com/662471Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501185}

This unlocks spinning animation during the user creation.

Bug: b/63900068
Test: Manually on device. Spinning animation is updating.
Change-Id: I156ecbe9cd070ff0193fe8f8cec38e1934a24000
Reviewed-on: https://chromium-review.googlesource.com/656559Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Commit-Position: refs/heads/master@{#501184}

Part 2/4 to replace these namespace qualifications.

TBR=dcheng@chromium.org
TBR=armansito@chromium.org for chromeos/network

Bug: 763556
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: Iea0a004973ff120b95c1d305d778f811810d62b9
Reviewed-on: https://chromium-review.googlesource.com/662139
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501183}

Bug: 764179, 764180
Tbr: benwells@chromium.org
Change-Id: I29c80af68e40186b814f4f215f96e25c4206ceb6
Reviewed-on: https://chromium-review.googlesource.com/662259
Commit-Queue: Ben Wells <benwells@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501182}

A browser test for no-state prefetch failed for
KeepAliveRendererForKeepaliveRequests feature, which meant a bug. This
CL fixed the mishandling. With this CL, "keepalive" flag is
transferred from the renderer to the browser, and the feature affects
only requests with "keepalive" flag.

The non-state prefetch browser tests are now run in both settings
(i.e., with/without the feature).

Bug: 695939
Change-Id: I77c42cce95346f034af3ef4b7496908affc3074d
Reviewed-on: https://chromium-review.googlesource.com/656741Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501181}

Convert WaitForServiceToBeAvailableCallback and OnConnectedCallback to
OnceCallback.

Remove unused MockObjectProxy::WaitForServiceToBeAvailable().
Add MockObjectProxy::DoConnectToSignal() to workaround Gmock's
limitation around move-only arguments.
https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#mocking-methods-that-use-move-only-types

BUG=740015
TEST=try

Change-Id: Ide16b01e57eac20f231d729ad570547376a7874d
Reviewed-on: https://chromium-review.googlesource.com/656480Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501180}

Make a new inner class. This calls OnComplete() with appropriate error code.

Bug: 758455
Change-Id: I2589dc740a7338bffaf6a059526775f620ee1a1c
Reviewed-on: https://chromium-review.googlesource.com/656880Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Emi Morikawa <emim@google.com>
Cr-Commit-Position: refs/heads/master@{#501179}

This is a reland of f79325e1

Change from the original CL (which is patch set #1):
* Disable tray animation in TrySwitchingUserTest. The animation was
  not triggered before because |small_image| was not set.

Original change's description:
> Apply system style to screen share notification.
> 
> In new-style notification, system notification has different style from
> other notifications such as web notification.
> This CL applies the system style to screen share notification.
> * The context header and action buttons have accent color.
> * New material design icon is added.
> * The title text is added.
> 
> TEST=manual
> BUG=751024
> 
> Change-Id: I43c623e6fe5a960289424500292ed75c2d63f2cb
> Reviewed-on: https://chromium-review.googlesource.com/656782
> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#500846}

Bug: 751024
Change-Id: If2b9b7779fb68be80a45d4584c9dfacadd0c2f57
Reviewed-on: https://chromium-review.googlesource.com/658681
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501178}

Using wpt-import in Chromium b9382586.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/1654

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=qyearsley@chromium.org

No-Export: true
Change-Id: Ib837e1c0cfcdd3f8c9318957a38d5da093dc118c
Reviewed-on: https://chromium-review.googlesource.com/662218
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501177}

Before this CL, type can be used without extended attributes in Iterable like this:
    ex1) iterable<long>;

After this CL, type can be used in Iterable with extended attributes' list as well:
    ex1) iterable<long>;
    ex2) iterable<[Clamp] long>;

I rewrote and added pattern match based tests and integer indexed tests.

Bug: 714866
Change-Id: I1b2a264a20d6ab43c7b8ef94d6fb72dd1ddaa83a
Reviewed-on: https://chromium-review.googlesource.com/660137
Commit-Queue: Lisa Suzuki <lisabelle@google.com>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501176}

Change-Id: Ic6f12588c39abff3c1f8efd1523b3a8d0ec2ec4a
Reviewed-on: https://chromium-review.googlesource.com/657579Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501175}

I added it in order to check if the assumption was violated. As it
doesn't look violated, I would like to remove it as planned.
SweepForbiddenScope already has the DCHECK, so I'm removing it completely
rather than turning it to DCHECK.

Bug: 756496
Change-Id: Ibbc2bb7d6d5d51bcd5e02503f3dd6f81d824142d
Reviewed-on: https://chromium-review.googlesource.com/662497Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501174}

This CL introduces FirstRunActivityBase which contains logic to be shared
between FirstRunActivity and LightweightFirstRunActivity.
This CL changes LightweightFirstRunActivity to extend
FirstRunActivityBase instead of FirstRunActivity.

BUG=755646

Change-Id: Id839e78361030aef6d7a5d2e94544760f3c117c8
Reviewed-on: https://chromium-review.googlesource.com/619252
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501173}