- 22 May, 2018 40 commits
-
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/083eb25f9acb..398fb44e2866 $ git log 083eb25f9..398fb44e2 --date=short --no-merges --format='%ad %ae %s' 2018-05-22 rharrison Print access errors using logging.error 2018-05-21 ehmaldonado roll-dep: Add tests. Created with: roll-dep src/third_party/depot_tools BUG=chromium:829134 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Idef2edda9678e0be50560b28a5501364ab479a9f Reviewed-on: https://chromium-review.googlesource.com/1069308 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560767}
-
Luke Zielinski authored
In this mode the trigger just listens for certain events and updates metrics, but never sends reports. This is useful to track the frequency of suspicious site hits even if reporting quota is spent for the user. Bug: 817377 Change-Id: Ie524953a438e41a42a63d1e1852f1cfc3093f353 Reviewed-on: https://chromium-review.googlesource.com/1065575 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#560766}
-
Johannes Henkel authored
This avoids issues with initialization (net::Error is an enum) and also it avoids passing net::Error as a modifiable reference. No behavior change is intended, this is meant to be a refactoring for improving the readability. Thanks much for considering. :-) Change-Id: I04965a780fc766d1f666d9cca524505251e10080 Reviewed-on: https://chromium-review.googlesource.com/1062945 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#560765}
-
Christian Biesinger authored
Even when reusing a layout result, we still need to update the shape info. Fixes these tests when fragment caching is enabled: external/wpt/css/css-shapes/shape-outside/shape-image/shape-image-009.html external/wpt/css/css-shapes/shape-outside/shape-image/shape-image-011.html http/tests/css/css-image-valued-shape.html http/tests/security/shape-image-cors-same-origin.html Also, moving the SetMayNeedPaintInvalidation call fixes these additional tests: fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed.html fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic.html fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed.html R=ikilpatrick@chromium.org Bug: 844751 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I412fd2eddd22c40a7b0c5c7b8a8d22612c1b3759 Reviewed-on: https://chromium-review.googlesource.com/1069173Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#560764}
-
Devlin Cronin authored
TBR=sky@chromium.org Bug: 117261 Change-Id: I4a8e646354e97d3ecbbf2e6889ff9c2217f17995 Reviewed-on: https://chromium-review.googlesource.com/1069222 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#560763}
-
Matthew Jones authored
This patch prevents a flash in the toolbar when creating new tabs. The theme color of the toolbar was being set prior to being needed due to an inconsistency in state in ToolbarPhone. Now, the update logic blocks theme color updates while exiting the tab switcher and requests an update once the transition finishes. Bug: 832594 Change-Id: Idf89eb43a8ce4ed155a815cdfe11147801ef40a6 Reviewed-on: https://chromium-review.googlesource.com/1067715Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#560762}
-
enne authored
This reverts commit 0c2124b3. Reason for revert: Speculatively reverting to see if it fixes webgl conformance test timeouts Bug: 845411 Original change's description: > Use thresholds based on RAM size for OOM intervention > > This CL does not change behavior of existing experiment on 512 devices. > 1. Remove low-end device checks while enabling intervention. This can be > filtered in Finch config. > 2. Set threshold based on percentage of RAM instead of absolute number. > 3. Disable intervention if device has more than 512MB RAM and threshold > was set to absolute number. > > BUG=843419 > > > Change-Id: Ib40a038d9d2f111a514b3f41ce7f32a3ea3a156d > Reviewed-on: https://chromium-review.googlesource.com/1066804 > Commit-Queue: Siddhartha S <ssid@chromium.org> > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560430} TBR=bashi@chromium.org,ssid@chromium.org Change-Id: I4b50e522dcc6c91542927a9e769e5eee24f486a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843419 Reviewed-on: https://chromium-review.googlesource.com/1069567Reviewed-by:
enne <enne@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#560761}
-
Marijn Kruisselbrink authored
This makes sure that we don't incorrectly reject large XHR-to-blob attempts before we've initialized blob storage limits. Bug: 843975 Change-Id: I93b45b020fea4a0964af0f26ff7337e4cf85d3d2 Reviewed-on: https://chromium-review.googlesource.com/1068116Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#560760}
-
Brandon Wylie authored
Task from this codereivew comment: http://shortn/_fQvYnatNbt. Bug: 830943 Change-Id: I6ae9f717f7237083e9f4b66ce1e6343c91730940 Reviewed-on: https://chromium-review.googlesource.com/1065093Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#560759}
-
Devlin Cronin authored
https://crrev.com/9486b056 updated shared module code to use allowlist; update the documentation to match. TBR=mkearney@chromium.org Bug: 842354 Change-Id: I2663de6faa05a7322ee9c63bfab73c6777da1532 Reviewed-on: https://chromium-review.googlesource.com/1068206Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#560758}
-
erikchen authored
This CL removes unused code. It has no intended behavior change. The out of process heap profiler [see components/heap_profiling and components/services/heap_profiling] has replaced the legacy heap profiler. This CL removes the implementation and allocator hooks. Future CLs will remove the plumbing to enable/disable legacy heap profiler. Bug: 822843 Change-Id: I79e320c3f17bacf2414c5d0815b5feb4288de7d7 Reviewed-on: https://chromium-review.googlesource.com/1066576 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#560757}
-
Michael Spang authored
This adds a vulkan renderer to ozone demo. To use it, build ozone_demo with enable_vulkan=true set in GN args and run: ozone_demo --enable-vulkan Bug: 581471 Test: ozone_demo --enable-vulkan on X11 Change-Id: Ic773186b1c1634611a28d803273d6dfcdb3aa378 Reviewed-on: https://chromium-review.googlesource.com/1058137 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#560756}
-
Scott Violet authored
BUG=none TEST=none Change-Id: I35e8ccfba62d4037bbcbb4ab16bbc6185b42cf83 Reviewed-on: https://chromium-review.googlesource.com/1069319 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#560755}
-
Jacob Dufault authored
If the cryptohome supports low-entropy credentials, registering a PIN will use the cryptohome backend. We prehash the PIN before submitting to cryptohome so we can automatically migrate existing prefs-based PINs when the user signs in. This will be done in a follow-up CL. Bug: 826773 Change-Id: I7e876a0a3bb4ab9681df08873cb4cd1465489e58 Reviewed-on: https://chromium-review.googlesource.com/1033212 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#560754}
-
Justin Cohen authored
Also disables using 'shard' e.g concurrent sharding for iOS 10.3, and instead uses 'shard size' e.g. swarming sharding Bug: 845186 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs Change-Id: I9c46970d80dc08edd752d6304caeb7fb0ef2d675 Reviewed-on: https://chromium-review.googlesource.com/1067637 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by:
Menglu Huang <huangml@chromium.org> Cr-Commit-Position: refs/heads/master@{#560753}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I6774666dbd2e780b5fe7c11d35d85590e4011c90 Reviewed-on: https://chromium-review.googlesource.com/1069535Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560752}
-
John Z Wu authored
This delegate will provide change notifications so the client knows when data has changed. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If9fd061ef1ecded33acf4847582d027435509f9a Reviewed-on: https://chromium-review.googlesource.com/1064544 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#560751}
-
Pavol Marko authored
This is a sync run from the server side. Bug: b:79362100 Change-Id: I5bdfc4c39c850a682110425934597334bbbec4c6 Reviewed-on: https://chromium-review.googlesource.com/1059410Reviewed-by:
Yves Arrouye <drcrash@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#560750}
-
Mounir Lamouri authored
Re-enabling the tests as they pass locally and pass in dry run. If they are still failing, it will allow to look at logs. Is is removing the code specific to AudioWorklet thread as it was breaking the tests and it is not needed. Bug: 757759, 763550 Change-Id: Iba36290f2c7b7b3a78313dad9cb60b373ede1d07 Reviewed-on: https://chromium-review.googlesource.com/757517Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#560749}
-
Reid Kleckner authored
This reverts commit 8e57e010. Reason for revert: It breaks official builds: https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/84546 Original change's description: > Use policy to control Chrome Cleanup reporting. > > Bug: 834939 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I603d1d8d43d5317f8a8ef24f4fdbb537e0a21541 > Reviewed-on: https://chromium-review.googlesource.com/1053763 > Commit-Queue: Roger Tawa <rogerta@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Reviewed-by: Joe Mason <joenotcharles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#559685} TBR=rogerta@chromium.org,dpapad@chromium.org,joenotcharles@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 834939 Change-Id: I1b6e1a4007935abf0f6e8f9b1adf05804c431a1f Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1069387Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#560748}
-
Tom Anderson authored
BUG=845608 R=dpranke Change-Id: I365f7a2a732c0c38082b6ef76a83ed39839acb9c Reviewed-on: https://chromium-review.googlesource.com/1067742Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#560747}
-
sczs authored
- Adds the new Folder assets. (For the regular folder I replaced some un-used assets) - Changes BookmarkFolderVC to match the UIRefresh styling. - Creates TableViewBookmarkFolderCell with the UIRefresh styling. Screenshot: https://drive.google.com/open?id=1Pq5CtxhnfjA3FDyWEN-E4KzE43kJt0LZ Bug: 839451 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia76fd4173f5f1c4f9ff9e75a4e87b675d20c81c2 Reviewed-on: https://chromium-review.googlesource.com/1066939Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#560746}
-
Michael Spang authored
Add support for creating a gpu::VulkanImplementation to ui::SurfaceFactoryOzone and hook this up to the common gpu::CreateVulkanImplementation() factory function. Initially only the X11 platform has support for this through the existing X11 code. This is accomplished by moving the code into a shared component; this allows code to be compiled as needed, as there is otherwise no way for the base //gpu/vulkan component to tell when to build it. Bug: 581471 Test: ozone_demo with vulkan support added Change-Id: Ieeaecf2e72801ec851968c58a80bc4df4c45ed36 Reviewed-on: https://chromium-review.googlesource.com/1058136 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#560745}
-
Jeremy Roman authored
This reverts commit 81715b61. Reason for revert: Breaks on Win10 Tests x64 (dbg). """ BrowserFinderException: Cannot find browser of type debug. Available browsers: debug_x64 reference """ and """ Traceback (most recent call last): File "..\..\testing\scripts\run_performance_tests.py", line 312, in <module> sys.exit(main()) File "..\..\testing\scripts\run_performance_tests.py", line 284, in main sharding = sharding_map[shard_index]['benchmarks'] KeyError: '7' """ depending on shard number Original change's description: > Re-adding dummy benchamrks to chromium debug waterfalls. > > Previously > reviewed here: https://chromium-review.googlesource.com/c/chromium/src/+/1055776 > and then reverted. > > We have to set the browser for each configuration that we run on. > It will be one of debug, release or android-chromium. We can do this one > of two ways: > > 1) multiple entries in test_suites.pyl > 2) add each entry in test_suite_exceptions.pyl > > Although #1 is less verbose I think #2 is how these files are intended > to be used. > > Bug: 840427 > Change-Id: Idff4c36a248215dbfdf0faed45b483800046bf26 > Reviewed-on: https://chromium-review.googlesource.com/1066088 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Emily Hanley <eyaich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560571} TBR=nednguyen@google.com,eyaich@chromium.org,jbudorick@chromium.org Change-Id: I89ca43c0eb6292ee252c459e1db94749bfb603b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 840427,845543 Reviewed-on: https://chromium-review.googlesource.com/1069420Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#560744}
-
Jeremy Roman authored
Bug: 845411,845438 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I96ea108224def7f2c8fa5e994f5a7c8a79164e58 Reviewed-on: https://chromium-review.googlesource.com/1069329Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#560743}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/534b00dbda3e..64ac5d9eb62e $ git log 534b00dbd..64ac5d9eb --date=short --no-merges --format='%ad %ae %s' 2018-05-22 lucferron Vulkan: Quick rename of member variable in DynamicBuffer 2018-05-18 geofflang Make sure the DisplayImpl is terminated if it fails to fully initialize. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: I2ede86383b3e722928ee9c10540fb5679150a1bc Reviewed-on: https://chromium-review.googlesource.com/1069225Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560742}
-
Jian Li authored
The passed SharedBuffer data may be null if the MHTML archive is empty. Added a check for this. Bug: 831443 Change-Id: Id675c801c7df94c9596d4a91a9ba5c7458f9936b Reviewed-on: https://chromium-review.googlesource.com/1063033 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#560741}
-
Robert Ogden authored
Uses two threads, one to start the server, and another to 'ping' it until it connects to a socket. Note that connecting on a socket is a safe operation that should always succeed, even if the handler is a blackhole. Bug: 823776 Change-Id: Ibee24eca923a5f0b860241b1204791392ac408b1 Reviewed-on: https://chromium-review.googlesource.com/1069417Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#560740}
-
Hiroshige Hayashizaki authored
ScriptLoader and related classes use two document.write()-related flags: - Document::IsInDocumentWrite() at the time of PrepareScript(): directly checked within PrepareScript() and used for multiple purposes. - Document::IsInDocumentWrite() at the time of <script> element creation: plumbed from HTML parser to ScriptLoader::created_during_document_write_ and used for DocumentParserTiming. This CL merges the latter into the former: - Moves ScriptLoader::created_during_document_write_ to PendingScript::created_during_document_write_ which is set to IsInDocumentWrite() at the time of PendingScript creation, which is within PrepareScript(), and - Removes the plumbing of the flag from the HTML parser to ScriptLoader. Thus this CL simplifies the code by reducing plumbing through ScriptLoader constructor. Bug: 842349 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I2b17dd098bb134a59b9c1ba2937c74bfa46b4c0f Reviewed-on: https://chromium-review.googlesource.com/1053163 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#560739}
-
Erik Luo authored
In StylesSidebarPane, the 3-dot 'More tools' icon reveals a toolbar on hover. On 'mouseenter', we set 'display: none' on it, so the following 'mousemove' determines its bounding rect as {x: 0, y: 0, w: 0, h: 0}, and shows a tooltip in the top-left of DevTools. This CL removes the unnecessary tooltip and checks that an element is visible before showing the tooltip. Bug: 829342 Change-Id: Ib0268f70dccbb1190916796e1ca6aadaec763e5f Reviewed-on: https://chromium-review.googlesource.com/1067784Reviewed-by:Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#560738}
-
Xing Liu authored
Previously we reused the spinner code in download location dialog, this CL implements new UI in download location preference to use a custom layout with radio button and text views. We reuses the adapter to provide the underlying data used by the UI. Bug: 842464,792775 Change-Id: Iaf68fa3e75d259c9c6e6fd6d79caa1845aaf18b3 Reviewed-on: https://chromium-review.googlesource.com/1062785 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#560737}
-
Scott Violet authored
BUG=none TEST=none Change-Id: I1663a6533941bd6fa078abfdf9452bd88652d9ed Reviewed-on: https://chromium-review.googlesource.com/1069449Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#560736}
-
Jeremy Roman authored
Bug: 845473 Change-Id: Ib01509ba1ff14c4a693786912b70c79165165c16 Tbr: lushnikov@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1069418Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#560735}
-
Luke Sorenson authored
This provides an alternate API for starting the underlying media analytics process. Eventually this will be used instead of setState in production when most of the communication to the service is replaced with a Mojo channel. Bug: 842718, 799739 Change-Id: Ia0cb6c74d580bf2f9b442e2fff8a12d4878f214a Reviewed-on: https://chromium-review.googlesource.com/1042363Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#560734}
-
Dale Curtis authored
This adds support for reporting muted watch time to UKM and UMA. Only the All, Src, Mse, and Eme keys are reported to UMA, while in UKM the full foreground keyset is reported with a new IsMuted boolean variable that functions similarly to the existing IsBackground. Specifically here are the new UMA keys: Media.WatchTime.AudioVideo.Muted.All Media.WatchTime.AudioVideo.Muted.MSE Media.WatchTime.AudioVideo.Muted.EME Media.WatchTime.AudioVideo.Muted.SRC And the only new UKM key is IsMuted. This functionality is implemented similarly to how background watch time is reported: a nested WatchTimeReporter is used that is played and paused when the volume transitions to and from the muted state. BUG=779192 TEST=updated unittests. Change-Id: I1127a5bb2e6c03f1a9bba1db94d028c5218a5cbc Reviewed-on: https://chromium-review.googlesource.com/1056363Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#560733}
-
dpapad authored
This is in preparation of rolling iron-flex-layout.html to its latest version. Bug: 738611 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I25d400daa74fe9357a1be072fafaaa4237ed8dd3 Reviewed-on: https://chromium-review.googlesource.com/1068208Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#560732}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/366df7fd6e6b..7f472cd8abe4 $ git log 366df7fd6..7f472cd8a --date=short --no-merges --format='%ad %ae %s' 2018-05-22 thestig Remove useless CPDFSDK_Widget::SetDefaultValue(). 2018-05-22 thestig Fix a regression with missing text. 2018-05-22 thestig Add test case for a font substitution regression. 2018-05-22 npm Order CHKs in alphabetical order within each file 2018-05-22 thestig Remove JBIG2_memcpy() and JBIG2_memset(). 2018-05-22 thestig Remove return value from CJBig2_Image::SetPixel(). 2018-05-22 thestig Fix method style in JBig2_Image. Created with: roll-dep src/third_party/pdfium BUG=chromium:820345,chromium:820345 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie1d03549493d95c1387d28bf3ae85ccfb087aafa Reviewed-on: https://chromium-review.googlesource.com/1069299 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560731}
-
Fabrice de Gans-Riberi authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/08d5b1f33af8..145d05750b15 $ git log 08d5b1f33..145d05750 --date=short --no-merges --format='%ad %ae %s' 2018-05-21 jdennett Downgrade to C++98. 2018-05-21 jdennett Downgrade to C++98 code. 2018-05-11 steelskin Remove unused variable in Fuchsia. 2018-05-10 jdennett Add support for versioned standard libraries. 2018-05-10 jdennett Update generated code. 2018-05-10 jdennett Add unit test for CanonicalizeForStdLibVersioning. 2018-05-02 scottmg Fix gmock not building when -fno-rtti Created with: roll-dep src/third_party/googletest/src Bug: 756269 Change-Id: I785635e4cab1b511aed5715dd8b949d813dcf20e Reviewed-on: https://chromium-review.googlesource.com/1069293Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#560730}
-
Patrick Monette authored
That factory was only used for the thread-bouncing in OnModuleLoad(), which is unnecessary given that the ModuleDatabase is a singleton that never gets freed. This fixes a crash where WeakPtrFactory::GetWeakPtr() was called from multiple threads concurrently, even though it isn't thread-safe. Bug: 845110 Change-Id: I071ab52d8938922c93eeac6adc4d592669d15ae7 Reviewed-on: https://chromium-review.googlesource.com/1069328 Commit-Queue: Patrick Monette <pmonette@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#560729}
-
Varun Khaneja authored
Issue reported here: https://github.com/aawc/unrar/issues/11 Upstream fix: https://github.com/aawc/unrar/pull/12 Release: https://github.com/aawc/unrar/releases/tag/5.6.1.8.1 Bug: 750327 Change-Id: Ia418dab88b6215c7daaa0b226e10041e8cbeca3c Reviewed-on: https://chromium-review.googlesource.com/1069408Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#560728}
-