GitLab

Bug: 922649
Change-Id: I7148f5145e99d88bfed9066677841f96faccf04d
Reviewed-on: https://chromium-review.googlesource.com/c/1415298Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632389}

More logging in hope of shedding some light on issue 929413
(content_shell outliving run_web_tests).

Bug: 929413
Change-Id: I47117a85a083158d13527a535dab312774220001
Reviewed-on: https://chromium-review.googlesource.com/c/1474630Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632388}

This broke chrome cast mirroring from a minimized browser window.

This changed in https://chromium-review.googlesource.com/c/1326621

Bug: 930429
Change-Id: I0e212da02b66eed3f4b6d64c0d37fb61f1a6e840
Reviewed-on: https://chromium-review.googlesource.com/c/1468762Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632387}

Change-Id: I9c0585f678eb98d6d5b758036e11859675f659e4
Reviewed-on: https://chromium-review.googlesource.com/c/1474094
Commit-Queue: enne <enne@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Auto-Submit: enne <enne@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632386}

This fixes the GCC build which was failing like this:

    ../../base/scoped_observer.h: In instantiation of ‘void ScopedObserver<Source, Observer>::RemoveAll() [with Source = TabStripModel; Observer = TabStripModelObserver]’:
    ../../base/scoped_observer.h:26:5:   required from ‘ScopedObserver<Source, Observer>::~ScopedObserver() [with Source = TabStripModel; Observer = TabStripModelObserver]’
    ../../chrome/browser/ui/views/extensions/extension_popup.h:115:70:   required from here
    ../../base/scoped_observer.h:45:20: error: invalid use of incomplete type ‘class TabStripModel’
           sources_[i]->RemoveObserver(observer_);
           ~~~~~~~~~~~~~^~~~~~~~~~~~~~

This is caused by https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89311 ("Brace
initialization needlessly invokes destructor"), i.e. having something like

    ScopedObserver<T, U> observer_{this};

in a header declaration requires T and U to be fully declared because
ScopedObserver's destructor references them. In a few cases, T was only
forward-declared.

Bug: 819294
Change-Id: Ie5b9dc2745e27d4532c5539e3845a8c9147a0595
Reviewed-on: https://chromium-review.googlesource.com/c/1472576
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632385}

This CL adds a common factory method named BuildChromeSigninClientWithURLLoader to
chrome/browser/signin/chrome_signin_client_test_util.cc|h to create a
ChromeSigninClient instance supplying the test's URLLoaderFactory to it.
This avoids GCMSFactory::GetInstance to be referenced from various places
for similar purposes.

In the end, there is no functionality change since GCMS fetches its
URLLoaderFactory instance from SigninClient when needed.

c/b/signin/gaia_cookie_manager_service_test_util.cc|h is removed.

This includes the following files:
- chrome/browser/ui/cocoa/test/cocoa_profile_test.mm
- chrome/browser/extensions/api/identity/identity_apitest.cc
- chrome/browser/ui/views/frame/test_with_browser_view.cc
- chrome/browser/metrics/ukm_browsertest.cc
- chrome/browser/sync/test/integration/secondary_account_helper.cc|h
- chrome/browser/sync/test/integration/single_client_secondary_account_sync_test.cc
- chrome/browser/sync/test/integration/single_cl

TBR=treib@chromium.org (Marc has reviewed //c/b/sync changes in CL_1466606
    that got reverted due to another problem).

BUG=930745

Change-Id: I4887f10f0a66b7c60d21bc7fd97f1b0d8f01a84b
Reviewed-on: https://chromium-review.googlesource.com/c/1471790Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#632384}

Adds the boolean "activatable" flag to DisplayLockOptions, which is
false by default. Signifies whether the lock can be activated by the
browser when needed, in cases like find-in-page, tab order navigation,
URL fragment anchor, etc.

This CL also renames the "IsSearchable" method in DisplayLockContext
to "IsActivatable", to be consistent with the option name.

The actual activation & "beforeactivate" event will be implemented in
another CL.

See doc: http://bit.ly/2RXULVi

Bug: 882663
Change-Id: I259ff7f2fed2e3e1f446fa33f202ed2d81a76ad7
Reviewed-on: https://chromium-review.googlesource.com/c/1466544Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632383}

This migrates chromeos::UserSessionManager from NetworkChangeNotifier to
NetworkConnectionTracker, which works with the network service enabled.

Bug: 887047
Change-Id: I814311aa08ab2dafa7bf9b4ac59b3dab0e0a984e
Reviewed-on: https://chromium-review.googlesource.com/c/1237553
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: proberge <proberge@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632382}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f806ca6b..3c4ae81e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I2667b8c45fc4d51781a2f8b9e3b5ba2db0f7b30d
Reviewed-on: https://chromium-review.googlesource.com/c/1473839Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632381}

This is a code-health cleanup following discussions in
https://crrev.com/c/1462139/13/chrome/test/chromedriver/test/run_webdriver_tests.py#30

This is a mechanical substitution in blinkpy excluding third_party.

Change-Id: Ib546bb5fea743484186f62fd6fc1ea561700d610
Reviewed-on: https://chromium-review.googlesource.com/c/1473845Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632380}

This patch adds OWNERS for display locking.

R=chrishtr@chromium.org, rakina@chromium.org

Change-Id: I694dd98886d25f061e8541f85eea888968e99e9a
Reviewed-on: https://chromium-review.googlesource.com/c/1474330Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632379}

This CL was uploaded by git cl split.

R=dahollings@chromium.org

Bug: 926235
Change-Id: I84ffed30ef9dd93d3a09ca6e9c07c775d60ca11b
Reviewed-on: https://chromium-review.googlesource.com/c/1463461
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632378}

This CL fixes the ScrollFocusedEditableIntoView method when the focused
element is inside a root scroller. This method is used to scroll an
editable input box into view on Android/ChromeOS when the user taps on
it and the virtual keyboard appears, potentially obscuring it.

The first fix is in LayoutBox::ScrollRectToVisibleRecursive. For this
use case we have a special option to avoid scrolling the layout
viewport that assumed it would always be the root LayoutView. We avoid
scrolling the layout view since ScrollFocusedEditableIntoView will
queue a smooth animation to scroll and zoom so we'd like to use that.
We still perform the ScrollRectToVisibleRecursive so that if the element
is obscured by other nested content it'll be put into view.

The second fix is in ComputeScaleAndScrollForEditableElementRects. This
method calculates how much scroll and zooming is needed. The results are
applied to the layout viewport correctly; however, the input is in
document coordinates. This means we're calculating the amount of scroll
incorrectly since the content space we care about is that of the root
scroller. If we have a root scroller, the document is guaranteed to be
unscrollable so document coordinates == frame coordinates. We can simply
adjust the coordinates by the root scroller's offset to get into the
scroller's content space.

Bug: 925245
Change-Id: I383a4a8e1a3a3c7fdd7cb894989a015a9eb25e5a
Reviewed-on: https://chromium-review.googlesource.com/c/1469071Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632377}

Remove unnecessary functions for single tab mode feature.

Bug: 929386
Change-Id: I5a7729e6d7f456b7cca6d0ea088d03b14fe1566e
Reviewed-on: https://chromium-review.googlesource.com/c/1469650
Commit-Queue: Yining Wang <yiningwang@google.com>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632376}

This CL introduces ParentComponent in LocalSurfaceId which is the
bundle of parent_sequence_number and embed_token, fixes some things
that go wrong when parent_sequence_number is reset, and adds TODO for
the breakages that aren't fixed yet.

Bug: 931801
Change-Id: I21dadac5fd152579312fd9e3d717169f2fdc5351
Reviewed-on: https://chromium-review.googlesource.com/c/1470739Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632375}

CrostiniExportImportUIAllowed is a user policy that controls
whether the export / import UI is shown to a user where
they can export and import container images in crostini.

Bug: 912638

Change-Id: Ia28d1d43ca5bfbb047c6f870a1de7b4d46605fe8
Reviewed-on: https://chromium-review.googlesource.com/c/1468223Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632374}

... and remove the latter as it was the last client.

BUG=916303,913570

Change-Id: Ida37eda8bcc61ca3382769e650f30165cd184c93
Reviewed-on: https://chromium-review.googlesource.com/c/1465145
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632373}

zlib uses malloc() to allocate temporary data. Unfortunately, on Android,
jemalloc (malloc()'s underlying implementation) caches temporary data after
free() in a thread-local cache. As renderers don't allocate from malloc() often
in background threads, this data is not reclaimed. This increases memory usage
by up to 256kiB per background compression thread, which is the cause for a
sizable malloc() memory regression from foreground string compression (see
linked bug).

The deeper reason for the regression is more complex, see details in the linked
bug, and
https://docs.google.com/document/d/1aRIifaHF5l9relq9vHirTOWt2AZoAkDNqHiYZrWGE9A/edit?usp=sharing

It involves some interaction between:
- jemalloc implementation and memory accounting
- Android's configuration of jemalloc
- Chrome's allocation and threading patterns
- zlib's allocation patterns

Nevertheless, the regression is real, and to mitigate it, use PartitionAlloc to
allocate zlib's temporary data.

This is not necessary for decompression, as the allocation patterns are not the
same, and the main thread doesn't have the same issues. As such, only do it for
compression, to avoid a needlessly complex CL.

On PartitionAlloc vs malloc():
The only path using partition alloc in this CL in from the renderer process,
where it is already widely used. The issue is less likely to appear in the
browser process as malloc() is more widely used there, though further
investigation may reveal issues.

Android vs everywhere:
The issue is present at least with jemalloc(), that is Android. However thread
caches and arena-allocators are used on other platforms as well, and as the
allocation is not performance-sensitive, using PartitionAlloc everwhere makes
the code simpler, and protects against potential issues (as we know that this
specific issue does not arise with PartitionAlloc).

Bug: 931553, 924164
Change-Id: I9e94e9cea5d51fac67b04fdb1681427e57bfbe1f
Reviewed-on: https://chromium-review.googlesource.com/c/1472578
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632372}

Introduce RulesetSource struct to be used for indexing code. This should help
make the indexing code a bit more generic since it does not need to assume the
location of the json and indexed ruleset files.

BUG=930961

Change-Id: I9f6f63434adbe8d3fbc0e5148c466c578c3dd422
Reviewed-on: https://chromium-review.googlesource.com/c/1466281Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632371}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/452a49f4b699..3ab00a7d068b


git log 452a49f4b699..3ab00a7d068b --date=short --no-merges --format='%ad %ae %s'
2019-02-14 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@3ab00a7d068b

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I04ef2e71f5f17a57dfde673f62d5d965702092b9
Reviewed-on: https://chromium-review.googlesource.com/c/1473875Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632370}

This CL was uploaded by git cl split.

R=japhet@chromium.org

Bug: 926235
Change-Id: I46f54cabb463e6322effde6316335e8d5e04abb8
Reviewed-on: https://chromium-review.googlesource.com/c/1464130
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632369}

There are two namespaces in extensions named GetRefererrChain and
in jumbo builds the identically named namespace aliases create for
them clashed. This just uses the full namespace name instead of
using aliases so that it's always clear (to compiler and humans)
which one is used.

Bug: 914411
Change-Id: I43336e962a82756bf4be7db74417c6a1fc78e889
Reviewed-on: https://chromium-review.googlesource.com/c/1472571Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#632368}

https://dawn.googlesource.com/dawn.git/+log/6fe9b9821a1a..1541c8ba7a7e


git log 6fe9b9821a1a..1541c8ba7a7e --date=short --no-merges --format='%ad %ae %s'
2019-02-14 enga@chromium.org Remove |start| and |size| from buffer mapping
2019-02-14 enga@chromium.org Split wire tests into multiple test files
2019-02-14 cwallez@chromium.org QueueSumit: Validate commands != nullptr before checking they are valid


Created with:
  gclient setdep -r src/third_party/dawn@1541c8ba7a7e

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:931880
TBR=cwallez@chromium.org

Change-Id: If917d0170c30ee1d2cbb1bf8b9e621edc9e1aadd
Reviewed-on: https://chromium-review.googlesource.com/c/1473879Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632367}

This moves TabCapturePerformanceTest and CastV2PerformanceTest into
browser_tests. By default, they have been changed to run in a quick-
check mode. When run for performance testing on the perf bots, the
additional --full-performance-run command line switch will be required.

The performance_browser_tests isolate config has been changed to run
browser_tests with the --full-performance-run switch, gtest filters,
and timeout overrides. Also, the old performance_browser_tests GN test
target has been turned into a simple group target that groups the
necessary data dependencies for running on the perf bots.

This change also includes some changes to allow the tests to complete
in the absence of tracing data when in quick-check mode. While most
bots do collect a reasonable amount of tracing data in a few short
seconds, one or two don't always do so. Unfortunately, we can't justify
making the CQ run longer to force data collection in all cases.

Bug: 804191
Change-Id: I2de6c0b94453981fb0d9015f6b3f0e42f57cc2a6
Reviewed-on: https://chromium-review.googlesource.com/c/1428399
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632366}

https://skia.googlesource.com/skia.git/+log/126ac6365c3c..10f3c40674e4


git log 126ac6365c3c..10f3c40674e4 --date=short --no-merges --format='%ad %ae %s'
2019-02-14 bungeman@google.com Don't respect FontConfig matrix for bitmap fonts.
2019-02-14 fmalita@chromium.org [SVGCanvas] Clean up public factories
2019-02-14 bungeman@google.com Defer loading particle effect to load time.
2019-02-14 robertphillips@google.com Baulk at creating wait semaphores if we can't always delete them
2019-02-14 michaelludwig@google.com Add blendmode to GrRTC::drawTexture
2019-02-14 egdaniel@google.com Use kRGB_888x_SkColorType when importing R8G8B8X8 AHB.
2019-02-14 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-02-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 1f0e830f..b698b62f (516 commits)
2019-02-14 halcanary@google.com resources: add text for testing shaper
2019-02-14 egdaniel@google.com Add kRGB_888X_GrPixelConfig


Created with:
  gclient setdep -r src/third_party/skia@10f3c40674e4

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stephana@chromium.org

Change-Id: I06dfd4e1a0a633f695e0a4008d02f7f77ed5f377
Reviewed-on: https://chromium-review.googlesource.com/c/1473874Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632365}

It's likely that at some point in the past Exo didn't properly emit
release events for buffers that were still attached to a surface when
that surface was destroyed.

Add this test to check that Exo now provides the expected behavior and
ensure we don't regress in the future

Change-Id: Ic73a49aebd9693b701c77580645d49e32dd96aca
Reviewed-on: https://chromium-review.googlesource.com/c/1458258Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632364}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/ffa447f419e1..0444f9acb88d


git log ffa447f419e1..0444f9acb88d --date=short --no-merges --format='%ad %ae %s'
2019-02-14 manojgupta@google.com chromeos_config: Make {arm64-generic|kevin64}-paladin important.
2019-02-14 cjmcdonald@chromium.org chromeos_config: Enable internal manifest for goma-full builder
2019-02-14 dgarrett@google.com default PreCQ: Remove betty-arcnext-pre-cq
2019-02-14 evanhernandez@chromium.org cros branch: Validate version after syncing.
2019-02-14 evanhernandez@chromium.org cros branch: --force overrides version check.
2019-02-14 evanhernandez@chromium.org cros branch: Final cleanup.
2019-02-14 evanhernandez@chromium.org cros branch: Users confirms generated branch name.


Created with:
  gclient setdep -r src/third_party/chromite@0444f9acb88d

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ia2c7e5d2d9ef7a8dba0808aaad32e0c8e6aa6b8d
Reviewed-on: https://chromium-review.googlesource.com/c/1473873Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632363}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0167a20b0af8..1b0047f21017


git log 0167a20b0af8..1b0047f21017 --date=short --no-merges --format='%ad %ae %s'
2019-02-14 stevenperron@google.com Add pass to remove dead members. (#2379)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@1b0047f21017

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Idef7a1d3aa1d0201af32934afa3275925caa16f6
Reviewed-on: https://chromium-review.googlesource.com/c/1473871Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632362}

https://chromium.googlesource.com/angle/angle.git/+log/52047de4d41f..77874e2ca341


git log 52047de4d41f..77874e2ca341 --date=short --no-merges --format='%ad %ae %s'
2019-02-14 timvp@google.com Vulkan: Reduce Default Descriptor Pool Max Sets


Created with:
  gclient setdep -r src/third_party/angle@77874e2ca341

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: I12682e011aa292292d5f04bf459dac8e9bf3b541
Reviewed-on: https://chromium-review.googlesource.com/c/1473872Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632361}

Previously this class was used for SadTab presentation.

Bug: 616244
Change-Id: I8f8fcf722e79a723dd279c0be5f4348e3876069e
Reviewed-on: https://chromium-review.googlesource.com/c/1467983Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632360}

BUG=931436,767906

Change-Id: Ic1a6eb88edcf3dbd06845d0d83230b1d8858f8f0
Reviewed-on: https://chromium-review.googlesource.com/c/1471255
Commit-Queue: Will Harris <wfh@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632359}

https://android.googlesource.com/platform/external/perfetto.git/+log/81bd0ea1ec21..4976b9f5f855


git log 81bd0ea1ec21..4976b9f5f855 --date=short --no-merges --format='%ad %ae %s'
2019-02-14 treehugger-gerrit@google.com Merge "Break up BookkeepingThread::HandleBookkeepingRecord."


Created with:
  gclient setdep -r src/third_party/perfetto@4976b9f5f855

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I27461becba7ecb3e9f3f4ad35bdbead5b225e56e
Reviewed-on: https://chromium-review.googlesource.com/c/1473876Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632358}

This CL changes the expires field of a NEL policy from base::TimeTicks
to base::Time. This will make it easier to serialize and deserialize
policies for persistent storage and, per the comment in
//base/time/time.h, a base::Time is more appropriate for tracking
expiration times.

Bug: None
Change-Id: Ib4530a97c178441228f42c46ac5195e04e9ba7df
Reviewed-on: https://chromium-review.googlesource.com/c/1461327
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632357}

Change-Id: I7ac0ec999afead7d39012b3a22b5b77e1670def0
Reviewed-on: https://chromium-review.googlesource.com/c/1468401Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Commit-Queue: proberge <proberge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632356}

We mocked out the android implementation in our early implementation, which
we address here. The AndroidIdleDetector makes bridge between the C++ idle
detection system and Android's Java Broadcast receivers.

Intent to implement:

https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OuwzBmH02M4

Design doc:

https://docs.google.com/document/d/1_XlwY3NuG2HwWEYVrR-MNvw_i4hj5ZNj3gKvxWqO0FU/edit

Bug: 878979
Change-Id: I2a6c288c750574f1d777115d9e574c66a3dcbbdb
Reviewed-on: https://chromium-review.googlesource.com/c/1415296Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Sam Goto <goto@chromium.org>
Auto-Submit: Sam Goto <goto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632355}

I forgot to add a null check as Dmitry suggested here:
https://chromium-review.googlesource.com/c/chromium/src/+/1357666/4#message-bc921121ce2c839de5e6a614a51ae48952d1a53a

Bug: 908592
Change-Id: I32d46fd2feef20b7c129ea5bf7075fd386befcb9
Reviewed-on: https://chromium-review.googlesource.com/c/1471220
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632354}

This is required for the test to pass on Android P.

Bug: 931480
Change-Id: I65dc175ed754a4201204bfdaf1cacd70d5f7e0df
Reviewed-on: https://chromium-review.googlesource.com/c/1471462Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632353}

For EG2 tests, we'd like to use ios/web/public/test/http_server from the
test process, but without pulling in all of //ios/web.  Moving this
utility function allows http_server to depend only on //base, //net, and
//url.

BUG=930859

Change-Id: Ia1e35b04089a3bd2cf00ee0e7a663783ac2762a7
Reviewed-on: https://chromium-review.googlesource.com/c/1473616Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632352}

As discussed in https://crrev.com/c/1449653 add a trace to make it
easier to spot priority inversions happeingin due to this wait.

Bug: 927548
Change-Id: I7f96079c5b290eabadc4b127ee15ece52f57f356
Reviewed-on: https://chromium-review.googlesource.com/c/1454919
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632351}

Some fonts have kerning between some characters and the space
character, which is unsafe if the line wraps there and the
space becomes a trailing space to be removed.

This patch avoids such reshaping unless the width of the text
is visible.

This patch improves:
  ArabicLineLayout by 40%
  chapter-reflow-once-random by 40%
  loading.desktop FCP:layout by 1-4%

Bug: 636993
Change-Id: Ifc190ccbce164b1ba498e922f98ffaa9b1c181f4
Reviewed-on: https://chromium-review.googlesource.com/c/1469846
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632350}