GitLab

BUG=None

Change-Id: I4f0c8fd5a24a5bfc1f3a81c96026a33c7700639e
Reviewed-on: https://chromium-review.googlesource.com/538980
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481024}

The patch which added the butter-bar for unimplemented modes
broke the task-profiler case for the heap-profiling flag.

Bug: 705461
Change-Id: Ib293ce8aa8d4c2f763c7b9ba414923381f2d9870
Reviewed-on: https://chromium-review.googlesource.com/540983Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481023}

This CL sends the Expect-CT expiration into the reporter, to include in the
report as key "effective-expiration-date".

http://httpwg.org/http-extensions/expect-ct.html#rfc.section.3.1

BUG=679012

Review-Url: https://codereview.chromium.org/2944953002
Cr-Commit-Position: refs/heads/master@{#481022}

[Offline pages]: Check ResponseHeader for null pointer before getting response code in Background Offliner

Bug: 734371
Change-Id: Ie5f3803931c67d27223564b542657c9824a59e36
Reviewed-on: https://chromium-review.googlesource.com/538740
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481021}

NOTRY=true
TBR=ulan@chromium.org

Bug: 735173
Change-Id: Iac9cceb3f5a05aa249d1565337602f2a65b4ee79
Reviewed-on: https://chromium-review.googlesource.com/541607
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481020}

BUG=

Review-Url: https://codereview.chromium.org/2940403002
Cr-Commit-Position: refs/heads/master@{#481019}

Add a feature to enable a timestamp on the Previews infobar. This
timestamp should be shown when the previews_freshness is greater
than the finch controlled "min_staleness_in_minutes" and less than
"max_staleness_in_minutes".

BUG=718643

Review-Url: https://codereview.chromium.org/2940083003
Cr-Commit-Position: refs/heads/master@{#481018}

TBR=charliea@chromium.org

Bug: 713222
Change-Id: I012ede587d5445937b1a92f0c985853a91e6d55c
Reviewed-on: https://chromium-review.googlesource.com/540827Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481017}

At this point there seems to be little danger that people will add
lines to SmokeTests willy-nilly, so I don't think we need special
owners for it.

R=ojan@chromium.org, jbudorick@chromium.org, peter@chromium.org

Change-Id: I75a71b1ee800348742177caf3ea94b1aca675d8b
Reviewed-on: https://chromium-review.googlesource.com/541603Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481016}

PersistenceDelegate is a new interface for persisting the contents of
the HostCache. This commit includes the interface itself, the logic in
HostCache for interacting with it, and a mock implementation of the
interface for testing. It does not include support for immediate data
removal since that won't be needed for the currently planned use case.

BUG=605149

Review-Url: https://codereview.chromium.org/2943143002
Cr-Commit-Position: refs/heads/master@{#481015}

Added the logic to create archive directories if the result of SavePage
is ARCHIVE_CREATION_FAILED. This is going to prevent potential increment
of failure rate once we move temporary pages to cache directory, and
download pages to external downloads directory which are vulnerable to
removal by user actions.
Also added an UMA counting the result of archive creation and related
tests.

Bug: 725266
Change-Id: Id726365ea53786077d71b02831f6dfca0d16c4f3
Reviewed-on: https://chromium-review.googlesource.com/540995Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481014}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/821867d51814..1556ddcf20a1

$ git log 821867d51..1556ddcf2 --date=short --no-merges --format='%ad %ae %s'
2017-06-20 simonhatch Dashboard - Add link to bisect docs in output.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I2ec3f077748783a87a826a41aae8a9ae74dc6580
Reviewed-on: https://chromium-review.googlesource.com/541553
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481013}

Reintroduces document click handler to screen_account_picker which brings
lock screen app window (if one exists) to foreground - this should happen
if the user clicks outside user pod/login header bar.

Removes background dim when an app window is in background - new UI
has the background dimmed by default.

Review-Url: https://codereview.chromium.org/2945153002
Cr-Commit-Position: refs/heads/master@{#481012}

BlockingPool is deprecated and being replaced with TaskScheduler.

BUG=667892

Change-Id: I9a4f133ccb3b173de468e8e26be179182b57eb64
Reviewed-on: https://chromium-review.googlesource.com/540475Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481011}

This file contains a ChromeRecovery.crx3, which contains a
ChromeRecovery.exe.

Bug: 687231
Change-Id: Ia9789b1c5c4cd8884d56c25e0765045dda7a749a
Reviewed-on: https://chromium-review.googlesource.com/541101Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481010}

The allocator shim is temporary until the base on can be refactored. The rest of the machinery for out-of-process heap profiling is hooked up in this patch.

Review-Url: https://codereview.chromium.org/2949703002
Cr-Commit-Position: refs/heads/master@{#481009}

This CL creates a feature-policy directory under wpt/, as well, provides some
framework for testing features with feature policy.

Using the framework, this CL added feature policy tests for payment, and
modified existing feature policy usb tests using the framework introduced.

Bug: 732003
Change-Id: I7d690acfe70b63d4935f6a4c6c43e94da5503827
Reviewed-on: https://chromium-review.googlesource.com/533953Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481008}

NOPRESUBMIT=true

Bug: 
Change-Id: I5c5b274bb7f520ef55081f3779922c5d0955e12a
Reviewed-on: https://chromium-review.googlesource.com/540289
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481007}

This CL:

* Introduces the RemotingResourceFactory class for providing different resources
  depending on whether it's an external or internal build.
* Adds an AppInitializer for initializing common resources.

BUG=731851

Review-Url: https://codereview.chromium.org/2937733003
Cr-Commit-Position: refs/heads/master@{#481006}

Add qiangchen@ as owner of c/b/ui/views/desktop_capture/.

Bug: None
Change-Id: I0e0ca093f1224abcd7ce7accf9400b11f1eab7cb
Reviewed-on: https://chromium-review.googlesource.com/540822
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481005}

Currently content download only supports upper case guid. This CL
limits guid in download service to be upper case ascii chars.

In the future, we should consider the two guid approach to decouple
from content layer guid details.



Bug: 734818
Change-Id: Id03a234c0edb14c9ee7a66d5bb486cb1503e1840
Reviewed-on: https://chromium-review.googlesource.com/540679Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481004}

Revert of Skip missing translations when generating JSON resources. (patchset #2 id:60001 of https://codereview.chromium.org/1676793002/ )

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 480994 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2QyZjUzYmUxNjFiMDFhNGNmMDRkZmEzODdiNjZiZGE3MTBmNjAxYzAM

Original issue's description:
> Skip missing translations when generating JSON resources.
>
> It doesn't make sense to replace missing translations with english
> strings because Chrome can do this automatically when getting
> resources.
>
> BUG=369572
>
> Review-Url: https://codereview.chromium.org/1676793002
> Cr-Commit-Position: refs/heads/master@{#480994}
> Committed: https://chromium.googlesource.com/chromium/src/+/d2f53be161b01a4cf04dfa387b66bda710f601c0

TBR=thakis@chromium.org,sergeyu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=369572

Review-Url: https://codereview.chromium.org/2948893002
Cr-Commit-Position: refs/heads/master@{#481003}

Prep CL for https://codereview.chromium.org/2882063002

BUG=721395
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2903213004
Cr-Commit-Position: refs/heads/master@{#481002}

In general, if a try job is successful, there
are no interesting new baselines or expectations to add.

If the tests were run, this just saves us one request;
if the tests were not run because the change doesn't
affect some platform, then this prevents us from printing
a warning message.

Change-Id: I937f4686bdf8911f10ba5f19d401ac088a3975eb
Reviewed-on: https://chromium-review.googlesource.com/526253
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481001}

https://pdfium.googlesource.com/pdfium.git/+log/d5a13afe9265..e10509a3d2a1

$ git log d5a13afe9..e10509a3d --date=short --no-merges --format='%ad %ae %s'
2017-06-20 janeliulwq Wrapper class for annotation dictionary + CPDF_Form

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I97324f780352e85c7fb7b53620f2b2de8c6bba34
Reviewed-on: https://chromium-review.googlesource.com/541795
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481000}

The drivers for several devices on Windows appear to not properly handle
querying for controls used in the context of Image Capture. These cases lead to
video capture being broken and users seeing only a blank image.

This CL adds a feature flag kImageCaptureControls Image Capture on Windows. 
For now, we disable this feature by default. The feature can be enabled by 
adding --enable-features=ImageCaptureControls to the command-line.

Bug: 722038
Test: Manual tested on Windows using iSpy virtual device.
Change-Id: I654ff72772af10c2d5356d5131ed7ed98e300c1f
Reviewed-on: https://chromium-review.googlesource.com/530076Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480999}

This logic matches the surface creation logic on Wayland.

BUG=angleproject:1651

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Icca63e3778d2f4c327da44758b09b9328d02adee
Reviewed-on: https://chromium-review.googlesource.com/537967Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480998}

Zucchini is a patching tool inspired by Courgette, for delta compression of archives containing common exexecutable formats.
This is the first step of integrating Zucchini in Chrome Installer.

BUG=729154

Review-Url: https://codereview.chromium.org/2922273002
Cr-Commit-Position: refs/heads/master@{#480997}

It didn't previously have a way of handling experimental options which
don't translate to settings on the URLRequestContextBuilder. This change
allows it to directly change settings on the URLRequestContextConfig so
those settings can be used outside of the builder.

This struct shouldn't really be a struct anymore, but it already
shouldn't really have been a struct. This CL is the minimum change
needed to unblock an upcoming feature plus some closely related cleanup.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2952653002
Cr-Commit-Position: refs/heads/master@{#480996}

Use logical offsets as much as we can, and have legacy layout convert
it for us when storing physical offsets in FloatingObject. Use
SetLogicalLeftForFloat() and SetLogicalTopForFloat() in
LayoutBlockFlow for this. They actually take inline and block offsets.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Iffd4aa759cb520f03a7642f15c1e40279e48c2b9
Reviewed-on: https://chromium-review.googlesource.com/541363Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Cr-Commit-Position: refs/heads/master@{#480995}

It doesn't make sense to replace missing translations with english
strings because Chrome can do this automatically when getting
resources.

BUG=369572

Review-Url: https://codereview.chromium.org/1676793002
Cr-Commit-Position: refs/heads/master@{#480994}

Currently, the flex-direction property is a 'storage_only' field, so
it has no generated public getters/setters.

This patch changes it to a 'keyword' field so that its getters/setters
can be generated as well. We also generate the EFlexDirection enum and
use the generated CSSValueID <-> EFlexDirection mappings.

Diff: https://gist.github.com/297d38d32b4b097536e73f7c1bd1b3d7/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2942393002
Cr-Original-Commit-Position: refs/heads/master@{#480688}
Committed: https://chromium.googlesource.com/chromium/src/+/d6df17438f4c6ae0a69e5650f63d0cd6c8d72a00
Review-Url: https://codereview.chromium.org/2942393002
Cr-Commit-Position: refs/heads/master@{#480993}

Memory estimate is collected from Directory for directory based datatypes and
from SharedModelTypeProcessor for USS datatypes. It is triggered right after
configuration when all sync data is loaded into memory.

BUG=706214
R=pnoland@chromium.org

Review-Url: https://codereview.chromium.org/2950583003
Cr-Commit-Position: refs/heads/master@{#480992}

The directory is not used on iOS at all.

Review-Url: https://codereview.chromium.org/2944973002
Cr-Commit-Position: refs/heads/master@{#480991}

R=thestig@chromium.org
CC=gab@chromium.org,peter@chromium.org,hashimoto@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2928513003
Cr-Commit-Position: refs/heads/master@{#480990}

Adds the border and shadow to the narrow-mode dropdown in Mac.

This does not implement the rounded corners yet, as that will be a lot
more work. That's still forthcoming.

BUG=728844

Review-Url: https://codereview.chromium.org/2934873002
Cr-Commit-Position: refs/heads/master@{#480989}

network traffic to the task manager for tracking network usage.

There are a number of naming changes to help distinguish between what
is and isn't a "rate" and what is sent vs read vs transferred. Read being
incoming bytes, sent being outgoing bytes and transfered being either
read or sent bytes.

The "rates" are not calculated based on what is live on the network.
It is instead based on when requests are completed so large uploads
will all be registered in one refresh.

This update changes the struct BytesReadParam to BytesTrasferedParam
and stores both bytes read and bytes sent. It updates how the struct is
processed to handle the additional tracking of sent bytes.

Tasks have been changed to store the cumulative_bytes_read_ and
cumulative_bytes_sent_ which are stored on Refresh() to the
last_refresh_cumulative_bytes_sent_ and
last_refresh_cumulative_bytes_read_ . These are used to calculate
network_sent_rate_ and network_read_rate_ which are summed for the
network_usage_rate_.

Tasks no longer store a network usage of -1 to signify that they have
not had any network traffic, the utility of that flag no longer appears
to be used so it was removed. Because of this ReportsNetworkUsage() has been removed.

Tasks and Task Groups can now report their cumulative network usage.

BUG=720773

Review-Url: https://codereview.chromium.org/2905403002
Cr-Commit-Position: refs/heads/master@{#480988}

culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzFhZWE3ODM3YTMxZDI1ZmI1ZTc0MjJjOTNhMmVmYmQxYTRiOGMzODgM

TBR=dpapad@chromium.org,jochen@chromium.org,nyquist@chromium.org,mathp@chromium.org,gogerald@chromium.org,anthonyvd@chromium.org,pkasting@chromium.org,zea@chromium.org

Change-Id: Ieb0fa227b6d22a3ff95cdc78f71de429a5baac15
Reviewed-on: https://chromium-review.googlesource.com/540793
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480987}

TBR=smut

Review-Url: https://codereview.chromium.org/2952733002
Cr-Commit-Position: refs/heads/master@{#480986}

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2949853002
Cr-Commit-Position: refs/heads/master@{#480985}