- 21 Sep, 2020 40 commits
-
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009210800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/cIWqR5ZGkLWwRsrEQfxfW_msq-yAvUIUa0Xxwz6bCXkC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/152286436,b/159892033,b/162706572,b/165872577,b/165883916,b/168080782 Tbr: media-app@grotations.appspotmail.com Change-Id: I83bad7ba8ef0f532a66b4bb56d9a51a6fe44510a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422206Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808922}
-
Dave Tapuska authored
This change moves the rest of the UpdateVisualState handling into blink. No functional changes are intended. BUG=1097816 Change-Id: Ib162f3add233971c76ceff4206e113bf66c6ad8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402116 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#808921}
-
Victor Hugo Vianna Silva authored
Some code that has minimal dependencies on AndroidSyncSettings depends unnecessarily on SyncContentResolverDelegate in its tests. This CL removes these dependencies (either by mocking AndroidSyncSettings or by using AndroidSyncSettingsTestUtils) and SyncContentResolverDelegate is made a package-private class. Bug: 1129426 Change-Id: I5374ea7378456bc7060e186254d3e6f80523ceb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421811 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#808920}
-
Corentin Wallez authored
Bug: chromium:1130483 Change-Id: Ie339143e1830e70e0da98a3cfc803cc6934f6e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421509 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#808919}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/62f651b1..ef916081 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia4004ba63c758f135307cc524d3252204e68835a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422040Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808918}
-
Mohamed Amir Yosef authored
The feature "AutofillUseApi" is now enabled by default. This CL removes it and starts removing dead code upon the removal of this feature flag. Follow up CLs will do more cleanup! Bug: 1114655 Change-Id: Iff96e341280fe35562469d32660446f5568887f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401040Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#808917}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f343742a8c9d..05f0bbb70bde If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC etiennep@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: etiennep@google.com Change-Id: I3bb0d9354322e82086b035607e5825c868f02449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422204Reviewed-by:
-
Yves Arrouye authored
This CL inserts the info discussed in go/zt-alt+v-id in the "version" string which already contains the serial number, while preserving the existing placement of the OS version on the left and the serial number on the right. See screenshots in bug. This CL shows the ZTE indication and always includes the ADID even when it is the same as the SN). Bug: chromium:1124875 Test: Build Chrome, deploy and restart UI, see ZTE info if warranted Change-Id: I2a70098546472b2a237ff6f9a0f82f375ab3f3fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404689 Commit-Queue: Yves Arrouye <drcrash@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808915}
-
dpapad authored
- Emit 'open-changed' events from cr-action-menu and add test. - Update viewer-pdf-toolbar-new to leverage these. - Change viewer-download-controls to use same approach. Previously relied on manually updating a boolean when the menu was triggered and when it was closed. Fixed: 1130107 Change-Id: I9303cd4a6cc4befd5aaf99e7eff9b0b95a8ec5d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421184Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#808914}
-
Tanmoy Mollik authored
The profile image in NewTabPage opens SyncAndServicesSettings page. When MOBILE_IDENTITY_CONSISTENCY is on, it should instead open MainSettings page. Bug: 1129933 Change-Id: I84a1701214b271caf6bf2727391dbc8c7506d468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421508 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4c87d83d0323..023e1ac7bc8e 2020-09-21 titovartem@google.com Improve reporting of plottable metrics in PC framework 2020-09-21 nisse@webrtc.org Delete unused NetEq stats currentPacketLossRate, currentDiscardRate and addedSamples If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1054c09fc5ff476fcf67e8e0a13d3f56b8c2228f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422198Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808912}
-
Renato Silva authored
The Assistant flow in OOBE mentions that it will only listen when the device is connected to a power source in order to save battery when no DSP is available. This prevents this message from showing up on Chromebases, Chromebits and Chromeboxes. Fixed: 1109363 Bug: 1109363 Change-Id: I188a06d8e7c42064a6daab8f27a2e963930ee1fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416696 Commit-Queue: Renato Silva <rrsilva@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
David Dorwin authored
Change-Id: Id74811dd56b8a4370959ed5c03a32aeea12ec5a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422338Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808910}
-
Rouslan Solomakhin authored
This reverts commit 379dbfae. Reason for revert: Finalizers are banned in Chromium. These finalizers have been causing assertion failures due to being called on the background thread. Bug: 1129695 Original change's description: > Add finalizers to Web Payment Java objects that own native objects > > These C++ objects are destroyed in PaymentRequestImpl.closeUIAndDestroyNativeObjects(). > However, if an object is garbage-collected for any reason without > PaymentRequestImpl.closeUIAndDestroyNativeObjects() being called, > then it will cause a memory leak. > > A finalize method should be added to these objects to ensure destruction > of the owned C++ objects. > > Bug: 1090918 > Change-Id: I12df86f9705d81d630b63223d15354d2b022e888 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392290 > Commit-Queue: DongJun Kim <djmix.kim@samsung.com> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804820} TBR=rouslan@chromium.org,djmix.kim@samsung.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1090918 Change-Id: I7710d7065a7e225be3a331b0dec289506ee1d4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422238Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#808909}
-
Nate Fischer authored
This adds a collapsible section with manual steps for removing system apps. This is helpful in case the script is broken (I've heard this is still the case for some devices) or someone wants to remove a different system app (ex. WebView shell). Fixed: 1006037 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: Id7a1bce22df6246bba34b6926a818c24c0e2d37c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419812 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Laís Minchillo <laisminchillo@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#808908}
-
George Burgess IV authored
It seems that this constructor call was intended to be used as a scope guard. In order for that to happen, there has to be a variable name here. Bug: 1130379 Change-Id: I895e76e1f450b944791679e8e2a4df09d5b317f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420914Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#808907}
-
Ryan Daum authored
* Unless is_char is true blink will interpret the key event as a raw keypress instead of a proper keystroke. Derive and pass through this property correctly. * Mark the event as EF_IS_SYNTHESIZED and ui::kPropertyFromVK, in the same manner that chromeos's virtual keyboard implementation does. Bug: internal b/161811385 Test: manual x86 cast_shell build with wayland_webview_client attached Change-Id: I4d752bd219eb540a719e0bd339ab674bbbd3db23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418999Reviewed-by:Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#808906}
-
Denis Kuznetsov authored
Also updated OfflineGaiaTestMixin to use new JSChecker features. Bug: 1110790 Change-Id: If30fde066b4768affc1ace615d2a745d791bbc1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418407 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f2db91bc8aed..2d461fa4a07b 2020-09-21 treehugger-gerrit@google.com Merge "ui: Make it impossible to select the close permalink button" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia2b549ce5e396bfc678479d7a7c1987914552f21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422200Reviewed-by:
-
Maxim Kolosovskiy authored
The timeout should be in seconds, not minutes. Bug: 1095627 Change-Id: I95b508f6bccaa23150cbf250531e4966c5f35034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421599 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Milica Selakovic <selakovic@google.com> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Milica Selakovic <selakovic@google.com> Cr-Commit-Position: refs/heads/master@{#808903}
-
George Burgess IV authored
It seems that this constructor call was intended to be used as a scope guard. In order for that to happen, there has to be a variable name here. Bug: 1130379 Change-Id: Iddba99a77b86488298c9ca214cfd0cee92b2ac3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420920Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#808902}
-
Mark Yacoub authored
Split the displays passed to the ScreenManager so that the list of configs all share the same DRM. This ensures that all parallel operations are done on the same DRM (i.e. Atomically committing all display props on the same commit, which requires the same fd). BUG=1082882 TEST=no changes in enabling or disabling displays. Change-Id: I2f38449c2114f71672f409b50808a92d72f758db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405414Reviewed-by:
-
Irina Fedorova authored
This CL adds a sort of weak credentials to GetWeakCredentials(). It uses the same comparator as used to display the list of saved passwords in the UI. Bug: 1119752 Change-Id: Iac597b71a55321f1a72a2d0f378f506976c8d21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418815 Commit-Queue: Irina Fedorova <irfedorova@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#808900}
-
Dominik Röttsches authored
Measure latency on the Blink side for IPC roundtrips retrieving fonts from Android downloadable fonts. Bug: 1115064 Change-Id: I0bb3f2f53470858de5c7803a1f6ec096be28f4e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416291Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#808899}
-
Andrew Grieve authored
* Fixes an issue with an unrecognized compiler flag. * Could not get -flto to work and no good error message from the failure. Left a TODO to re-enable it. Bug: None Change-Id: I683119e43e767ff5b228706bc6b6f68c2282f7a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418993Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#808898}
-
nancylingwang authored
This CL adds unit tests to verify: 1. Loading compressed icons. 2. Loading icons from the resource. 3. Loading icons from the compressed data. BUG=1083331 Change-Id: I35d0ff87e7f8a1f5099408f194572b3c527b3213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418692Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#808897}
-
Etienne Pierre-doray authored
org.chromium.chrome.features.start_surface.StartSurfaceLayoutTest#testCloseTabViaCloseButton is flaky. TBR=meiliang@chromium.org Bug: 1130212 Change-Id: I2f1f44879c9f849db98ded90f53568971d77ef2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421610Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#808896}
-
Yuanyao Zhong authored
The valuables scroll_extent_min and scroll_extent_max are only meaningful when the node is scrollable and min is smaller than the max. On non-x86 the value is 0, so it was working previously. However on x86 the value is "8000 0000" Test: build on device and x86 version to test the functionality. Bug: None Change-Id: Ie065617712722f2250067293836221e57f7a0a9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419599Reviewed-by:
Randy Rossi <rmrossi@chromium.org> Commit-Queue: Yuanyao Zhong <yyzhong@google.com> Cr-Commit-Position: refs/heads/master@{#808895}
-
Henrique Nakashima authored
Output now looks like this (removed some lines for brevity): Printing class dependencies for .c.b.app.flags.ChromeCachedFlags: 2 inbound dependency(ies) into .c.b.app.flags.ChromeCachedFlags: [chrome_java] <- .c.b.app.ChromeActivity <- .c.b.init.ChromeBrowserInitializer 6 outbound dependency(ies) from .c.b.app.flags.ChromeCachedFlags: [chrome_java] -> .c.b.app.appmenu.AppMenuPropertiesDelegateImpl -> .c.b.tasks.ReturnToChromeExperimentsUtil -> .c.b.tasks.tab_management.TabUiFeatureUtilities -> .chrome.features.start_surface.StartSurfaceConfiguration [//c/b/flags:java] -> .c.b.flags.BooleanCachedFieldTrialParameter -> .c.b.flags.CachedFeatureFlags was before: Printing class dependencies for org.chromium.chrome.browser.app.flags.ChromeCachedFlags: 2 inbound dependency(ies) into org.chromium.chrome.browser.app.flags.ChromeCachedFlags: [//chrome/android:chrome_java] org.chromium.chrome.browser.app.ChromeActivity org.chromium.chrome.browser.init.ChromeBrowserInitializer 6 outbound dependency(ies) from org.chromium.chrome.browser.app.flags.ChromeCachedFlags: [//chrome/android:chrome_java] org.chromium.chrome.browser.app.appmenu.AppMenuPropertiesDelegateImpl org.chromium.chrome.browser.tasks.ReturnToChromeExperimentsUtil org.chromium.chrome.browser.tasks.tab_management.TabUiFeatureUtilities org.chromium.chrome.features.start_surface.StartSurfaceConfiguration [//chrome/browser/flags:java] org.chromium.chrome.browser.flags.BooleanCachedFieldTrialParameter org.chromium.chrome.browser.flags.CachedFeatureFlags Change-Id: If9535c19ab5121a6a057e5c6d1dedea657e453ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392942Reviewed-by:Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#808894}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d970d657aa56..4559368cc4a1 2020-09-21 robertphillips@google.com Add MRU to GrThreadSafeUniquelyKeyedProxyViewCache If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: csmartdalton@google.com Change-Id: I7e3303255f103ec31b28878f1b1c0a535bb48e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421544Reviewed-by:
-
David Jean authored
The collapsed state is shared silently by the ListModel (by saving to NSUserDefaults). So if more than one window use the same collapse key, they become unsync if one changes without telling the others. Bug: 1125093 Change-Id: I987f98c590f743fd12f7d8aab3ac2782554a9a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409908 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#808892}
-
Anqing Zhao authored
Considering this case was disabled 3 years ago, but it runs successfully in local test. Let's re-enable it and monitor its current status. Bug: 766169 Change-Id: I3518ef855e4cd319ca0e2045fe764751d0c54923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420608 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#808891}
-
Manuel Rego Casasnovas authored
We can avoid the Unite() operation in AdjustScrollableOverflowForPropagation() when we're processing a kFragmentBox, because ScrollableOverflow() already returns the element's size for that type of elements if TextHeightType is kNormalHeight. BUG=1128984,1130140,1130141 Change-Id: I828b7098e1a40b975bd257f99525e7cc9f4956fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420611Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#808890}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fcd0fd47bdba..a53556930038 2020-09-21 adithyas@chromium.org Portals: Add support for highlighting in ConsoleContextSelector 2020-09-21 sigurds@chromium.org Show report-only mode setting for COOP/COEP in frame tree 2020-09-21 jacktfranklin@chromium.org Fix ElementsBreadcrumbs mutation bugs. 2020-09-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-09-21 tvanderlippe@chromium.org Upgrade TypeScript to 4.1.0-beta 2020-09-21 changhaohan@chromium.org Skip idle state e2e test for now 2020-09-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-09-21 tvanderlippe@chromium.org Fix more issues for TypeScript 4.1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1005916,chromium:1011811,chromium:1051466,chromium:1129881,chromium:1130513 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I03f82624125a4224eff1dae62cd8447ffa051a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421546Reviewed-by:
-
Sebastien Lalancette authored
Updated EG tests and also had to disable drag-drop functionality in Reading List, Bookmarks and History tables when EG tests are running. This is because of an EG framework issue (which hangs the tests) that is being worked on: crbug.com/1129058 Bug: 1110944 Change-Id: I378d86e76cff6aa6e2389f5fc008a8e5805d7061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368497Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#808888}
-
Michele Mancina authored
Bug: b/169042549 Change-Id: Ie69d4306bc055278c344fc4de8decf46d8a287c5 Change-Id: Ie69d4306bc055278c344fc4de8decf46d8a287c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421451 Commit-Queue: Michele Mancina <micantox@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#808887}
-
Nicolas Ouellet-Payeur authored
This CL removes Nearby Share code from the Linux/Windows builds: https://crrev.com/c/2416726 This wasn't caught by the traffic_annotation_auditor buildbot, because the CL only modified BUILD files. So we need to fix annotations.xml separately. TBR=rhalavati@chromium.org Change-Id: I75241d848dacf798665be0f86d62530bac6b4406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422239Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#808886}
-
Fredrik Söderqvist authored
Reorder the function to check for a paintserver resource first and then return any color. This structure should be more conducive to future paintserver handling. Change so that we don't resolve a color if there is no color value to resolve. Also apply the same restriction to the visited paint/color, such that only a color can "replace" a color. Bug: 109212 Change-Id: I81a0c47b694406c931663804df6705f7bf651572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418372Reviewed-by:
-
Peter Kotwicz authored
This CL adds a strict mode violation exemption for DexPathList#toString() for Android P in addition to the existing suppression for Android O. The fix to not call File#isDirectory() in DexPathList#toString() landed in Android Q. BUG=1109678 TBR=agrieve Change-Id: I5d028a4584c2e2de7acfe2cdd2631260d3f61cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417494 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#808884}
-
arthursonzogni authored
We want to display "issues" in the Devtool panel when an access is made in between two windows from different virtual browsing context group. Checking the access was previously gated behind having at least one reporting endpoint defined. This patch removes it. We are still gating emitting ReportingObserver events behind having a reporting endpoint defined. This might be something we might want to remove in the future as well. Bug: 1124251 Change-Id: I0e77ed9530d55ec50a011caedd765c07612b407b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418711Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#808883}
-
