- 11 Aug, 2020 40 commits
-
-
sauski authored
The no-search attribute was erroneously left permanently enabled for the cookies-page element after the solidification of the privacy settings redesign. This CL removes the attribute, which should never be present. Bug: 1067336 Change-Id: Ifc56db8e951492d0aee9fdee67efe9f9b7589a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346668Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#796756}
-
My Nguyen authored
Autocorrect range and bounds are wrong after new line because the offset is in a different node. Need to use PlainTextRange instead. Bug: 1114543 Change-Id: I913bd8a2d150388fc034236eba42e5983f765383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344566 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796755}
-
Kent Tamura authored
Add a fieldset check to NGSimplifiedLayoutAlgorithm() to avoid CHECK failures in the following tests. - external/wpt/inert/inert-retargeting-iframe.tentative.html - external/wpt/inert/inert-retargeting.tentative.html They failed in NGPhysicalBoxFragment::CheckSameForSimplifiedLayout() at DCHECK_EQ(is_fieldset_container_, other.is_fieldset_container_). Bug: 875235 Change-Id: I14251ee9385375076317f983e9c21c9f89c51a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346100Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#796754}
-
arthursonzogni authored
This updates some variable names in the access-reporting/ WPT test direction. This doesn't change the WPT test behaviors. The first iteration of tests were using: - callback_token - executor_token while the new one are using: - openee_token - opener_token - test_window_token This patch upgrades every names to the last iteration, to maintain consistency. Bug: 1090273 Change-Id: If49be91fd99d93d14271693fda11ce68a866217d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346351 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#796753}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4f52dde7..86f54785 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iddb79e447272554680c33c611d556e509789528c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348053Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796752}
-
Alex Rudenko authored
This CL implements a new method for searching for nodes by computed styles. Design doc: https://docs.google.com/document/d/1wEldHPdUW3cwoUk54vZQmDsggK4LAPUb69fMEDLrKrg Bug: 1109177 Change-Id: Ife6e00c6361722f6902d7fc37feecd03e5fb1773 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340975Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#796751}
-
Anatoliy Potapchuk authored
This tast have been increasingly flaky on ASAN/LSAN builders for the recent few days: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ASan%20LSan%20Tests%20%281%29 TBR=eugenebut@chromium.org Bug: 1114226 Change-Id: I549b6caef3046e36da64da5010179e965b6e8fbb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348928 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#796750}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I0b56999b4bd96a1d8ec32ca826878d2001396777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348490 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#796749}
-
Hiroshige Hayashizaki authored
They are now called only from ClassicScript. This CL removes them and makes ClassicScript directly call EvaluateScriptInMainWorld(). This CL exposes EvaluateScriptInMainWorld() needed for this. Bug: 1111134 Change-Id: I16eb81d2328e975e4ed0a9dc9428a3669d9f9aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326051 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#796748}
-
Noel Gordon authored
Files app currently uses chrome.mediaGalleries.getMetadata for content mime type sniffing, and audio/video blob metadata extraction. However, chrome.mediaGalleries.getMetadata is deprecated. Split the API into two parts getContentMimeType and getContentMetadata being the constituent parts chrome.mediaGalleries.getMetadata, this to allow files app to skip parsing blobs that are not audio or video. Reuse service manager's public media galleries SafeMediaMetadataParser for parsing blobs in the utility process. Add file manager private IDL and external Closure type definitions. The CL owes much to existing mediaGalleries.getMetadata implementation C++; we run on the UI thread and use the same tools: extension::Blob:: Reader and utility process SafeMediaMetadataParser. The helper routine to convert a mojo::MediaMetadata to a MediaMetadata is mostly verbatim and the extensions system Metadata IDL types also. Changes that extend mediaGalleries.getMetadata: support for empty blob input, map audio mime type to video mime type if the MediaMetadata has width and height (only video sets those fields). No change in behavior, no new tests. Tests coming in CL:2345936. Bug: 1114622 Change-Id: I89346376db54c387383505b7839f92b38512deb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344335 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#796747}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33d3db6eaffb..35ae05bf9fc1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC alancutter@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: alancutter@google.com Change-Id: I63e3fc479bc53fd1340eb1e143bceeb1780dc2cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348327Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796746}
-
Nohemi Fernandez authored
This test appears to have been classified as flaky when in fact the analysis tools show that there were infrastructure failures for the ios_chrome_ui_eg2tests_module across various devices. https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVgsSBUZsYWtlIktjaHJvbWl1bUBpb3NfY2hyb21lX3VpX2VnMnRlc3RzX21vZHVsZUBGaXJzdFJ1blRlc3RDYXNlL3Rlc3RUb2dnbGVNZXRyaWNzT24M Bug: 1109117 Change-Id: I0ccfebacb5c04c764eb494e9ca43639a9d30005b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343109Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#796745}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597103970-7949af98f84f094ce49225adb2a5f704b5b255e9.profdata to chrome-mac-master-1597125357-adec03df0679051d9df22e43cd9f58968dde96e7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I89a677cd553e2ea70637f3c94d6b0ab36b452ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348593Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796744}
-
Jan Wilken Dörrie authored
This change adds an "Edit password" menu item to the compromised credential view on Android. Furthermore it adds a corresponding `onEdit` to PasswordCheckCoordinator.CredentialEventHandler, hooks up the mediator and adds a test. Translation Screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/29fbfcf5121721e305692723d8531f61540e5065 Bug: 1114720 Change-Id: I7166c3c9c16555fad99f4dc37c5865b5b584881f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346248Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#796743}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f64194d1efb6..bb67d54f9310 2020-08-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 48ba75ac6845 to 23335ac01cb8 (21 revisions) 2020-08-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 1662e97f324e to cbec3179ef87 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1104516,chromium:1112800 Tbr: fmalita@google.com Test: Test: Test: dEQP-GLES2.functional.fbo.render.recreate_* Change-Id: Ib92e07554bf2a6894367918dd988d9f64dbf1fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348325Reviewed-by:
-
Tal Pressman authored
This CL introduces the (empty) AgentSchedulingGroupHost class, that is owned by the RenderProcessHost. For now, a new ASGH is created per RPH. Bug: 1111231 Change-Id: Ib384fc34e4fa72e6c1c9e709e4599da1f82a6bc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294699 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
-
Naoki Fukino authored
If write-related functions are called on read-only roots, we can return errors immediately instead of making mojo calls which always fail. Bug: 956852 Test: Ran unit_tests Change-Id: I81bbe3aea12f683ecf7dc89db698983d35202a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346101Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#796740}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d07b78c82f85..3903e3a96c5d 2020-08-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-08-11 szuend@chromium.org [issues] Cleanup firing of FullUpdateRequired event in IssuesManager 2020-08-11 szuend@chromium.org Type-check ui/ARIAUtils.js with TypeScript 2020-08-11 alexrudenko@chromium.org Layout pane 2020-08-11 szuend@chromium.org [TypeScript] Don't use document as a Map in ui/AriaUtils.js 2020-08-11 szuend@chromium.org [issues] Add detection for third-party SameSite cookie issues If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1080589,chromium:1109177 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifa5a8b931a1e50fdb1710eb0f9f4dfc9c84005ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348588Reviewed-by:
-
Alexander Dunaev authored
The Textfield::WriteDragDataForView sets transparent background color for the drag image, which is not always supported on X11 (depends on whether the compositing manager is available), but Ozone/X11 didn't check that and always used the transparent color. This CL adds a new method in the Ozone platform that returns whether transparent color could be used. Bug: 1085700 Change-Id: I2c812086993fc825bb8f7bc0d416b7aa4ab44d89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323293Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#796738}
-
My Nguyen authored
InputMethod isn't notified of the change in focus until the focus is already changed. Let InputMethodController handle autocorrect marker removal. Bug: 1114877 Change-Id: I1e5a8f0ae1e52d3ec2aa0f97f0479bf987787451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345932 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
These tests confirm sandbox directives are no-op for workers, because sandbox directive is not yet specified for workers. (This CL doesn't add tests for dedicated workers, because dedicated workers inherit parent Document's CSP, the parent Documents should be sandboxed and thus it's hard to test whether dedicated workers from sandboxed Documents are sandboxed) Bug: 1112143, https://github.com/w3c/webappsec-csp/issues/279 Change-Id: Iff34da98de61214584681ae6f12ffcbf1dee1880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333908 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#796736}
-
Tomasz Śniatowski authored
Fall back to the old behavior of just writing to a trace file directly if we're unable to open a temporary file in the same directory. This can happen in some configurations on restrictive Android systems for example, where the browser may only be able to write to the actual file specified in --trace-startup-file, and not to any nearby path. Bug: 1082916 Change-Id: I3c1275b4c70cc8edb6e50adc321ba412c6226de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346352Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Tomasz Śniatowski <tsniatowski@vewd.com> Cr-Commit-Position: refs/heads/master@{#796735}
-
Frédéric Wang authored
According to the URL specification [1], several parts of a parsed url must UTF-8 percent-encoded supersets of the C0 control percent encode set [2]. However, Blink does not do that for U+007F DELETE in the cannot-be-a-base-URL path and fragment states [3] [4]. This CL fixes that and also adds URL WPT tests for various URL percent-encoding cases. You can find more details on the Chrome status entry [5] and intent-to-ship thread [6]. [1] https://url.spec.whatwg.org/#concept-basic-url-parser [2] https://url.spec.whatwg.org/#c0-control-percent-encode-set [3] https://url.spec.whatwg.org/#cannot-be-a-base-url-path-state [4] https://url.spec.whatwg.org/#fragment-state [5] https://chromestatus.com/feature/5651438652882944 [6] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/en6buycTcKQ Bug: 809852 Change-Id: I9c75224a537f09a5b41ca7e9295f2a3bf7fad061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324425Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#796734}
-
Koji Ishii authored
Another fix to use |PostLayoutChildren|, this time in |NGPhysicalLineBoxFragment::ScrollableOverflow|. DevTools console hits the DCHECK added in r795416 <crrev.com/c/2339699>, this patch fixes the case. Bug: 965639 Change-Id: Ia3a74eb45c17923fa879dd0b663f48b441481968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345941Reviewed-by:
-
Alan Cutter authored
virtual/threaded-prefer-compositing/fast/scrolling/resize-corner-tracking-touch.html is flaky on all platforms. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests&tests=fast%2Fscrolling%2Fresize-corner-tracking-touch.html TBR: lanwei@chromium.org Bug: 1095540 Change-Id: I9d5f70d9c2e42236505d5d03e7818651aa000acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348489Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#796732}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/cf8ea9c25903..faa233ccab76 2020-08-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 48eed585..5246cdb2 (796566:796691) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic6238b67379aa42820bd3f91a3e83a9a4b2f2680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348323Reviewed-by:
-
Christopher Cameron authored
As background, YUV 420 biplanar videos on macOS (basically all videos) cannot be sampled directly in OpenGL. When we want to sample them, we do a copy and YUV to RGB conversion. In the compositor, we will draw either using OpenGL or using overlays. We bracket our use with calls to Begin/EndSharedImageAccess using the argument READ (for GL) or OVERLAY (for overlay). In the case of overlay access, we skip the copy. The DisplayResourceProvider will agglomerates the calls to Begin/EndSharedImageAccess into a single pair -- so if there is already a READ access active, and another READ access comes in, then we skip the second call to Begin/EndSharedImageAccess. The bug is that if we do OVERLAY access, and then want READ access, the DisplayResourceProvider will say "oh, you already have access, I'll skip the BeginSharedImageAccess call". Which means no copy, and random texture contents. To fix this, detect the case of transitioning from OVERLAY to READ access, and do a EndSharedImageAccess followed by a new BeginSharedImageAccess. This is all fairly horrible. Once we move everything to the SkiaRenderer, then we can remove the OVERLAY GL parameter and forget that this episode ever existed. Bug: 1113925 Change-Id: I25071324eb49c5fd3026a77c20034c9f5e647328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346843 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#796730}
-
Yusuke Sato authored
crrev.com/796583 broke post-submit ARC tests on P boards. BUG=1114931 TEST=tast run DUT_EVE arc.Boot Change-Id: Id2bed1c14707763023ee145f6bc8931ecf5b847b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348197Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#796729}
-
Peter Kasting authored
This changes the API to look like CallbackList's: instead of calling UnregisterEvent(), callers destroy a subscription object they get from registering. This is a bit easier for callers to deal with. However, the necessity of also synchronously clearing the event from the WaitSet makes the implementation a bit irritating, since while CallbackList does provide a hook to be called back on callback removal, that happens after notification is finished, rather than right at subscription destruction. Instead of using the hook, wrap the CallbackList::Subscriptions in an object that will also remove the WaitSet item if need be. Bug: none Change-Id: Ideb74b1435bfaad1647324e5ba5f90976c268e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343956 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#796728}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/531d992f00bb..95df5d3cbaf6 2020-08-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: Iced333d87d724c5a8155d62995d38aede59ab75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348320Reviewed-by:
-
Ahmed Mehfooz authored
This CL adds skeleton code for the dark mode feature pod. Bug: 1106012 Change-Id: Icb4046bf25fd90482a69588611445a2604c39247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339289 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796726}
-
Peter Kasting authored
It looks like rounding would reduce overall error in these spots. Bug: none Change-Id: I473aa9dac00e454ae2ec344bf554928ce9236a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345287Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#796725}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e80c7a00e1c9..33d3db6eaffb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC alancutter@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1110338 Tbr: alancutter@google.com Change-Id: I41daa4d230b4603c55a4650af4d14377881f3f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348098Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a4b9169fb6b3..f64194d1efb6 2020-08-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 4430c2c5 to 5246cdb2 (398 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: I0180b7b5e1f58925aba05a1e221b86e39910a34c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347398Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5ca8a31b. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ia23ccfbd5870b621fc6db812ad47d1a82356233d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347346Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796722}
-
Lei Zhang authored
Normally, when Print Preview finishes, the browser will call PrintPreviewDone(), which in turn calls OnClosePrintPreviewDialog(). Change PrintPreviewDialogControllerBrowserTest and PrintRenderFrameHelperPreviewTest to do this as well. This is in preparation for a follow-up CL that changes when webpages are (un)paused for printing. With that CL, tests can no longer start a print preview and leave it in an unfinished state like it does now. Bug: 956832 Change-Id: I70908f0b86bfa288c257a65046c021cdd6138c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340515Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#796721}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/275a495dbb2d..23335ac01cb8 2020-08-11 ynovikov@chromium.org Roll chromium_revision ed7912a2..c8c2c646 (794870:796654) 2020-08-11 ynovikov@chromium.org Fix clang revision regexp in chromium autoroller to match new format 2020-08-11 jmadill@chromium.org TestRunner: Fix test result handling. 2020-08-11 ynovikov@chromium.org Skip WebGL2CompatibilityTest.CopyMip1ToMip0 on Mac Intel GL 2020-08-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from f881f08358b0 to 2de6d657dde3 (2 revisions) 2020-08-11 ynovikov@chromium.org Suppress dEQP-GLES3 failures on D3D11 NVIDIA If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1104516 Tbr: ynovikov@google.com Change-Id: I99939da3733d1853f04b882ba76ef7f6c983731b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348251Reviewed-by:
-
Lei Zhang authored
In PrintRenderFrameHelper::PrintNode(), the print preview path sends beforeprint/afterprint events, but the system print dialog path does not. Fix this discrepancy. Though in practice, this does not matter because the only nodes that can be printed are probably plugins. Change-Id: Ibe45bb97ab7a614e7004a090c3e665b61144ca99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342139Reviewed-by:
-
Joe DeBlasio authored
This CL adds sensitive keyword detection to the simplified domains logic. It leverages the existing 'has-sensitive-keywords' heuristic, with some modifications, to trigger elision instead of a Safety Tip. Some of those changes include: - Searching through all subdomains, not just the e2LD, - Exclusion of common words in the keywords found, - Some general code cleanup, - Some housekeeping to eventually support more than 500 keywords. Bug: 1106962 Change-Id: I955c150968ef8b2e8fcf0ede85e4128b2545087a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343536 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#796718}
-
Ahmed Mehfooz authored
Bug: 1114820 Change-Id: I2eaf8d09ec99ee4115ecae8fe26ab2ec4eedea93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347305 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#796717}
-
