- 07 Aug, 2020 40 commits
-
-
Sophie Chang authored
Bug: 1112970 Change-Id: I6d8fbbb236a185bec828d11720407b66aee3f8c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337287 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#795755}
-
Matthias Körber authored
Change-Id: Ic1f755bb69a5f1313ed702906b673ed959942cc6 Bug: 1113955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340970Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#795754}
-
Yutaka Hirano authored
To delete WebURLLoaderImpl::SinkPeer, this CL has PrefetchURLLoader to handle no-state prefetch requests. Bug: 1112310 Change-Id: I2c13bd91969bdb41105f246d570f9ca100a63c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041152Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#795753}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0427441466a3..5cf00e267438 2020-08-07 bsheedy@chromium.org [Telemetry] Disable testGetMinidumpPathOnCrash If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1108432 Tbr: oysteine@google.com Change-Id: Iea7d91a9f5a8f97c5f38ceccb7fa49b1d61c35d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341855Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795752}
-
Stephen Martinis authored
This reverts commit e6ad8b42. Difference from previous reland: using close and join instead of terminate Original change's description: > Revert "Reland "Parallelize fetching telemetry benchmark deps"" > > This reverts commit 95e22d39. > > Reason for revert: Potentially breaking many builders, https://crbug.com/1108314 > > Original change's description: > > Reland "Parallelize fetching telemetry benchmark deps" > > > > This is a reland of 8ab0b856 > > > > Original change's description: > > > Parallelize fetching telemetry benchmark deps > > > > > > The fetching script currently fetches about 2 GB (on my linux workstation) > > > from cloud storage serially. This can (and is) trivially parallelizable, and > > > should speed up the fetching script significantly. > > > > > > This script has been taking 20 minutes on mac machines for a long time. This > > > will hopefully significantly speed the mac builders up. > > > > > > Bug: 1102597 > > > Change-Id: I93d2fa2b1f4b4ef6e27e9c894a9dd4c0d0e12d7b > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285503 > > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> > > > Reviewed-by: John Chen <johnchen@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#786521} > > > > Bug: 1102597 > > Change-Id: I37d0055fadb26bf4eae2b0b5fe0ecc4732edde3d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288740 > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > Reviewed-by: John Chen <johnchen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#789736} > > TBR=martiniss@chromium.org,johnchen@chromium.org,wenbinzhang@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > # Tree is currently closed, trying to fix an outage > > No-Try: true > No-Tree-Checks: true > Bug: 1102597 > Change-Id: If6b95395208a3136a798118e4eb229e4322c7878 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317774 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791304} TBR=martiniss@chromium.org,johnchen@chromium.org,wenbinzhang@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1102597 Change-Id: I2f9a7162e73ee264ed9f0f844f45106160bce793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339589 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#795751}
-
Yuheng Huang authored
Setup ctrl(cmd on Mac) + shift + e as tab search keyboard shortcut for all desktop platforms Bug: 1099917,1112558 Change-Id: I6c50b26714d678d0f89d2c846909ff0b802e4f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329944 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#795750}
-
Claudio M authored
The comment can be removed because crbug.com/855192 and its canonical crbug.com/872096 are closed (obsolete). Bug: b:163002438 Change-Id: I7ef1c7854cb82a3855fd0d09f7d0ccaef0daa112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340924Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Claudio M <claudiomagni@chromium.org> Cr-Commit-Position: refs/heads/master@{#795749}
-
Marijn Kruisselbrink authored
In preparation for making BlobUrlRegistry per storage partition, this cleans up the code a bit by moving all the blob URL logic to a separate class. This CL itself should not have any behavior changes, it is purely moving code around. Also fixes some naming inconsistencies (URL vs Url among others). Bug: 1106890 Change-Id: I0e7f9f8597d280ee2f69286c5a35cbb3997c9d9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330314 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#795748}
-
Wei Li authored
Bug: none Change-Id: Idaae709188c12ef7f8b8b94b3362e6e20983f90e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324410Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Florian Uunk <feuunk@chromium.org> Reviewed-by:
-
Devlin Cronin authored
One test still had handling for either js-bindings or native bindings. Since native bindings have been shipped for a long time, remove the old js binding errors. Bug: None Change-Id: Ifa37068f9356c5d210593f068864b6efff3e0d20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336995Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795746}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2c4a07d925cc..b3231b152604 2020-08-06 johnstiles@google.com Disable the coverage-as-alpha optimization flag for the Bicubic effect. 2020-08-06 brianosman@google.com Fix IWYU error in metal-code generator, re-gen dither effect If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I6385ce2ba53ccf2744a3bd4b72a1198050e91391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340680Reviewed-by:
-
Reilly Grant authored
This test appears flaky. See the issue for details. TBR=alancutter@chromium.org Bug: 1113951 Change-Id: I1fd43393848727c9144cc28948084dc425d85dd5 No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341669Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#795744}
-
Chris Thompson authored
Bug: 1100647 Change-Id: Ibd84d2d12d3b750c864311535d041064c715aa8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340642Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#795743}
-
Thiabaud Engelbrecht authored
Freelist size is only meaningful on the client side, that is Client SharedDiscardableMemoryManager. Virtual size is already reported on the service size, though not per-client. Add reporting to process memory metrics, to UMA only. Bug: 1106364 Change-Id: I03fe01e3f140f23d7b84794453bda0179a9f4176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314832Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Cr-Commit-Position: refs/heads/master@{#795742}
-
Ilia Samsonov authored
Requires https://chromium-review.googlesource.com/c/chromium/tools/build/+/2339301. Bug: 1104846 Change-Id: I2d8ccfd51c840af7e922d8b5b999a397d45f8c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341696Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#795741}
-
Owen Min authored
Create PolicyServiceAndroid and PolicyServiceObserverAndroid class so that the Java part can listen to the policy initialization event. Bug: 1108118 Change-Id: I7766808291eef6e0deab3a2d3f7badd2d64b6d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327286 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#795740}
-
chinsenj authored
If a user is previewing a wallpaper and begins to cycle windows, the preview item for the wallpaper picker is empty/transparent. Now when the window cycle starts up, it closes the wallpaper preview if it is open so the preview item displays the wallpaper picker properly. Test: WallpaperControllerTest.ClosePreviewWallpaperOnWindowCycleStart Bug: 895265 Change-Id: Ie1900f2ce172ec03407e6801c051d34f0a94d975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341143Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#795739}
-
Devlin Cronin authored
The old docs at chrome/browser/extensions/api/README.txt are obsolete with chrome/common/extensions/api/schemas.md and extensions/docs/writing_a_new_api.md. Remove it. Bug: None Change-Id: If5de57295ad326b55742536435f4aa7dc524fac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340165Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I1b5c7195ad6ef8263c5deee2c485069b40696589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341176Reviewed-by:
-
Thomas Lukaszewicz authored
The Chrome for ChromeOS team is looking to collect UMA metrics for the time taken to render the initial list of tabs in our Tab Search feature's UI. This metric needs to be logged from the JS side and access to the Extensions API provides a clean way to log this data. This is the recommended way to log metrics in WebUI code. Bug: 1099917 Change-Id: Icf16404d47406858fd3c6cef2ba4b8462f2edb18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339211 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#795736}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metatada from OWNERS files for //app Bug: 1113033 Change-Id: I31c0900fc4e4135fcbc5f0945669d3574b8272aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341157 Commit-Queue: Norman Rosas <normando@google.com> Auto-Submit: Norman Rosas <normando@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#795735}
-
Wan-Teh Chang authored
After decoding each image, validate that the image's YUV format matches the YUV format from the container. Also copy the bit depth validation to the DecodeToYUV() method. Bug: 960620, 1113777 Change-Id: I2802b61858d4675b7efb4710e547e6487528ba46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341039 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#795734}
-
Ahmed Fakhry authored
This CL builds on previous UI work, and adds the necessary views for implementing the CaptureBarView. BUG=1112919 Change-Id: I1807458bb7ca6149e600b596b5cb6a87adbbdff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333825 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#795733}
-
Dominic Mazzoni authored
AccessibilityNodeInfo.ACTION_CONTEXT_CLICK is already implemented; make sure AccessibilityNodeInfo.ACTION_LONG_CLICK does the same thing. Bug: 1095107 Change-Id: Ib3511a13fc4537b8e59c01fae2bf261832eadc28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341398 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#795732}
-
Michael Moss authored
e3a62dc [Mac]Exit with unique status in symupload when file already exists. BUG=1021742 R=mark@chromium.org, nbilling@google.com Change-Id: Idbbdd6a959b0c2b10a7880c72d91e6efbdd67967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342046 Auto-Submit: Michael Moss <mmoss@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#795731}
-
Rayan Kanso authored
Change-Id: If9d4f5018f944d59118b392e5d88933991ffa1b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341122 Auto-Submit: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#795730}
-
Caleb Raitto authored
Text operations are tracked via the 2D canvas context digest, not the PaintOp digest. Because these digests are maintained separately, without this change, drawing a rectangle and then text wouldn't be distinguised from drawing text than then a rectangle in the final, combined digest. Bug: 973801 Change-Id: If237733320d0a2e3ce95dcbd3bc2f97c69d888bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327132 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#795729}
-
Ahmed Fakhry authored
This is the first CL that implements the CaptureBarView. It only adds the CaptureModeToggleButton, and the CaptureModeCloseButton, subsequent CLs will build on these two views to implement the rest of the UI. TBR=beccahughes@chromium.org BUG=1112919 Change-Id: If9aca284bf419936df61ef0e285d1f143b06b0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336021 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#795728}
-
Toshiki Kikuchi authored
This CL fixes the issue that selecting async apps (e.g. ARC apps) from overview does not trigger auto snapping in tablet splitview. In tablet splitview, when a window is snapped, we can select which window to fill (be snapped in) the other side. It works for synchronized Chrome windows, but not for async windows because calling Unminimize(), which is used for canceling the restore animation, bypasses auto snapping. So we should use Show() here and extract async activation logic from OverviewItem to make sure it works for async apps. BUG=b:162552497 TEST=SelectMinimizedSnappableWindowInSplitView Change-Id: I653451533c58a6241130a5ab369bb080290810af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327364 Commit-Queue: Toshiki Kikuchi <toshikikikuchi@chromium.org> Reviewed-by:
-
Eric Orth authored
Add a flag to DnsUdpTracker to signify "low entropy" (setting that flag in non-test is TODO for a subsequent CL). Rework DNS attempt code to allow using TCP instead of UDP when that flag is set. Bug: 1093361 Change-Id: I74e935e0ddf2a76112222e395b6b1c7e6bf469bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340281Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#795726}
-
Melissa Zhang authored
This CL closes the sharesheet once an app is launched. Bug: 1097623 Change-Id: I72ab0f8ff39569a4fd14a1f3f3efd1df46af7f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338154Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#795725}
-
Nate Fischer authored
This adds a "clear text" icon to the flag UI's search bar. The "clear text" icon is hidden by default and only appears if the user has typed some text. This imports the "clear text" material icon for the close button. Bug: 1052345 Test: run_webview_instrumentation_test_apk -f FlagsFragmentTest.* Change-Id: Ia694ca5f13a38ce25107dade3921221670251b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340651 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#795724}
-
Rakina Zata Amni authored
We shouldn't proctively swap BrowsingInstances if the current frame has not committed any navigation yet. See: https://chromium-review.googlesource.com/c/chromium/src/+/2210174/16/content/browser/frame_host/render_document_host_user_data_browsertest.cc#305 Bug: 977562 Change-Id: If228976b79d6fb0e8cc99492a50c5acb65bef73e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340361 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#795723}
-
Darren Shen authored
As a workaround, SetCompositionRange can be implemented by first finishing the current composition, deleting the new composition range, and recomposing with the deleted text. Works ok on a nocturne, but flickers about 10% of the time due to latency from deleting and recomposing. Bug: 1113940 Change-Id: If7147d3727850694cc68c45662f72178bcb06fd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340943 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#795722}
-
Reilly Grant authored
This test appears to be flaky. Further details on the bug. TBR=mmenke@chromium.org Bug: 11139282 Change-Id: I559a75c6840502c5683b56616b703678899195a6 No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341821Reviewed-by:
-
Zach Trudo authored
SharedQueue wraps a std::queue with RefCountedThreadSafe to allow it to be shared across threads. It utilizes a SequencedTaskRunner in order to ensure that Pop and Push commands are done in order of arrival. Bug: chromium:1078512 Change-Id: I57ec543fc3bf641ee16cd2e36fbe8f24ac082102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340709 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#795720}
-
Justin DeWitt authored
Previously, the android manifest would be included always, this can result in issues extra permissions being requested if minSdkVersion is not set. Bug: 1113301 Change-Id: I716fdf151a0ef56fbddfea990db2f0fe9b131f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340066Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#795719}
-
Nate Chapin authored
Change-Id: If76acf50bb70df341c88164961912b74b0c3bb31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341818Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#795718}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/32be4523385c..0427441466a3 2020-08-06 bsheedy@chromium.org [Devil] Run pkill retry through strace If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1038789 Tbr: oysteine@google.com Change-Id: I3ba758b5ff41089fff2d051d44cd8eba0c01e3b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341937Reviewed-by:
-
Nate Chapin authored
This only matters for Documents that will be attached, but given that the Document will attach to the LocalDOMWindow, that should be the primary object the DocumentInit holds. Also, while cleaning up state on DocumentInit, remove GetUseCounter(). It's only use is during the Document constructor, and we have another reliable path to the UseCounter. Change-Id: Iafbb3c1c335c37bdf5bcf7e2ed3856ebf22bc861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339399 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
