- 17 Jul, 2019 40 commits
-
-
Mitsuru Oshima authored
This is no longer necessary. Bug: 984347 Test: updated the test. no functional change. Change-Id: Ia1ae37b6ed9a84af49ce5e6ab3025f0d9cb13ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704314Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#678299}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e574f1e409aa..64329094c2a8 git log e574f1e409aa..64329094c2a8 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 egdaniel@google.com Move renderable flag and valid samplecounts in GrGLCaps to FormatInfo. 2019-07-17 egdaniel@google.com Add comment regarding gl BGRA format and renderability. Created with: gclient setdep -r src/third_party/skia@64329094c2a8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=nifong@google.com Change-Id: Ic312d577387fb3122d51dad56258378e7c1b5061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706770Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678298}
-
Raphael Kubo da Costa authored
This commit makes the technical changes required to make the wake lock code in Blink aware of workers (i.e. use ExecutionContexts instead of Documents, exposing the WakeLock interface to dedicated workers and making WakeLockController support both Documents and DedicatedWorkerGlobalScopes). From a user perspective, though, this is still not very useful, as dedicated workers cannot acquire screen locks, and right now we always deny all requests for system locks. Bug: 967667 Change-Id: I6a775b1aac2b600006cb6f2ce0595514548bff17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702378Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#678297}
-
David Bokan authored
This crash happens because the hit test returns a null node. In that case it's safe to just return without doing anything. Not sure how to set this case up in a test though. Bug: 982360 Change-Id: I20d32e2704543ee816ac17c31a51957b30366309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706355 Commit-Queue: David Bokan <bokan@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#678296}
-
Sylvain Defresne authored
Change ProfileDownloaderDelegate to expose two new methods to access the IdentityManager and the URLLoaderFactory thus allowing to inject just the needed dependencies instead of requiring a Profile. Convert ProfileDownloaderTest to use IdentityTestEnvironment and TestURLLoaderFactory from IdentityTestEnvironmentProfileAdaptor, thus allowing to remove the need for creating a TestingProfile. Convert other implementation of ProfileDownloaderDelegate to fetch the IdentityManager and URLLoaderFactory internally from their Profile instance. Bug: 984487 Change-Id: Id0a43967acb5c9bbc82e18de39093724acb7401a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704255 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#678295}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Icca82bfb2f2d03f4c4e0a5d8b842a903fb41f863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706768Reviewed-by:
-
Nektarios Paisios authored
This patch fixes screen reader announcements when moving by character or by line in editable fields, either through a hard line break <br>, or through a blank line (<br><br>). A tree position is returned by the AX selection API when either the anchor offset or the focus offset refers to a child index and not to a character offset. We were not handling tree positions on Mac at all, whilst on Windows IA2 and Linux ATK we were not handling them if any of the caret or selection APIs were called on the anchor or the focus of the selection and not on one of their ancestors, e.g., calling IAccessibleText::get_caretOffset on a content editable that contains an img element as a direct child, and the caret being placed before the image. Tree positions were correctly handled on Windows IA2 and Linux ATK if the selection endpoints were inside a descendant of the current object, or in a completely different part of the tree. Bug: 951777 R=aleventhal@chromium.org Change-Id: Iac3c673c4c15668367f379d979d3f2457c9fefb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699017Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#678293}
-
Robbie Gibson authored
Bug: 976681 Change-Id: I664faa59f53464cadb0ab73910936e49e7ad756d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706850Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#678292}
-
Dave Tapuska authored
The histogram is expired now and the implementation can be removed. BUG=975271 Change-Id: I264d8cf74d951c368ff4ca41a024aa315273279b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703924Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#678291}
-
Chris Lu authored
Bug: 981925, 976901 Change-Id: Ie4be37f33212753b6b44b5cfb370c646597ea5e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702285Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#678290}
-
Michael van Ouwerkerk authored
Bug: 976311 Change-Id: I2da915f5aca77d8d882f503dd22d2a8cffc15078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703409 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Auto-Submit: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#678289}
-
Wei-Cheng Xiao authored
Histograms: Cryptohome.ChecksumStatus Cryptohome.TimeToMountGuestAsync Bug: 972785 Change-Id: Ic3d800cdf30b7fc95e17d329b8fd006917a752ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704757 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
On <div><b>x y<b></div>, we do following steps: 1. "x y".splitText(1) -> " " "x y" 2. " ".splitText(0) -> "" " " "x y" Before this patch, we have following layout tree: LayoutInline {<pseudo:first-letter>} at (0,0) size 8x19 LayoutTextFragment (anonymous) at (0,0) size 8x19 text run at (0,0) width 8: "x" LayoutText {#text} at (8,0) size 4x19 text run at (8,0) width 4: " " <======= This is for " " before "x y" LayoutTextFragment {#text} at (12,0) size 8x19 text run at (12,0) width 8: "y" This is invalid because " " should be collapsed and placed before <pseudo:: first-letter>. After this patch, |Element::UpdateFirstLetterPseudoElement()| detects this case then rebuild first-letter part of layout tree. Bug: 984389 Change-Id: I7eaa613045da44e09caa80435a04ad9615f4c40f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706030 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#678287}
-
Javier Ernesto Flores Robles authored
Updates the tab strips backgrounds with the new vertical ones. Deletes unused ones @1x. Updates constants specific to each assets: tab overlap and cap inset. Bug: 976817 Change-Id: Ida3b95548ac33c0740c2375eb2153f5bafc569e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706436Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#678286}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/134aeeec27e1..f43cc6905fc2 git log 134aeeec27e1..f43cc6905fc2 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 33130413..b5dcfdfc (678125:678230) Created with: gclient setdep -r src/third_party/webrtc@f43cc6905fc2 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I00e8733888880aeecfcccd57ed5bf48eacb9fab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706610Reviewed-by:
-
Alex Ilin authored
The following tests are being disabled: - VrBrowserCompositorViewHolderTest#testResizeWithCompositorViewHolderDetached - VrBrowserTransitionTest#test2dtoVrShellNfcUnsupported - VrBrowserTransitionTest#test2dtoVrShellto2dUnsupported - WebXrVrDeviceTest#testGvrlessMagicWindowCapabilities__ChromeTabbedActivity - WebXrVrDeviceTest#testGvrlessMagicWindowCapabilities__CustomTabActivity - WebXrVrDeviceTest#testGvrlessMagicWindowCapabilities__WebappActivity TBR: bsheedy@chromium.org Bug: 984943 Change-Id: If391b8cd7f66d7f3ca81e2081f21e0e2096c724d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706437Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#678284}
-
henrika authored
These are monitored as part of experiments from time to time. Bug: 984192 Change-Id: Ib7fba49f58906d5b9c18b5d4bccef8fd5174cadd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706513Reviewed-by:
-
Ben Kelly authored
Bug: 984125 Change-Id: I0c3c88a410a3697040dd1b508ee3b78fb75ec08c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702523 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#678282}
-
Lan Wei authored
In order to run the web-platform-tests automatically, we will use testdriver Action API in all the wpt to simulate inputs. Here we are changing some touch input tests with touch action in pointerevents/extension. Bug: 606367 Change-Id: Icd5b11236bf3ec575cb93b7cb7403cea1f983034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704690Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#678281}
-
Michael Lippautz authored
Otherwise, they are not considered on benchmarks. Bug: 948807 Change-Id: I9b4b6b4d6cc1ed1e6dd65f804e1bfe4d06b0ba4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706505 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#678280}
-
Adam Raine authored
Originally we got the device scale factor in PaintWorklet::Paint, but now we get the value is CSSPaintValue::GetImage so that future patches can use it in the off thread case as well as the main thread case. Bug: 980594 Change-Id: Idff87f901de7a821d37d1631ad33babab795fd4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702146Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Adam Raine <asraine@google.com> Cr-Commit-Position: refs/heads/master@{#678279}
-
Tim van der Lippe authored
This CL refactors the mojo callback for push events to provide a PushSubscription instead of the individual fields. This refactoring is then used to define a new DispatchPushSubscriptionChangeEvent method that takes the old and new subscription to fire the event. Bug: 646721 Change-Id: If72d2e587013fc82d8e724ec8033ab7e5527640b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702343Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@google.com> Cr-Commit-Position: refs/heads/master@{#678278}
-
Andrew Grieve authored
These started getting discarded when we switched to r8. Two of these were previously fixed by adding @UsedByReflection, but it seems safer to just keep all fragment constructors and does not seem to keep anything unused. Bug: 983904 Change-Id: I60bbc5a32dc49732aebd8048d674375cbc133f7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703595 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#678277}
-
Maksim Ivanov authored
Extend the OobeTest.NewUser test to verify the parameters passed to the MountEx call to cryptohomed, including the verification that the key label is "gaia". To simulate the flow that is close to the real flow, the FakeCryptohomeClient class is slightly enhanced to support replying to MountEx with CRYPTOHOME_ERROR_ACCOUNT_NOT_FOUND when no "create" proto field is provided. This allows to achieve the simulation of the following flow: (1) Chrome calls MountEx for the new user without specifying |create|; (2) cryptohomed checks that this user doesn't exist, and replies with the CRYPTOHOME_ERROR_ACCOUNT_NOT_FOUND error; (3) Chrome sees this errors and repeats the MountEx request with specifying |create|; (4) cryptohomed creates the new mount and succeeds. Bug: 983103 Test: browser_tests --gtest_filter=OobeTest.NewUser Change-Id: If27bcb05187219e046025f469ffe8bfe5c214562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690880 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#678276}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Please review and LGTM before July 16th or the CL will be submitted as-is. TBR=sky@chromium.org NOTRY=true Bug: 977050 Change-Id: I931d31a5f716e469e52e85fdaa0ff9781febba00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700842Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#678275}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I12a0d472ab0bb37e77981f5059ad23ebb512e34f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703628Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#678274}
-
Antonio Gomes authored
There are some trailing includes, and also some forward declarations that can be removed. Drive by CL. BUG=704136 R=guidou@chromium.org Change-Id: I2cf0d2e9fcc0e273d759ba870718f87a5359e405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704719 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#678273}
-
Mike West authored
Spec change: https://github.com/whatwg/fetch/pull/916 Bug: 979946 Change-Id: Ic1cd8691c9b06371b94de29a5648fb6c8d7bebed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702311 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: Ib8e79d7ab0748536e5a75a13153bcbc29039dabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702375Reviewed-by:
-
Sergey Poromov authored
DeviceLocalAccounts are supplied by |username| that is not a user email and can't be converted into AccountId. Because of that ValidateUser() can't be used and ValidateUsername() should be returned back that won't convert into AccountId. The same applies for component policy validations as they can belong to DeviceLocalAccount and also not have real username. This is an adapted partial "revert" of https://crrev.com/c/980873 and https://crrev.com/c/1003193. Before that ValidateUsername() existed and was used for all accounts. Bug: 983523 Change-Id: I11fab29bebd3770d6983206574595c2fab577cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698537 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: Ifef1b1bb0ad29da61559db4e92a57cf982afbcd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703227Reviewed-by:
-
Dave Tapuska authored
It is obvious that even though the renderer has requested main frames the browser may not deliver it until a much later time. So we will definitely keep the raf fallback timer code. BUG=975271 Change-Id: I868bc32a7e95c59585dfa72fe3c56959979a17f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703092Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/63fdd0191be0..e574f1e409aa git log 63fdd0191be0..e574f1e409aa --date=short --no-merges --format='%ad %ae %s' 2019-07-17 halcanary@google.com [reland] SkMetaData: move from src/ to tools/ Created with: gclient setdep -r src/third_party/skia@e574f1e409aa The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=nifong@google.com Change-Id: Id4ef5dc90d78903ac3724fd12e36ceaed8b38fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706608Reviewed-by:
-
Robbie Gibson authored
This does not change the color on the placeholder background + icon for when a suggestion has no image because that will be removed before dark mode is finished. Bug: 976641 Change-Id: I0bf0e26e7ce087917c38017d15a85c0a2ecbf6b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706431 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#678266}
-
Yutaka Hirano authored
Discussion: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/GF1Wg0JbEhw Bug: 983200 Change-Id: I27e02f2b195a93a7f2b0630af632ec0122581da9 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697481Reviewed-by:
-
Greg Thompson authored
external/wpt/referrer-policy/unsafe-url/http-rp/cross-origin/http-http/img-tag/no-redirect/generic.http.html and friends time out. BUG=982149 TBR=jochen@chromium.org Change-Id: I80773a464d18e243ece2f0677177ac32a5d13b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706501Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#678264}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2faec47d8d6a..45086ca6db84 Created with: gclient setdep -r src-internal@45086ca6db84 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=pdr@google.com,grt@google.com Change-Id: I8585d0f5ae07426f3ff6a76089cf5ea26b47974f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706389Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678263}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dcdb80df..aec429d1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I28e9b469cd9635866c3a9bb8431605128a0181c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706448Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678262}
-
Richard Knoll authored
This adds an icon in the omnibox via PageActionIconView. This is the ancher point of the Click to Call bubble dialog. Bug: 972059 Change-Id: I69aeb6bfcfd47082ad1a3460d58c2dd107746353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695551Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#678261}
-
Yi Gu authored
In the constructor of AggregatedHitTestRegion there is a DCHECK to verify that async_hit_test_reasons is set if and only if the kHitTestAsk flag is set [1]. This assertion stands for most cases but HitTestManagerFuzzer where we manually set the flag without setting async_hit_test_reasons. It was missed when introducing async_hit_test_reasons in crrev.com/c/1318078. [1] https://cs.chromium.org/chromium/src/components/viz/common/hit_test/aggregated_hit_test_region.h?q=AggregatedHitTestRegion&dr=CSs&l=48 Bug: 910872 Change-Id: I1d9e79e2583a0a180c8905ec4cf80d48bb1072f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705052Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#678260}
-
