GitLab

A small fix so that modifying the existing code becomes safer.

BUG=none
TEST=SyncTaskManagerTest.ScheduleAndCancelTask

Review URL: https://chromiumcodereview.appspot.com/23513021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222214 0039d316-1c4b-4281-b951-d872f2087c98

This issue was found by a linter.

R=rdevlin.cronin@chromium.org, yoz@chromium.org

BUG=

Review URL: https://chromiumcodereview.appspot.com/23503045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222213 0039d316-1c4b-4281-b951-d872f2087c98

BUG=285941
R=stevenjb@chromium.org, bartfab@chromium.org
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/23464044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222212 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes the bug that the directory list is not drawn correctly sometimes.

Previously, DirectoryTree.updateSubDirectories() tries to retrieve an entries from the file system. But the directory structure of the top level is different from the file system, instead, we need to use the special list. This patch change the updateSubDirectories() to use the special list.

BUG=286421
TEST=manual
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/23636014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222211 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manually tested
TBR=hirono@chromium.org
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/23461038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222210 0039d316-1c4b-4281-b951-d872f2087c98

Old: Select an app to open this file.
New: Select an app to open this file

BUG=288438
TEST=manually tested
TBR=hirono@chromium.org
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/23461037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222209 0039d316-1c4b-4281-b951-d872f2087c98

AsyncPixelTransferManager checks for some EGL specific
extensions that are available on the device, but was not
correctly retrieved by the GLNonOwnedContext.

Note that GLNonOwnedContext is only used on android webview,
not chrome on android.

BUG=287962

Review URL: https://chromiumcodereview.appspot.com/23460026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222208 0039d316-1c4b-4281-b951-d872f2087c98

When passing a TextureMailbox from the impl thread out to the cc
embedder on the main thread, we need to keep a ref on the ContextProvider
that owns the texture in the mailbox, to keep the mailbox alive while
the embedder is receiving it.

However if the compositor shutsdown and the impl thread goes away, we
must have already dropped the ref on the ContextProvider or it will be
destroyed (a) on the wrong thread and (b) after the global GPU process
objects it holds pointers to have been destroyed. Crash will occur.

So, we add a TextureMailboxDeleter class that the GLRenderer uses to
generate a TextureMailbox release callback for the main thread instead
of rolling its own thing. The TMDeleter class' lifetime is bounded by
the life of the compositor instance on the impl thread, so it is
destroyed before the impl thread is joined. And when it is destroyed it
deletes the textures it was meant to destroy, and drops its ref on the
context provider.

BUG=283625
R=piman

Review URL: https://chromiumcodereview.appspot.com/23454014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222207 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222206 0039d316-1c4b-4281-b951-d872f2087c98

Makes tests very Flaky.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Chromium&testType=sync_integration_tests&tests=TwoClientPasswordsSyncTest.SetPassphraseAndThenSetupSync

Can reproduce on local build.


> sync: Gracefully handle very early shutdown
> 
> Introduce a new object to communicate cross-thread cancellation signals.
> This new object, the CancellationSignal, is protected by a lock.  It
> allows the receiving thread to query whether or not a stop has been
> requested.  It also allows the receiving thread to safely register a
> cross-thread callback to be invoked immediately when a stop is
> requested.
> 
> This class is used to reimplement the UI thread to sync thread early
> shutdown signal.  Previously, the UI thread would try to call in to
> objects owned by the sync thread.  This required a workaround if the
> signal arrived very early, since we couldn't guarantee the sync thread
> had actually created those objects until later.  The CancellationSignal
> is owned by the UI thread, so it is safe to call its RequestStop() at
> any point during sync initialization.  The sync thread will receive the
> signal when it's ready.
> 
> The new scheme has a few advantages over the old:
> - Thread ownership is simpler.  The SyncBackendHost::Core, SyncManager,
>   ServerConnectionManager, SyncScheduler and Syncer can now claim that
>   all their member functions run on the sync thread.
> - We no longer need to implement special case logic for when a shutdown
>   is requested before the SyncManager has initialized.
> - In a future CL, we can take advantage of the fact that we no longer
>   require the special case to reduce inter-thread communication during
>   sync startup.  This will make startup simpler and, in some cases,
>   improve sync startup time by as much as a few hundred milliseconds.
> - This will make it easier to address crbug.com/236451.
> 
> BUG=236451
> 
> Review URL: https://chromiumcodereview.appspot.com/23189021

TBR=rlarocque@chromium.org

Review URL: https://codereview.chromium.org/23658030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222205 0039d316-1c4b-4281-b951-d872f2087c98

Breaks testGotQueryParams on Mac 10.6 and 10.7.

> Telemetry: smoothness measurement throws MissingTimelineMarker.
> 
> Rather than throwing a generic LookupError exception when the timeline marker
> cannot be found in the trace, throw a MissingTimelineMarker which is a subclass
> of page_measurement.MeasurementFailure. These exceptios get caught by the page
> runner.
> 
> Stop catching LookupError exeptions in _RunPage.
> 
> BUG=238864
> 
> Review URL: https://chromiumcodereview.appspot.com/23766009

TBR=dominikg@chromium.org

Review URL: https://codereview.chromium.org/23693005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222204 0039d316-1c4b-4281-b951-d872f2087c98

Fixes regression from r222200.
BUG=none
TBR=chrisgao

Review URL: https://codereview.chromium.org/24086003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222203 0039d316-1c4b-4281-b951-d872f2087c98

> Turn on canvas_skia for OSX
> 
> Re-submit of r221930, with fixed include path.
> 
> TBR=asvitkine@chromium.org
> BUG=151935
> 
> Review URL: https://chromiumcodereview.appspot.com/23454018

TBR=groby@chromium.org

Review URL: https://codereview.chromium.org/23845004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222202 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=chrisgao@chromium.org

Review URL: https://codereview.chromium.org/23542015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222200 0039d316-1c4b-4281-b951-d872f2087c98

UsbKeycodeMap.Basic consistently fails on the Win7 dbg main waterfall bot:
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(1)
base\keycodes\usb_keycode_map_unittest.cc(36): error: Value of: "Unidentified"
Actual: 00890D98
Expected: InvalidKeyboardEventCode()
Which is: 007F90D4

> Add a CodeToNativeKeycode helper that converts UIEvent code to native code.
> Also add a SimulateKeyPress helper for browser_tests that takes both a UIEvent |code| and a ui::KeyboardCode.
> 
> issue=284754
> 
> Review URL: https://chromiumcodereview.appspot.com/23542008

TBR=weitaosu@chromium.org

Review URL: https://codereview.chromium.org/23451030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222199 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222194 0039d316-1c4b-4281-b951-d872f2087c98

Re-submit of r221930, with fixed include path.

TBR=asvitkine@chromium.org
BUG=151935

Review URL: https://chromiumcodereview.appspot.com/23454018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222192 0039d316-1c4b-4281-b951-d872f2087c98

The problem was that the positioning was done before it was shown and the move_with_anchor didn't work since there was no anchor. Changed it now to use an anchor offset.

BUG=284780
TEST=unittest (partial), visually [(RTL and LTR) x (left, right, bottom aligned) x (always visible, sliding into view, hidden)]

Review URL: https://chromiumcodereview.appspot.com/23622020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222191 0039d316-1c4b-4281-b951-d872f2087c98

We frequently run in to the situation where we change the generators
which causes some real (but usually minor) change in header files, even
though the IDL is unchanged. We should just warn in that situation, so that
developers can use the CQ for these kind of generator changes.

BUG=

Review URL: https://chromiumcodereview.appspot.com/23620032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222190 0039d316-1c4b-4281-b951-d872f2087c98

BUG=164227
TEST=No

Review URL: https://chromiumcodereview.appspot.com/23751004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222189 0039d316-1c4b-4281-b951-d872f2087c98

BUG=286519
R=isherman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23498027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222188 0039d316-1c4b-4281-b951-d872f2087c98

When a non-default input device is selected, do a best-effort selection of a matching output device.
This is used to switch output of media stream audio tracks to the output device that matches the currently open capture device (microphone).
An typical example is to support switching to USB headsets when in a audio/video call.
This does not affect the audio output of non-webrtc related audio elements and only happens when there's exactly 1 active audio capture device in the page.

BUG=276894

Review URL: https://chromiumcodereview.appspot.com/23731007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222187 0039d316-1c4b-4281-b951-d872f2087c98

CL 17114003 and 22410004 added a way for Mac and views to hide the top
omnibox match when it is a verbatim match we do not want to show. This
implements that for GTK too so it'll work on all desktop platforms.

BUG=252823
TEST=Manually. Run with no flags and verify that when you type 'faceb'
in the omnibox, the popup shows a search suggestion for 'faceb'. Run
again with the flags
--enable-instant-extended-api
--force-fieldtrials='InstantExtended/Group1 hide_verbatim:1/'
and verify that you do not see this suggestion. Also check that with the
flags set, hovering on the top suggestion works and that there are no
off-by-one problems when clicking on suggestions.

Review URL: https://chromiumcodereview.appspot.com/22679003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222186 0039d316-1c4b-4281-b951-d872f2087c98

BUG=269131
TEST=trybot

Review URL: https://chromiumcodereview.appspot.com/24064002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222185 0039d316-1c4b-4281-b951-d872f2087c98

 * Content Length
 * If the media is being streamed
 * Same Origin Status
 * CORS Status
 * HTTP Range support

BUG=260005

Review URL: https://chromiumcodereview.appspot.com/22914021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222184 0039d316-1c4b-4281-b951-d872f2087c98

This change appears to have broken three unit tests:
  ProcessSingletonLinuxTest.NotifyOtherProcessDifferingHost
  ProcessSingletonLinuxTest.NotifyOtherProcessOrCreate_BadCookie
  ProcessSingletonLinuxTest.NotifyOtherProcessOrCreate_DifferingHost

http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/38908
http://build.chromium.org/p/chromium.linux/builders/Linux%20Clang%20%28dbg%29/builds/49891

> Improve the UI for handling profile lock contention.
> 
> Linux/GTK only.
> 
> BUG=282509
> TEST=ln -s fake.com-123 SingletonLock, then run Chromium, then check that [ Quit ] and [ Unlock and Relaunch ] work.
> 
> Review URL: https://chromiumcodereview.appspot.com/23506011

TBR=palmer@chromium.org

Review URL: https://codereview.chromium.org/23708026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222183 0039d316-1c4b-4281-b951-d872f2087c98

This issue was found by a linter.

R=yoz@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/23717041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222182 0039d316-1c4b-4281-b951-d872f2087c98

When this flag is enabled, we'll use a non-compositing decoder in
MediaDrm by default. Otherwise, a compositing decoder will be used
by default.

TBR=ddorwin@chromium.org, qinmin@chromium.org
BUG=163552
TEST=Tried on Nexus 7 with and without this flag.

Review URL: https://codereview.chromium.org/23903023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222181 0039d316-1c4b-4281-b951-d872f2087c98

BUG=285440

Review URL: https://chromiumcodereview.appspot.com/23534051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222179 0039d316-1c4b-4281-b951-d872f2087c98

error code in addition to the error message. This turned out to be a
surprisingly invasive yak shave and is accompanied by a few very small fixes
to inefficient and overly complex code I noticed along the way.

This is the first stage in making the chrome.storage extension/app API able to
gracefully recover from leveldb corruption.

BUG=261623
R=mpcomplete@chromium.org
TBR=tim@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/24021002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222178 0039d316-1c4b-4281-b951-d872f2087c98

what happens is that we use vector_as_array(&data) which returns null if data is empty, but we don't check |size| whichcan be 0 so data.resize(size) still an empty vector.

This is currently happening for browser_tests.exe in the waterfall.

There might be a better fix but lots of tests are having exceptions so I want to stop that.

TBR=mnissler
BUG=none
TEST=logs are clean

Review URL: https://codereview.chromium.org/23961004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222177 0039d316-1c4b-4281-b951-d872f2087c98

This patch is almost a revert of crrev.com/219997.

CommandUtil.getCommandPath() is no longer necessary because the patch for M30 has been merged successfully and the unavailable shortcut would been automatically removed.

BUG=287597, 284921
TEST=manually tested
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/23944007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222176 0039d316-1c4b-4281-b951-d872f2087c98

source address tokens in ServerHello messages.

Merge internal CL: 51981820

List output parameters after input parameters.

Merge internal CL: 52069947

R=rch@chromium.org,rtenneti@chromium.org
BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/23766019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222175 0039d316-1c4b-4281-b951-d872f2087c98

r220909 has fixed the share dialog. This patch fixes not oly the share dialog, but also the suggest app dialog and default task pick dialog.

And this patch also introduces FileManagerDialogBase, which manages the dialog in file manager not to have the multiple dialogs visible simultaneously.

BUG=279214
TEST=manually tested
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/23483029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222174 0039d316-1c4b-4281-b951-d872f2087c98

There is no change allowed to the shelf when the enterprise mode 'locks down' the shelf.

BUG=285056
TEST=none

Review URL: https://chromiumcodereview.appspot.com/24076002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222173 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE

Review URL: https://chromiumcodereview.appspot.com/24079002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222172 0039d316-1c4b-4281-b951-d872f2087c98

Need to pass the CONFIGURATION_NAME through to the push python libs.

BUG=

Review URL: https://chromiumcodereview.appspot.com/23936004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222171 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=286022

Review URL: https://chromiumcodereview.appspot.com/23726024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222170 0039d316-1c4b-4281-b951-d872f2087c98

Delegated frames may contain an offscreen filter. If they do, then the
LayerTreeHost needs to know about it so it can create an offscreen
context.

R=piman
BUG=287870

Review URL: https://chromiumcodereview.appspot.com/23451023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222169 0039d316-1c4b-4281-b951-d872f2087c98

Also add a SimulateKeyPress helper for browser_tests that takes both a UIEvent |code| and a ui::KeyboardCode.

issue=284754

Review URL: https://chromiumcodereview.appspot.com/23542008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222168 0039d316-1c4b-4281-b951-d872f2087c98