GitLab

When the tab switch button was "focused", the tab key wasn't working
because the routine involved was returning true, saying that it had
handled the tab key. This CL changes that.

Arrow keys still need to return true in this case, so
'AtEndWithTabSwitch()' was broken up into 'BidirAtEnd()' and
'SelectedSuggestionHasTabSwitch()' so that the tab key can
ignore the first condition, while arrow keys consider it.

Bug: 936851
Change-Id: I84b8b2e41f2601c978d31405b727eb60ea3c78c0
Reviewed-on: https://chromium-review.googlesource.com/c/1495198
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636939}

This allows for branch urls to be added to the CQ.

Bug: 922150
Change-Id: Ic4380a87610949fbc0443d0a17b0021821e390e9
Reviewed-on: https://chromium-review.googlesource.com/c/1497180
Commit-Queue: Karen Qian <karenqian@google.com>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636938}

Bug: 929973
Change-Id: Idbe28468069455b9f460728820bed6a9c4397cf1
Reviewed-on: https://chromium-review.googlesource.com/c/1494891
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636937}

UserInitiatedChromeCleanups was enabled by default in M67.

Change-Id: I98b9b3da11bc7bbb44e58e9101b589cf6b666788
Reviewed-on: https://chromium-review.googlesource.com/c/1491852
Commit-Queue: Veranika Liaukevich <veranika@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Cr-Commit-Position: refs/heads/master@{#636936}

Since M59, this URL simply forwards to chrome://history. This CL
removes the redirect.

reached" page.

Bug: None
Test: Visit chrome://history-frame, should see "This site can’t be
Change-Id: I6642b4be8b1b28ba9471b1dc64aa24a444aaeed2
Reviewed-on: https://chromium-review.googlesource.com/c/1496494
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636935}

- Enabled/implemented IsOffscreen property for UIA in
AXPlatformNodeWin::GetPropertyValue and assoicated browser tests.
GetPropertyValue calculates isOffscreen status by utilizing
AXTree::RelativeToTreeBounds, which looks at the bounds of the
node relative to its ancestor and rootWebArea bounds to determine
the isOffscreen status.

- Modified AccessibilityWinBrowserTests::FindNodeInSubtree to take
into account of StringAttribute::kValue when finding the node.

Bug: 844149
Change-Id: Ied62e00814957a6ca97b1849935ec692f1acf03a
Reviewed-on: https://chromium-review.googlesource.com/c/1481800
Commit-Queue: Victor Fei <vicfei@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636934}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/19dd955a0744..b2b876f75ba1


git log 19dd955a0744..b2b876f75ba1 --date=short --no-merges --format='%ad %ae %s'
2019-03-01 chrome-bot@chromium.org Update config settings by config-updater.
2019-03-01 dgarrett@google.com chromeos_config: Change packages for old factorybranches.


Created with:
  gclient setdep -r src/third_party/chromite@b2b876f75ba1

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: I4868d817bc7911e01f11b339b6ef66952d40e228
Reviewed-on: https://chromium-review.googlesource.com/c/1496103Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636933}

Now checking for nullptr before assigning the char* result from
ippGetName.

Bug: chromium:935873
Test: Unittests still pass.
Change-Id: Ic5d665b69e41821dd44abb41efcee6276655cf13
Reviewed-on: https://chromium-review.googlesource.com/c/1490753Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636932}

The URL to the new flake portal will be https://analysis.chromium.org/p/chromium/flake-portal
"Flake Portal" refers to the set of tools that Findit provides to deal with flakiness.

In Findit, the data in /p/chromium/flake-portal/flakes are flaky tests only, because successful and consistently failed tests are filtered out.
Besides, Findit has following features:
1) Flake Report: aggregation of flakiness data by crbug component.
2) Flake Analysis: find the culprit commit for a flaky test; verify flake fixes.
3) Flake bug management: auto-create flake bugs, comment on existing bugs filed by human, auto-merge flake bugs if the root cause is the same culprit, etc.

Also reworded the original "Flakiness Dashboard" to "Legacy Flakiness Dashboard".
It shows the full history of a specific test.
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ChromeVoxLiveRegionsTest.LiveStatusOff

Bug: 934569
Change-Id: Ib05c43b67bf0f87307c135ca3f630200a7daf78f
Reviewed-on: https://chromium-review.googlesource.com/c/1482113
Commit-Queue: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636931}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d7ccfee2ef7c..6ecc5174ac93


Created with:
  gclient setdep -r src-internal@6ecc5174ac93

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:937214,chromium:937241
TBR=mmoss@chromium.org

Change-Id: Ice2f3a35edbd3033d1aaf996e57df32bd7dbed79
Reviewed-on: https://chromium-review.googlesource.com/c/1496959Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636930}

When service worker context initializes, add the corresponding
entry to ProcessManager and remove it when the context stops.

Introduce IPC for worker initialization
(DidInitializeServiceWorkerContext) and modify worker
stop IPC (DidStopServiceWorkerContext) as necessary.

Note that we cannot use loadstop
(DidStartServiceWorkerContext) for PM entry addition because it
can be too late as extension API calls might arrive in browser
process before this.

Also add SW information cleanup on render process termination as
termination doesn't trigger stop worker messages (where the
regular cleanup in PM happens).

This CL will enable extension messaging in future CLs.

Add tests for shutdown and termination behavior.

Bug: 925918
Change-Id: I9442bac9a1e9acf01063084a1e6ef2fac3279e09
Reviewed-on: https://chromium-review.googlesource.com/c/1455267Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636929}

This reverts commit 0bfee16c.

Reason for revert:
New test times out on Linux official builds and clang ToT builds:
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20trunk/builds/15834
https://ci.chromium.org/p/chromium/builders/ci/ToTLinux/5415

Original change's description:
> Add integration test for butter credit card save dialog
> 
> Tests upload scenario and local save because payments rejected the card.
> 
> Bug: 876301,915216
> Change-Id: I8c73ea867872dc99fee3f2dcbb10bb0a6f123472
> Reviewed-on: https://chromium-review.googlesource.com/c/1486336
> Commit-Queue: Florian Uunk <feuunk@chromium.org>
> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#635529}

TBR=vasilii@chromium.org,sebsg@chromium.org,feuunk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 876301, 915216
Change-Id: I49b54f21b0286b946be2b72fd26d3b98fac08067
Reviewed-on: https://chromium-review.googlesource.com/c/1497185Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636928}

This is another example of WKWebView loading slowly, or not at all, when removed
from the view heirarchy.  On restore, the tab is swapped out, but since there's
an NTP visible after a crash, the restore underneath may stall if the new tab's
webState view isn't swapped into the BrowserViewContainerView.

Bug: 848789
Change-Id: I62020b3ebd2fd4e9ab8ded003f0cc62d35104374
Reviewed-on: https://chromium-review.googlesource.com/c/1496539
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636927}

This will cause the device to stay unlocked for the amount of time set in the duration and locked afterwards.

Bug: 934923
Change-Id: Ia05d7e74ac0d89d682e332c3a248d802bd5df0ef
Reviewed-on: https://chromium-review.googlesource.com/c/1477826
Commit-Queue: Leonardo Padilha <ldaguilar@chromium.org>
Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636926}

The OWNERS file in question has a list that mostly replicates the main
Autofill OWNERS file, in //components. However, this list has not been
updated regularly to reflect team changes. I think it makes the most
sense to simply use the same OWNERS for both places.

I'm leaving the per-file OWNERs for the password team, which is
consistent with what we've done in various other places in the codebase.

Change-Id: Ia183a78392c4623ea9cd4525cb59d175e80f69ff
Reviewed-on: https://chromium-review.googlesource.com/c/1497184
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Auto-Submit: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636925}

This CL updates oudated comments, with no production code changes.

TBR: chcunningham@
Change-Id: Ie12fb6ba08048c7ca2a14c49f0daee8636e058db
Reviewed-on: https://chromium-review.googlesource.com/c/1497175
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636924}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Ib65dce096d41e2a965628b8dd3f1bbd5fdc4b23a
Reviewed-on: https://chromium-review.googlesource.com/c/1495729Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636923}

https://android.googlesource.com/platform/external/perfetto.git/+log/ab0bd92ed40d..640200f64d14


git log ab0bd92ed40d..640200f64d14 --date=short --no-merges --format='%ad %ae %s'
2019-03-01 costan@google.com Merge "test: Migrate googletest TEST_CASE APIs to TEST_SUITE."


Created with:
  gclient setdep -r src/third_party/perfetto@640200f64d14

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I314813b03d823b8a18d4ce80e2f15880463c5cb6
Reviewed-on: https://chromium-review.googlesource.com/c/1497114Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636922}

Change-Id: I552ed0de86b5dc7aa9e10e61877e601ba2b42b22
Reviewed-on: https://chromium-review.googlesource.com/c/1496956
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636921}

******************************Resource Sizes Diff******************************
Specifics:
       +58,488 bytes main lib size
      +436,504 bytes main dex size
      +159,240 bytes secondary dex size
      +938,740 bytes normalized apk size
InstallSize:
      +345,802 bytes APK size
    +1,042,823 bytes Estimated installed size (Android Go)
    +2,752,607 bytes Estimated installed size
InstallBreakdown (+2,751,322 bytes):
        +2,124 bytes Native resources (no l10n) size
        +2,400 bytes unwind_cfi (dev and canary only) size
        +2,224 bytes Non-compiled Android resources size
       +58,488 bytes Native code size
          +653 bytes Package metadata size
    +2,668,649 bytes Java code size
       +16,784 bytes Compiled Android resources size
Dex:
        +3,155 entries fields
        +4,868 entries methods
        +1,599 entries types
        +3,291 entries strings

Change-Id: I56ddb01aa0be9582936ca3abbb37755a6b86e82f
Reviewed-on: https://chromium-review.googlesource.com/c/1496600Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636920}

This allows optimizing away the String creation in
css_parsing_utils::ConsumePath, while also being slightly more generic.

Change-Id: Iba17ca82e45304dd217487cb526cf8ba692c3276
Reviewed-on: https://chromium-review.googlesource.com/c/1497001Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#636919}

This value is needed in extensions, so we can use NSUserDefaults to
store it.

Bug: 913958
Change-Id: I4cacfb56c62e84e97a6529797bb97473715b5eb0
Reviewed-on: https://chromium-review.googlesource.com/c/1488911Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#636918}

Follow-up work for https://chromium-review.googlesource.com/c/chromium/src/+/1493084

Also remove some outdated comments.

Bug: None
Change-Id: I5c01528a334d2924b80f9fa4954777795d847fc9
Reviewed-on: https://chromium-review.googlesource.com/c/1496517Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636917}

I'm going to fork them to create a material design version of this
dialog and I don't want to pollute the main c/b/resources/chromeos
directory.

Bug: 927732
Test: browser_tests SetTimeWebUITest.testChangeTimezone
Change-Id: I5463a76d3da6d7784635ec9126c4ac64186f219d
Reviewed-on: https://chromium-review.googlesource.com/c/1496491
Commit-Queue: James Cook <jamescook@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636916}

Change-Id: I149eac32914985224986fe569959054934980b8e
Reviewed-on: https://chromium-review.googlesource.com/c/1497193Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636915}

This issue is best docuemnted in https://crrev.com/31183. The best
repro is to
- Nativate to https://crbug.com/25462
- Download test.html
- Open test.html from the downloads bar
- Tab-drag test.html out, and hold the drag for at least 5 seconds

The implmenetation of this functionality effectively uses
WebContentsViewCocoa (via cancelPreviousPerformRequestsWithTarget and
performSelector) as a weak pointer for WebContentsViewMac. This is not
the right tool for the job, and is guaranteed to not work when
WebContentsViewCocoa is in another process.

Change this to use a weak pointer for weak pointer functionality.

Merge WebContentsView::IsEventTracking and CloseTabAfterEventTracking
into a single function.

Bug: Cleaning up WebContentsView
Change-Id: I215744f048d5c49be00ae94ecdbfdbbdbd62415a
Reviewed-on: https://chromium-review.googlesource.com/c/1492754Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636914}

This flag isn't needed any more, but the feature still is, per email discussion
with mpearson and jdonnelly.

Bug: None
Change-Id: I59cf49bef661245da9c40115b626875e351bd4f5
Reviewed-on: https://chromium-review.googlesource.com/c/1496559
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636913}

When the Network Service is enabled, LBS failed to download sitelists
for file:// URLs. This CL fixes the issue.

Bug: 936160
Change-Id: Iae19b7d9798236f35f7a8c525569b4cb241296c5
Reviewed-on: https://chromium-review.googlesource.com/c/1495575
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636912}

Update callers that relied on the default argument. Modernize code
along the way.

Change-Id: I5486202a2b740e9451cf737b54549168419f4493
Reviewed-on: https://chromium-review.googlesource.com/c/1495813
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636911}

This is a simple one and gets rid of a redundant call to
TimeTicks::Now() thanks to the new API :)

Bug: 885371
Change-Id: I3dccde418849992ad0bce18297c79eea6f98f072
Reviewed-on: https://chromium-review.googlesource.com/c/1485125
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636910}

See linked bug for details.

TBR=lushnikov@chromium.org
NOTRY=true

Bug: 937416
Change-Id: If8c917fa804d9def71a5bf5ec24da85ae02fd840
Reviewed-on: https://chromium-review.googlesource.com/c/1497127Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636909}

Move all checks for if a OverlaySurfaceCandidate is potentially valid
into CanHandleCandidate(). Also simplify CheckOverlaySupport() a bit.

Add a test that exercises DrmOverlayManger caching to ensure that
request for overlay validation gets sent at the right time.

Bug: 930173
Change-Id: I1d0705b76c1b2ba806a207b9e2ba55d161ae60d6
Reviewed-on: https://chromium-review.googlesource.com/c/1495740Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636908}

This change removes the previous_committed_source_id_ member.

This member was used to retain the source id of the last committed
navigation as a new navigation was completing.

This member is only used in one place, and it's possible to remove it
by deferring updating of the last_committed_source_id_ until after
that code completes.

Change-Id: I18811c048ce07590c5dd2fa4bb273b7ad5a53628
Reviewed-on: https://chromium-review.googlesource.com/c/1491892
Commit-Queue: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636907}

This CL adds a UMA metric for the type of content that was used for the
largest content paint.

Change-Id: I3ee520fa2e45f00a68ad405320010de0247b41bc
Reviewed-on: https://chromium-review.googlesource.com/c/1489413
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636906}

To ensure the data is populated for SBER users, but not regular users,
add a unit test.

Bug: 922226
Change-Id: Ia8af7e347bcfe546d8f3af5d5c53aa8067d4a3ee
Reviewed-on: https://chromium-review.googlesource.com/c/1495367
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636905}

This reverts commit 9866f6ae.

Reason for revert: ApkMerger script is fixed in cl:
https://chromium-review.googlesource.com/c/chromium/src/+/1496316

Original change's description:
> Revert "Make sure unwind tables are added for 32 bit libraries in arm64 monochrome"
>
> This reverts commit 200a953f.
>
> Reason for revert: Breaking official build due to APK merge.
>
> Original change's description:
> > Make sure unwind tables are added for 32 bit libraries in arm64 monochrome
> >
> > The assets were not added since we checked "can_unwind_with_cfi_table"
> > value, which depends on "build_secondary_abi" build arg. So, explicitly
> > add the asset for 64-bit monochrome apk, which contains 32 bit library.
> >
> > BUG=924842
> >
> > Change-Id: I6488d5c4e5a80787735c5b09134b013a87b5c553
> > Reviewed-on: https://chromium-review.googlesource.com/c/1432836
> > Commit-Queue: ssid <ssid@chromium.org>
> > Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#625789}
>
> TBR=ssid@chromium.org,agrieve@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 924842
> Change-Id: Ic8e542cc1cf52f24b7866c1620ac764bf2f92672
> Reviewed-on: https://chromium-review.googlesource.com/c/1439074
> Reviewed-by: Ben Mason <benmason@chromium.org>
> Commit-Queue: Ben Mason <benmason@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#626505}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 924842
Change-Id: I36b5cd2ab479f3038e3c31a69fe70aacef4db618
Reviewed-on: https://chromium-review.googlesource.com/c/1496275
Commit-Queue: ssid <ssid@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636904}

Relanding since use-after-free bug is fixed in https://crrev.com/c/1489098

Original CL description:
> A network error should be reported if the resource fetch is aborted
> before it is complete:
> https://w3c.github.io/network-error-logging/#transmission-of-request-and-response-errors
>
> This CL adds NEL error generation (with report type ERR_ABORTED) for
> any HttpNetworkTransactions destructed without previously generating a
> success or error report. This guarantees that every
> HttpNetworkTransaction results in a NEL report. Successes are reported
> after receiving valid headers (if the response code is 4xx or 5xx, or
> if the body will not be read, or on a redirect), or after completely
> reading the body. Any other outcome is reported as an error.
>
> Bug: 934000
> Change-Id: I8f71309c9cea0295546b23861fba6b131f72a3d7
> Reviewed-on: https://chromium-review.googlesource.com/c/1480195
> Commit-Queue: Lily Chen <chlily@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634834}

Bug: 934000, 935209
Change-Id: I9a73a7a9ed24e5b536b7ff7bb80a79523bf58f4a
Reviewed-on: https://chromium-review.googlesource.com/c/1491905Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636903}

Currently, FCP++ is only collecting results from the main frame. This CL
will enable it to collect results from subframes, including OOPIFs in
particular.

This CL also simplify the size calculation. Originally, we intersect the
mapped visual rect with the viewport rect. This step is actually
unnecessary, because LocalToAncestorVisualRect() has already included the
viewport clipping.

For OOPIF, this CL adds an extra step upon the normal work flow. Visual
rects of OOPIF live in the main frame space, but they are not clipped by
the main frame viewport. So we add MapToVisualRectInTopFrameSpace, which
do the viewport clipping.

Bug: 934318

Change-Id: I5f91815cafdadd68a01bc1cdd5d8cf009a6e4fbe
Reviewed-on: https://chromium-review.googlesource.com/c/1481574
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636902}

In the case when a GestureScrollBegin comes without a GestureTapDown,
and that when the both |allowed_touch_action_| and |active_touch_action_|
have no value, it could crash at line 139 which tries to access the value
of |active_touch_action_|.

This CL fixes that and adds unit testing.

Bug: 904648
Change-Id: Id4bc2a79f8716ed43981a77278d82d3539fc9a5e
Reviewed-on: https://chromium-review.googlesource.com/c/1495354Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636901}

- Better explain ownership semantics.
- DCHECK the code runs on the UI thread.
- Use base::TimeDelta in more places.
- Pass non-POD objects by const-reference.
- Add an OWNERS file.
- Fix nits.

Change-Id: Iaa41d368882c08a56977ee418416c31e2bdc46dc
Reviewed-on: https://chromium-review.googlesource.com/c/1496538Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636900}