- 07 Nov, 2016 40 commits
-
-
michaeldo authored
Remove the restriction that only a single state can be active at a time. This is to allow incognito and normal mode WKWebViews live side by side where they can be two active states at any given time. BUG=579264 Review-Url: https://codereview.chromium.org/2251023003 Cr-Commit-Position: refs/heads/master@{#430298}
-
tbansal authored
Separate out observation sources as either HTTP layer or transport layer. Majority of the current observation sources (e.g., cached estimate, external estimate) are not broken down by which networking layer they were computed at. This CL breaks down the observation sources by the layer (either HTTP or transport layer). e.g., this will be useful for observers to distinguish between a cached HTTP RTT estimate vs. a cached transport RTT estimate. when NQE caches both HTTP RTT, and transport RTT. As a side-effect, this CL will prevent the observers from distinguishing between the RTT from a TCP source vs. a QUIC source since both of them will now be bundled into NETWORK_QUALITY_OBSERVATION_SOURCE_TRANSPORT. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester BUG=490870 Review-Url: https://codereview.chromium.org/2453653002 Cr-Commit-Position: refs/heads/master@{#430297}
-
fsamuel authored
BUG=none Review-Url: https://codereview.chromium.org/2484483002 Cr-Commit-Position: refs/heads/master@{#430296}
-
mlippautz authored
Untangle TraceWrapperV8Reference from ScopedPersistent. This is required as the combination of vtable and templates makes it impossible to properly cast to the needed type. BUG=chromium:662303 Review-Url: https://codereview.chromium.org/2479133002 Cr-Commit-Position: refs/heads/master@{#430295}
-
kylechar authored
Run the following tests on linux_chromium_chromeos_ozone_rel_ng: 1. mus_demo_unittests 2. views_mus_interactive_ui_tests 3. views_mus_unittests BUG=642433,611473 Review-Url: https://codereview.chromium.org/2478633003 Cr-Commit-Position: refs/heads/master@{#430294}
-
fdoray authored
BrowserThreads are being migrated to TaskScheduler which doesn't support MessageLoop destruction observers. Destruction observers currently serve two purposes in ModelSafeWorker: 1. Set a "stopped" flag to true. When this flag is true, DoWorkAndWaitUntilDone() returns CANNOT_DO_WORK immediately. -> This is useless because all DoWorkAndWaitUntilDoneImpl() implementations already return CANNOT_DO_WORK when they are unable to schedule a task. For example, in BrowserThreadModelWorker::DoWorkAndWaitUntilDoneImpl(): // Note: PostTask returns false once the MessageLoop // running on the BrowserThread is destroyed. if (!runner_->PostTask( FROM_HERE, base::Bind(...))) { DLOG(WARNING) << "Failed to post task to runner " << runner_; error = CANNOT_DO_WORK; return error; } 2. Notify SyncBackendRegistrar that the MessageLoop was destroyed so that it can move the ModelSafeWorker to an inactive list. When all ModelSafeWorkers have been moved to the inactive list, SyncBackendRegistrar deletes itself. -> There is no reason to keep SyncBackendRegistrar alive after both SyncManager and SyncBackendHostImpl have cleared their pointer/unique_ptr to it. With this CL, SyncBackendRegistrar is deleted by a DeleteSoon task posted from SyncBackendHostImpl::Shutdown(). -> Deleting SyncBackendRegistrar causes the ModelSafeWorker references kept in |stopped_workers_| to be released. This is not dangerous since any object that still needs to use a ModelSafeWorker should have its own reference to it. BUG=650723 Review-Url: https://codereview.chromium.org/2471183003 Cr-Commit-Position: refs/heads/master@{#430293} -
lgrey authored
Per offline discussion, leaving "ChromeOS.MemoryPressureLevel" code in place for ChromeOS while history builds up in "Memory.PressureLevel" BUG=655304 Review-Url: https://codereview.chromium.org/2434103003 Cr-Commit-Position: refs/heads/master@{#430292}
-
msarett authored
Revert of Replace flaky smoke test (patchset #1 id:1 of https://codereview.chromium.org/2477013003/ ) Reason for revert: Still breaking the Android bot Original issue's description: > Replace flaky PNG smoke test > > The removed test is a bit slow, which I suspect is > causing flaky behavior on Android. The test that > is replacing it provides coverage of png decoding > and color correction. > > BUG=657839 > BUG=661769 > > Committed: https://crrev.com/373093497c9ebca029a707a8d9fee5e57e3d2af6 > Cr-Commit-Position: refs/heads/master@{#430270} TBR=dpranke@chromium.org,msarett@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=657839 Review-Url: https://codereview.chromium.org/2479253002 Cr-Commit-Position: refs/heads/master@{#430291}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/660b1cf4a963..43513543de10 $ git log 660b1cf4a..43513543d --date=short --no-merges --format='%ad %ae %s' 2016-10-14 halcanary SkXPS: handle case where snapSpecial() returns null 2016-11-07 mtklein SkRasterPipelineBlitter: blitAntiH + full coverge --> blitH 2016-11-07 mtklein update ANGLE docs for GN, current test tools 2016-11-07 robertphillips Further centralize computation of GrSurface VRAM consumption - take 2 2016-11-06 mtklein GN: quiet alink spam on Mac 2016-11-06 mtklein GN: quiet link.exe warning spam. Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=scroggo@google.com Review-Url: https://codereview.chromium.org/2479223002 Cr-Commit-Position: refs/heads/master@{#430290}
-
lgrey authored
Based on shrike@'s work in https://codereview.chromium.org/989703002 The original change was reverted as a result of https://crbug.com/536170. The underlying issue (backgrounding affecting session restore) was fixed in https://codereview.chromium.org/1769123002, so this change mostly adapts the original code to the current state of the codebase and adds a new feature to gate it. BUG=460102, 536170 Review-Url: https://codereview.chromium.org/2454073003 Cr-Commit-Position: refs/heads/master@{#430289}
-
lizeb authored
Chrome connects to a bound service exposed by GSA, elevating its importance to the system (see the linked bug). This requirement is going away, and this CL is assessing the amount of memory wasted / saved this way. On a Nexus 5X, the cost of gathering this data has been measured (through Trace events) to be ~60ms of wall clock time (on a low-priority background thread), with ~2ms of CPU time on a little core. The data is gathered at most once per startup. BUG=614388 Review-Url: https://codereview.chromium.org/2477513004 Cr-Commit-Position: refs/heads/master@{#430288}
-
debugwang authored
NPAPI is not used in WebPlugin.h, remove it BUG=none R=haraken@chromium.org Review-Url: https://codereview.chromium.org/2481213002 Cr-Commit-Position: refs/heads/master@{#430287}
-
blink-w3c-test-autoroller authored
Using update-w3c-deps in Chromium 89f010d8. TBR=qyearsley@chromium.org Review-Url: https://codereview.chromium.org/2476293002 Cr-Commit-Position: refs/heads/master@{#430286}
-
nednguyen authored
Reland of [testing/script] Switch run_telemetry_as_googletest.py to produce full json results format (patchset #1 id:1 of https://codereview.chromium.org/2408043002/ ) Reason for revert: Mac 10.10 Tests & Mac 10.11 Tests are now swarmed: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/8831 https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.11%20Tests/builds/3344 Original issue's description: > Revert of [testing/script] Switch run_telemetry_as_googletest.py to produce full json results format (patchset #2 id:20001 of https://codereview.chromium.org/2403913002/ ) > > Reason for revert: > Speculatively reverting this patch (suggested by findit) to see if it fixes Mac telemetry unit tests. > > https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/8276 > > https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/8277 > > Original issue's description: > > [testing/script] Switch run_telemetry_as_googletest.py to produce full json results format > > > > BUG=649762 > > > > Committed: https://crrev.com/caa3b797728c9337fcea7d108a087d005fa7f451 > > Cr-Commit-Position: refs/heads/master@{#424206} > > TBR=kbr@chromium.org,dpranke@chromium.org,nednguyen@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=649762 > > Committed: https://crrev.com/12b54d66ba1ce9e7a6c729fdf136b5b5c257b6f2 > Cr-Commit-Position: refs/heads/master@{#424341} TBR=kbr@chromium.org,dpranke@chromium.org,loyso@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=649762 Review-Url: https://codereview.chromium.org/2480273002 Cr-Commit-Position: refs/heads/master@{#430285}
-
hiroshige authored
internals.settings.setOverlayScrollbarsEnabled() doesn't work well when it is called after ScrollbarTheme is initialized in the first layout. The CL [1] modifies the timing of document load event and makes onload() in fast/scrolling/scrollbar-tickmarks-hittest.html to be called after the first layout, and thus breaks the test. This CL moves setOverlayScrollbarsEnabled() to outside onload() such that it is called before ScrollbarTheme is initialized. [1] https://codereview.chromium.org/2269043002/ BUG=624697 TEST=fast/scrolling/scrollbar-tickmarks-hittest.html Review-Url: https://codereview.chromium.org/2484613003 Cr-Commit-Position: refs/heads/master@{#430284}
-
raphael.kubo.da.costa authored
The function has never been used anywhere ever since it was introduced, which can trigger a build failure on GCC 6.2.0 due to -Wunused-function. R=asvitkine@chromium.org,holte@chromium.org,isherman@chromium.org Review-Url: https://codereview.chromium.org/2481793002 Cr-Commit-Position: refs/heads/master@{#430283}
-
zpeng authored
Create java_assertion_enabler, a Java binary that takes in a JAR file, modifies the bytecode of classes that use Java ASSERT, and outputs them to a new JAR file. BUG=462676 Review-Url: https://codereview.chromium.org/2475003005 Cr-Commit-Position: refs/heads/master@{#430282}
-
skyostil authored
When a navigation happens, we should reset the number of pending input events in the user model to avoid waiting for an acknowledgement which may never arrive. This is a speculative mitigation for crbug.com/652294. BUG=652294 Review-Url: https://codereview.chromium.org/2476263002 Cr-Commit-Position: refs/heads/master@{#430281}
-
csharrison authored
This API is unused, so there is no need for a thread safe map, or even a scheme map at all. BUG=348655 Review-Url: https://codereview.chromium.org/2475673003 Cr-Commit-Position: refs/heads/master@{#430280}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8ac279fd8db3..0adb6ef9b5dd $ git log 8ac279fd8..0adb6ef9b --date=short --no-merges --format='%ad %ae %s' 2016-11-07 nednguyen [Telemetry] Remove the logic of killing stray adb processes BUG=656224 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2477243003 Cr-Commit-Position: refs/heads/master@{#430279}
-
mlippautz authored
BUG=chromium:468240 NOTRY=true Review-Url: https://codereview.chromium.org/2442503006 Cr-Commit-Position: refs/heads/master@{#430278}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/19cd7cc42700..470b5fa8f8db $ git log 19cd7cc42..470b5fa8f --date=short --no-merges --format='%ad %ae %s' 2016-11-07 thestig Compile fuzzer sources in standalone builds. Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2483833002 Cr-Commit-Position: refs/heads/master@{#430277}
-
clamy authored
This CL makes the request initiator used in ResourceRequests and NetURLRequests optional. This will eventually allow to distinguish between a unique initiator and a request with no initiator (eg. a top-level browser-initiated navigation). BUG=475027 Review-Url: https://codereview.chromium.org/2405483002 Cr-Commit-Position: refs/heads/master@{#430276}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/424704de..18f26b66 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2484683002 Cr-Commit-Position: refs/heads/master@{#430275}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/51c5678f2587..660b1cf4a963 $ git log 51c5678f2..660b1cf4a --date=short --no-merges --format='%ad %ae %s' 2016-11-07 borenet Roll recipe DEPS Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=scroggo@google.com Review-Url: https://codereview.chromium.org/2482893002 Cr-Commit-Position: refs/heads/master@{#430274}
-
vitaliii authored
Due to crbug.com/660343 we could not remove an unused resource string, which is finally removed in this CL. Also an obsolete TODO related to crbug.com/641568 is removed (offline pages are now opened correctly, see crbug.com/661214). BUG=none Review-Url: https://codereview.chromium.org/2477313003 Cr-Commit-Position: refs/heads/master@{#430273}
-
mahmadi authored
BUG=660835 Review-Url: https://codereview.chromium.org/2480603003 Cr-Commit-Position: refs/heads/master@{#430272}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/3c90067aa0d9..8ac279fd8db3 $ git log 3c90067aa..8ac279fd8 --date=short --no-merges --format='%ad %ae %s' 2016-11-07 hjd [tracing] Fix typo in layer tree view error Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2477263003 Cr-Commit-Position: refs/heads/master@{#430271}
-
msarett authored
The removed test is a bit slow, which I suspect is causing flaky behavior on Android. The test that is replacing it provides coverage of png decoding and color correction. BUG=657839 BUG=661769 Review-Url: https://codereview.chromium.org/2477013003 Cr-Commit-Position: refs/heads/master@{#430270}
-
sdefresne authored
Add new template compile_plist that merge multiple plist files and perform variables subsitutions and change info_plist implementation to use it. The new template will be used to compile entitlements files that need different substitutions and do not use the one for Info.plist. BUG=613543 Review-Url: https://codereview.chromium.org/2475893002 Cr-Commit-Position: refs/heads/master@{#430269}
-
Florin Malita authored
Disable analytic AA as it is consistently causing crashes on the performance waterfall, e.g.: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%284%29/builds/13936/steps/smoothness.tough_path_rendering_cases/logs/stdio This is effectively a revert of https://codereview.chromium.org/2457393004 without the changes to the test expectations since they do not revert cleanly any longer. BUG=662722 TBR=fmalita@chromium.org Review URL: https://codereview.chromium.org/2476273002 . Cr-Commit-Position: refs/heads/master@{#430268}
-
amalika authored
This is part of an experimental feature Embedding-CSP. In particular this is the second CL devoted to implementing *3.3. Is policy list subsumed under subsuming policy? In this patch we try to find normalized list of CSPSources from the two given vectors of CSPSources. Example: A: http://*.example.com B: http://example.com/index.html In this case, the latter contains more information because it provides a more specific path and no host wildcard. Thus, their normalization would be equivalent to B. Example: A: http:// B: http://example.com/index.html Scheme-source/ host-source expression normalization should be equivalent to B. Example: A: https:// B: http://example.com/index.html Scheme-source/ host-source expression normalization should return https://example.com/index.html. BUG=647588 Review-Url: https://codereview.chromium.org/2470083002 Cr-Commit-Position: refs/heads/master@{#430267}
-
arthursonzogni authored
This CL gives frames the opportunity to show alternative content when <object data="..."> navigation fails instead of displaying an error page. It fixes a collection of tests(see bug description) that fail with the --enable-browser-side-navigation flag. BUG=657834 Review-Url: https://codereview.chromium.org/2439903003 Cr-Commit-Position: refs/heads/master@{#430266}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/ad512797c940..51c5678f2587 $ git log ad512797c..51c5678f2 --date=short --no-merges --format='%ad %ae %s' 2016-11-07 caryclark use reversePathTo in place of addPathReverse Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=scroggo@google.com Review-Url: https://codereview.chromium.org/2481203002 Cr-Commit-Position: refs/heads/master@{#430265}
-
robpercival authored
This allows audit (aka. inclusion) proofs to be verified, which helps check that CT logs are behaving correctly. BUG=631087 Review-Url: https://codereview.chromium.org/2182533002 Cr-Commit-Position: refs/heads/master@{#430264}
-
rohitrao authored
BUG=None TEST=None Review-Url: https://codereview.chromium.org/2477243002 Cr-Commit-Position: refs/heads/master@{#430263}
-
sfiera authored
There's a lot more here that ought to be tested, but this is a start. Review-Url: https://codereview.chromium.org/2471133004 Cr-Commit-Position: refs/heads/master@{#430262}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a69e9719..424704de Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2484633002 Cr-Commit-Position: refs/heads/master@{#430261}
-
sdefresne authored
Chrome deployment target is now 10.9 so remove override from iossim when building iOS. BUG=595295 Review-Url: https://codereview.chromium.org/2469983004 Cr-Commit-Position: refs/heads/master@{#430260}
-
sdefresne authored
BUG=658242 Review-Url: https://codereview.chromium.org/2454093002 Cr-Commit-Position: refs/heads/master@{#430259}
-