- 02 Feb, 2018 40 commits
-
-
Istiaque Ahmed authored
These tests extend ExtensionRegistryObserver to wait for extension load/unload etc. TestExtensionRegistryObserver already provides this functionality. Bug: 808136 Test: None Change-Id: I195f206163f54b7547079b10c48e677a86eaf6db Reviewed-on: https://chromium-review.googlesource.com/897468Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533967}
-
Dominick Ng authored
This CL implements a mini-infobar that is displayed when users visit any PWA. Tapping the infobar will trigger add to home screen. The intention is to inform users that they are browsing a PWA, give easier access to add to home screen, and encourage developers to adopt PWAs through privileged UI. App install currently fulfill the informational role that ambient badges will now take. This CL will enable future work to stop app banners from automatically appearing, and change them to adopt a modal, developer-triggered flow which hands more control to sites. Future CLs will: - disable automatic app install banner triggering when the ambient badge feature is active - change the string of the ambient badge such that it launches the PWA if it is already installed Eventually, it is hoped that a less intrusive UI will take the place of the mini infobar for the ambient badge. BUG=782120 Change-Id: Id012522982699d61293c57b79c4eb3ef0fe9e55f Reviewed-on: https://chromium-review.googlesource.com/879701 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#533966}
-
Hayato Ito authored
There should be no functional changes from this patch. Bug: 776656 Change-Id: I975e32a2cd2fa2610352ce1c85f10b3afe5bc688 Reviewed-on: https://chromium-review.googlesource.com/897288Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#533965}
-
Kunihiko Sakamoto authored
Bug: 803774 Change-Id: I5d81a2044e1467e19d3b99edc8bad6192829a7e6 Reviewed-on: https://chromium-review.googlesource.com/895238 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#533964}
-
Kent Tamura authored
This CL has no behavior changes. Change-Id: I3909b2f6232569df1889471d07132a90c1023009 Reviewed-on: https://chromium-review.googlesource.com/897386Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#533963}
-
Ehsan Chiniforooshan authored
This adds two stories for measuring UI compositor FPS: 1- Loads news.yahoo.com; goes to overview mode; exits overview mode. 2- Loads poster circle; goes to overview mode; exits overview mode. The stories run only when the browser backend supports overview mode actions; so this will not break perf bots. For now, we will run these stories manually. Note: this should be landed after 884511, due to using --always-request-presentation-time browser arg. Bug: 795928 Change-Id: Ib09348334ba3708d316c46a7a89f0febc8532264 Reviewed-on: https://chromium-review.googlesource.com/895411Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#533962}
-
Tien-Ren Chen authored
This reverts commit 19374016. Reason for revert: crbug.com/806848 Original change's description: > Reland "LayoutView::StyleWillChange viewport invalidation" > > This reverts commit 8c08d938: > > Revert LayoutView::StyleWillChange viewport invalidation > > > > This patch is a speculative revert of the following patch: > > "Let LayoutView::StyleWillChange handle viewport invalidation." > > https://chromium-review.googlesource.com/c/chromium/src/+/609984 > > r495573 > > 1fac40c9 > > > > This patch could be responsible for regressions in the following: > > * Blink.Paint.UpdateTime > > * Blink.Compositing.UpdateTime > > > > Bug: 768612 > > Change-Id: I8d12b80473afee2eecdb3ff1a8c3538f334eaf59 > > Reviewed-on: https://chromium-review.googlesource.com/719336 > > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > > Reviewed-by: Rune Lillesveen <rune@opera.com> > > Commit-Queue: Rune Lillesveen <rune@opera.com> > > Cr-Commit-Position: refs/heads/master@{#509012} > > Unfortunately we couldn't observe performance metric recovery from the > speculative revert, thus landing the CL again and we will be watching if > performance fluctuated. > > BUG=768612 > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng > Change-Id: I05c2a6bfe0f85cffdbf0b2ea1813a3ff7a83f05d > Reviewed-on: https://chromium-review.googlesource.com/848153 > Commit-Queue: Tien-Ren Chen <trchen@chromium.org> > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532087} TBR=trchen@chromium.org,chrishtr@chromium.org,futhark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 768612 Change-Id: Icd9d0febbee618735c7ae60b639d8b45ea19f644 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/892124 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#533961}
-
David Tseng authored
Test: chromevox_tests. Prior to the change, BackgroundTest.ActiveDescendantUpdates fails because 'Selected' is not spoken. Compute text content for list items without names Chrome doesn't compute descendant name on focus. Test: manually on twitter.com using j/k. Verify all text gets read. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie75dff41f98b8aa3904e435afa4bd245b9771cce Reviewed-on: https://chromium-review.googlesource.com/891676 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#533960}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6c1a69bb..09eb87e6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I99040eac63e97d1be2f656a38920ee155da6e498 Reviewed-on: https://chromium-review.googlesource.com/897754Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#533959}
-
khmel authored
Custom app icon loading is started immidiatelly when it is assigned, including the case when it is set as a create parameter for Chrome app window. In last case icon gets loaded in together with main page content loaded. Here is the race. If page is loaded first it commits navigation which abort all pending resource load requests, including the custom icon. As result custom icon is not loaded. Solution is to start custom icon loading only when app window is ready. Test: Manually Bug: 788531 Change-Id: If72a094a846b87f45bfe60bfbbcb7889281579c5 Reviewed-on: https://chromium-review.googlesource.com/895200 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#533958}
-
https://webrtc.googlesource.com/src.git/+log/5f94aa2c013e..ed7b4ff9e38c $ git log 5f94aa2c0..ed7b4ff9e --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I942dec5d9938f6fb937c2b06c358ccf26bace46c Reviewed-on: https://chromium-review.googlesource.com/898587Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533957}
-
Yoichi Osato authored
htmlElementTypeForTag(tagName) returns HTMLElementType for the name. However this returned wrong type for each tag that's DOM interface is HTMLElement but Blink implements the class inheriting HTMLElement, e.g. ruby element. htmlElementTypeForTag is generated function by make_element_type_helpers.py using HTMLTagNames.json5. This patch modifies the python script to return each appropriate DOM interface. Bug: 805281 Change-Id: I81525ae0a79d7b37e8e5e0df664375e2019f37c2 Reviewed-on: https://chromium-review.googlesource.com/892843Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#533956}
-
Kevin Marshall authored
Enable the new-style (SSH-based) test runner on the "Fuchsia" chromium.fyi bots on test suites which don't depend on dynamic linking or multiple packaged executables. * Add a command line switch to conditionally redirect execution to the v2 runner script (--use-new-test-runner). * Include archive_manifest file in v2 runner's runtime deps. * Relativize archive_manifest source paths for isolate portability. * Automatically resolve paths to unstripped binaries during symbolization. Change-Id: I4f482c666c4f1e0f546f0f07d4498f721776215b Reviewed-on: https://chromium-review.googlesource.com/895386Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#533955}
-
Darren Shen authored
This patch removes the tentative extension from CSSURLImageValue and adds an IDLHarness test for it. TBR=nainar@chromium.org Bug: 774887 Change-Id: I3dceb0a91231f40ff7a44a620146bcf77baf260f Reviewed-on: https://chromium-review.googlesource.com/897229Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#533954}
-
Joel Hockey authored
This fixes a number of bugs found on clusterfuzz. Change-Id: Id2fa1d96e55be1e0483c135c20c20b90a068f4c3 Bug: 790944 Bug: 793715 Bug: 796804 Bug: 799707 Reviewed-on: https://chromium-review.googlesource.com/897220 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#533953}
-
Wenzhao Zang authored
1) Opening wallpaper picker is NOT allowed if: a) The active user is policy controlled (must be checked by //ash/WallpaperController), or b) The active user type is GUEST or KIOSK etc. (can be checked from //ash or //chrome). 2) The wallpaper picker can be opened either from the setting page (//chrome) or the shelf context menu (//ash). In addition, the setting page need to distinguish between cases a) and b), in order to show different UI. So we need to create two mojo callbacks. 3) In addition, WallpaperControllerClient should not rely on the setting page to check a) and b): it must call into //ash to ask, in case a refactoring of the setting page will cause regression (there was once a bug because of this.) 4) The check of b) used to rely on LoginState but it was recently deprecated, so it's using SessionController in //ash instead. TBR=blundell@chromium.org in Settings is a) invisible for guest session, b) disabled for users controlled by wallpaper policy, c) enabled for other cases. Bug: 798604 Test: 1) ash_unittests 2) Manual test by checking the 'Wallpaper' item Change-Id: Icb1479d2112f02b823237c418622cc0cdbae65fc Reviewed-on: https://chromium-review.googlesource.com/848193Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#533952}
-
Yoshifumi Inoue authored
This patch moves "doubleclick-inline-first-last-contenteditable.html" to "editing/selection/mouse" because this test verifies selection with mouse for ease of maintenance. This is a follow-up of reviewer's suggestion in the patch[1]. [1] http://crrev.com/c/896903 Rewrite editing/selection/doubleclick-inline-first-last-contenteditable.html to use selection_test() NOTRY=true TBR=yoichio@chromium.org Bug: 679977 Change-Id: I35e79f27723204dd697b8920028300c6584ee354 Reviewed-on: https://chromium-review.googlesource.com/897391Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533951}
-
Xianzhu Wang authored
Set correct property tree state for frame printing. Skips frame scroll translation because we always print from the origin of the frame which initiated printing. We don't need to skip LayoutView scroll translation with RLS because we print in the LayoutView's container space. Bug: 808219 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7d605b7f5e79156829ba861a0a27b8c844892157 Reviewed-on: https://chromium-review.googlesource.com/894486 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#533950}
-
Darren Shen authored
Currently CSSStyleImageValue implements the CSSImageValue class in Typed OM. CSSImageValue can be anything that's an <image> i.e. a <url>, <gradient>, or <cross-fade>. However, the current implementation of CSSStyleImageValue only really works for <url>s. This patch moves <url> specific logic into CSSURLImageValue. This prepares for the implementation of <gradient> and <cross-fade>, which will be subclasses of CSSStyleImageValue. We also do some cleanup work (e.g. making things const, moving code in header to cpp). Bug: 803680 Change-Id: I848b3eab5dbbcb9bbe7f0aea0d377497f63bfda3 Reviewed-on: https://chromium-review.googlesource.com/882786 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#533949}
-
Yuta Kitamura authored
TBR=wez@chromium.org Bug: 808138 Change-Id: I773d3238fb4140211cba071148d1c864930983c9 No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/897393 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#533948}
-
John Budorick authored
This reverts commit ca7f0798. Reason for revert: Seems to be breaking chromium.chromiumos bots w/ GS ACL issues: crbug.com/808312 Original change's description: > Automated Commit: Committing new LKGM version 10365.0.0 for chromeos. > > TBR=chrome-os-gardeners@google.com > > Change-Id: I3f6a6302f140de133d5e4419a7b2b93065537820 > Reviewed-on: https://chromium-review.googlesource.com/897844 > Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533936} TBR=chrome-os-gardeners@google.com,chromeos-commit-bot@chromium.org Change-Id: Ie67db1d4d475a25adee37edaade0c3234322905e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/898642Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#533947}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I0077afe015482b328614da282966a4886f74eebc Reviewed-on: https://chromium-review.googlesource.com/898662Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#533946}
-
Sean Kau authored
We need notification of reference invalidation for ExternalPrinters objects. So, change to distributing WeakPtrs instead of raw pointers. Bug: 805825 Change-Id: I06aee8e91df490ceae8fd8fe671e31472ae316fd Reviewed-on: https://chromium-review.googlesource.com/891574 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#533945}
-
Siddhartha authored
GetOrCreateAllocatorDump() was exposed for a particular case where multiple dump providers need to create same dump. Using this method in common providers lead to errors in reporting. R=dskiba@chromium.org Change-Id: I164574f635ab316390778eefd5b4b0c0c8ef5da5 Reviewed-on: https://chromium-review.googlesource.com/892491Reviewed-by:
Dmitry Skiba <dskiba@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#533944}
-
Matt Giuca authored
These labels are treated specially by the parser, and need tests. We test both valid xn-- domain labels (ASCII only), as well as xn-- labels that contain Unicode characters (which are invalid). Bug: 804462 Change-Id: I943034745bdf65ae3b6df77c5ed8cb95a590a105 Reviewed-on: https://chromium-review.googlesource.com/897286Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#533943}
-
Matt Falkenhagen authored
Previously, if the <video> src was same-origin as the page, and the service worker intercepted the request and responded with an opaque response (by making a cross-origin request without CORS sharing), the <video> would be considered same-origin data. The solution is to teach the data backing <video> about FetchResponseType, which tells us if a response is opaque or non-opaque. There is some complexity with multiple responses due to range requests/ partial content responses. It's possible that some responses are opaque and some are non-opaque. Once the opaque bit is set, it shouldn't be cleared. This fixes tests added in: https://chromium-review.googlesource.com/c/chromium/src/+/892683 and https://chromium-review.googlesource.com/c/chromium/src/+/897165 Bug: 780435 Change-Id: I95f7f088d907f84edd4c2db8b57532e761237465 Reviewed-on: https://chromium-review.googlesource.com/828564Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#533942}
-
https://pdfium.googlesource.com/pdfium.git/+log/59790cef1a09..f7c84e910899 $ git log 59790cef1..f7c84e910 --date=short --no-merges --format='%ad %ae %s' 2018-02-02 thestig Fix IWYU errors in fpdfppo.cpp. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ibc52bf576b7449bbeaa035f348c33bc91876a95a Reviewed-on: https://chromium-review.googlesource.com/898586Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533941}
-
Wez authored
Unlike the existing Linux warnings, this is enabled for Fuchsia including Chromecast and Ozone builds. Bug: 177475, 808138 Change-Id: Idaf85eabbf3029f37c9c37c7b1bd8f03e411a9d1 Reviewed-on: https://chromium-review.googlesource.com/898007 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#533940}
-
Xianzhu Wang authored
- Move PropertyTreeStatePrinter from PropertyTreeState.h into PaintPropertyNode.h and rename it to PropertyTreePrinter. - Remove duplicated code originally in platform/.../PropertyTreeState.h and core/.../PaintPropertyTreePrinter.cpp and let PaintPropertyTreePrinter use the new PropertyTreePrinter in platform/.../PaintPropertyNode.h - Add PaintPropertyNode::DebugName (DCHECK only) to store annotations for the node, so that we can also see them in the result of ToString() and ToTreeString(). This will help debugging property tree states in platform/ code. - Remove paintPropertyTreeGraph which is out-dated and unlikely to be maintained. - Other code cleanup and simplification Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I02cdf3f054110a63190997db9f7543b6c254eb22 Reviewed-on: https://chromium-review.googlesource.com/897825 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#533939}
-
https://skia.googlesource.com/skia.git/+log/e45d32abe132..85ae7159c9c8 $ git log e45d32abe..85ae7159c --date=short --no-merges --format='%ad %ae %s' 2018-02-01 bsalomon Add new GrContext queries for imagability, surfacability, and max sample count of color types Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Ibf3a252c640f3be1e0a3715082a43e11453cb94b Reviewed-on: https://chromium-review.googlesource.com/898585Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533938}
-
Timothy Loh authored
This patch implements UKM for permission actions, alongside the current reporter which uses the SafeBrowsing service. For now we handle exactly the set of actions which the current reporting handles for prompts, but revocations are not yet reported. The logged URL is the top frame's url even for prompts from an iframes, as UKM does not permit logging iframe urls. This is fine as the upcoming permission delegation work will make those prompts request under the top frame's origin. Bug: 793202 Change-Id: I7b1d7a022c436eb8cbb458c1655f6ee81bdb88eb Reviewed-on: https://chromium-review.googlesource.com/872371 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#533937}
-
chromeos-commit-bot@chromium.org authored
TBR=chrome-os-gardeners@google.com Change-Id: I3f6a6302f140de133d5e4419a7b2b93065537820 Reviewed-on: https://chromium-review.googlesource.com/897844Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#533936}
-
Dmitry Gozman authored
Bug: none Change-Id: I875bf9ad5eea00d1c1965ac280d0dce46215624b Reviewed-on: https://chromium-review.googlesource.com/896871Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533935}
-
Yoshifumi Inoue authored
This patch changes "remove-underline-across-paragraph{,-bold}.html" to utilize |selection_test()| for ease of maintenance. Note: Both tests use similar test case, this patch puts them into one file. Bug: 679977 Change-Id: Ic80aa10d94210016fec484ff93262e9346e4639d Reviewed-on: https://chromium-review.googlesource.com/897309Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533934}
-
Yoshifumi Inoue authored
This patch changes "overtype.html" to utilize |selection_test()| for ease of maintenance. This patch is a preparation for the patch[1]. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection Bug: 679977 Change-Id: I9a043b5537dc188a46984d62708ad98dcd9b933b Reviewed-on: https://chromium-review.googlesource.com/897306Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533933}
-
Yoshifumi Inoue authored
This patch changes "remove-format-multiple-elements-{mac,-win}.html" into "remove-format-multiple-elements.html" with utilizing |selection_test()| for ease of maintenance. Because of test cases specify selected range directly instead of using |Selection#modify()|, test cases are independent from platform, e.g. selecting whitespaces after word. Bug: 679977 Change-Id: I2dd807062a1c1547072a2407057f8b400b98b7c1 Reviewed-on: https://chromium-review.googlesource.com/896764Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533932}
-
Yoshifumi Inoue authored
This patch renames "pasteboard/5032095.html" to "inserting/insert_html_at_end_of_paragraph.html" to provide what this test verifies from file name for improving code health. Because of this test verifies "insertHTML" command instead of clipboard, this patch moves this file to "editing/inserting" directory. This is a follow-up the patch[1]. [1] http://crrev.com/c/892552 Rewrite editing/pasteboard/5032095.html to use selection_test() Bug: 679977 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: If90700169e84c2e6c9381a55a5397cc7bff05368 Reviewed-on: https://chromium-review.googlesource.com/897226Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533931}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ad9e8781..6c1a69bb Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I7928bf761af3d32bb85d3cccd295e7acd72f784b Reviewed-on: https://chromium-review.googlesource.com/897843Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#533930}
-
Yoshifumi Inoue authored
Rewrite editing/selection/doubleclick-inline-first-last-contenteditable.html to use selection_test() This patch changes "doubleclick-inline-first-last-contenteditable.html" to utilize |selection_test()| for ease of maintenance. Bug: 679977 Change-Id: Id65f597b65a031ff4a6ce2137373b03905e6b839 Reviewed-on: https://chromium-review.googlesource.com/896903Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533929}
-
Dirk Pranke authored
The mac10.13_blink_rel was not running any tests, because the builder it was set up to mirror ("Dummy WebKit Mac10.13") was on the wrong waterfall. R=robertma@chromium.org BUG=807817 Change-Id: I067f5f12dde2cdca89959ec59afeaed45d2296cc Reviewed-on: https://chromium-review.googlesource.com/898210 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#533928}
-