- 03 Oct, 2018 18 commits
-
-
Dan Sanders authored
VideoFrames marked with VideoFrameMetadata::READ_LOCK_FENCES_ENABLED must be retained until all reads have been completed. Such frames are produced when software frames are uploaded to GpuMemoryBuffers. The VideoResourceUpdater handles this, but PaintCanvasVideoRenderer implemented only sync tokens. As a result, WebGL reads of software-decoded frames can tear when the storage is reused for later frames. This CL adds a GL_COMMANDS_COMPLETED_CHROMIUM query after each potential VideoFrame read in PaintCanvasVideoRenderer, and retains a reference to the VideoFrame until it completes. This ensures that the memory is not reused until after the reads complete in the GPU process. TBR=tedchoc@chromium.org,pfeldman@chromium.org Bug: 819914 Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel Change-Id: Iec05d3bca69e68ae3d3b231db84caa9bed24d777 Reviewed-on: https://chromium-review.googlesource.com/c/1258212 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#596072}
-
Luis Hector Chavez authored
I'm not going going to be watching ARC-related changes going forward. Bug: None Change-Id: I606c46f81e39cf00ce7eb3611fc96c8a628730e2 Reviewed-on: https://chromium-review.googlesource.com/c/1258602Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#596071}
-
Dmitry Gozman authored
We already pass WebFrameLoadType around, which controls whether we should replace the current history item or not. TBR=mmenke@chromium.org Bug: none Change-Id: Ifd0ac92396334dac14bd4822c7a4f702e31b265e Reviewed-on: https://chromium-review.googlesource.com/c/1246419 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#596070}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/64ba5a302bf0..2be958cd896f Created with: gclient setdep -r src-internal@2be958cd896f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:888064,chromium:891313 TBR=mmoss@chromium.org Change-Id: I4d15bfac9610f58b70a294324daec7393d1dac58 Reviewed-on: https://chromium-review.googlesource.com/c/1258403Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596069}
-
Steve Anton authored
This CL implements the RTCQuicTransport createStream method and the corresponding quicstream event hooked up to the QUIC adapters. It also implements RTCQuicStream.reset/finish and statechange event to allow end-to-end testing. Bug: 874296 Change-Id: I331d37f3e21c606697b8768bf9eea59c90487163 Reviewed-on: https://chromium-review.googlesource.com/c/1217846 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#596068}
-
Alexey Baskakov authored
This reverts commit dec38a71. Reason for revert: Crashes browser_tests. Example: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8933735011043353616/+/steps/browser_tests/0/stdout Original change's description: > CrOS FilesApp: Share crostini entries before opening > > When a user opens files within Downloads using a crostini app, > show a dialog for the user to give permission to share the > directory that the files are in with crostini. > > * Move handling of 'crostin-files' flag checking into > foreground/js/crostini.js > * Change FileTasks.executeInternal to detect files that > can be shared with crostini and do sharing before execute. > * UI Test verifies share dialog is shown before execute. > * ConvertFileSystemURLToPathInsideCrostini maps > path from within Downloads to '/ChromeOS/Downloads/...' > > Bug: 878324 > Change-Id: Ie88090ff958dd201aeacb23fdfcc84a4f3d20210 > Reviewed-on: https://chromium-review.googlesource.com/c/1243871 > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596003} TBR=timloh@chromium.org,joelhockey@chromium.org,nverne@chromium.org,lucmult@chromium.org Change-Id: I553be4bfe6c0fad8435383c70b44a420237b250b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 878324 Reviewed-on: https://chromium-review.googlesource.com/c/1258622Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#596067}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7f47c50227fb..0c56d6362b95 git log 7f47c50227fb..0c56d6362b95 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 thestig@chromium.org Make CFGAS_DefaultFontManager a class with only static methods. 2018-10-02 thestig@chromium.org Reduce includes in cfgas_defaultfontmanager.h 2018-10-02 thestig@chromium.org Remove unneeded cfgas_fontmgr.h includes. 2018-10-02 tsepez@chromium.org Consolidate ReadMoreData() calls. 2018-10-02 tsepez@chromium.org Remove ability to delete annot in CJS_Document::removeField() Created with: gclient setdep -r src/third_party/pdfium@0c56d6362b95 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891210 TBR=dsinclair@chromium.org Change-Id: I495207acea5218f1631688c1520c7d2be33b6c6d Reviewed-on: https://chromium-review.googlesource.com/c/1258404Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596066}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/76c775f48dec..deb512045e6a git log 76c775f48dec..deb512045e6a --date=short --no-merges --format='%ad %ae %s' 2018-10-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 75753f9f4c65..e5051aa35032 (4 commits) 2018-10-02 mtklein@google.com add BonusConfigs bot to CQ 2018-10-02 mtklein@google.com Revert "Add GM for less common YUV formats" 2018-10-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 60be5c45fab2..75753f9f4c65 (1 commits) 2018-10-02 herb@google.com Reland "Remove obsolete paint copy" 2018-10-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 16c20140e05e..df836ff8f17d (12 commits) 2018-10-02 brianosman@google.com Remove unused premul/unpremul FP code 2018-10-02 mtklein@google.com Revert "Remove obsolete paint copy" 2018-10-02 robertphillips@google.com Add GM for less common YUV formats 2018-10-02 mtklein@google.com cleanup SkColorSpace API and members 2018-10-02 mtklein@google.com Reland "clamp gamut if needed in SkConvertPixels" 2018-10-02 fmalita@chromium.org [skottie] External logger support Created with: gclient setdep -r src/third_party/skia@deb512045e6a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: I487b0b0503df5f0faacdc3dc6af15ed39de8d85e Reviewed-on: https://chromium-review.googlesource.com/c/1258405Reviewed-by:
-
Matt Falkenhagen authored
The name is changing due to a change of the server-side configuration. Bug: 715640 Change-Id: I6804c7178e7d7e3e2d5c34504435f73ca543a77c Reviewed-on: https://chromium-review.googlesource.com/c/1256397Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#596064}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a80f9bc11bcb..6a1afc01be80 git log a80f9bc11bcb..6a1afc01be80 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 primiano@google.com Merge "Ftrace: Add Setup/Start support for fast triggering" 2018-10-02 fmayer@google.com profiling: Add unittest for wire_protocol Created with: gclient setdep -r src/third_party/perfetto@6a1afc01be80 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I4d8fdc458a86406f7a518177d2b6753a28f1edbc Reviewed-on: https://chromium-review.googlesource.com/c/1257615Reviewed-by:
-
Erik Luo authored
When SuggestBox is open, ArrowUp/Down should move vertically among suggestions. Before, it might increment numerical values. Bug: none Change-Id: Ic0ede8ddca09818cd850be5bef06a8e685018dd0 Reviewed-on: https://chromium-review.googlesource.com/c/1258203Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#596062}
-
David Black authored
Previously we relied on deactivation of the Assistant widget to tell us when we should hide Assistant UI. This did not work in all cases because the user can interact with the Desktop our Settings tray without causing inactivation of the widget. Now, we register an EventMonitor to watch for events on our root window while Assistant UI is visible. If a press event happens outside our bounds, we hide Assistant UI. Note that in testing this did not cause any unexpected behavior with regards to metalayer. This CL was adapted from logic implemented here: https://cs.chromium.org/chromium/src/ash/system/tray/tray_event_filter.cc?type=cs&g=0&l=38-115 Bug: b:115923288 Change-Id: If708427467bca4ec6f0dd12a6aa876d47d033a4c Reviewed-on: https://chromium-review.googlesource.com/c/1256221Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#596061}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /base. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=dcheng@chromium.org Bug: 890902 Change-Id: I1e938b7c80ba50b8e8a0d90f4a0b57ac4e3ae5b5 Reviewed-on: https://chromium-review.googlesource.com/c/1257885Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cb192dee19d4..2dd914402ebc git log cb192dee19d4..2dd914402ebc --date=short --no-merges --format='%ad %ae %s' 2018-10-02 dtu@chromium.org [pinpoint] Allow users to enter a Gitiles url to mean a Commit. Created with: gclient setdep -r src/third_party/catapult@2dd914402ebc The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I8dd6e0695ddb60d875f68f2c7088d2ef3339acdc Reviewed-on: https://chromium-review.googlesource.com/c/1257616Reviewed-by:
-
Jordy Greenblatt authored
The new strings for settings (added in https://chromium-review.googlesource.com/c/chromium/src/+/1252915) include a notification title that contains the host device name. This CL provides it as an argument to MultiDeviceNotificationPresenter::OnNewChromebookAddedForExistingUser and updates the references to that function. Several of these are for tests (unit and manual). Screenshot of the new notification: http://screen/fzqJUOtSgHV Bug: 890521 Change-Id: If3586ea526866530a35b35d80957c57d3c83fe5c Reviewed-on: https://chromium-review.googlesource.com/c/1252338 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#596058}
-
Dan Beam authored
This document is far more a styleguide than something tracking capabilities of a system. There's many things that are functionally available in Chromium/V8 but that we're choosing not to use yet for various reasons (i.e. tooling support). R=dpapad@chromium.org BUG=671426 Change-Id: I588fd338e89813200e934a00d7ac69c325d07968 Reviewed-on: https://chromium-review.googlesource.com/c/1257544Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#596057}
-
Robbie McElrath authored
This migrates content::PpapiPluginProcessHost::PluginNetworkObserver from using NetworkChangeNotifier to NetworkConnectionTracker, which is backed by the network service. Bug: 887054 Change-Id: Ieee103c35dd2adde840ea21890c03fe4f0cc76ed Reviewed-on: https://chromium-review.googlesource.com/c/1238446 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#596056}
-
Simeon Anfinrud authored
This avoids some heap allocations and allows many callsites to be more concise. Bug: 646113 Bug: Internal b/117125296 Test: all the unittests I can run on desktop, CQ Merge-With: eureka-internal/206552 Merge-With: eureka-internal/206533 Change-Id: I48505d8c2a693c7e36616d47b6aad2348db115a6 Reviewed-on: https://chromium-review.googlesource.com/c/1256214Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596055}
-
- 02 Oct, 2018 22 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d2650d1a2851..779366899ae8 git log d2650d1a2851..779366899ae8 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 buildbot@webrtc.org Roll chromium_revision 24d8c445..b06fe539 (595822:595926) 2018-10-02 benwright@webrtc.org Add FrameEncryptor/FrameDecryptor support to Objective C API for WebRTC. 2018-10-02 jeroendb@webrtc.org Deliver partial SCTP messages when the SID is (unexpectedly) changed. 2018-10-02 philipel@webrtc.org Added RtpFrameObject::SetBitstream so that the frame can be updated with the decrypted payload. Created with: gclient setdep -r src/third_party/webrtc@779366899ae8 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:884926 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I31d10abafbd4d85c560728e2ee91bcae79ddb1cc Reviewed-on: https://chromium-review.googlesource.com/c/1257713Reviewed-by:
-
Hector Carmona authored
Followup CLs will address other visual issues to avoid over-complicating this CL Bug: 874118 Change-Id: I709fa1165e11444899f1efa5cf23270a1fb2ae6b Reviewed-on: https://chromium-review.googlesource.com/c/1226464 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596053}
-
Khushal authored
The GLOutputSurfaceBufferQueueAndroid should not use ui/gl includes since it is expected to use client-side GL. Doing so breaks jumbo builds. R=piman@chromium.org Bug: 891529 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ib7b9d424d864c4a585bae561c67ce8badbd6a5aa Reviewed-on: https://chromium-review.googlesource.com/c/1257659Reviewed-by:
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /chrome/browser/ui. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=sky@chromium.org Bug: 890902 Change-Id: I1cb56cf91d4eae9289c1316d20714f3096b8a606 Reviewed-on: https://chromium-review.googlesource.com/c/1257847Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#596051}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /content/renderer. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=haraken@chromium.org Bug: 890902 Change-Id: I50debb7aaf123e76bb03925e7720ab5be5dd16a8 Reviewed-on: https://chromium-review.googlesource.com/c/1257906Reviewed-by:
-
Lan Wei authored
In order to improve the performance and eliminate the issues that the fake mouse move events cause to the testing and web developers, we should not send fake mouse move events during scroll. This is implemented behind a flag. We will update the hover effect after scroll finishes in a following patch. Bug: 877132 Change-Id: Iee838f50e0a52b5048081d79f91442ddf0467e8f Reviewed-on: https://chromium-review.googlesource.com/c/1211907 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596049}
-
Sam McNally authored
Run with DriveFS enabled: - Drive-related context_menu.js tests. - Drive-related metadata.js tests. - folder_shortcuts.js tests. - fileDisplayDrive in tablet mode with DriveFS enabled. In order to make those tests pass: - Pass capabilities metadata to FakeDriveFs in SetMetadata() and return it in GetMetadata(). - Populate croppedThumbnailUrl so metadata cache doesn't retry fetching metadata, trying to get a value for it. - Remove two unused and incomplete tests in context_menu.js. - Only perform early-init for the downloads volume for the "user" profile. Bug: 891197 Change-Id: I8ddcbd75b74258b6988ad5c70c4e70c707d18f70 Reviewed-on: https://chromium-review.googlesource.com/c/1255086Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#596048}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /chrome/browser. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=thestig@chromium.org Bug: 890902 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id50b106729a64268795a4ca170c62573fae65abc Reviewed-on: https://chromium-review.googlesource.com/c/1257846Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#596047}
-
James Cook authored
This avoids some cases where code in //chrome/browser is directly poking into //ash to copy around tree IDs. It will also make it easier to support multiple remote tree IDs, since we're not just storing a single one in ash::AccessibilityController any more. Bug: 888147 Test: covered by tests, manually use Select-to-speak and ChromeVox with keyboard shortcut viewer, spoken feedback and focus work as expected Change-Id: Ica5c856ed8378a69fda86a2111b97bff1ee8a441 Reviewed-on: https://chromium-review.googlesource.com/c/1252905 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#596046}
-
Shakti Sahu authored
With this CL, select/share/share all context menu options will be disabled when we don't have any completed items. Delete/delete all will be always enabled and will cancel the incomplete downloads. Bug: 890537 Change-Id: I7a8cd4b5a8fea2e6daeae7a10b79a023c7f0b5a0 Reviewed-on: https://chromium-review.googlesource.com/c/1257680 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#596045}
-
Matt Swartwout authored
Bug: None Test: Build no longer fails with linker errors for this function. Change-Id: I0b126ae80f01b659dbc679f34f465322eecb7282 Reviewed-on: https://chromium-review.googlesource.com/c/1258210Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Matt Swartwout <mwswartwout@google.com> Cr-Commit-Position: refs/heads/master@{#596044}
-
Fabio Tirelo authored
Bug: 882525 Change-Id: I4eec6fca2f24fc50a9004d3f2e2aa816b0a9951c Reviewed-on: https://chromium-review.googlesource.com/c/1240393Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#596043}
-
Paul Jensen authored
Previously it was always initialized to CONNECTION_NONE, so if the first transition is to CONNECTION_NONE, it would not send out a notification. Bug: 883208 Change-Id: I583003a8d2d7160c88165a72194ca84eb9f42925 Reviewed-on: https://chromium-review.googlesource.com/c/1256285Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596042}
-
siyua authored
In the migration dialog, previously the user could click the save button if the user decided to upload no cards, in which case, we would still send a no-op Rpc call to Payments. This was not an ideal situation. Instead, we would disable the save button and the user can click the cancel button to quit the flow. Bug: 852904 Change-Id: I6a1e005a63b19046728568b4ce08755616361e08 Reviewed-on: https://chromium-review.googlesource.com/c/1255608 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#596041}
-
Jun Mukai authored
The reported bug (tab-dragging to snap to left/right on tablet mode with Mash) happens due to the timing of ClearTabDraggingInfo(), it clears ash::kTabDroppedWindowStateTypeKey but this property is used on IsSnapped() function. To have this property, this CL moves invocation of ClearTabDraggingInfo() slightly later in EndDragImpl, so that CompleteDrag() can use the values. BUG=880635 TEST=existing test passes, assuming this break nothing Change-Id: I8ba34c793dade6462fb1ee9470851cf8f066c4ad Reviewed-on: https://chromium-review.googlesource.com/c/1256006 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
-
Patrick Noland authored
Bug: 888627 Change-Id: Ibb73ce82d983aa9a4e7493352b7469ac00e85d69 Reviewed-on: https://chromium-review.googlesource.com/c/1257815Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#596039}
-
John Abd-El-Malek authored
Change-Id: I314cfd4e5e9e8ffab588a9beb53d0538eaf4c557 Reviewed-on: https://chromium-review.googlesource.com/c/1258248Reviewed-by:
Chong Zhang <chongz@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#596038}
-
Antoine Labour authored
They are not used anywhere any more. Some of them never ever were. Bug: 889651 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I81e4746927dfd763a80b215788e1690a4728ff59 Reviewed-on: https://chromium-review.googlesource.com/c/1252855Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#596037}
-
Ted Choc authored
BUG=881659 Change-Id: Ib1ad439d73b7951603a35fb9760d9cec943f0acd Reviewed-on: https://chromium-review.googlesource.com/c/1257666 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596036}
-
Dale Curtis authored
This is only used during building, there's not a good reason to have the sanitizers enabled since it will significantly slow down the actual build process and seems to try to allocation nearly a terabyte of memory at some points. BUG=861418 TEST=none Change-Id: I8d2116fbcee6dff2f1ecc422fbca5ef506fad6dd Reviewed-on: https://chromium-review.googlesource.com/c/1257671Reviewed-by:
Evgeniy Stepanov <eugenis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#596035}
-
Jun Mukai authored
HostedAppAshInteractiveUITest.MenuButtonClickable is flaky with SingleProcessMash, and I think it could be the case of unstable mouse location. When mouse move events occur during the test, then the last mouse location could change and then further mouse clicks occur on an unexpected location. UIControlsFactoryOzone can remember the last specified location and can use the remembered location for clicks. This will stabilize the HostedAppAshInteractiveUITest.MenuButtonClickable, and I hope others will get benefits. BUG=890953 TEST=locally interactive_ui_tests --enable-features=SingleProcessMash Change-Id: I3542a5a961dd4e7e8819e924d1d0c170c4dfaff1 Reviewed-on: https://chromium-review.googlesource.com/c/1255607 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
-
Varun Khaneja authored
Bug: 881605 Change-Id: I55eba01698b7504420cd4c3a6e58f01e98cbad25 Reviewed-on: https://chromium-review.googlesource.com/c/1257811Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#596033}
-
