- 26 Feb, 2020 40 commits
-
-
Yulun Wu authored
Bug: 1034168 Change-Id: I0c138a43cf76a3302aecebe11a1ad8011bb7bb59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053286 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#744501}
-
Tom Anderson authored
BUG=None R=pkasting Change-Id: I7336a75a635b95fa79adfcb3da150913c6da9242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073227 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#744500}
-
David Tseng authored
See go/unified-accessibility-component-extensions for more details. This change partially finishes item 1 above. Instead of unifying the source view of all extensions, starting off with ChromeVox and Select to Speak. Test: existing browser_tests Bug: none TBR=thakis@chromium.org Change-Id: I11cfa1664777ba68202b74e55e86efdb0663f0f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051037Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#744499}
-
Gyuyoung Kim authored
This CL replaces .mojom.h includes with .mojom-forward.h in some sub-directories of chrome/browser to reduce the pre-processed size of header files and shorter build time. The sub-directories are following, - chrome/browser/ssl - chrome/browser/storage - chrome/browser/sync - chrome/browser/task_manager This CL has no behavior changes. Bug: 1001360 Change-Id: Ie1dbb137f77733597b9a9dbac9fd735996e9a750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071525 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#744498}
-
Nate Chapin authored
I changed this to null-checking Document::GetFrame() in https://chromium.googlesource.com/chromium/src/+/976cbccdd563f77e188f0b8b1f881f101fcaf4c4, which is necessary but not sufficient. Document::Loader() will be null in any situation GetFrame() is, but will also be null in some additional ones around Document detach. Bug: 1035967 Test: Requires full print logic, so no web_test. Manually verified with clusterfuzz test case from bug. Change-Id: I33aeb63bfdc4c4fc672c72295b17064cc2a95c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072595Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#744497}
-
Haiyang Pan authored
Also remove invalid config for playstore system image on API 23 Bug: 1049700, 922145 Change-Id: I1ec89d30630ee9b4149d96b43b0a8df5a06c00fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073012 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#744496}
-
Xiaoqian Dai authored
If the back gesture nudge is waiting to be shown or is currently showing-in-progress, we should cancel the show or fade out the nudge if: * tablet mode is ended * or another window is activated on top of the window that's having the nudge ui * or the user navigates away from the current tab Bug: 1009005b Change-Id: Ic014214b41184f0e112d069ca04475740d4c41a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068052 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#744495}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be4da4f63d35..6600d4515abe Created with: gclient setdep -r src-internal@6600d4515abe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I1507013c945d2602f530ad2062b8e6f3070f0f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072852Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744494}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/422f9dd5df8e..a6db9c8fe927 git log 422f9dd5df8e..a6db9c8fe927 --date=short --first-parent --format='%ad %ae %s' 2020-02-25 deadbeef@webrtc.org Rename NetworkPriority to just Priority Created with: gclient setdep -r src/third_party/webrtc@a6db9c8fe927 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1e6b99cb33985df912f85f31f8485f01c754f95c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072935Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744493}
-
dalyk authored
This change adds several elements alongside the second radio button in the setting. The dropdown list is populated based on the user's current country code, and providers can be excluded from the dropdown list using the new FeatureParam, "DisabledProviders". The dropdown lists are not yet final. The privacy policy line contains a link to the privacy policy of any non-custom resolver selected from the dropdown menu. A future cl will display a text field when the custom resolver option is selected from the dropdown menu. The privacy policy line is hidden in this case. Change-Id: I0a2f7317d7c364e872ee1b05a7f85f65378ba499 Bug: 1040145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981852 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#744492}
-
Jacques Newman authored
The corresponding histogram log was not added when AXPlatformNodeWin::Navigate was implemented. Adding it now. Bug: 928811 Change-Id: I1dea51509c8a57e33e8ab0c1c531eb387251234c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073018 Commit-Queue: Jacques Newman <janewman@microsoft.com> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#744491}
-
Yutaka Hirano authored
Being proposed as https://github.com/mikewest/corpp/pull/8. This CL introduces a new mojo struct, CrossOriginEmbedderPolicyWithReporting to group related values. It has (virtually trivial) type mapping, because mojo::[Inlined]StructPtr is initialized as null while we don't want to allow null for CrossOriginEmbedderPolicyWithReporting. Bug: 1052764 Change-Id: I1985f24386c9dd3f76bfd2bab395b9103d14a4ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060090 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#744490}
-
Honglin Yu authored
Update DEPS to use the following commit, https://chromium.googlesource.com/chromium/deps/icu.git/+/49ee7b1d18c88676f77e8316f604bc6f89af9cb1 TEST=CQ Change-Id: Ia578fbe01641a3b1ae75ed3af3fa9ab7c8c63e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060211 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#744489}
-
Xinghui Lu authored
Bug: 1054978 Change-Id: I6bcd7fe1b30134acd6dd123805c4ce283a707ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072591 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#744488}
-
Maggie Cai authored
This CL collects the replaced preferred app when setting a preferred app for an intnet filter. This information will be send to ARC to sync with ARC. In addition, a set preferred app to ARC intent helper package will be send to ARC as well. BUG=853604 Change-Id: I1b715498cd2edca58319f70847a2919d351c0603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043332 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744487}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/530e1f0dae34..e2b3df265ebe git log 530e1f0dae34..e2b3df265ebe --date=short --first-parent --format='%ad %ae %s' 2020-02-26 dschuff@chromium.org Roll Chromium build tools Created with: gclient setdep -r src/native_client@e2b3df265ebe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: mseaborn@chromium.org Change-Id: I4c0da6155fc172c218730f9e33aa0646dc404538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072402Reviewed-by:
-
Yulun Wu authored
Tracks the number of times a user returns to home screen in tablet mode through a shelf window drag. Contextual nudge that teaches users how to return to home from in app shelf should not be shown after user performs the gesture to do so enough times. This CL counts the number of times the gesture is successfully performed. Bug: 1034168 Change-Id: If070eda66780b20077961808be0538f3679fc346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072929 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Auto-Submit: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
-
Adithya Srinivasan authored
Check if CreateProxyAndAttachPortal is called on a portal that has already been attached, and kill the renderer that sent the message if so. Bug: 1041406 Change-Id: Idea04773db777ee0591003810bbe30dcb8fa7586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072465Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#744484}
-
Sven Zheng authored
This change intend to fix that many tests generate different screenshots. Example: https://chrome-gold.skia.org/diff?test=BrowserUiDialog_ContentSettingBubbleDialogTest_InvokeUi_midi_sysex&left=976b634302062ddfddbfab74337b05e9&right=0a04041835d8de2300bb26d51621f321 https://chrome-gold.skia.org/diff?test=BrowserUiDialog_ContentSettingBubbleDialogTest_InvokeUi_midi_sysex&left=68f7bf6192125dab08a198db8b5ecf44&right=2ef995bc65b4c27bf468e042ba0d9dc9 When the dialog is not activate, it will show a deep blue for the button. When the dialog is activate, it will show a light blue for the button. So to get a more stable pixel output, we activate the dialog before taking screenshot. Bug: 1055882 Change-Id: Id452b7fa5e914e5a892d02e19174312d00c20512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071111Reviewed-by:
-
David Staessens authored
The V4L2 decode accelerator currently has its own routines and thread to manage polling the V4L2 device. This CL changes the decoder to make use of the V4L2 device poller that was introduced recently. TEST=./video_decode_accelerator_tests on hana BUG=None Change-Id: I9719bc4b45bd3bd0fbb3e11773f3a18be7299098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994844 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#744482}
-
Etienne Bergeron authored
This CL is adding unittests for unicode text that triggers FontLink fallback fonts on Windows. Bug: 995789 Change-Id: Ifdab997838f71ac6ae85dcf0ba3679520b6c101e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071252Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#744481}
-
Haiyang Pan authored
Since //third_party/android_sdk/public/tools is deleted in crrev.com/c/2044885, switch the path to //third_party/android_sdk/public/cmdline-tools/latest. Bug: 1049700, 922145 Change-Id: I7b17bdd3707bcfb2179cce0538dcc892d6e8d5f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073144Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/63832e9056ec..ab9cc2c149a0 git log 63832e9056ec..ab9cc2c149a0 --date=short --first-parent --format='%ad %ae %s' 2020-02-25 ehmaldonado@google.com my_activity: Add some tests and fix some bugs Created with: gclient setdep -r src/third_party/depot_tools@ab9cc2c149a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ic8b2b3f2a75f6289de8227833667405d5674cb95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072851Reviewed-by:
-
chrome-untrusted://new-tab-page/promoEsmael El-Moslimany authored
Bug: 1041127, 1044269 Change-Id: I8cbb50e4f0b63fe75591e415736684efc4dd2b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068745 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#744478}
-
Connie Wan authored
This doesn't get us to the final API that we want (ideally it would take a model rather than a controller), but it's a step in that direction. It also easily allows us to delete a large part of the TabController API that was used exclusively by the Editor Bubble. Bug: 1055537 Change-Id: I0914175aade82ebf874f85d979977372281dec40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070959 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#744477}
-
Adrienne Walker authored
This is in preparation for moving this code to the storage service. Bug: 1015214 Change-Id: I0d8ffc6ea4ead555e90890e8457a807f8da35abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073118 Commit-Queue: enne <enne@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#744476}
-
Joey Scarr authored
Bug: 1007685 Change-Id: I1da28c782fc4d2f808e1c728dfdf010666fceeaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059699Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Joey Scarr <jsca@chromium.org> Cr-Commit-Position: refs/heads/master@{#744475}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/e060aaf770ca..f0cc231dab7d git log e060aaf770ca..f0cc231dab7d --date=short --first-parent --format='%ad %ae %s' 2020-02-25 miu@chromium.org Add libopus and libvpx as optional external libraries. Created with: gclient setdep -r src/third_party/openscreen/src@f0cc231dab7d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I83249c0d678e24bec526c30798203d9e642c679b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072100Reviewed-by:
-
inglorion authored
This adds a gn arg, use_goma_thin_lto. When true, this enables a linker wrapper which causes ThinLTO code generation to be distributed using Goma. This can be used to reduce build time compared to a non-distributed ThinLTO build. The new gn arg allows this feature to be controlled by the build configuration, allowing distributed ThinLTO to be rolled out gradually. The arg defaults to false. R=akhuang,gbiv,hans,rnk,thakis Bug: 877722 Change-Id: Ibe4dac1669b297e8cb865dcfd3fe512f8f0cdf60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067858 Commit-Queue: Bob Haarman <inglorion@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#744473}
-
Carlos IL authored
Bug: 1047527 Change-Id: I4538ef26236a9a22539cb8cf3930ff433ba24b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073003Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#744472}
-
Stefan Zager authored
This CL made it obsolete: https://chromium-review.googlesource.com/c/1453196 R=chrishtr@chromium.org Change-Id: I6ea6e9d2053f6bb7af9152f8f01202a8bc6cf082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072932 Commit-Queue: Stefan Zager <szager@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Stefan Zager <szager@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#744471}
-
zhaoyangli authored
- Added function of moving raw coverage data in a new utility file and corresponding tests. - Added "use_clang_coverage" arg to run.py and all simulator test runner classes. - Added check of the arg and call to the function in TestRunners after running unit tests and EG tests. Bug: 943883 Change-Id: I5f16c152a38f7a8a3d988aac9e73964d890219b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048851Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#744470}
-
Carlos IL authored
AwContentsClientBridge UserData was not being cleared from the WebContents on AwContents destruction, which was causing a crash. Test: This is covered by testDestroyWebViewWithInterstitialShowing which will be re-enabled in a separate CL Bug: 1047527 Change-Id: Ic40bf3a0be8af35dbf85a8f27e6898a53462803c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071114Reviewed-by:
-
Chris Cunningham authored
First failing build: https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux/b8887471857804681856 Following guidance here: https://bugs.chromium.org/p/chromium/issues/detail?id=1047205#c5 BUG=1040247 Change-Id: I4afbef2c03652db42a225a279cd25336d40b7b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073008 Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
-
Joey Arhar authored
This test is now timing out on all platforms Bug: 1053870, 1016456 Change-Id: I9e8010a73ffdd6d2794a8e461293b8d3970195a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071097 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#744467}
-
Michael Spang authored
Add support for using zircon handles rather than file descriptors for memory object & semaphore import/export. This is needed on Fuchsia. Bug: 766360 Change-Id: If8fd761e2f4bb6bb4084127d25dd494151b3d96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642277Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744466}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f8ef81b35e8f..0941b6e91bed git log f8ef81b35e8f..0941b6e91bed --date=short --first-parent --format='%ad %ae %s' 2020-02-25 brianosman@google.com Use SkTPin in magnifier filter to avoid integer overflow with NaN 2020-02-25 bsalomon@google.com Add GrContextOption for GL error checking, shader, and program success. 2020-02-25 bsalomon@google.com Manual ANGLE roll. Update to our BUILD.gn to gen ANGLE's commit.h Created with: gclient setdep -r src/third_party/skia@0941b6e91bed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1040186,chromium:1054887 Tbr: jlavrova@google.com Change-Id: I65f1fdf0f0f6ddc1d338dc79361043eee7f1661e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072398Reviewed-by:
-
Paul Dyson authored
Class to check an external server for whether the user is is in a dogfood trial. This code is not active as it is not yet called by any other code. Bug: 1010366 Change-Id: I1f5063dbd46db3cc34092cb1575fd830fdf3f277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833167Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Paul Dyson <pdyson@chromium.org> Cr-Commit-Position: refs/heads/master@{#744464}
-
Benjamin Beaudry authored
When navigating with Narrator using Scan Mode, Narrator gets stuck on images surrounded by text inside a link. E.g.: <a href="#">hello<svg></svg>world</a> This issue is caused by AXPosition::AbortMoveAtParagraphBoundary that should return true when a position is inside of an embedded object (e.g., an image). Scan Mode uses paragraph navigation to jump from one element to the next/previous. This CL fixes it. I also added two tests: 1. A unit test for AXPosition::AtStart/EndOfParagraph, which directly depends on AXPosition::AbortMoveAtParagraphBoundary. 2. A browser test to test paragraph navigation in this specific example. This one is testing the end user experience. Bug: 928948 Change-Id: Iccd5a67c50a2b0360a749e5cecb12d60b5f5e74f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069027 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#744463}
-
David Tseng authored
- inconsistent application (e.g. tooltip didn't get delays applied) - inconsistent application of RuleStr.write (used for developer logging) - within a single output rendering (i.e. .go()), each hint got delayed; only delay the first - refactor hint_ into separate functions to clearly show the intent of the two groups (ordinary hints, and delayed hints); the former can more easily be added to for future authors - clean up debt (lots of repeated code, unneeded params) Test: existing browser_tests and a new test to show both ordinary and delayed hints together. Change-Id: I5c5c261fb013b6f33a8fa3620e9669b48e957c01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069841 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#744462}
-
