- 24 Jul, 2019 40 commits
-
-
Mario Sanchez Prada authored
Now that we have blink::SurroundingText inside Blink and implemented using internal Blink types like WTF::String and LocalFrame, we can finally migrate blink::SurroundingTextImpl away from WebLocalFrame and remove the DEPS exception rule we previously introduced during this process of Onion Soup'ing the SurroundingText API. Additionally, we move the instantiation of blink::SurroundingTextImpl from WebLocalFrame to LocalFrame as well and, with that, we remove any reference to public Blink classes from SurroundingText-related code. Bug: 980151 Change-Id: I1a1014dbf6671b9327a068ceca4f62d873cb5fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698413 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#680346}
-
Armando Miraglia authored
The bug crbug.com/970153 has identified an issue which is present in the way unplugged default and communications devices are handled. In fact, due to the way the IDs for such devices are stored, Chromium was not notifying that such devices were unplugged. This CL addresses the issue by making sure that the event is triggered on both the actual device as well as the virtual default or communications device associated to it BUG=970153 Change-Id: I30949cb8ca6f1d904dbdf94c4002c4c86d6cafc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708136Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#680345}
-
David Staessens authored
This reverts commit 5531d748. Reason for revert: Some issues still persist after the CL was re-landed with fixes. Currently all binary video decoder (perf) Tast tests are broken. The test launcher spawns a new process to run the tests, passing arguments to the new process. Unfortunately positional arguments are not passed, causing the test to be run without a video file. This can be circumvented by specifying "--single-process-tests" on the command line, but this would complicate manual usage of the video decoder tests. crrev.com/c/1708621 moved the test-launcher-specifc arguments to the video encoder tests, so it's no longer required to use a test-launcher here. Original change's description: > Reland "media/gpu: VDA tests and perf tests uses base::TestLauncher." > > This CL relands commit 372610a8, which broke the > test when enabling DCHECK. The breakage has now been fixed. > > Original change's description: > > media/gpu: VDA tests and perf tests uses base::TestLauncher. > > > > In CL:1679774 we added a TestLauncher specific argument for each > > Chrome test binary at Tast framework. However, currently VDA test and > > VDA perf test doesn't use base::TestLauncher, so they failed at > > parsing arguments. > > In this CL, we use base::TestLauncher at both VDA tests and perf > > tests. > > > > BUG=chromium:985179 > > TEST=./video_decode_accelerator_tests --test-launcher-timeout=3600000 > > > > Change-Id: I8155aae78be81bedcb252bfbdb534760e788d3be > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708150 > > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > > Reviewed-by: Alexandre Courbot <acourbot@chromium.org> > > Reviewed-by: David Staessens <dstaessens@chromium.org> > > Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#678603} > > BUG=chromium:985179 > > Change-Id: Iae3a514972498f2f51f0a087662f009fdec72ab1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710071 > Commit-Queue: David Staessens <dstaessens@chromium.org> > Reviewed-by: Chih-Yu Huang <akahuang@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#679032} TBR=akahuang@chromium.org,hiroh@chromium.org,dstaessens@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:985179 Change-Id: I22f15d4185cccbdd702be1b2ef2e8d111ea1b002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716366Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#680344}
-
Wei Lee authored
This CL changes the behavior to throw error when the given device id is invalid for CrosImageCapture API. Bug: b/137605244 Test: Manually Change-Id: I8a6b6e6e2a3edce600eb1f84759ed92aa491cdf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705854Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#680343}
-
Jinsuk Kim authored
This CL makes the top corners of BottomSheet round shape (of radius 4dp). The round corners resides inside the top shadow and takes the half the height. Bug: 985644 Change-Id: Ibfc26c06a9ca4c83aa5f7304e27a91f50fba9df7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710016 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#680342}
-
Jose Dapena Paz authored
A GCC build regression has happened on DisjointRangeLockManager, as its move operator and constructor were declared noexcept. This was failing because the default implementation depended on base::WeakPtr, that did not provide noexcept declaration for them. So make base::WeakPtr noexcept. Bug: 819294 Change-Id: I936784b881c7c1afea136ceedbe9341e76464f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708141Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#680341}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e29b1cf3. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" 6a6b173b "Add type option to showToast helper" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ifd05031ccd172eeb1eb6a6a2f9fcf075017194d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715919Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680340}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d15571af2e1b..0f9c660aa939 git log d15571af2e1b..0f9c660aa939 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@0f9c660aa939 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: None Change-Id: I68f62db4898c93e3066991d7a89ccf87eeee3f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716403Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680339}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: Idfe097d692ac6a347f364d48d3a1d99769d161af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715365Reviewed-by:
-
Ren-Pei Zeng authored
Instead of using Ozone platform to create NativePixmap, this CL makes it create NativePixmapDmaBuf directly which doesn't rely on Ozone. Bug: b:120057531 Test: video_decode_accelerator_tests Test: media_unittests --gtest_filter=PlatformVideoFrameUtils* Change-Id: I85ecfa4ca550c4f80f6f6f08b0c71ceeee5dbde1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688834 Commit-Queue: Ren-Pei Zeng <kamesan@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This is for strange error in https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux/24185 Change-Id: Ief72e01492d5f2567985cb66857763bc955cd4ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714947 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#680336}
-
Jeevan Shikaram authored
This is a reland of d44f4549 Original change's description: > Revert "[App Management] Enable App Management by default." > > This reverts commit 2fd01309. > > Reason for revert: Disabling App Management before branch point. > > Original change's description: > > [App Management] Enable App Management by default. > > > > Enable App Management by default. Current entry points are about:settings > > and about:app-management. > > > > Bug: 906508 > > Change-Id: I0118a4b51eda6e65bc72186e771fc2ede2acb45f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610658 > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#659341} > > TBR=dominickn@chromium.org,jshikaram@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 906508 > Change-Id: I302364e6573eaf21b7a0a3a93ecf517fc473740a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636652 > Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> > Commit-Queue: Dominick Ng <dominickn@chromium.org> > Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664595} TBR=dominickn@chromium.org Bug: 906508 Change-Id: Iae08c2de1231360e6882b74aeee5d02f4a7fae2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716045Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#680335}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ac7c4af504d5..532f86826d5c Created with: gclient setdep -r src-internal@532f86826d5c The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com Bug: chromium:None Change-Id: Idef56a831c3002ee14fa8f866bb5e5f42f536f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716402Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680334}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I04ec1ffa64070b9a76fa5c9d9dc82a59ab4cf014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714810Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#680333}
-
Yoichi Osato authored
This relands the test: crrev.com/c/1692423 Originally the test was reverted because of slowness on the msan bot: crbug.com/985791 This makes the test faster by using window.crypto.subtle.digest instead of stringify array buffers. Bug: 985791 Change-Id: Ia9cba0de376c26d202e81fb7c8fd53b51def2370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709178Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#680332}
-
tby authored
Since we have more than one Dolphin model running, it would be useful to be able to separate out our metrics per-model. This CL adds parameterised histograms to do that. At the same time, it increases the number of things we report metrics about. In particular, we now keep counts of how often each function of the RecurrenceRanker is used. Bug: 921444 Change-Id: I100830883158c071bbf299efc204425b802f0f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713149 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#680331}
-
Hiroki Nakagawa authored
The test sometimes times out on linux and win bots. Bug: 987138 Change-Id: I0f23623626b12ecc58696b87095646b0a058c418 Tbr: nhiroki@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715415Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#680330}
-
Rachel Wong authored
Bug: 985205 Change-Id: I60a5fc905958be1a3f2f56e92ec2be4767e28d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715920Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#680329}
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/fd97d43..682a230 Size increase: android_small & ios 5K chromeos 43.3K common 15K Bug: v8:9475 Change-Id: I78c863dfd3dde589e5bdd08968c1b499ad6225bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715115 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#680328}
-
Joel Hockey authored
Bug: 968060 Change-Id: I7f6e8b3cf4bd278316e4b2e21af250fcf65ef984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715185 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#680327}
-
Hiroki Nakagawa authored
This test is flaky not only on win and linux but also on mac. Bug: 986282 Change-Id: I5bb49f1e45c984261024d00cdce55825de8fbbd1 Tbr: nhiroki@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715776Reviewed-by:
-
Fergus Dall authored
Due to a bug in the original implementation of the metrics, Crostini.TimeToInstallCancel and Crostini.AvailableDiskCancel were not collected in most cancellations and could sometimes be collected in the wrong state. Bug: 953545 Change-Id: I9c23abdb61b2b3b8d33dec802f89035ed59d9db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714724 Auto-Submit: Fergus Dall <sidereal@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#680325}
-
Wei Lee authored
This CL supports forwarding Android camera intents from ARC++ intent helper to CCA and is able to return the captured result back to the ARC++ intent helper. Bug: b/131809655, b/134635999, 980812, 967611 Test: am start -a android.media.action.IMAGE_CAPTURE Test: am start -a android.media.action.VIDEO_CAPTURE Test: Run CtsVerifier -> Camera Intents Test: Run Hangout -> Capture photo/VIDEO_CAPTURE Test: ./cts-tradefed run commandAndExit cts -m CtsCameraTestCases Test: (Simulate camera v1 stack on Nocturne) (dut) $ mv /usr/bin/cros_camera_service /usr/bin/cros_camera_service_old (dut) $ (Tested with external camera) Change-Id: I738483dfdf63c56bb0947bb1ff201fba9be02bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592991 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:Ricky Liang <jcliang@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#680324}
-
Hiroki Nakagawa authored
Bug: 987132 Change-Id: I846c70ee0dd07af1ffc9f53f475bed061db6f1e7 Notry: true Tbr: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715169Reviewed-by:
-
Will Harris authored
This test verifies the behavior when CIG is enabled but the signed interception is not in place, for both the case where process startup fails because imports fail to load, and also when a manual dll load fails. BUG=750886 Change-Id: I88575515b566b9edb4f4c4a1ba8fcf91fceb730c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715240 Auto-Submit: Will Harris <wfh@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#680322}
-
Paul Dyson authored
1. Move the AppLaunchEventLogger member variable from AppListClientImpl to SearchResultRanker. 2. Move the app_launcher_event_logger* files from chrome/browser/ui/app_list to chrome/browser/ui/app_list/search/search_result_ranker. Bug: 899123 Change-Id: I329d69b00facd3321335ba1cfbc2b86296339aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705459 Commit-Queue: Paul Dyson <pdyson@chromium.org> Reviewed-by:
-
Adrienne Walker authored
This will help diagnose high rates of webview read failures. Bug: 977231 Change-Id: I2fd23593e62291c71c01583e3db6cd8a2ee5e8d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707983Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#680320}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I208065ee12e450c785e9c0c4b45b1a7d51d23b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716399Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/83166a2bdb79..ac7c4af504d5 Created with: gclient setdep -r src-internal@ac7c4af504d5 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com Bug: chromium:None Change-Id: I2cddfe6b41ae83ae0ae7e46b4702dc7fc2f01f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716395Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2de8692b. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" 6a6b173b "Add type option to showToast helper" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I567e1fa9c2f1c9f951e7fa800948a94e4fb63162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716212Reviewed-by:
-
Kristi Park authored
This is a remnant from when the tile icon images were generated with a (dark) gray background, depending on the system theme. Now that the tile background controlled via CSS, it's no longer required to reload the tiles when the background image is changed in dark mode. Bug: 986935 Change-Id: Iccd076f354a838e9025856151e1e486824ed4c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716100Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#680316}
-
David Bokan authored
This reverts commit 5dd16566. Reason for revert: This CL was confirmed to be the cause of the perf regression in crbug.com/978980 - this is artificial so we can reland Original change's description: > Revert "Do not coalesce wheel with phaseBegan to wheel with phaseEnded." > > This reverts commit 2ca01526. > > Reason for revert: Speculative revert for https://crbug.com/978980 > > Original change's description: > > Do not coalesce wheel with phaseBegan to wheel with phaseEnded. > > > > If no element in the scrolling chain is not scrollable in the given direction > > (delta_hints) on GSB we latch to the viewport. This is not user friendly on > > platforms that do not have any scroll affordance animations (e.g. Windows) > > since if the user changes the scrolling direction and an element in the chain > > is actually scrollable in the new direction, the user expects it to scroll and > > has no idea that we have latched to the (possibly unscrollable) viewport for > > the rest of the scroll sequence. To address the issue for timer based wheel > > scroll sequence we end the sequence and start a new one upon arrival of a wheel > > event with different delta directions if no GSU has been consumed since the > > beginning of the sequence. This cl ensures that the GSE/GSB generated for > > breaking the latching seqeunce are not coalesced with each other. > > > > Bug: 882998 > > Change-Id: Icf703c935475fffd69b899c59abc03ec1b548784 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524703 > > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > > Commit-Queue: Sahel Sharify <sahel@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#641719} > > TBR=nzolghadr@chromium.org,sahel@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 882998,978980 > Change-Id: I85799b6e6eace029b4c2ef00e142f035ac9e8e4c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688230 > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#674615} TBR=bokan@chromium.org,nzolghadr@chromium.org,sahel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 882998, 978980 Change-Id: I3dfb3f3ec0467b7101597720325222899e46f10b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716444Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#680315}
-
Takuto Ikuta authored
Test from this builder consumes around the following machine hour * p99 CI: 38.27611111111111 * p90 CI: 34.07888888888889 * p50 CI: 32.31194444444444 * p99 CQ: 36.07277777777778 * p90 CQ: 35.85166666666667 * p50 CQ: 28.64027777777778 in chrome pool in recent 30 days. I took the stats from http://shortn/_vS3Df0uFD0 Bug: 954450 Change-Id: I050e133192423c1bb734e612c9a8be2417259a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712704Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#680314}
-
Nick Diego Yamane authored
At the moment, //ui/events/platform/x11 has a single dependency on //ui/base/x, which is ui::XScopedEventSelector, that actually is a X11 event-related component. This CL moves XScopedEventSelector source files into //ui/events/x, thus getting rid of aforementioned dependency, which prevent //ui/base/x components to depend on X11EventSource* classes (which lives on //ui/events/platform/x11), for instance, which has been becoming more and more common in the aura/x11 -> ozone/x11 migration, where core X11 classes are made reusable and placed in ui/base/x to be shared between ozone and non-ozone X11, e.g: crrev.com/c/1695008. Bug: 789065 Test: None (no functional change) Change-Id: I94aba04b420f6d718c41abcc93ceafaf13963173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712955Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#680313}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I2d7f8bfa090f643a494d2d9965634e638fc29bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716325Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#680312}
-
Alexander Alekseev authored
Bug: 975758 Change-Id: I5262bccc4000f2f0ff2c6ac7ab71abc980395ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713242Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#680311}
-
Gyuyoung Kim authored
NavigatorContentUtils has been installed by ModulesInitialized::InstallSupplements while a frame is created. But, it's also possible to install NavigatorContentUtils when it's real functions are called like other Supplements. The lazy installation is a typical use case of Supplement as well as it helps to occupy less memory if not used. Bug: 987080 Change-Id: If22d7c992b987e59dd326546663bb4c5a16d7959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715167Reviewed-by:
-
Ryan Hansberry authored
Make UnlockManagerImplTest more closely follow how UnlockManagerImpl actually behaves in production by making UnlockManagerImpl directly listen on RemoteDeviceLifeCycle::Observer events, and make FakeRemoteDeviceLifeCycle::Start() notify observers. This all allows the test RemoteDeviceLifeCycle object to notify UnlockManager as soon as its state changes, instead of having to manually emulate state change events. This CL unblocks testing for the bug fix (crbug.com/890047) in the subsequent CL. As it turns out, this refactor actually exposes that bug -- had this test code been structured this way before, the bug could have been fixed long ago. TODOs have been left in the test code marking accommodations made for the bug -- they will be removed in the subsequent CL. Bug: 926608, 890047 Change-Id: Iee96974d9376bda1f75deba314f28efccae7052c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716154 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#680309}
-
Alexander Alekseev authored
Bug: 984272 Change-Id: I5af611329444f07328313b2eb401dbc31522cbbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714044Reviewed-by:
-
Andrew Grieve authored
Was reverted in: 54f75614. Reason for reland: Includes fix for downstream targets. Change-Id: I2a5f77cdbd40934ae206dd91b2e12e7b5e6553e1 Bug: 986693, 986693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715004Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#680307}
-
