GitLab

Test verifies that only one tile is present.

Bug: 741329
Change-Id: I30bb1d7f1f0a5af13ccb2d364d97fe3d67ae6d88
Reviewed-on: https://chromium-review.googlesource.com/568025
Commit-Queue: Mike Baxley <baxley@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485954}

TBR=yzshen@chromium.org
NOTRY=true

Change-Id: I05de50a37e9b258d80c9927d9d3ab893afe105a3
Reviewed-on: https://chromium-review.googlesource.com/566897Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485953}

This is now dead code.

Bug: 738644
Change-Id: I4f199067216fa09d94d1ba59d954f2f120d57f78
Reviewed-on: https://chromium-review.googlesource.com/567705Reviewed-by: Ali Juma <ajuma@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485952}

EarlGrey tests are run differently than other iOS targets, so this
should be document.

Bug: 
Change-Id: I112108008a85f810b7e96fb0241b1c8277ec9ea9
Reviewed-on: https://chromium-review.googlesource.com/567918Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485951}

Revert of customtabs: Remove unnecessary Context plumbing. (patchset #5 id:80001 of https://codereview.chromium.org/2966193002/ )

Reason for revert:
Causing compilation errors in ChromeCustomTabsConnection.java.

BUG=741667

Original issue's description:
> customtabs: Remove unnecessary Context plumbing.
>
> Also removes Context -> Application downcasts in callers.
>
> Review-Url: https://codereview.chromium.org/2966193002
> Cr-Commit-Position: refs/heads/master@{#485909}
> Committed: https://chromium.googlesource.com/chromium/src/+/a0d1c1531de988606c0425de933722358985374b

TBR=yusufo@chromium.org,yfriedman@chromium.org,lizeb@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2976023002
Cr-Commit-Position: refs/heads/master@{#485950}

Change-Id: I451ee4818035688e5d3d880e0955b0d9ed716269
Reviewed-on: https://chromium-review.googlesource.com/568037Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485949}

Bug: 
Change-Id: I9e206d26a2c11fbf5193170108c8f4354d32fb4e
Reviewed-on: https://chromium-review.googlesource.com/567500Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485948}

Use renderer scheduler policy to throttle background timer queues
when the renderer is backgrounded.

R=alexclarke@chromium.org

Change-Id: Iff6f4b80883f1030b14e9f67345a7df9dd018a63
Reviewed-on: https://chromium-review.googlesource.com/567932Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485947}

- Adding persistence via the keychain to remember secrets.
- Hide the checkbox based on host reported capabilities.

Change-Id: Ibf18726fd97636bd880395d44d6dc92a54ff1b69
Reviewed-on: https://chromium-review.googlesource.com/565660Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Scott Nichols <nicholss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485946}

The named thread API is deprecated in favor of the post_task.h API.

Bug: 689520
Change-Id: I8068157d94c0d3dd2fb385dcf74d4fc28444e64d
Reviewed-on: https://chromium-review.googlesource.com/548558
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485945}

Within browser/speech code, use BindOnce when posting tasks to
check whether speech recognition is allowed.

Bug: 714018
Change-Id: Ifa4eb2797601be2736dda1bf1a17ac57e5a34301
Reviewed-on: https://chromium-review.googlesource.com/565762
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485944}

Bug: none
Change-Id: I5659106f3c8bd6608f4f6f410e3815fa1bed8c71
Reviewed-on: https://chromium-review.googlesource.com/567899Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485943}

non VR content includes:
1. 2D Dialog for external navigation request while in incognito mode
2. external 2D app


Bug: 739778, 740742
Change-Id: Idd1de302a1412a1815b6d64fc7db5ac6b8a458ed
Reviewed-on: https://chromium-review.googlesource.com/563883Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485942}

The image is shipped as part of the compiled assets catalog and
need to be loaded using -imageNamed: instead of by a path.

Bug: 738359
Change-Id: Ife467b503a298e3c1811c2ab76a860f780b482ed
Reviewed-on: https://chromium-review.googlesource.com/568032
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485941}

This reverts commit 4721652f.

Reason for revert: https://crbug.com/689762#c12

Original change's description:
> Change NetworkSessionConfigurator to process multiple versions from quic_version field
> 
> Bug: 689762
> Change-Id: Ic0de2dacd01158d85318794d05f8f763659d9228
> Reviewed-on: https://chromium-review.googlesource.com/565784
> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
> Reviewed-by: Ryan Hamilton <rch@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485678}

TBR=rch@chromium.org,zhongyi@chromium.org

Change-Id: If18efa529febe19aa543eb2b6947434daeed7374
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 689762
Reviewed-on: https://chromium-review.googlesource.com/567283Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485940}

There are multiple Cache types and Response types so when importing
one of them into the global namespace you can easily get naming conflicts, especially with jumbo. This renames Cache and Protocol
locally to avoid such naming conflicts.

Review-Url: https://codereview.chromium.org/2968183002
Cr-Commit-Position: refs/heads/master@{#485939}

This test is flaky (sometimes crashes) on "Mac10.10 Tests".

TBR=tapted@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Bug: 741642
Change-Id: I53925b699979d967d3e3aa1df73436dfefdcbd57
Reviewed-on: https://chromium-review.googlesource.com/568100
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485938}

Merges server changes 161010731, 161020298 by birenroy.

Bug: 488484
Change-Id: I81e4cb367e2f2b5627b9d68355ef5a4ac1b1a9e0
Reviewed-on: https://chromium-review.googlesource.com/567386
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485937}

BUG=728322

Review-Url: https://codereview.chromium.org/2967063002
Cr-Commit-Position: refs/heads/master@{#485936}

Implements lazy serialization in the C++ bindings. This means a few
things:

- Every bindings endpoint monitors the remoteness of its peer endpoint
- Bindings endpoints prefer serialized messages only when their peer
  appears to be remote
- Generated C++ bindings will use an unserialized message context to
  capture and carry message parameters when sending on an endpoint that
  does not prefer serialized messages
- Unserialized message contexts will serialize a bindings message if
  coerced to do so, either by an explicit call to
  Message::SerializeIfNecessary or by Mojo internals when the message
  needs to be routed out-of-process

Because support for lazy serialization incurs a significant code
size cost, individual mojom GN targets must opt into support by
setting |support_lazy_serialization| to true. This is turned on for
ipc_perftests test interfaces as well as
mojo_public_bindings_unittests test interfaces, and is used to
ensure sufficient test coverage for all message construction and
dispatching code paths.

BUG=725321
TBR=yhirano@chromium.orf

Change-Id: I85197b74a87bcf9fc9ff14b4c787c7eabc897829
Reviewed-on: https://chromium-review.googlesource.com/562180
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485935}

This could avoid a potential crash.

Bug: 741054
Change-Id: I7f606d0edc3741b05b73f678f7a2e28c343852f4
Reviewed-on: https://chromium-review.googlesource.com/567463Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485934}

Prefetching allows the collection view to get cells configured by the
item before it is visible. The item will not reconfigure the cell for
this display.
If the CollectionViewController tries to reconfigure the items
associated with this cell in the moment between the prefetching and
the time the cell is visible, the reconfigure will do nothing.

In ContentSuggestions this problem was encounter for the display of
the articles' images.

Bug: 740572
Change-Id: I99c1bd2a95159d22512494961b3fb1ad935ad998
Reviewed-on: https://chromium-review.googlesource.com/567924Reviewed-by: Elodie Banel <lod@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485933}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6c835897..c9a1f8e8

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: If8b8c9f4446feecba97e43fa9f1c5c7078ea448a
Reviewed-on: https://chromium-review.googlesource.com/567635Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485932}

Change-Id: I4f926faa964b9eded1ec4ea9a19058c30de05de0
Reviewed-on: https://chromium-review.googlesource.com/564303
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485931}

This reverts commit 164f881f.

Reason for revert: https://build.chromium.org/p/chromium/builders/Android/builds/74079

Original change's description:
> 📺 Use video aspect ratio to determine PiP params.
> 
> Use the bounds of the fullscreen video to determine the starting
> bounds for the PiP transformation and the aspect ratio of the PiP
> window.
> 
> Change-Id: Ia2227c9d277b5ae2a1dedddb899082e2947137fe
> Reviewed-on: https://chromium-review.googlesource.com/536974
> Commit-Queue: Peter Conn <peconn@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485916}

TBR=bauerb@chromium.org,mlamouri@chromium.org,peconn@chromium.org,jochen@chromium.org

Change-Id: I972cec53d7937ec9c210832677ff79cc80bef2fe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/567273Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485930}

This reverts commit 164f881f.

Reason for revert: Caused a failure https://build.chromium.org/p/chromium/builders/Android/builds/74079

Original change's description:
> 📺 Use video aspect ratio to determine PiP params.
> 
> Use the bounds of the fullscreen video to determine the starting
> bounds for the PiP transformation and the aspect ratio of the PiP
> window.
> 
> Change-Id: Ia2227c9d277b5ae2a1dedddb899082e2947137fe
> Reviewed-on: https://chromium-review.googlesource.com/536974
> Commit-Queue: Peter Conn <peconn@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485916}

TBR=bauerb@chromium.org,mlamouri@chromium.org,peconn@chromium.org,jochen@chromium.org

Change-Id: I91b3e716c02bd5c41cf93d3fde04e0874d26d3e6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/566865Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485929}

This reverts commit 54275e80.

Reason for revert: breaks ios_showcase_egtests downstream. Failure details: https://paste.googleplex.com/6470224534568960 - fails on all simulator bots.

Original change's description:
> [ios showcase] Removes ios/web dependency.
> 
> Showcase is intended to be a standalone UI app and as such should not reference 
> //ios/web or //ios/chrome. This CL eliminates the Showcase app creating an IOSChromeMain 
> instance and thus implicitly being an //ios/web embedder, instead directly inlining the 
> minimal parts of that startup that are needed (initializing base::CommandLine and loading resources).
>  
> As part of that change, this CL eliminates Showcase bundling //ios/web resources.
> 
> Bug: 738880
> Change-Id: I0a3d3494838cc588034feb48443d24ddf1bec03a
> Reviewed-on: https://chromium-review.googlesource.com/565453
> Commit-Queue: Sergio Collazos <sczs@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Reviewed-by: Louis Romero <lpromero@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485815}

TBR=blundell@chromium.org,lpromero@chromium.org,sczs@chromium.org

Change-Id: I8f2daeb1adeabe4622e312b5bc1d70a5591bd68e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 738880
Reviewed-on: https://chromium-review.googlesource.com/566864Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485928}

Following bot results are included.
723 724 728

884 lines were removed by consecutive passes since 643 (Jul 6),
excluding the bot troubles yesterday (701-711). This should undo all
additions during the bot troubles.

TBR=eae@chromium.org
NOTRY=true

BUG: 591099
Change-Id: I5c62411bf0a3b32a5c1c95fc94c2d0c5dd3a6d10
Reviewed-on: https://chromium-review.googlesource.com/567939
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485927}

Bug: none
Change-Id: Iba0bacce5bd0baf9079bab9a8ce0e2bb4f884fca
Reviewed-on: https://chromium-review.googlesource.com/565405Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485926}

Bug: 532989
Change-Id: I2295d05c59e24f8ae36d763a38c65188b2495675
Reviewed-on: https://chromium-review.googlesource.com/559047
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485925}

Bug:657041

Change-Id: Idafd23621f458dfd73757899bca952f470f31767
Reviewed-on: https://chromium-review.googlesource.com/563299
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485924}

Bug: 728199
Change-Id: I386530410dcafa76cfe2be91744e6d82a5ea232e
Reviewed-on: https://chromium-review.googlesource.com/552639
Commit-Queue: Hector Dearman <hjd@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485923}

TabSockets are intended to either be installed into the main world or
a isolated world created by Page.createIsolatedWorld.  Previously we
only supported a single TabSocket per WebContents but that's unfortunate
with OOPIF.  This patch lets us support multiple TabSockets up to one
per world per frame.

The mojoms have changed a bit with
TabSocket::AwaitNextMessageFromEmbedder moving to 
HeadlessRenderFrameController::SendMessageToTabSocket which simplifies
recieveing a message from the embedder since a hanging IPC is no
longer needed.

Original patch: https://chromium-review.googlesource.com/c/543160/

Bug: 546953
Change-Id: Iab134b78d3cbfcbdb00ada15a6ae6d3b253727a8
TBR: jochen@chromium.org, mkwst@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/565404Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485922}

This makes stamping folder trees with closed folders significantly
faster, without making any noticeable impact on fully-open trees.

Bug: 727177
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I087898598b265a396aeb6e178487ee8a5ece8d5a
Reviewed-on: https://chromium-review.googlesource.com/566205Reviewed-by: Christopher Lam <calamity@chromium.org>
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485921}

This is preparation to split LayoutSelection start/end calculation w/o 
canonicalization.
This CL also fixes issue that Selection API consider editable boundary incorrectly

Bug: 739062
Change-Id: I84623287faebcb3bc5c497abf1d9560a54f5d751
Reviewed-on: https://chromium-review.googlesource.com/566208Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485920}

It used to be used for file URLs and TransportSecurityStatePersister as
well, but this CL moves those over to using the task scheduler. Can't
just always use that for the cache as well due to the cache needing a
SingleThreadTaskRunner, and getting one of those from the task scheduler
is a bit more resource intensive.

BUG=734199
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2977693003
Cr-Commit-Position: refs/heads/master@{#485919}

A plain "NoDevicesError" with no further explanation was confusing to
developrts when there were devices but all failed with some errors.

Bug: 732724
Change-Id: Ib4d2bff47ca85da3212e28394f6d41742df7cf53
Reviewed-on: https://chromium-review.googlesource.com/558072Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485918}

There have been some reports of these features not working together. This 
test tries to ensure that they do work.

Bug: 732154
Change-Id: Ieccd55603d35a92342a868fc7753f3af98a4aed7
Reviewed-on: https://chromium-review.googlesource.com/567505
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485917}

Use the bounds of the fullscreen video to determine the starting
bounds for the PiP transformation and the aspect ratio of the PiP
window.

Change-Id: Ia2227c9d277b5ae2a1dedddb899082e2947137fe
Reviewed-on: https://chromium-review.googlesource.com/536974
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485916}

This patch changes |TypingCommand::DeleteKeyPressed()| to utilize early-return
style and const-variable with splitting function for improving readability.

Change-Id: I8f153fdefca3d1f6575a127d31c24746fd7b3724
Reviewed-on: https://chromium-review.googlesource.com/566743Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485915}