- 28 Feb, 2020 40 commits
-
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for settings people page strings from settings_strings.grdp to os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: I1129aa982124596f102d1586f2a183ab894d9b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070411 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#745615}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/817bf7ab..c6bde393 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I732188bb10eda8691a953f7dfcb3ae9f37a6b614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079638Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745614}
-
Abigail Klein authored
Introduce the caption bubble inside of chrome/browser/accessibility and instantiate it from browser_view behind the kLiveCaption flag. Bug: 1055150 Change-Id: I316a52f22b7bf50627bf481192fb15006fc2efb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068727Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#745613}
-
Thomas Guilbert authored
This CL decreases the resolution of the presentationTime, expectedPresentationTime, elapsedProcessingTime and captureTime fields, to limit potential timing attacks. expectedPresentationTime should correspond to an animation frame timestamp and technically shouldn't need be clamped. However, this is not always the case in the WebRTC path, and we should keep it clamped for now. Bug: 1012063 Change-Id: Ie9247be8f3c91e2fef3d62cf939b1d8488f0a75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071113Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#745612}
-
Daniel Clark authored
This change removes support for the following hotkeys in date/week/month/datetime-local popups: m/M: Advance to next/previous month y/Y: Advance to next/previous year d/D: Advance to next/previous decade t: Select the current day The refreshed control implementation inherited these from the old implementation, but their value is questionable. PageDown/PageUp is a more intuitive version of m/M for changing month. Selecting the current day by keyboard can be achieved by tabbing to the 'Today' button and pressing Enter. This is more keystrokes but this should be ok because it is not an action that the user would need to perform more than once once per popup. There is no equivalent to y/Y or d/D for advancing by year/decade, but these do not seem like common scenarios. If they were, we would want to provide a more visible mechanism for achieving this. All of these hotkeys are non-discoverable aside from trial and error. As such they may be as likely to cause user confusion when stumbled across accidentally as they are to help. Given the above considerations, this change removes them. Bug: 1052388 Change-Id: I2602250352df6569100df1ba512cd624c9bd2f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079219Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#745611}
-
Nicolás Peña Moreno authored
This CL adds TBT to TTI's trace event by keeping track of the longtasks and using the list to compute TBT as soon as TTI is known. The computation is done inside the trace event to avoid running the code when tracing is disabled. An args param is added because there are no macros supporting more than 2 args, so two of them are merged into a single TracedValue param. Bug: 1055806 Change-Id: Ided9c2378aff6d98cbdf5e88e99d46735b92e284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079616Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Deep Roy <dproy@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#745610}
-
Chris Mumford authored
This reverts commit dfd901d6. Reason for revert: TabsSnapshotTest.Test is > 50% flakey. See https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/8642 Original change's description: > User data downgrade: Test snapshot tabs state > > Bug: 958893 > Change-Id: If0cc3e0cd1e70a3b21c675b3979166f7aaba554d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076438 > Commit-Queue: Yann Dago <ydago@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745474} TBR=grt@chromium.org,ydago@chromium.org Change-Id: Idab515fc68a966222463a74341f46929464d97c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080811Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#745609}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1e247059f49b..4f489240742b git log 1e247059f49b..4f489240742b --date=short --first-parent --format='%ad %ae %s' 2020-02-28 ehmaldonado@google.com roll-dep: Make it possible to run using Python 3. Created with: gclient setdep -r src/third_party/depot_tools@4f489240742b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:984182 Tbr: agable@chromium.org Change-Id: I843d6db93245b1c21bbbab8945100389509c5886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080486Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745608}
-
Huanzhong Huang authored
Bug: 1055860 Change-Id: Iff0c883b02c9edf7c553db97ecf33692eed8ca24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074697 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#745607}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: If3c110beb82115714fff4b2d859c765a3e94460a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080191 Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#745606}
-
Wan-Teh Chang authored
Change-Id: Ica03485ea531c5cc31c4e7a1ee75eed5fa2a9d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079845Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#745605}
-
Ayu Ishii authored
This change extends expiration for WebOTP API histograms to M85. We are planning on launching WebOTP in M82. We would like to continue tracking these histograms to observe the performance of the API during this launch. Bug: 1052930, 1052929 Change-Id: I85ad770e412921fd034eee110529ee0fe91c1940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068247Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#745604}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/cabed431f8c8..4f3c4fcb1f26 git log cabed431f8c8..4f3c4fcb1f26 --date=short --first-parent --format='%ad %ae %s' 2020-02-28 titovartem@google.com Temporary debug logging for SingleProcessEncodedImageDataInjector 2020-02-28 srte@webrtc.org Thread affinity fix for scenario test SetMuted. Created with: gclient setdep -r src/third_party/webrtc@4f3c4fcb1f26 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I21d3a6721e82a728a4733d3e32257405633d53aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080580Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745603}
-
Dale Curtis authored
We're noticing that running the video.rAF as part of the rendering steps isn't always performant since the BeginFrame powering window.rAF is run much later than the one powering video rendering - resulting in frequent misses. While trying to diagnose this issue and whether we should switch to using a microtask we're running into issues where dev builds are not as performant as official builds, so to ease testing and analysis land a temporary microtask version of video.rAF behind a flag so we can compare using Mac/Win canary builds more effectively. Bug: 1012063 Change-Id: Ie0609717d1863800550e858efbe144c8c0dde624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076180 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#745602}
-
Kyle Milka authored
These got lost while rebasing the last few CLs. Bug: 1009124 Change-Id: I85daee52a6506d1b21d1e9c276ca5dd2de4a0443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080468Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#745601}
-
Anastasia Helfinstein authored
This is the first step in incorporating Sophie and Rose's code from last summer into the new navigation paradigm. Bug: 982004 Change-Id: I247fa82ec58560505c64f92993108ec7b5687d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076000Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#745600}
-
Yi Xu authored
This reverts commit 5854b63f. Reason for revert: failed to build on bot linux-chromeos-rel details: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/35381? Original change's description: > Add unit tests for drag handle nudge. > > Other changes: > > Add test methods to drag_handle class > Modified shelf_widget GetDragHandle() to return DragHandle* instead of View* > Modified DragHandle::ShowDragHandleNudge() to fetch timeout for current pref instead of taking it as an argument. > Fixed bug where ShowDraghandleNudge did not call handleNudgeShown. > > Bug: 1034168 > Change-Id: Ifde73e31b1e35b630ab61b7ab43d49c9796dce20 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076015 > Auto-Submit: Yulun Wu <yulunwu@chromium.org> > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Commit-Queue: Yulun Wu <yulunwu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745583} TBR=tbarzic@chromium.org,manucornet@chromium.org,yulunwu@chromium.org Change-Id: Iee2da855a7f8ca0c0cba9689a4319607edbdd108 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1034168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079204Reviewed-by:
Yi Xu <yiyix@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#745599}
-
Esmael El-Moslimany authored
Bug: 1056063 Change-Id: I513d5d1d4b0629aef7bbe85cf48dbb10e43bccc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076533 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#745598}
-
Michael Lippautz authored
Adds a target for the library and test targets. - Integrate into compontents_unittests as all other components do as well. This ensures that unittests are automatically run on CI. - Provide a separate gc_unittests binary as the components binary requires ~35k files to build. Bug: 1056170 Change-Id: I8fa235c239f2dc5217145c12abb8c1f27af84fc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080422 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#745597}
-
John Abd-El-Malek authored
Change-Id: Ibd9edc2f826f3a6a0cd4014fccf9308fd3791285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080076 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#745596}
-
Christopher Cameron authored
Set kCFBundleNameKey to be the app title. Leave the behavior of legacy apps (not PWAs) unchanged. Bug: 1021804 Change-Id: I0c4dbfc01cead79c3fad8b1bc7a9ddd1147c9bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080471Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#745595}
-
Robert Sesek authored
Bug: 710376 Change-Id: I40fe4b1aa37d9c1f334ade3b474135d7a7f9ccf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078653Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#745594}
-
Toni Barzic authored
Change-Id: Ib4559631453e2eec14345b9c9273d770b2eefb9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077118Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#745593}
-
John Budorick authored
Bug: 1056878 Change-Id: I82ee6e3b9990495c5a82abd0472bbbd0f7e2e032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080435 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#745592}
-
Etienne Bergeron authored
The gfx GetFontFallback(...) using Skia is using the same API under the hood than font_fallback_mac.mm. see: https://cs.chromium.org/chromium/src/third_party/skia/src/ports/SkFontHost_mac.cpp?l=3043 This CL is doing the migration to use GetSkiaFallbackTypeface(..) like other platforms to have an more uniform results. Skia Implementation also supported other corner cases like decomposition. see: ui/gfx/font_fallback_skia_impl.cc Bug: 1026735 Change-Id: If26ce32a0a826fea688dbbf25977ffb7590e31df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075222Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#745591}
-
Reilly Grant authored
This reverts commit b2543971. Reason for revert: The underlying cause of crbug/1055216 has been fixed. Original change's description: > Revert "[WebNFC] Enable feature flag by default for Origin Trial" > > This reverts commit 22b25dd3. > > Reason for revert: NFC settings crash on Android L and M. (crbug/1055216) > > Original change's description: > > [WebNFC] Enable feature flag by default for Origin Trial > > > > For the WebNFC Origin Trial the feature flag needs to be enabled by > > default and configured as "disable only" in runtime_features.cc so that > > it can still be used as a kill switch but will not enable the feature > > on sites which don't have a valid Origin Trial token. > > > > Bug: 1035048 > > Change-Id: I139a79dd0f93013bc59d5023017b49c820532fb1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052198 > > Commit-Queue: Reilly Grant <reillyg@chromium.org> > > Reviewed-by: Charlie Reis <creis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#743309} > > TBR=creis@chromium.org,reillyg@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1035048, 1055216 > Change-Id: I6617ee1b2bc6b3d1fb719d0454d4f8f4735bd44c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070106 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743984} TBR=creis@chromium.org,reillyg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1035048, 1055216 Change-Id: Ifc09be93e634ce418e21d2b8482eb38a07b2e8cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079159Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#745590}
-
Cathy Li authored
This is a reland of 21245a70 Original change's description: > [xsurface]: Update SurfaceAdapter to SurfaceRenderer and spec > > Change-Id: Ib77234174ece4facb35596808fd964a18db04311 > Bug: 1054944 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048409 > Commit-Queue: Cathy Li <chili@chromium.org> > Reviewed-by: Justin DeWitt <dewittj@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744352} Bug: 1054944 Change-Id: Ifc70eedc0dd645d6f1ae834a05c3989c1c67dfa3 TBR: twellington@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079850 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#745589}
-
Matt Wolenetz authored
AttachToElement() name was unclear: while it technically attaches the MediaSource to the Element, the underlying MediaSource cannot be used for appending media, etc. by the app until it is opened with a call to SetWebMediaSourceAndOpen(). This change renames these two methods, respectively, to {Start,Complete}AttachingToMediaElement(), along with some comment updates. Actual function remains unchanged. This clarification CL is expected to improve readability and review, especially of the in-progress MSE-in-Workers CLs. BUG=878133 Change-Id: Ic726cbee71d92e82a5a8c7d3be7d8d9185d1fb76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079384Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#745588}
-
Mikhail Khokhlov authored
This CL adds JankyScrollPeriods metric from Chrometto dashboard to be computed on the waterfall. We want to compare results of this metric and ScrollJankMetric on lab devices and delete one of them afterwards. Bug: b/150125501 Change-Id: Ifec9f2f41b9f579a94ada95d35459f00b3f17cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080414Reviewed-by:
Deep Roy <dproy@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#745587}
-
Robert Sesek authored
In the process, convert the buffer_types.mojom to handle<platform>. This also adds a legacy IPC::ParamTraits<ScopedHandle> to support sending GpuMemoryBufferHandle over legacy IPC. Tbr: flackr@chromium.org Bug: 863011, 710376 Change-Id: I087d9d83edc729b512dbb79806a0b4b2db2b31bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064609 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#745586}
-
Zhongyi Shi authored
Every time a quic merge with API changes will introduce changes to quic transport files. This is to decrease the review latency of a regular quiche merge. No-Try: True Change-Id: I02fbc4eb79798236e18d4795132195d4b521c3c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079896Reviewed-by:
Steve Anton <steveanton@chromium.org> Commit-Queue: Steve Anton <steveanton@chromium.org> Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#745585}
-
Khushal authored
This reverts commit 99965b74. Reason for revert: Fix for the test landed. Original change's description: > Disable the load:games:spychase:2018 story on webview due to flakes > > TBR=crouleau@chromium.org > NOTRY=true > > Bug: 1046101 > Change-Id: Ifb27532f7096ab1461a552b87a20e1f9379ddb10 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023987 > Reviewed-by: oysteine <oysteine@chromium.org> > Commit-Queue: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735574} TBR=oysteine@chromium.org,crouleau@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1046101 Change-Id: I2816333bcae2a57fd7e07ac6af2d7b9d277c2949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080440Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#745584}
-
Yulun Wu authored
Other changes: Add test methods to drag_handle class Modified shelf_widget GetDragHandle() to return DragHandle* instead of View* Modified DragHandle::ShowDragHandleNudge() to fetch timeout for current pref instead of taking it as an argument. Fixed bug where ShowDraghandleNudge did not call handleNudgeShown. Bug: 1034168 Change-Id: Ifde73e31b1e35b630ab61b7ab43d49c9796dce20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076015 Auto-Submit: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#745583}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=mark@chromium.org Bug: 1026641 Change-Id: I32abc8694280a33819067901636915b2be5f12dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078421 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#745582}
-
Armando Miraglia authored
It was noted that in the case of WebView the labels are not shown even though the permission to access the devices were granted. After further inspection, crrev.com/c/1964495 exposed an issue in permission checking in the case of WebViews. To give us time to look into the issue further and fix the actual permission checking for WebViews, this CL disables by default the behavior change of enumerateDevices on Android. Bug: 1055770 Change-Id: I9dc557fed9961cf90794c87c4da4fa12213793f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078547 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#745581}
-
Clark DuVall authored
When a request was redirected to a page with a service worker installed, webRequest was not seeing the events. This is because the network loader factory was no longer proxied on the redirect. Bug: 1012977 Change-Id: I1161a8d6ac58711b83427accc8026a0981fa527e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079932Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#745580}
-
Esmael El-Moslimany authored
Change-Id: I5215174f057e1e377216db73b7f0bf7a77086f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079465 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#745579}
-
Chris Mumford authored
TBR=caseq@chromium.org Bug: 1055006 Change-Id: Ie2859a35d586ff2ae9ea54f461c9fd8552e32c3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078975 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#745578}
-
Yi Xu authored
canvas-lostgpu-context.html is consistently crash in last 3 builds: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29 TBR=thakis@chromium.org Bug: 818426 Change-Id: I77f658d014ca5eab2bfef811e182e27f1c53ad3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079681Reviewed-by:
Yi Xu <yiyix@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#745577}
-
Esmael El-Moslimany authored
Fixed: 1057032 Change-Id: I594e390ec47d17fed42cb8a374f4d58917addc62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079688 Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#745576}
-