- 29 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dca568a3575f..dc883a948e71 git log dca568a3575f..dc883a948e71 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src ec12de913124..42f885238114 (3 commits) Created with: gclient setdep -r src/third_party/angle@dc883a948e71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: chromium:None Change-Id: I6446141ec36771dcda4b6fb6444a3c6aa6070417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886753Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710292}
-
Mikhail Khokhlov authored
This is to comply with the latest changes in the LUCI protocol. Bug: 1018248 Change-Id: I2c71dfc1a15fd456f77b9a39e54eb8de1207c7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884290Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#710291}
-
David Roger authored
The GCMS was ignoring some cookie change notifications, specifically the ones receieved while the GCMS is busy. This was orinally done to fix a bug in the AccountReconcilor (see https://crbug.com/516070). However this was arguably the wrong place to fix it, and also it made the GCMS unreliable. Later, the AccountReconcilor was fixed (https://codereview.chromium.org/1267843003), and thus this is no longer necessary. This CL restores the previous behavior, and is essentially a revert of https://codereview.chromium.org/1264143003/ To completely avoid reconcilor loops, we will do the following: - rate-limit the reconcilor (bug 1008435) - add a new histogram that give the detailed status of a reconcilor run. The buckets could be something like: * no-op * failure (ideally including the failure reason) * success (logout) * success (multilogin) * success (MergeSession) * success (MergeSession + logout) Bug: 923873 Change-Id: Ib82cb511ea328793f80293450d140a74a1de6415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831863Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#710290}
-
Miyoung Shin authored
This CL converts ProvisionFetcher{Ptr, Request} in media and content to the new Mojo type. Bug: 955171 Change-Id: If6bf828080e81389209404050145849f6249f7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882265 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#710289}
-
Robert Liao authored
BUG=5027 Change-Id: I0046e489dbf25a4954321eb3c01ec36b15392345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885632 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#710288}
-
Kamila Hasanbega authored
This reverts commit 77add479. Reason for revert: This cl introduces consistent test failures https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/46230 Original change's description: > [omnibox] improve on device head suggest incognito flags. > > 1. Allows to enable on device head suggest in incognito w/o enabling it > in non incognito first. > 2. Removes request delay in incognito since there is no server > suggestion which we need to cope with. > > Bug: 925072 > Change-Id: I344ecc2c620cb95c3b5f7c929cac0d9287b3c05b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881978 > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Commit-Queue: Ce Chen <cch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710127} TBR=tommycli@chromium.org,jdonnelly@chromium.org,cch@chromium.org Change-Id: I7feaf59d4f0c16afb89e6048e622e4c5e294afd5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 925072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886333Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#710287}
-
Vasilii Sukhanov authored
The experiment was launched with the threshold '3'. Bug: 552010 Change-Id: I6bf72aa48715a15c021c907c1a6fd3f0de80a26d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880042Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#710286}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a0b89dfb..2fa0ef25 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6284c0440d24c119460b16547e27914b92d02b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886790Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710285}
-
Jan Wilken Dörrie authored
This change prepares //chrome/browser/ui/webui and //chrome/browser/chromeos for the upcoming switch of base::Value::GetList() from ListStorage& to base::span<base::Value>. It does so by both directly using list APIs exposed on base::Value and making use of base::span where apporopriate. TBR=poromov@chromium.org Bug: 646113 Change-Id: If286e21b71d5abc371d8d6936bca6c4cb9cbb0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874205 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#710284}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/01a21f71f427..9c71e4936bc2 git log 01a21f71f427..9c71e4936bc2 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 sprang@webrtc.org Remove redundant BitrateProber::OnIncomingPacket() call Created with: gclient setdep -r src/third_party/webrtc@9c71e4936bc2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I4f1636367c90829f013354c663a11b98044ff0a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886751Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710283}
-
Kamila authored
Change-Id: Ib3249e012753027b1d8ea8024df6cee0e589d3c8 TBR: afakhry@chromium.org BUG: 1019080, 1018498 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886672 Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#710282}
-
Juan Antonio Navarro Perez authored
Same crash in prediction_metrics_handler.cc as other infinite scroll stories. NOTRY=true TBR=crouleau@chromium.org Bug: 1017661 Change-Id: I902abdf15002e3dcbf93faba0c9c511861724230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886852Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#710281}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1874c334. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" af56e43c "Refactor fetch-error.https.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I64d18427f5d7316f0ca60c374c12c4e637aa6a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886370Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710280}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5a19effaca7e..b254eda6882d git log 5a19effaca7e..b254eda6882d --date=short --no-merges --format='%ad %ae %s' 2019-10-29 primiano@google.com Merge "UI: fix include path in heap_profile_flamegraph/common.ts" Created with: gclient setdep -r src/third_party/perfetto@b254eda6882d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I23b5e5b9587611095b7196e21595012ab508908d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886750Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710279}
-
Juan Antonio Navarro Perez authored
Make it slightly easier to write integration tests for results processor involving artifacts. Also fix a bug where creating multiple artifacts of the same type (e.g. many histogram artifacts for different test runs) would write all of them to the same file name, causing them to get overwritten. Bug: 981349 Change-Id: I7eaa8793d09fe0afc869dd8154df628d9ece7774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880034 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#710278}
-
Monica Basta authored
This CL does the following: (1) If the user has not customized their local profile name |IsUsingDefaultName() == true| and their local profile name is not 'Person %n', we change the local profile name to 'Person %n'. (2) For newly created profiles, we set the local profile name to 'Person %n' unless the user specifies something else. (3) Fix some corner cases for the display profile name. Bug: 1018719 Change-Id: Ic92bde725d5e33105e251214f01b646a2ff63088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878377 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#710277}
-
Henrique Ferreiro authored
blink::WebCanonicalCookie has no users outside of //third_party/blink. Move this class to //third_party/blink/renderer/platform as blink::CanonicalCookie. Bug: 919392 Change-Id: I352d287bc93b3d9801d5598de47d93dc3e8c09e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883576Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#710276}
-
Julie Jeongeun Kim authored
This CL converts ProxyResolvingSocketFactoryRequest to new Mojo types using PendingReceiver, Receiver, and UniqueReceiverSet. Bug: 955171 Change-Id: Ief7194cf589fae12f331ab30f0faeff04efeaefa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863409Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#710275}
-
sandromaggi authored
Previously, when autofill actively failed - as opposed to just being unable to fill the fields -, the action was completely terminated. New the required fields fallback will be triggered. Bug: b/143266929 Change-Id: I40ce9ae9d73f1d592d74a6aae3cdac9c25542434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879893 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#710274}
-
Sylvain Defresne authored
As documented in //components/README.md, code in components must not depend on higher-level layers of the Chromium codebase, including //ios/chrome. Move ukm_url_recorder.* and tests from ios/chrome/browser/metrics to components/ukm/ios (to parallel the version in content that is found in components/ukm/content). Fix UkmUrlRecorderTest to use WebTestWithWebState instead of the unavailable (due to layering violation) ChromeWebTest. Bug: 754895 Change-Id: I829486037063f16fe5fca5b7617017c0530a1859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878649 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#710273}
-
chrome://weblayerKamila Hasanbega authored
This reverts commit 90c5851b. Reason for revert: This introduces tests that constantly fail, https://ci.chromium.org/p/chromium/builders/ci/win-asan/8177. Original change's description: > [WebLayer] Add tests for chrome://weblayer page > > This page recently broke (fix in http://crrev.com/c/1880171), so tests > seem like a good idea. > > This also adds a test helper for executing javascript, and makes the > NavigateAndWaitForCompletion function work more similarly to the one in > the instrumentation tests by waiting until the page is finished loading. > > Bug: 1017924 > Change-Id: I8ca048f9a9a92808abf6cfa5d0e091550cc3d9a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880173 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709552} TBR=sky@chromium.org,cduvall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1017924 Change-Id: Ifc5689dc8bb0ec9fdc793bdbb79f44c5388b2266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886413Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#710272}
-
Mikel Astiz authored
GUID-related tests have been flaky since introduction and recent investigations suggest that the underlying issue is FakeServer's lack of sending sync invalidations for certain APIs like InjectEntity(). This patch modifies FakeServer to actually issue invalidations and removes some now redundant (and undesired) calls to TriggerSyncForModelTypes(). Assumes this fixes the flakiness, all tests are reenabled. Bug: 1014086 Change-Id: Ie0f597c024646586b9ec6c3dfbb761a86dadaad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879293Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#710271}
-
Christian Dullweber authored
Test that web features like SharedWorker and WebLocks that allow to communicate between tabs are blocked when third-party cookies are blocked. The WebLock test is disabled until WebLock works correctly Bug: 989926, 1016355 Change-Id: Ifd885b4e22338d211b35635ad0d85f0981c8e518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883632Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#710270}
-
Mathias Carlen authored
Before this patch perform_assistant_action was used to trigger Autofill Assistant layer scripts. For an external DirectAction caller it is expected to get a flattened list of direct actions instead of this indirection. The indirection got removed in a previous patch and the perform_assistant_action can now be removed too. Bug: b/138833619 Change-Id: Ib41fe034dc1cdeaae38582c7f5389ed8d1b3946a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879453 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#710269}
-
Arthur Hemery authored
Removing the unusued feature. Bug: 784904 Change-Id: I9d5bed00c0c95b634ce2be7cc1d251be691b2417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883074Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#710268}
-
Mikel Astiz authored
No behavioral changes: many concepts and member fields, in particular class Connection itself, are specific to one of the implementations, SyncServerConnectionManager. Other production implementations (LoopbackConnectionManager) as well as tests do not use any of those concepts, and use hacks to plumb in data as well as logic that is actually never used. Instead, let's move the subclass-specific logic to SyncServerConnectionManager and let the base interface be simpler. Bug: 951350 Change-Id: I74dcbbaf55676a7c1c9f8c38aca76288591048f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625999 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#710267}
-
Arthur Hemery authored
Removed a bunch of remaining DCHECKs and clarified future removal with comments. Bug: 784904 Change-Id: I439aa220af91b96c3b74a9b79868c5ca91fcbb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883073Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#710266}
-
Fredrik Söderquist authored
This changes from using essentially a linear-scan for the "update intervals" step to using a priority queue with the next interval time as the key/priority. Besides providing a dramatic reduction in the amount of actual interval update steps being performed, this also shifts the responsibility for the timing updates away from the sandwich structure and into the time container. This will in turn allow future simplification of the setup for animation value application/sandwich management. To aid the switch to the priority queue scheduling mechanism, the update of the "next interval time" is sunk out of and now performed as a separate step after UpdateInterval(). Some code is consolidated around the new "reschedule" operation (the SMILTimeContainer::Reschedule(...) method) which greatly simplifies some code. Bug: 998526 Change-Id: I1e22625eac022155607a3ccc66dd2d21f52cc7ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876031Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#710265}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/70f122128c..8bb84e5801 TBR=aerotwist@chromium.org Change-Id: Id2370e489efc7024b916b328f7e8f46e9f314bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886410Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#710264}
-
Mathias Carlen authored
For testing purposes we want to already expose an argument for a specific action. The correct way to address this is to use the action specs given in the proto and properly report the args configured therein. R=szermatt@chromium.org Bug: b/138833619 Change-Id: I4d5d0795e6a1249879b2675428e9418264251ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883076 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#710263}
-
Michael Lippautz authored
During marking, (a) marking an object and (b) processing it currently happen on the main thread. In future, concurrent marking will move both steps to helper tasks. Even with concurrent marking, the write barrier remains on the main thread and will require at least (a) to be executed right away. It is thus beneficial to increment live bytes counters in (b) which can be offloaded to helper tasks. Output on Z840 (down from ~13.1x): [ RUN ] WriteBarrierPerfTest.MemberWritePerformance *RESULT WriteBarrierPerfTest writes during GC: = 46497.21016738996 writes/ms *RESULT WriteBarrierPerfTest writes outside GC: = 541516.2454873646 writes/ms *RESULT WriteBarrierPerfTest relative speed difference: = 11.646209386281587 times [ OK ] WriteBarrierPerfTest.MemberWritePerformance (67 ms) Bug: 1014414 Change-Id: I5295e4738fce9410fbfbed51829c04b2e25f2d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883719 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#710262}
-
Hitoshi Yoshida authored
Adds a support for callback interfaces in Web IDL database. Bug: 839389 Change-Id: Ic4911a18fa7abf0b0891f53bc3dc8de38dd48730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886073 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#710261}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e78527989c4c..dca568a3575f git log e78527989c4c..dca568a3575f --date=short --no-merges --format='%ad %ae %s' 2019-10-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 1737a30e3e34..f8f6103eb89f (2 commits) Created with: gclient setdep -r src/third_party/angle@dca568a3575f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I9050e3f66566507ef3c815c61bcb042a2536a315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886511Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710260}
-
Mihai Sardarescu authored
This CL removes unifiedConsentEnabled variable from all settings resources that were still referencing it. Bug: 1015805 Change-Id: I8c12a9558a4cfab236d423c037f92e24bea99975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878195Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#710259}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ec12de913124..42f885238114 git log ec12de913124..42f885238114 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 bclayton@google.com utils: Add a vscode extension for SPIR-V disassembly files (#2987) 2019-10-28 greg@lunarg.com Add two new simplifications. (#2984) 2019-10-28 afdx@google.com spirv-fuzz: Transformation to extract from a composite object (#2991) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@42f885238114 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Bug: None Change-Id: I275ca1123d678df4b9688c7bfcb5a09ede232114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886510Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710258}
-
Julie Jeongeun Kim authored
This CL converts URLLoaderClientRequest to new Mojo types using PendingReceiver and Receiver. Bug: 955171 Change-Id: Ib359451c4e8286b61e24327dc15a1629d4a6c0ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883457 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#710257}
-
Mario Sanchez Prada authored
Convert the remaining bits referencing this mojo interface using the old mojo APIs, to the new mojo types. Bug: 955171 Change-Id: I552ea14b3bcd3700423bc13dc0bf0a9cc1198d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881233Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#710256}
-
Jan Wilken Dörrie authored
This change implements LWG3101 [1], which disables span's Container constructors when the extent is static. This change disables the corresponding constructors appropriately and modifies base::make_span<N> to call the two argument (data, size) constructor instead. [1] https://wg21.link/LWG3101 Bug: 828324, 877931 Change-Id: If3e615ea26f2a051c0c650bed0789c9442ca47b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883569Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#710255}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a8fe19e0c492..e0d8f948954f git log a8fe19e0c492..e0d8f948954f --date=short --no-merges --format='%ad %ae %s' 2019-10-29 tmrts@chromium.org [vinn] Enable snapshots and update Mac d8 binary to 7.7.299.15 Created with: gclient setdep -r src/third_party/catapult@e0d8f948954f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:1001953 Change-Id: Ib95040bbb81e53ab46fabc338a3f1823f748ad14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886290Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710254}
-
Kamila Hasanbega authored
This reverts commit 37574271. Reason for revert: It seems to be the reason for https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests starting to fail. Original change's description: > WebApp: Implement sync-initiated installs for sync-stub apps. > > This code is disabled by default behind kDesktopPWAsWithoutExtensions and > kDesktopPWAsUSS base features. > > A browser end-to-end tests will be added later in a follow up CL. > An MVP implementation of the bridge+sync needed first. > > Bug: 860583 > Change-Id: I461e24fefcbb5d2a0bf819d63a480635e91c732c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858025 > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710218} TBR=mpearson@chromium.org,alancutter@chromium.org,loyso@chromium.org Change-Id: I90e076fa6710d06dc118ee57adb0ab454b0e55d9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 860583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886411Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#710253}
-