- 12 Sep, 2017 40 commits
-
-
Wenzhao Zang authored
The interface is used to close the note taking app from the views-based login shelf. Also added TestTrayActionClient which are shared by various unit tests. Bug: 701157 Change-Id: I88c871f1597369f11b5b2c9d1c3548c790c0b088 Reviewed-on: https://chromium-review.googlesource.com/656059Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#501378}
-
sebsg authored
Bug: 764464 Tbr: miu@chromium.org Change-Id: Ibe3cc60266d1c20c79fe6f4b742f882426796ced Reviewed-on: https://chromium-review.googlesource.com/664065Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#501377}
-
Brett Wilson authored
Part 3/4 to replace these namespace qualifications. TBR=dcheng@chromium.org Bug: 763556 Change-Id: I052b146dd2ce9f5e3997ab5ae1e362b2422fb03e Reviewed-on: https://chromium-review.googlesource.com/662140Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#501376}
-
Xianzhu Wang authored
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I64abe06057f9978289ec183a28a6c756fdf40aa1 Reviewed-on: https://chromium-review.googlesource.com/661784 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#501375}
-
Matt Mueller authored
Windows has been on use_byte_certs since M61. Bug: 671420 Change-Id: I78c7f7f2a2e94ebd18d4d0c76909a9549231ec85 Reviewed-on: https://chromium-review.googlesource.com/661885Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#501374}
-
John Rummell authored
Add versioning to functions that query the storage ID. This will enable changes in the future if Chrome ever needs to use a different method of determining the ID. Pepper will only support a single version (version 1). BUG=478960 TEST=EME browser_tests pass Change-Id: Iea2d3ef00f3e8a3316952e0061dbbf666a2798bb Reviewed-on: https://chromium-review.googlesource.com/661117Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#501373}
-
Helen Li authored
This CL removes SDCH code from net/filter/. This CL is one of the CLs to remove SDCH from Chromium. SDCH has been disabled in Chrome since M59. For more details please see Issue 690070 and blink-dev@ thread linked below. Bug: 762686 Change-Id: I5d98c0171a4fbceb1348ccc2a67fa2a51bd4df8a Reviewed-on: https://chromium-review.googlesource.com/663239Reviewed-by:
Randy Smith <rdsmith@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#501372}
-
Ira Burak authored
Windows doesn't allow defining empty arrays, so for the case when there are no expired histograms, the dummy value is added. Bug: 753485 Change-Id: I69efcaa7ea63939d1e1b75497f6a1a252de010f2 Reviewed-on: https://chromium-review.googlesource.com/650468Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Ira Burak <iburak@google.com> Cr-Commit-Position: refs/heads/master@{#501371}
-
Carlos IL authored
URLs for manually opening chrome interstitials (chrome://interstitials/...) now use exact path matching instead of only checking that the first characters match (e.g. chrome://interstitials/ssl--invalid-- will not open chrome://interstitials/ssl). Added a test that verifies this change. R=estark@chromium.org Bug: 759915 Change-Id: I0d83709e54b83784c3f26a8d0511a77511d5fb63 Reviewed-on: https://chromium-review.googlesource.com/663204Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Carlos Joan Rafael Ibarra Lopez <carlosil@google.com> Cr-Commit-Position: refs/heads/master@{#501370}
-
Christopher Grant authored
This is a reland of 3e3149a8 Original change's description: > ElideUrl: Refactor tests to use a progressive elision approach. > > Several elision test cases specify multiple progressively shorter > versions of the same original URL. With this change, we'll test that > progression more thoroughly by specifying the expected sequence of > consecutive results that should be generated as available space > decreases. > > This helps eliminate the risk of a broken corner case. > > BUG=753789 > > Change-Id: Ib727295522f588f5e8b658661d2314587aa61844 > Reviewed-on: https://chromium-review.googlesource.com/643153 > Reviewed-by: Tommy Li <tommycli@chromium.org> > Reviewed-by: Matt Giuca <mgiuca@chromium.org> > Commit-Queue: Christopher Grant <cjgrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#499962} TBR=tommycli@chromium.org Bug: 753789 Change-Id: Ief5f6c029f93282de64d3946266b8608620aff80 Reviewed-on: https://chromium-review.googlesource.com/663677Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#501369}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/00f454c9..a3ef78d9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I7b9ea0307d465ec4cccca9225545d296470fe7c9 Reviewed-on: https://chromium-review.googlesource.com/663409Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#501368}
-
Sean Topping authored
This is needed to enable remote browser traces on Chromecast. Bug: internal b/65209777 Change-Id: I0ea49227ac484f7a278328eeff6eedfdac7bf946 Reviewed-on: https://chromium-review.googlesource.com/662362Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#501367}
-
Eric Holk authored
This test make sure that breakpad generates a crash dump when the renderer crashes. We also need to ensure crash reports are generated when WebAssembly is using trap-based bounds checks, as WebAssembly's attempts to recover from SEGV signals could prevent crash reports from being generated. Bug: chromium:722585 Change-Id: I152a6a1d6d0f91590c4e0fb0acfcce866064399d Reviewed-on: https://chromium-review.googlesource.com/661785Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#501366}
-
Conley Owens authored
This change adds a CCCD (Client Characteristic Configuration Descriptor, as defined in Vol 3, Part G, 3.3.3.3) to the measurement interval of the fake health thermometer. This will allow us to call startNotifications() on the measurement interval. BUG=719816 Change-Id: Ia7b515378be0c66e58c68d10451fbbd600e1c9c5 Reviewed-on: https://chromium-review.googlesource.com/663938 Commit-Queue: Conley Owens <cco3@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#501365}
-
Greg Kerr authored
The bootstrap sandbox was replaced by the V2 sandbox. Bug: 762077 Change-Id: I2c9aeab22d29a42a2c800a53e0c8a5484e00c043 Reviewed-on: https://chromium-review.googlesource.com/647686Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#501364}
-
Mohamad Ahmadi authored
- Sets PaymentRequestManager's active WebState to nullptr in BVC's shutdown method to make sure the active WebState is clean when BVC shuts down. - Adds a call to update PaymentRequestManager's active WebState in -tabModel:didReplaceTab:withTab:atIndex: in order to clean the the previously active WebState and enable PaymentRequest on the new one. This call happens when a recent tab is opened. - This CL adds a unit test to verify that the BVC shuts down cleanly with Payment Request enabled. - This CL removes the calls to enable/disable the active WebState in the [PaymentRequestManager enablePaymentRequest:] and instead changes the behavior so that the script commands are ignored when the Payment Request is disabled. The reason for this change is that this method is called when the BVC is disabled before it shuts down. This could result in a second attempt to disable the active WebState when the BVC actually shuts down which is wrong. TBR=rouslan@ Bug: 761358, 755799, 602666 Change-Id: Id984aec77194993b23085448cb802ba9fe120379 Reviewed-on: https://chromium-review.googlesource.com/660480 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#501363}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4ba1c8da. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/1660 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request TBR=qyearsley@chromium.org No-Export: true Change-Id: I24cd14a12b95c0165056623ccf52afc02497d5f4 Reviewed-on: https://chromium-review.googlesource.com/663622 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501362}
-
Dmitry Gozman authored
Bug: 590878 Change-Id: I5606ba2082e7ea81b95547b8b28f476ce3f59b43 Reviewed-on: https://chromium-review.googlesource.com/630564Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501361}
-
Derek Cheng authored
Add option to pass in NetLog to socket used for mDNS. Pass in ChromeNetLog from Chrome code service_discovery_client_mdns. This will hopefully help us diagnose long standing Cast / mDNS reliability issues. The NetLog entries can be easily filtered by searching the IP endpoint used for mDNS (defined in net/dns/mdns_client.cc?). BUG=751207 Change-Id: Id649a03d498e077738c5e071214f31f6577401e6 Reviewed-on: https://chromium-review.googlesource.com/647490Reviewed-by:
Gene Gutnik <gene@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#501360}
-
Sebastien Seguin-Gagnon authored
This reverts commit 5605a3d7. Reason for revert: Causing failures on all platform webkit layout test external/wpt/innerText/getter.html. see bug: crbug.com/764417 Original change's description: > Stop TextIterator from emit double newlines after H4~6 elements > > TextIterator currently may add two consecutive newlines after an > H4, H5 or H6 element, while the spec of innerText doesn't have > this case at all. > > This patch removes the extra newline to make TextIterator more > spec-complicant. > > Note: TextIterator should eventually remove double newline emission > also for H1~3. This patch removes it only for H4~6 to keep the > amount of rebaselined tests small. > > Bug: 752672,758816 > Change-Id: I32583c194a829f52411555125e77590e36ccf838 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng > Reviewed-on: https://chromium-review.googlesource.com/661937 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501297} TBR=yosin@chromium.org,kojii@chromium.org,xiaochengh@chromium.org,simonp@opera.com Change-Id: I16487602d07a29ac95d79867ae0522dbfbe130d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 752672, 758816 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/663941Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#501359}
-
Tommy C. Li authored
This CL adds a unified match_in_foo implementation for use between HistoryURLProvider, Bookmarks, and Navsuggest. It deliberately leaves off HQP, as that has does tricky operations using adjusted match offsets rather than unadjusted (like the other providers). It should be very posible to refactor HQP to use this unified code as well, but that should be saved for a separate CL. Bug: 761505 Change-Id: I8107915cae0ef6477e18de32fd924c2a9506e2ad Reviewed-on: https://chromium-review.googlesource.com/661884 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#501358}
-
Aidan Wolter authored
This will allow apps to be conditionally started as services. The enable_headless_music_mode flag is also added. Bug: internal b/64904346 Test: Set the enable_headless_music_mode flag and test that GPM and YTM start as services. Change-Id: Ibbdf4f1874438288659bd4988567a5826986a538 Reviewed-on: https://chromium-review.googlesource.com/654298 Commit-Queue: Aidan Wolter <awolter@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#501357}
-
Shivani Sharma authored
The special handling for 416 is not needed and added comment for auth response since in URLRequest::CancelAuth scenario HC::T::Read() can be invoked even though the transaction is still entry->headers_transaction. Bug: None Change-Id: I9b031e8025b721a45f16957868d540b13c09fb09 Reviewed-on: https://chromium-review.googlesource.com/612400 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501356}
-
Jacob Dufault authored
Also remove a LOG(ERROR) that was accidentally committed. Bug: 719015 Change-Id: Ib4564903b358cdba5c1189a5b9fac484e7c8ad16 Reviewed-on: https://chromium-review.googlesource.com/663667 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#501355}
-
Sammie Quon authored
Test: ash_unittests PeripheralBatteryNotifierTest.* Bug: 761556 Change-Id: I45f691d17380812c37de13d5d3a8df9d87ad2fa6 Reviewed-on: https://chromium-review.googlesource.com/656513Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#501354}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/2ab4b2b871c0..79a1256c2233 $ git log 2ab4b2b87..79a1256c2 --date=short --no-merges --format='%ad %ae %s' 2017-09-12 benjaminwagner Simpler version of wait-for-device. 2017-09-12 jvanverth Add support for additional textures in GrDrawOpAtlas Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I6e990b313f0c5a8a2740556fd45812cee0768ad9 Reviewed-on: https://chromium-review.googlesource.com/663740Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501353}
-
Theresa authored
This reverts commit 5d786be1. Reason for revert: org.chromium.net.ExperimentalOptionsTest#testHostCachePersistence crashing on Android Cronet Builder Asan Original change's description: > Simplify CronetPrefsManager after SDCH has been removed in M63 > > BUG=758711 > > Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester > Change-Id: Iacfd99301c8924e4126c9684a2da24ef8a415a5a > Reviewed-on: https://chromium-review.googlesource.com/660922 > Reviewed-by: Helen Li <xunjieli@chromium.org> > Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501271} TBR=xunjieli@chromium.org,kapishnikov@chromium.org Change-Id: I7e93dcb088101de02144aa8f05fd7b07e98f7d75 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 758711 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Reviewed-on: https://chromium-review.googlesource.com/663566Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#501352}
-
Koji Ishii authored
This patch computes break opportunities after bidi controls. Before this patch, bidi controls always prevented line breaks. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I0215c62b50f46506fdaa49ed6bc0332d0aa76ebf Reviewed-on: https://chromium-review.googlesource.com/661118 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#501351}
-
Tom Sepez authored
Reciprocal of SandboxTypeFromCommandLine(). Fix a few more places where we need to treat network sandboxes as unsandboxed. Change-Id: Ice093ff819fd7376bda9f44352f20e8784c1dccd Reviewed-on: https://chromium-review.googlesource.com/658560Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#501350}
-
Tom Anderson authored
Running RPM find-requires on libwidevinecdm.so on Debian Testing reports no libstdc++ dependency, but running it on Ubuntu Trusty does. This CL explicitly allows libstdc++.so as an RPM dependency -- this is a requirement to reland r501104. BUG=758654 R=thestig@chromium.org Change-Id: Ie008e51184b92cf891b4f74c1a432b771adfec5d Reviewed-on: https://chromium-review.googlesource.com/662401Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#501349}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4298cb322ef3..000134387797 $ git log 4298cb322..000134387 --date=short --no-merges --format='%ad %ae %s' 2017-09-12 dskiba Respect tracing time in startup tracing agent. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I0aeae70423e05326ebe08e533befcab6eeca15f8 Reviewed-on: https://chromium-review.googlesource.com/663564 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501348}
-
Steven Bennetts authored
This shows the list of Shill devices in chrome://network Bug: none Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icf7fdce83722a3a84b82baee28b35bd5b40ad4c0 Reviewed-on: https://chromium-review.googlesource.com/656377Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#501347}
-
Scott Graham authored
There's no advisory file locking, cross-process mutex or semaphore, or implemented flock on Fuchsia currently. So fallback to using dot-file locking for the time being. Bug: 758634 Change-Id: I7be88b0930eca3d4527e6ff161914987ac2150cb Reviewed-on: https://chromium-review.googlesource.com/661321Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#501346}
-
bsheedy authored
Updates the VR motion-to-photon latency test's output.json format to match the newer version used by Telemetry and other script tests. This is necessary because the chromium_tests recipe was recently updated to assume that a test is disabled if the results don't include the "tests" key, which is causing results to not be uploaded to the dashboard. Bug: Change-Id: I15102724d3a688bd80b87e583c85dd159cc9feba Reviewed-on: https://chromium-review.googlesource.com/662879Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#501345}
-
Artem Strygin authored
Use received bytes count as the value for progress, not chunks count. Reason for reland: The fix of revert reason has been added. Bug: 755061 Original change's description: > Revert "Reland of Improve linearized pdf load/show time." > > This reverts commit 9a6d1487. > > Reason for revert: https://crbug.com/755061. This appears to be > causing a serious regression in loading. The loading bar does not > appear as expected and appears all at once at the end as the screen > displays. There is 5-6seconds of nothing happening which makes it look > like the browser has stopped working. > > > Original change's description: > > Reland of Improve linearized pdf load/show time. > > > > XFA forms loading has been fixed. > > Now for document with single non XFA page, the form load first. > > This is necessary for correct loading pages, because in XFA document > > the page count and them contents may be changed after loading form. > > > > See > > https://codereview.chromium.org/2558573002/ > > > > For test this: > > build chromium pdf with XFA support > > and open any document from > > https://www.idrsolutions.com/jpdfforms/xfa-html5-example-conversions/ > > > > Original CL: > > https://codereview.chromium.org/2455403002/ > > > > Original description: > > Improve linearized pdf load/show time. > > Reduce Pdf Plugin's count of reconnects. > > Add tests for PDFPlugin DocumentLoader. > > > > DocumentLoader was splitted into separate components, and missing tests was added for them. > > > > The main ideas in this CL are: > > > > 1) Do not reset browser initiated connection at start (includes case when we can use range requests), if we request data near current downloading position. > > 2) Request as much data as we can on each request, and continue loading data using current range request. (like tape rewind) > > 3) Isolate RangeRequest logic into DocumentLoader. Method OnPendingRequestComplete is called, when we receive requested data (main connection, or Range connection). (like tape playing without rewing). > > 4) Fill this logic by tests. > > > > Example URL: > > http://www.major-landrover.ru/upload/attachments/f/9/f96aab07dab04ae89c8a509ec1ef2b31.pdf > > Comparison of changes: > > https://drive.google.com/file/d/0BzWfMBOuik2QNGg0SG93Y3lpUlE/view?usp=sharing > > > > Change-Id: I97bb25d2e82bcb4ba2e060af8128f49b9c0680d9 > > Reviewed-on: https://chromium-review.googlesource.com/581292 > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Reviewed-by: Dan Sinclair <dsinclair@chromium.org> > > Commit-Queue: Art Snake <art-snake@yandex-team.ru> > > Cr-Commit-Position: refs/heads/master@{#489755} > > TBR=rsesek@chromium.org Change-Id: I78e10565f639c26faae29b3cf854419208af8665 Reviewed-on: https://chromium-review.googlesource.com/615302 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
(000 09-08 - 09-18) dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#501344}
-
Eugene But authored
Cancelling system long press gesture cancels all system UI (selection and context menu). Cancelling system context menu UI is intentional, because Chrome want to show own context menu. Cancelling system selection UI was a bug. Bug: 763985 Change-Id: I19fb9b7a90948a2ae9151028d4b7bff53e65b0cf Reviewed-on: https://chromium-review.googlesource.com/663780 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#501343}
-
Elliot Glaysher authored
Bug: 706200 Change-Id: Iceaa1b1bac05b348274ddd78040ded6e4a4de42e Reviewed-on: https://chromium-review.googlesource.com/641377 Commit-Queue: Elliot Glaysher <erg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#501342}
-
Ryan Hamilton authored
Change-Id: I8d0df310e716f3663704f5bfb087ac85c7d1fb64 Reviewed-on: https://chromium-review.googlesource.com/663563Reviewed-by:
Buck Krasic <ckrasic@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#501341}
-
Isha Bobra authored
There is a chance that a race condition occurs where the page returns canScrollForward/backward/up/down/left/right as true but actually the page cannot scroll further. In those cases the scroll function in browser android accessibility should return false instead of true. Bug: 763014 Change-Id: I777b5fb562713e0bd835a354adab9cbf86fcd853 Reviewed-on: https://chromium-review.googlesource.com/661718Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#501340}
-
Helen Li authored
SDCH has been disabled in Chrome since M59. For more details please see Issue 690070 and blink-dev@ thread linked below. This CL is to remove sdch code from net/url_request. This is the first CL in the series. Bug: 762686 Change-Id: If467b19a2b963c3790bf372ab278bbf847052ddf Reviewed-on: https://chromium-review.googlesource.com/660999Reviewed-by:
Randy Smith <rdsmith@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#501339}
-