GitLab

- rename WebInspector.Layers3DView.ActiveObject to ...Selection;
- introduce proper constructors and isEqual methods for Selection;
- generalize hover/selection handling logic for different objects;
- make hovered (but not selected) object bluish

Review URL: https://codereview.chromium.org/711423002

git-svn-id: svn://svn.chromium.org/blink/trunk@185203 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit 095f52e20d593fd0ca4d615455ff65b568728112 aka

https://src.chromium.org/viewvc/blink?view=rev&revision=185184

Auto rebaselines landed for that change but the bots did not cycle green.
Seems the mac needs a generic mac port image result, as it won't fallback
to use either the win or generic results. Reverting for now.

TBR=yhirano@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/717113002

git-svn-id: svn://svn.chromium.org/blink/trunk@185202 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/705063004

git-svn-id: svn://svn.chromium.org/blink/trunk@185201 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When a block element becomes a float or out of flow we should strip
any anonymous blocks wrapping its inline siblings.

BUG=331251

Review URL: https://codereview.chromium.org/253313005

git-svn-id: svn://svn.chromium.org/blink/trunk@185200 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to the specification, the first argument should be
  (HTMLOptionElement or HTMLOptGroupElement)
and the second argument should be
  (HTMLElement or long)?
(and also be optional and default to null).

This changes behavior for the first argument (previously HTMLElement)
where a call was a silent no-op for invalid element types, and where
HTMLHRElement was allowed against the specification and with no
observable effects.

The new behavior is to throw TypeError for all invalid arguments, which is
compatible with Firefox and MSIE.

Also apply the same change to HTMLOptionsCollection.add(), which is little
more than a short-hand for calling add() on the owning select element.
Also drop the custom bindings implementation for that method, which was
essentially implementing the unionized second argument.

The behavior of HTMLOptionsCollection.add() is changed to ignore all
invalid (out of range) integer second arguments, rather than to throw for
negative ones below than -1. This change is also per specification and
compatible with other implementations.

BUG=430337

Review URL: https://codereview.chromium.org/716773002

git-svn-id: svn://svn.chromium.org/blink/trunk@185199 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If an element A has a parent element, then A's assigned context menu is the assigned context menu of its parent element. Otherwise, A's assigned context menu is null.

Specification: https://html.spec.whatwg.org/multipage/forms.html#assigned-context-menu

"Each element has an assigned context menu, which can be null. If an element A has a contextmenu attribute, and there is an element with the ID given by A's contextmenu attribute's value in A's home subtree, and the first such element in tree order is a menu element whose type attribute is in the popup menu state, then A's assigned context menu is that element. Otherwise, if A has a parent element, then A's assigned context menu is the assigned context menu of its parent element. Otherwise, A's assigned context menu is null."

BUG=424494

Review URL: https://codereview.chromium.org/721603002

git-svn-id: svn://svn.chromium.org/blink/trunk@185198 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It seems that these are leftovers when I replaced Dictionary
with IDL dictionaries. Added a forward declaration in
Element.h instead (which is actually using Dictionary).

Review URL: https://codereview.chromium.org/723473002

git-svn-id: svn://svn.chromium.org/blink/trunk@185197 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously WTF_CPU_32BIT definition is inside #if of ARM.
This CL make CPU(32BIT) true on all architectures if and only if not CPU(64BIT).

BUG=432033

Review URL: https://codereview.chromium.org/712303003

git-svn-id: svn://svn.chromium.org/blink/trunk@185196 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a follow-up CL of https://codereview.chromium.org/690923004/.

It would be great to show "(A or B)" rather than "AOrB".

BUG=240176

Review URL: https://codereview.chromium.org/722523003

git-svn-id: svn://svn.chromium.org/blink/trunk@185195 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Dictionary.h has some problems (it cannot handle ExceptionState,
difficult to understand). We want to reduce Dictionary uses
in core/modules so that make it more maintainable.

Tests under fast/plugins cover this change.

BUG=403150

Review URL: https://codereview.chromium.org/720673002

git-svn-id: svn://svn.chromium.org/blink/trunk@185194 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185184

BUG=405803
TBR=noel@chromium.org

Review URL: https://codereview.chromium.org/712173004

git-svn-id: svn://svn.chromium.org/blink/trunk@185193 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes the idl interfaces for getPropertyCSSValue and friends
(i.e. those behind the runtime flag CSSValue), and removes code that only
existed to support this.

BUG=331608

Review URL: https://codereview.chromium.org/717933002

git-svn-id: svn://svn.chromium.org/blink/trunk@185192 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=432051
R=philipj@opera.com

Review URL: https://codereview.chromium.org/710173004

git-svn-id: svn://svn.chromium.org/blink/trunk@185191 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The operation may take noticable time an may give the user additional information about his page performance.

BUG=424502

Review URL: https://codereview.chromium.org/717573003

git-svn-id: svn://svn.chromium.org/blink/trunk@185190 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Even though we want to avoid using generic Dictionary in IDL
files, we need them in some cases. For example, WebCrypto
uses generic Dictionary because we don't have IDL dictionary
inheritance support. Add generic Dictionary support so that
such customers can use union types.

BUG=240176

Review URL: https://codereview.chromium.org/713403004

git-svn-id: svn://svn.chromium.org/blink/trunk@185189 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=yukishiino@chromium.org
TBR=haraken@chromium.org
TESTS=build on Linux
BUG=

Review URL: https://codereview.chromium.org/717873005

git-svn-id: svn://svn.chromium.org/blink/trunk@185188 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Following r185177, these tests no longer crash.

TBR=yhirano,haraken
BUG=431996
NOTRY=true

Review URL: https://codereview.chromium.org/719023002

git-svn-id: svn://svn.chromium.org/blink/trunk@185187 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=243223

Review URL: https://codereview.chromium.org/643693006

git-svn-id: svn://svn.chromium.org/blink/trunk@185186 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently the fallback behavior for redirect responses is not implemented correctly.
https://codereview.chromium.org/705273004/ will fix this problem.
This patch adds LayoutTests for this bug.

BUG=431985

Review URL: https://codereview.chromium.org/712303002

git-svn-id: svn://svn.chromium.org/blink/trunk@185185 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Delete mac result, rebaseline to grab any new mac result, which should
match the windows result and be optimized out if things are working as
expected per issue 405803 and issue 409435.

BUG=405803
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185102

Review URL: https://codereview.chromium.org/697843005

git-svn-id: svn://svn.chromium.org/blink/trunk@185184 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We should not implement this change, since table cells would not update if we
later set their row/colspan to 1.

Review URL: https://codereview.chromium.org/688683004

git-svn-id: svn://svn.chromium.org/blink/trunk@185183 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WebPluginContainerImpl::scriptableObject calls into WebPlugin::scriptableObject
which (in the PepperWebPluginImpl implementation) sends synchronous messages
to the plugin which can result in re-entrancy. This re-entrancy may cause the
plugin to be destroyed, which sets m_webPlugin to null in
WebPluginContainerImpl::dispose. We need to check for a null value to avoid
dereferencing a null pointer.

BUG=423263

Review URL: https://codereview.chromium.org/715073002

git-svn-id: svn://svn.chromium.org/blink/trunk@185182 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make already-implemented functions up to date. Unimplemented features such
as piping and strategy are still unimplemented.

BUG=393911

Review URL: https://codereview.chromium.org/712043002

git-svn-id: svn://svn.chromium.org/blink/trunk@185181 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Implementing Element.closest() API according to specs https://dom.spec.whatwg.org/#dom-element-closest

This API will parse selectors and if fails then throw SyntaxError
else return closest ancestor that matches selectors if there is
no ancestor that matches selectors, it will return nullptr.

Blink-Dev Intent to Implement and ship Link :
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/yk_Fo6hyvb8

This patch is a merge from webkit http://trac.webkit.org/changeset/174324
by Dhi Aurrahman <diorahman@rockybars.com>".

BUG=422731, 417603
R=habib.virji@samsung.com

Review URL: https://codereview.chromium.org/701723007

git-svn-id: svn://svn.chromium.org/blink/trunk@185180 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch makes animation-test-helpers.js not care about which
properties are being tested by always working with strings from computed
style directly. The previous behaviour relies heavily on the no longer
web-exposed getPropertyCSSValue which we want to delete.

Instead of having separate expectation types for different properties,
we simply match numeric substrings of the computed style value. The top
of the file has a comment explaining in more detail.

BUG=428595

Review URL: https://codereview.chromium.org/716963002

git-svn-id: svn://svn.chromium.org/blink/trunk@185179 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Following Christian's suggestion on https://codereview.chromium.org/715083002

Review URL: https://codereview.chromium.org/718943003

git-svn-id: svn://svn.chromium.org/blink/trunk@185178 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It is not allowed to destruct HRTFDatabaseLoader::m_thread during a sweeping phase
because WebThreadSupportingGC's destructor enters a safe point scope.
This CL avoids the situation by explicitly joining with the loader thread in AudioContext::uninitialize().

In order to make sure that the loader thread finishes touching m_thread,
this CL posts a clean-up task and wait for its completion before calling
m_thread.clear().

BUG=432041

Review URL: https://codereview.chromium.org/711323002

git-svn-id: svn://svn.chromium.org/blink/trunk@185177 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit d43def09a965260b603064b5e6916c534b74b17c, aka r185145.

Speculative revert to fix content_browsertest failures on chromeos_rel
bot.

TBR=bokan
BUG=

Review URL: https://codereview.chromium.org/717053002

git-svn-id: svn://svn.chromium.org/blink/trunk@185176 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I've benchmarked and found that DOMDataStore::setReturnValueFast
is quite effective for document.implementation and
getElementsByTagName.  We should keep this method.

BUG=235436

Review URL: https://codereview.chromium.org/702523003

git-svn-id: svn://svn.chromium.org/blink/trunk@185175 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some layout tests time out since the switch to apache server, with
AcceptEx failures logged on error log. This may fix the issue.

BUG=30536, 431172

Review URL: https://codereview.chromium.org/695193006

git-svn-id: svn://svn.chromium.org/blink/trunk@185174 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Cache and reset the intrinsic content logical height of children when stretching them
in FlexBox. This is to avoid them reseting it to the stretched height, which leads
us to improperly avoiding layout later when stretching is no longer necessary.

This solution is too fragile, but I couldn't come up with one that was more robust
but doesn't break the optimization.

BUG=409779

Review URL: https://codereview.chromium.org/715083002

git-svn-id: svn://svn.chromium.org/blink/trunk@185173 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185157

BUG=420901
TBR=bungeman@chromium.org

Review URL: https://codereview.chromium.org/717043002

git-svn-id: svn://svn.chromium.org/blink/trunk@185172 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185161

BUG=423834
TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/716973003

git-svn-id: svn://svn.chromium.org/blink/trunk@185171 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Having fragmentation data be lazy on RootInlineBox only saves us a single
int (due to the pointer and the fact that we have room to pack its bool
into InlineFlowBox's bitfields), and the allocation overhead was large enough
it appeared on performance tests (see bug).

BUG=313700

Review URL: https://codereview.chromium.org/715973004

git-svn-id: svn://svn.chromium.org/blink/trunk@185170 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL ensures ResourceFetcher::requestPreload to request with
an appropriate context, RequestContextPrefetch.
This CL fixes the issue that ASSERT in
MixedContentChecker::contextTypeFromContext is hit when preloader
is invoked.

This is to prepare for CL http://crrev.com/673603002 , which makes
preloader to be invoked more often.

TESTS=http/tests/security/mixedContent
BUG=421300

Review URL: https://codereview.chromium.org/711213002

git-svn-id: svn://svn.chromium.org/blink/trunk@185169 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since ContentDecryptionModuleResult objects are often used to return
promises, add ContentDecryptionModuleResultPromise as a base class
that includes the promise and allow existing classes to only override
the complete() method that they expect to get called.

BUG=358271
TEST=existing EME tests pass

Review URL: https://codereview.chromium.org/687533004

git-svn-id: svn://svn.chromium.org/blink/trunk@185168 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=423071

Review URL: https://codereview.chromium.org/716023002

git-svn-id: svn://svn.chromium.org/blink/trunk@185167 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Makes CSSRule and its subclasses inherit from ScriptWrappable.

Amongst top 10 mobile web sites, only one web site instantiates
only one instance of CSSRule unless Developer Tools is opened.
Most of web pages don't instantiate CSSRules and its subclasses
(unless Developer Tools is opened), so it should be okay to make
CSSRule inherit from ScriptWrappable, although it increases the
size of CSSRule by 4 or 8 bytes (= the size of v8::Persistent).

BUG=390065

Review URL: https://codereview.chromium.org/699043003

git-svn-id: svn://svn.chromium.org/blink/trunk@185166 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As getPropertyCSSValue, CSSPrimitiveValue, etc. are no longer
web-exposed, we should stop testing them so we can delete the interface.

BUG=428595

Review URL: https://codereview.chromium.org/715913003

git-svn-id: svn://svn.chromium.org/blink/trunk@185165 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Apache gets stuck when the pipe connected to stderr gets filled up and
not read. This patch makes stderr of apache directly goes to build log.

BUG=30536, 431172

Review URL: https://codereview.chromium.org/712253002

git-svn-id: svn://svn.chromium.org/blink/trunk@185164 bbb929c8-8fbe-4397-9dbb-9b2b20218538