- 30 Oct, 2017 40 commits
-
-
Andrew Grieve authored
LocalPath() should be used in error messages, but never when actually trying to access a path. For this, you should use AbsoluteLocalPath. Bug: 768962 Change-Id: I28cd31ca71c24234813bd90bec2be0cffe416777 Reviewed-on: https://chromium-review.googlesource.com/744461Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#512601}
-
Andrew Grieve authored
Bug: 778067 Change-Id: Ib61c658583e4f89ed94af229ded597baa4ee1887 Reviewed-on: https://chromium-review.googlesource.com/744341Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#512600}
-
Blake O'Hare authored
This introduces a new flag to the extension called 'floatingkeyboard' as opposed to the old flag which was 'floatingvirtualkeyboard'. The old flag is still referenced by a helper method which is used to activate legacy floating keyboard code. Due to the semi-tandem nature of the extension, this is just the first step to relaying the flag. The extension needs to be updated to remove references to the old flag and the different name here will prevent accidental collisions or showing the old keyboard. Bug: 776260 Change-Id: I38b5f5275b2b493e5eea5c87b7ad509a018741cc Reviewed-on: https://chromium-review.googlesource.com/741426 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#512599}
-
Daniel Erat authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/53717bc2de48..47afcabaf957 $ git log 53717bc2d..47afcabaf --date=short --no-merges --format='%ad %ae %s' 2017-10-25 derat system_api: Add powerd ScreenIdleState proto. 2017-10-25 ejcaruso shill: make property identifier for Cellular.ModelID consistent 2017-10-02 ejcaruso switches: add modemfwd_switches.h Created with: roll-dep src/third_party/cros_system_api Bug: 778449 Change-Id: Ifaefefa117c08d824e1bf1125037f6e6fad1105b Reviewed-on: https://chromium-review.googlesource.com/742231Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#512598}
-
Stephen Martinis authored
This reverts commit 1d3fc0ad. Reason for revert: Broken for now, will reland with some fixes. ashleymarie@ might do the reland. Original change's description: > //tools/perf: Use trigger script in OBBS tester > > Change-Id: Ie024ff5713fde047803601391629caff3f40950b > Reviewed-on: https://chromium-review.googlesource.com/722067 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#510581} TBR=nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org,ashleymarie@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I4de924b07b2420e6a9f1fba6095e993292354595 Reviewed-on: https://chromium-review.googlesource.com/734990Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#512597}
-
Juan A. Navarro Perez authored
Nothing appears to be using this pageset_data. Benchmark was deleted at: https://chromium-review.googlesource.com/684416 Bug: 632021 Change-Id: Ic9f1ff242f97e79ac9faec80a7e98fba9dbc39be Reviewed-on: https://chromium-review.googlesource.com/744202Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#512596}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/1fc3c3b309d9..d2d4df84d3c2 $ git log 1fc3c3b30..d2d4df84d --date=short --no-merges --format='%ad %ae %s' 2017-10-30 dsinclair Rename report to cjs_report 2017-10-30 dsinclair Rename event to cjs_event 2017-10-30 dsinclair Rename console to cjs_console 2017-10-30 dsinclair Rename color to cjs_color 2017-10-30 dsinclair Rename app to cjs_app 2017-10-30 dsinclair Rename PublicMethods to cjs_publicmethods 2017-10-30 dsinclair Move JS_Value into JS_Define 2017-10-30 dsinclair Rename JS_Runtime_Stub to cjs_runtimestub 2017-10-30 dsinclair Move JS_Object to cjs_object 2017-10-30 dsinclair Rename Icon to cjs_icon 2017-10-30 dsinclair Rename Field to cjs_field 2017-10-30 dsinclair Rename Document to match class Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ifc2c413b0f217174ee2414733ec7b0d74648f18d Reviewed-on: https://chromium-review.googlesource.com/744314 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#512595}
-
Martijn Croonen authored
Bug: 624946 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4521dda8e15afb4c724432f99963aa8d83410503 Reviewed-on: https://chromium-review.googlesource.com/743010Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Martijn Croonen <martijnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#512594}
-
Ryan Hamilton authored
up to 20 times and record the results in a histogram. Change-Id: I75186530c562b994891cdcf81cd5323fdd076e40 Reviewed-on: https://chromium-review.googlesource.com/724182Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#512593}
-
Brian Osman authored
Bug: 776727 Change-Id: I401f31efa5a25033999e1cf5275275c7955fa41c Reviewed-on: https://chromium-review.googlesource.com/731323Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#512592}
-
Eric Lawrence authored
The code that coalesces multiple messages to a summary message lacked a space before the "M<XX>" string, but the regular expression that matches the input consumes a space, meaning that the replacement operation causes two words to run together. This CL adds a leading space to the replaced text. Bug: 779104 Change-Id: Id8399a584e2988755d46bd56402f3846fd59f49e Reviewed-on: https://chromium-review.googlesource.com/740979 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#512591}
-
Jun Cai authored
This CL moves some crashed tests to timed out tests to better categorize them. Bug: 769401 Change-Id: I92d7dff7a39c1eb02cf4aa9d62814cf887c52533 Reviewed-on: https://chromium-review.googlesource.com/742458 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#512590}
-
Yuwei Huang authored
Given that fixes in both MDC and GoogleKit have already been rolled into Chromium, the workaround is no longer needed. Bug: 766892 Change-Id: I2ba2b09c399bc845f867057c261125cbcc3444ea Reviewed-on: https://chromium-review.googlesource.com/740879Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#512589}
-
Hui(Andy) Wu authored
This change will change the autofill phone number rationalization to group fields in a form into sections first, then call the rationalization logic once per each sections. This will allow autofill of multiple phone numbers as long as they are in different sections(typically: billing vs shipping). Related change: Ia7084e63cadf676fba4af72fadcec73880be5579 Bug: 779585 Change-Id: I0224ea355836798537195852ddc44634ba813f89 Reviewed-on: https://chromium-review.googlesource.com/743688Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Hui Wu <wuandy@chromium.org> Cr-Commit-Position: refs/heads/master@{#512588}
-
Sammie Quon authored
This was needed previously at the end of some tests otherwise there will be a memory leak. The introduction of SplitViewTestWindowDelegate makes this not needed anymore. Test: ash_unittests SplitView* with asan and without Bug: 766725 Change-Id: I4e9754f541719fa23250ee7f691d345f5e58bdc5 Reviewed-on: https://chromium-review.googlesource.com/744291Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#512587}
-
Mohamad Ahmadi authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie818accb5c56a472ce424b442d13ee0a1dfa3a95 Reviewed-on: https://chromium-review.googlesource.com/741092Reviewed-by:
Marc-Antoine Courteau <macourteau@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#512586}
-
Avi Drissman authored
BUG=768475,768900,769351 TEST=as in bugs Change-Id: I1fb3244db8883e059e927e84ecca09dd3591f75d Reviewed-on: https://chromium-review.googlesource.com/687811Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#512585}
-
Hector Carmona authored
Bug: 764125 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If131619735e2e81b6d45837616b5a4e56ff6173f Reviewed-on: https://chromium-review.googlesource.com/740823 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#512584}
-
Emircan Uysaler authored
This CL adds MAIN and HIGH profile support. Bug: 779246 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5af448a35d2e8dfa97e0f30ea988f64ce74ad1ea Reviewed-on: https://chromium-review.googlesource.com/743023Reviewed-by:
Magnus Jedvert <magjed@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#512583}
-
Walter Korman authored
Bug: 771401 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie2dc6ec96574d47f44b03a11339b7f39ce3464a4 Reviewed-on: https://chromium-review.googlesource.com/740018 Commit-Queue: Walter Korman <wkorman@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#512582}
-
Donn Denman authored
The testTriggeringContextualSearchHidesFindInPageOverlay has been very flaky recently, and it looks like the problem is due to clicks in the content not triggering Contextual Search. There's probably a race condition between scrolling to put the word to click into view and scrolling for the Find target. The fix is to not type any Find target to avoid the scroll. BUG=765462 Change-Id: I007f7fa986e2528d7b7f9a4829be08c566572433 Reviewed-on: https://chromium-review.googlesource.com/742147Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#512581}
-
Peter Beverloo authored
When showing a non-persistent notification, the caller would receive a closure in return that could be used to close the notification after it had been shown. This system existed for two reasons: 1. There was an assumption that it could outlive the profile. 2. The notification's Id was not known to the //content layer. Both reasons have changed -- all notification code in //content and below is explicitly associated with a renderer, and thereby profile. The Id is generated within //content these days. We can therefore simplify the code by removing the closure, and instead extending ClosePersistentNotification to work with non-persistent notifications as well. BUG= Change-Id: I79530f4142c9926edab46b23cdba292c1b5e50d2 Reviewed-on: https://chromium-review.googlesource.com/744205 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#512580}
-
Tom Anderson authored
This is a correction to the (reverted) CL [1], which returned true from ShouldWindowContentsBeTransparent() whenever transparent visuals were supported. This broke tabstrip colors when using certain browser themes because TabStrip uses that function to decide if Aero Glass is enabled, and makes parts of the tabstrip partially translucent. This CL relaxes that function to only return true when the window itself is translucent. [1] https://chromium.googlesource.com/chromium/src/+/cd8bc9f0e7a14c70037b9b7245812674652f5971 BUG=758304 R=erg@chromium.org CC=thestig@chromium.org Change-Id: I57ea2421d19d0cf7d1b76f131cb3e79461c096b9 Reviewed-on: https://chromium-review.googlesource.com/742448Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#512579}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dd608e6f..d7dba58e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ie4aab1d0100e9df97b3e936e519de62af71189fe Reviewed-on: https://chromium-review.googlesource.com/743856Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#512578}
-
Hiroshige Hayashizaki authored
Bug: 771486 Change-Id: Ic9c98da7001ea320ee7bcd8ab7f92e90ce171b0a Reviewed-on: https://chromium-review.googlesource.com/734318 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#512577}
-
Becca Hughes authored
Fix the overflow menu by aligning it with the bottom right of the overflow menu icon. Update the text tracks menu to spec. BUG=761309 Change-Id: If4351029bf318ce3fe5a14874dc25e21b7f36a6e Reviewed-on: https://chromium-review.googlesource.com/723474 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#512576}
-
Min Qin authored
TBR=rdsmith@chromium.org Bug: Change-Id: I448de8134beafc1e4b12bf5d972c32952c917b29 Reviewed-on: https://chromium-review.googlesource.com/744425Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#512575}
-
src-internal-roller@chromium.org authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6107a9e99383..2c1ee306751c $ git log 6107a9e99..2c1ee3067 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=phajdan.jr@chromium.org Change-Id: Id6fdd42c9d8bc8488d00b22a4772d83aeb9a3c9b Reviewed-on: https://chromium-review.googlesource.com/744289Reviewed-by:
src-internal-roller . <src-internal-roller@chromium.org> Commit-Queue: src-internal-roller . <src-internal-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#512574}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 449262de. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/4296 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=leon.han@intel.com No-Export: true Change-Id: I2f7a438b7414a66b08c6d4b2fa1e061e2c927c19 Reviewed-on: https://chromium-review.googlesource.com/743808 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#512573}
-
Sarah Hu authored
Create LoginButton class as a base class for touch targets to enable ripple effects. This CL adds ripple to the following touch targets: 1. Dropdown menu button. 2. Submit button. 3. Pin keyboard button. Bug: 778740 Change-Id: Ifd856da4ada342d94511fd2ead11933468fa8750 Reviewed-on: https://chromium-review.googlesource.com/739960 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#512572}
-
Toni Barzic authored
BUG=767717 Change-Id: I96e2a7468188eaefe196ba87fb49061a88dd8e93 Reviewed-on: https://chromium-review.googlesource.com/742623Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#512571}
-
Steven Bennetts authored
This CL: * Moves network_siminfo to cr_components * Cleans up the detail dialog for Cellular and adds siminfo * Modifies the system tray to open the Settings UI (details dialog in the login screen) when the SIM is locked. Bug: 777778 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I664f8e5a4b7e5011c28cb188911d5b4e515809ad Reviewed-on: https://chromium-review.googlesource.com/740088Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#512570}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/c5503564d23f..1a5cf00f7634 $ git log c5503564d..1a5cf00f7 --date=short --no-merges --format='%ad %ae %s' 2017-10-30 perezju [Telemetry] Log memory usage on the host machine Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia5dc6ece6e2787e61235f7ebb353fa35e18d48a0 Reviewed-on: https://chromium-review.googlesource.com/744303 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#512569}
-
Helen Li authored
The DCHECK is not valid after recent refactoring which makes JobController to create jobs after proxy resolution (i.e. a JobController can have no pending Job when it is in proxy resolution.) UMA data show that having multiple hundreds of JobController is not indicative of memory leak, so this CL also adjusts the threshold for emitting UMA stats. Bug: 775253 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5f12ee5c16de51a87aaf7dd2aed6840801b5367a Reviewed-on: https://chromium-review.googlesource.com/743689Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#512568}
-
Charles Harrison authored
This patch does a few things: 1. Beef up the TestSafeBrowsingDatabaseHelper, so callers can optionally, pass in a custom TestV4GetHashProtocolManagerFactory. If this is null, then the helper will not mock the v4 hash protocol manager. This causes real API requests to go out to the network. 2. Make TestV4Store::MarkPrefixAsBad support multiple prefixes per prefix size. 3. Minor cleanups of names and std::make_unique 4. Add a new browser test suite for subresource_filter which uses the v4 embedded_test_server request handler, combined with the new TestSafeBrowsingDatabaseHelper, to mock out v4 API responses for the subresource filter list. This tests enforcement and warning variants. Bug: 775530,737201 Change-Id: Id26b676194fd33c28737bcb693e47ca75145f82f Reviewed-on: https://chromium-review.googlesource.com/730405Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#512567}
-
Yue Li authored
Skip the Playstore ToS screen if ArcShouldAwaysStart flag is set. Bug: b/68226368 Change-Id: Ie9bdee837df7beb24aa7bca74ca02a8b8f2e2eca Reviewed-on: https://chromium-review.googlesource.com/742135Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#512566}
-
Reza.Zakerinasab authored
Passing an ImageData that is created from U16/F32 data but does not have a color settings to ImageDataInCanvasColorSettings results in a crash. This change temporarily fixes this until the proper color space (extended-srgb) is provided. Bug: 779419 Change-Id: I491fa86f53b73473cba514512e64de69db49fc91 Reviewed-on: https://chromium-review.googlesource.com/743804Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#512565}
-
David Reveman authored
Use flipped image instead of relying on css transform for image preview. This allows both the grid image and the image preview to be displayed correctly. Bug: 779519 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icd0fb45f1dc433d490f24d5342c250197e96c11b Reviewed-on: https://chromium-review.googlesource.com/743693Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#512564}
-
Leonard Grey authored
This hits a NOTIMPLEMENTED on Windows: https://bugs.chromium.org/p/chromium/issues/detail?id=726505#c10 Restricting it to the platforms that have an implementation in process_metrics.cc Bug: 649641 Change-Id: I02648ae4b09ac24fad6ec6894db91b5a82939f92 Reviewed-on: https://chromium-review.googlesource.com/734360 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#512563}
-
Theresa Wellington authored
In BottomSheetContentController#onSheetContentChanged() we were previously destroying bottom sheet contents based on the sheet state. It is possible for the sheet transitions to non-home content after the state is set to peek e.g. user taps on a suggested article and a bottom navigation icon at the same time. Only destroy sheet contents if the sheet is currently showing the home content. BUG=779470 Change-Id: Iffd2f5972bff4bf6cd84df72fa8efa072d35ff09 Reviewed-on: https://chromium-review.googlesource.com/744309Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#512562}
-