- 20 Oct, 2020 40 commits
-
-
Benjamin Beaudry authored
Some elements were skipped by Narrator because NormalizeTextRange called in AXPlatformNodeTextRangeProviderWin::GetAttributeValue modify the internal endpoints, while Narrator doesn't expect the range to be modified in a function like GetAttributeValue. In this CL, we now operate NormalizeTextRange on a clone of the |start_| and |end_| endpoint and use the normalized endpoints to get the attribute value. We do the same in FindAttribute. In ExpandToEnclosingUnit, Narrator does expect the range to be modified so I believe it makes sense to normalize the internal endpoints. Bug: N/A Change-Id: Ie202a7ee3e4b4e08c95c6361260c54b941c85b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481743Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Victor Fei <vicfei@microsoft.com> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#818972}
-
Xing Liu authored
We are still doing A/B testing for query tiles for different set of configs. This CL extends the expiration date to M91. Bug: 1125748 Change-Id: I6da6774bc3d9f59132016440e0047f6bc88680f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485876Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818971}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/429410096af9..cdba9badd3b3 2020-10-20 tvanderlippe@chromium.org Disallow editors of reading legacy file symbols 2020-10-20 andoli@chromium.org [ts] Typecheck snippets/ScriptSnippetFileSystem.js with TypeScript 2020-10-20 kimanh@chromium.org Adding linear memory inspector navigator component 2020-10-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-20 tvanderlippe@chromium.org Move startup files to GN If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1110202,chromium:1131500 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7a2de059204d637939973b394475590406297839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487168Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818970}
-
Lukasz Anforowicz authored
Motivation for this CL ====================== Before this CL url_formatter::FixupURL could transform URLs of renderer-initiated navigations. This may have allowed an attacker to "launder" URLs past early filters (if the initial URL provided by the attacker looks benign, but after passing the filters is transformed by FixupURL into a malicious form). The following bugs in the past seem to have been at least partially enabled by this transformation: - Laundering a "javascript:" URL: https://crbug.com/1116280 and https://crbug.com/850824 - Omnibox spoof due to the modified url: https://crbug.com/449829 and https://crbug.com/657720 - Invariant violation due to a difference between virtual url and regular url: https://crbug.com/895065 Before this CL, url_formatter::FixupURL was called for renderer-initiated navigations via WillHandleBrowserAboutURL. This doesn’t seem necessary per the TODO in this function asking to "Eliminate "about:*" constants [...] then hopefully we can remove this forced fixup". Note that BrowserURLHandler::SetFixupHandler has been introduced in r316923 as a workaround to ensure URL consistency by adding FixupURL in one more place. If FixupURL wouldn’t be called from WillHandleBrowserAboutURL, then BrowserURLHandler::SetFixupHandler wouldn’t be needed in the first place. Finally, https://crbug.com/1130091#c3 points out that url_formatter::FixupURL should only be invoked on user input (e.g. URLs typed into the omnibox and used for browser-initiated navigations) rather than on arbitrary URLs. Summary of changes in this CL ============================= Based on the above, the CL: - Removes the FixupBrowserAboutURL call from WillHandleBrowserAboutURL - Removes the BrowserURLHandler::SetFixupHandler method and related code - Fixes tests so that they use the final URL form (rather than relying on the FixupURL call) - Adjusting expectations of tests that were testing laundering scenarios The CL also opportunistically: - Simplifies WillHandleBrowserAboutURL (path transformations were a no-op; early return for kChromeUISettingsHost and kChromeUIHelpHost can be consolidated) Testing ======= Manual testing: - Verified that "about:version" typed into the omnibox still ends up navigating to "chrome://version/" - Verified that renderer-initiated navigations to "about:version" are translated into "about:blank#blocked" by RenderProcessHostImpl::FilterURL Bug: 1130091 Change-Id: I9a9f32d4d9c0ec630c2110679efe0c1d18b4370b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441284Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#818969}
-
Vincent Boisselle authored
Change-Id: Ia01b8458da01d15fdf15beefbfa75c5b01a6fc12 Bug: 1138000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469517 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#818968}
-
Gang Wu authored
Bug: 1138729 Change-Id: I5c9b3cbf04e5bfebcc71d4ef1248da179f0ef8ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481058 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#818967}
-
Wenbin Zhang authored
Before making changes on how to generate the shard map to run the same benchmarks on multiple devices, manually update the shard map to try things out. This also allow starting to work on merging results from multiple devices. Bug: chromium:1140389 Change-Id: Ic89b82e642d8fb11be889acd372edf22dd96c7d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486576 Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#818966}
-
Clemens Arbesser authored
This makes it easier to control the amount of data we send in the RPC. It's also cleaner this way, and furthermore, this is in preparation for a new RPC, which lite_service will communicate with, but service_impl will not. Bug: b/171178550 Change-Id: Idbab2402ede4f4473575baf4254ed0cc13d0c7e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485254 Commit-Queue: Clemens Arbesser <arbesser@google.com> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#818965}
-
Jesse Schettler authored
For each scan source reported by lorgnette, use its scannable area to determine the page sizes it supports. Add these page sizes to each ScanSource reported by ScanService. Bug: 1059779 Change-Id: Id909260f2de8eeebf15d1d67776403c993b81c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481742Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#818964}
-
Dominik Röttsches authored
We still want to track DirectWrite stability and timings. Fixed: 1138262, 1138263, 1138264, 1138265, 1138266, 1138267, 1138268, 1138269, 1138270, 1138271, 1138272 Change-Id: I9515e25d26093bc98830b716311b4714e0c3d941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475795 Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#818963}
-
Hidehiko Abe authored
According to the spec, it is expected that preedit_string is sent only when the preedit is updated. Bug: 1139731 Test: Test manually with SHIFT+LEFT + JP IME. Ran exo_unittests. Change-Id: I650ac18b585c00901671633e0f50221fd84ac66f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485666Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#818962}
-
Dave Tapuska authored
A lot of the core functionality has moved into blink. Yet a number of using and include definitions were left behind. BUG=1097816 Change-Id: I03092d6f2944d1aab549c89673f7bc7e6cfbef81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487221Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#818961}
-
Victor-Gabriel Savu authored
Allow fake login to continue without an OAuth cookie to fix the fake enterprise enrollment. Bug: chromium:1140422 Test: tast run <ip> policy.SystemTimezone Change-Id: I75985607421c370c610336b1afbcf5b7c708da89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487268 Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#818960}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cd74dfa47721..13fa34606b78 2020-10-20 kjlubick@google.com [infra] Sync to latest infra repo. 2020-10-20 bsalomon@google.com Remove legacy SkImageGenerator YUV planes interface 2020-10-20 johnstiles@google.com Improve gencode for inlined blend and composition functions. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: I442fb2041043b59099020da2ad04969b4470ecf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487209Reviewed-by:
-
Tommy Li authored
This CL is a followup to: https://chromium-review.googlesource.com/c/chromium/src/+/2485561 It ports one more browser test to a unit test. Bug: 751031 Change-Id: I56928ef473e3a14982c2fec0d900176c3175de9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485562 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#818958}
-
Antonio Gomes authored
... and rename it to ImmersiveModeControllerChromeos. CL also adapts chrome::CreateImmersiveModeController(), the helper that create instances of ImmersiveModeController (see immersive_mode_controller_factory_views.cc). This is phase 3, on the design document [1]. [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/ BUG=1113900 R=jamescook@chromium.org, sky@chromium.org Change-Id: I9d13060bae1098ff7026b65e21545373503cc4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486114 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#818957}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010200700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/U-5IIfB8vy39NvpI83unV6yKRSTL446Zw5cBERt3kGgC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/168563701,b/169509246,b/170161460 Tbr: media-app@grotations.appspotmail.com Change-Id: I0aac44facb2dfa655945cdf570c413268961b6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487164Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818956}
-
James Cook authored
Lacros gets its initial metrics consent state from ash. Older versions of ash didn't send this data, so we would open a first-run dialog to ask again if the user wanted to send metrics. Ash now always sends the data, so clean up the code that opens the dialog. Bug: 1131164 Test: manual, lacros inherits metrics consent from ash Change-Id: I75384f03b3cec28293c8ee019e0c57e817a8dc8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481960Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#818955}
-
Viktor Semeniuk authored
Bug: 1140400 Change-Id: I88e442649ce0fb0844f1a2633a81a27df6b58018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487128 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#818954}
-
Prakhar authored
Bug: 1139007 Change-Id: I4307e52114f1cc7a9d18c760014e06e23651708e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477613 Commit-Queue: Prakhar Asthana <pasthana@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Prakhar Asthana <pasthana@google.com> Cr-Commit-Position: refs/heads/master@{#818953}
-
Anders Hartvoll Ruud authored
Wrap CSSValue and the corresponding TreeScope from MatchResult in a ScopedCSSValue passing it to StyleBuilder. Currently use a nullptr TreeScope in the cases where we don't have one to look up tree-scoped references. We do not support such names/ references in UA stylesheets. We currently support @keyframes in user stylesheets, but collect them from the StyleEngine regardless of which scope the animation-name came from. It would be possible to have a TreeScope for user sheets (and even UA sheets) and use ScopedStyleResolvers instead of extra structures in StyleEngine. For now pass null TreeScopes for UA and user style values. Bug: 336876 Change-Id: I033c503aa92178a0c32efdac861ddf606ceb2cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484656Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#818952}
-
Peter Kotwicz authored
This CL: - Makes fetch_all_androidx.py generate //third_party/androidx/cipd.yaml with all of the files that the bot should upload. This includes: - for each library: aar, LICENSE, README.chromium - //third_party/androidx/BUILD.gn - //third_party/androidx/additional_readme_paths.json - Makes fetch_all_androidx.py work if //third_party/androidx/BUILD.gn does not exist. - Makes fetch_all_androidx.py fail if fetch_all.py subcommand fails. BUG=1064277 Change-Id: I423763f9a1a4cf8328ca6133f0ead52dcad9b0f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462674 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#818951}
-
Chris Lu authored
This change fixes most of the multiwindow resizing bugs for the Smooth Scrolling viewport feature. See video for one remaining issue. Video: https://drive.google.com/file/d/1a_1-NTtp1NUIKhf2bnxzuhSKkUcQsynR/view?usp=sharing Bug: 1121527 Change-Id: I911ab6f8efd103650a35617eebc1a85c189908a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477597 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#818950}
-
Michael Moss authored
Some tools need to be used both when creating diffs and when installing diffs, so need to support the archs of both the target system and the system generating the diffs. These are generally the same thing, but when cross-compiling for arm64 on x86, it requires universal binaries. BUG=1119472 Cq-Include-Trybots: luci.chromium.try:mac-rel,mac-arm64-rel Change-Id: Ic329561b8f034477d491121e507ba34821419516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462242 Commit-Queue: Michael Moss <mmoss@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#818949}
-
Boris Sazonov authored
Extends "Profile.AndroidAccountManagementMenu" histogram by 6 months. Bug: 1127958 Change-Id: Id3aad1a26848a3ea0267aa3dafc8cd3f07e031f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479171 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I26c5d5fed4b6a4e85373efafde52549a329de200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487170Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c4593127cbdd..e557087870b0 2020-10-20 cwallez@chromium.org CMakeLists: make DAWN_THIRD_PARTY_DIR an option. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: If43a048eb320501bff73d60bde087f09bdb3bf0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487165Reviewed-by:
-
Aaron Tagliaboschi authored
Implement the Critical-CH response header as a URL Loader throttle. This restarts/internally redirects the request when it sees a Critical-CH header is can honor, as defined in the Client Hint Reliability explainer. https://github.com/WICG/client-hints-infrastructure/blob/master/reliability.md#critical-ch Bug: 1127313 Change-Id: I3987d8d385f078ecb781a5895ab637522c8c8261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405697 Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#818945}
-
rbpotter authored
Bug: 1132403 Change-Id: I7c86e8e57dd780e04fb2fb8d67dd33940cbe9ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486681Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#818944}
-
Josh Nohle authored
Always include the logged-in account in the list of contacts uploaded to the Nearby Share server. Also, mark this contact as "selected". This automatically enables sharing with other devices logged in with the same account. This self-sharing works in all- or selected-contacts visibility modes. Previously, to enable self-sharing, a user would need to manually add their own account to their list of contacts at contacts.google.com, for instance. Verified fix with manual testing. Fixed: 1138679 Change-Id: Ib3a2137257e4d4c56a43011d747811f522d9ad40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487244 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#818943}
-
Sorin Jianu authored
This function returns the version of the active updater. Bug: 1140270 Change-Id: I1e6fea77cb33be879cf5d8a0e148f0bdea1ca56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485554Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#818942}
-
Yifan Luo authored
Bug: 1116418 Change-Id: Idfc4a634a12b354c0aa96c0cf5f2516138b38235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475814 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#818941}
-
Fergal Daly authored
http://cl/338053345 is updating the experiment to include disabling SkipEarlyCommitPendingForCrashedFrame and this change is needed alongside it. Bug: 1072817,1139104 Change-Id: Ie2c54557d85ba0fbbe1a494626602f6f8daaf583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486009 Commit-Queue: Fergal Daly <fergal@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#818940}
-
Rune Lillesveen authored
This implements the style support for the pseudo element. The paint code needs to query the pseudo style during painting and paint invalidation needs to be added. Bug: 1136817 Change-Id: I933c4de5f473c25000f9a34efa00a5af2cc52232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463563Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#818939}
-
Sebastien Lalancette authored
On iPad, the Activity View popover needs to point to the start of the selected text for Shared Highlight (like what the default "Share..." action does). To do so, we needed to retrieve the client rect from JavaScript, convert it to the browser UI's coordinates, and then set the values on the UIActivityViewController's popover controller. Bug: 1136043 Change-Id: I95a1ced0a019524b76c3ad4995068f58755acb0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463324 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#818938}
-
Leonard Grey authored
Bug: 1014639 Change-Id: Idb0efe25b4a02432bbc4f07f29ac1fba963e600f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486092 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Leonard Grey <lgrey@chromium.org> Reviewed-by:
-
Colin Blundell authored
This CL adds the subresource_filter namespace to classes that were recently moved from //chrome to //components/subresource_filter. Bug: 1116095 Change-Id: I91a27afcc8a70e101d53042d69dd5dbbd517be74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484426Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#818936}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0c84d564df9f..b1ac88b6534f 2020-10-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 7e1825a59619 to 6fac705e7616 (6 revisions) 2020-10-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from f4f1d8a352ca to 3ead01191215 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I089eb77b719f500e9af4b812f3a5a06664ac9b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487144Reviewed-by:
-
Sebastien Lalancette authored
Two cases: - A simple page with two fragments in the URL. - A very long page, to force a scroll to occur. Bug: 1116463 Change-Id: I64c30542971e82f7b941b6d40d6b266f4435a0cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485573Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/19640aa61b04..1d0e7b6bbe17 2020-10-20 glahiru@webrtc.org Remove usage of "use_ios_simulator". If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2b148e0c6da999720c8be31bc5ea61ce1132fc44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487147Reviewed-by:
-
