- 09 Aug, 2018 40 commits
-
-
Mohamed Amir Yosef authored
Bug: 516866 Change-Id: Ib91eb840c937e0aa6a7056a1d68555a02bbdac4c Reviewed-on: https://chromium-review.googlesource.com/1167509 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#581801}
-
Yuwei Huang authored
This is part of the work of refactoring the iOS audio playback logic. This CL implements the AudioPlaybackSink for iOS using the AudioQueue API. The implementation is following Apple's guide for the playback process: https://developer.apple.com/library/archive/documentation/MusicAudio/Conceptual/AudioQueueProgrammingGuide/AboutAudioQueues/AboutAudioQueues.html#//apple_ref/doc/uid/TP40005343-CH5-SW22 In the next CL there will be an AudioPlaybackStream class that connects the AudioJitterBuffer with AudioPlaybackSinkIos. Bug: 868088 Change-Id: Ifbaa08bfcf5f983587bfb71418c681001ab7cdca Reviewed-on: https://chromium-review.googlesource.com/1166246 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#581800}
-
Noel Gordon authored
Use the menu #share-menu:not([hidden]) prefix in the share button/menu dialog test case flow to avoid CSS matching hidden menus that have the same command |id|. None do at the moment, but the |id| "#share" is too generic, so a more precise CSS selector prevents future bugs (when we have something else to "#share" in future, which seems plausible). Minor: remove old TODO and its associated test step: the mocked shared dialog is 300 x 100px, no need to measure/worry about its size. Minor: use !!result when checking remote call return results. Bug: 872119 No-try: true Change-Id: I504421ebd4c2e9a6d0cece351b9f2bed8defde35 Reviewed-on: https://chromium-review.googlesource.com/1167924Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#581799}
-
Scott Violet authored
This reverts commit 93a3a4b3. Reason for revert: msan issue was fixed and landed (and wasn't triggered by this patch). Reverting the revert to reland. Original change's description: > Revert "window-service: makes objects using Env take Env (or get from WindowService)" > > This reverts commit 04308f3d. > > Reason for revert: Patch earlier in the chain caused failures on msan bot. > > Original change's description: > > window-service: makes objects using Env take Env (or get from WindowService) > > > > This allows for multiple Envs at the same time. > > > > BUG=847992 > > TEST=covered by tests > > > > Change-Id: I20dda0f7e3fde50027c9c867562718e49152d238 > > Reviewed-on: https://chromium-review.googlesource.com/1167654 > > Reviewed-by: Michael Wasserman <msw@chromium.org> > > Commit-Queue: Scott Violet <sky@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#581701} > > TBR=sky@chromium.org,msw@chromium.org > > Change-Id: If149ac9dc90f0ef6cec5e59f744cd0c3189d01e6 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 847992 > Reviewed-on: https://chromium-review.googlesource.com/1168402 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581715} TBR=sky@chromium.org,msw@chromium.org Change-Id: Id10e4d33b7cf619b4e14f1ed4c8f604cd2c96591 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 847992 Reviewed-on: https://chromium-review.googlesource.com/1168326Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#581798}
-
Scott Violet authored
This reverts commit 07aab203. Reason for revert: msan issue was fixed and landed (and wasn't triggered by this patch). Reverting the revert to reland. Original change's description: > Revert "wm/views: makes objects using Env take Env" > > This reverts commit 9feb99aa. > > Reason for revert: a patch earlier in the chain caused msan failures. > > Original change's description: > > wm/views: makes objects using Env take Env > > > > This allows for multiple Envs at the same time. Additionally: > > . NativeWidgetPrivate::CreateNativeWidget: now takes InitParams > > . NativeWidgetPrivate::IsMouseButtonDown() is now an member function. > > > > BUG=847992 > > TEST=covered by tests > > > > Change-Id: Ic35b274c0a927a7c602809a7e611383b5d3dd3e2 > > Reviewed-on: https://chromium-review.googlesource.com/1166148 > > Commit-Queue: Scott Violet <sky@chromium.org> > > Reviewed-by: Michael Wasserman <msw@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#581621} > > TBR=sky@chromium.org,msw@chromium.org > > Change-Id: I9410bf471a71d07b32f49a139b7afa9ced0f3fea > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 847992 > Reviewed-on: https://chromium-review.googlesource.com/1168403 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581716} TBR=sky@chromium.org,msw@chromium.org Change-Id: I1fcd75fb66d00693dfc2e0b78e871848a335319a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 847992 Reviewed-on: https://chromium-review.googlesource.com/1168566Reviewed-by:
-
Scott Violet authored
This reverts commit c179496f. Reason for revert: The test failure was fixed at https://chromium-review.googlesource.com/c/chromium/src/+/1168466 . The failure was a lingering issue and not caused by patch (but triggered by my patch), so reverting the revert. Original change's description: > Revert "aura: makes each Window be associated with an Env" > > This reverts commit 99df3b26. > > Reason for revert: Caused failures on msan bot. > > Original change's description: > > aura: makes each Window be associated with an Env > > > > This is to avoid using Env::GetInstance(), so that there can be multiple > > Envs created at once. > > > > BUG=847992 > > TEST=covered by tests > > > > Change-Id: I2e2604c8f8a356ca9cc6771ed050ef8431e7b840 > > Reviewed-on: https://chromium-review.googlesource.com/1165861 > > Commit-Queue: Scott Violet <sky@chromium.org> > > Reviewed-by: Michael Wasserman <msw@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#581568} > > TBR=sky@chromium.org,msw@chromium.org > > Change-Id: I50fb5f0d27011219ed2569b1035a78e01b9b3de9 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 847992 > Reviewed-on: https://chromium-review.googlesource.com/1168323 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581718} TBR=sky@chromium.org,msw@chromium.org Change-Id: I83e61d6ca9de8dcd023757f03bb18f0abf09790e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 847992 Reviewed-on: https://chromium-review.googlesource.com/1168565Reviewed-by:
-
Trent Apted authored
JS files don't name their `#includes`, but for closure compilation we must effectively list each .js file's #includes in build dependencies. We can use this to generate the list of .js files, in the correct order, that we use for js unittests. Manually creating the foo_unittest.html files is fiddly, error-prone, and is not robust to files being moved around. However, it does require the unittest js file to be properly closure-compiled. Start by obsoleting the 3 foo_unittest.html files in gallery/image_editor, which are the only ones currently closure- compiled. Note that the dependency files are created _regardless_ of the `closure_compilation = true` gn flag. i.e. this does not introduce a dependency on the closure _compiler_: dependency information comes from the GN build files alone. The closure_compilation flag only affects the js_type_check(..) targets, but the approach here uses js_library(..) targets. Bug: 867700 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I91b3a726b999a9f7db721fefc23b3f6512fd3c0c Reviewed-on: https://chromium-review.googlesource.com/1161720Reviewed-by:
-
Bo Liu authored
Change-Id: Ic9f5deeb77213bf58e3706983e2291955b84f519 Reviewed-on: https://chromium-review.googlesource.com/1167544Reviewed-by:
-
David Jacobo authored
ARC apps are added to the context menu to allow the user to handle certain urls via an installed app. However these apps shoudln't be added to such UI while in incognito mode, this CL enforces that. Bug: b/112107069 Test: Try. Change-Id: I200e38403f07301fb5d90fd6a381c57a0d150872 Reviewed-on: https://chromium-review.googlesource.com/1168146Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#581793}
-
Scott Violet authored
This reverts commit 3882e0ff. Reason for revert: *SIGH* reverted wrong revert, relanding. Original change's description: > Revert "views: changes test to not use equality" > > This reverts commit 72a83a6c. > > Reason for revert: The text failure was fixed at https://chromium-review.googlesource.com/c/chromium/src/+/1168466 . The failure was a side effect of my change and a lingering issue, so reverting the revert. > > Original change's description: > > views: changes test to not use equality > > > > This test was assuming a newly created Window got a pointer value different > > than one recently destroyed. For whatever reason my recent patch made it more > > likely (on the msan bot) that the newly created pointer got the same value as > > the one destroyed, leading to failure. > > > > I'm converting the test to verify the window is destroyed using a WindowTracker. > > > > BUG=847992 > > TEST=covered by tests > > > > Change-Id: I4f9f64ad59ae15b0314619a93935d7e85bb6d8e7 > > Reviewed-on: https://chromium-review.googlesource.com/1168466 > > Reviewed-by: Michael Wasserman <msw@chromium.org> > > Commit-Queue: Scott Violet <sky@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#581788} > > TBR=sky@chromium.org,msw@chromium.org > > Change-Id: I902ae7e85e8a40e5d682a332b2a7171eb233c300 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 847992 > Reviewed-on: https://chromium-review.googlesource.com/1168762 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581791} TBR=sky@chromium.org,msw@chromium.org Change-Id: I3f26795a5a5959ad38949cc451591f34539f2141 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 847992 Reviewed-on: https://chromium-review.googlesource.com/1168763Reviewed-by:
-
Scott Violet authored
This reverts commit 72a83a6c. Reason for revert: The text failure was fixed at https://chromium-review.googlesource.com/c/chromium/src/+/1168466 . The failure was a side effect of my change and a lingering issue, so reverting the revert. Original change's description: > views: changes test to not use equality > > This test was assuming a newly created Window got a pointer value different > than one recently destroyed. For whatever reason my recent patch made it more > likely (on the msan bot) that the newly created pointer got the same value as > the one destroyed, leading to failure. > > I'm converting the test to verify the window is destroyed using a WindowTracker. > > BUG=847992 > TEST=covered by tests > > Change-Id: I4f9f64ad59ae15b0314619a93935d7e85bb6d8e7 > Reviewed-on: https://chromium-review.googlesource.com/1168466 > Reviewed-by: Michael Wasserman <msw@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581788} TBR=sky@chromium.org,msw@chromium.org Change-Id: I902ae7e85e8a40e5d682a332b2a7171eb233c300 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 847992 Reviewed-on: https://chromium-review.googlesource.com/1168762Reviewed-by:
-
Marijn Kruisselbrink authored
Not perfect, since this really should be going through the mojo interface for dealing with blobs, but a lot better than going through blob URLs. Tbr: reillyg@chromium.org Bug: 859594, 868462, 804546 Change-Id: Ifd7cd11b7bf4432eff41bdef00edd079d31e49c6 Reviewed-on: https://chromium-review.googlesource.com/1164523 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#581790}
-
Steve Anton authored
Bug: 864871 Change-Id: I8e7b6f33685625b831ea326737d605ffc813288b Reviewed-on: https://chromium-review.googlesource.com/1153477 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#581789}
-
Scott Violet authored
This test was assuming a newly created Window got a pointer value different than one recently destroyed. For whatever reason my recent patch made it more likely (on the msan bot) that the newly created pointer got the same value as the one destroyed, leading to failure. I'm converting the test to verify the window is destroyed using a WindowTracker. BUG=847992 TEST=covered by tests Change-Id: I4f9f64ad59ae15b0314619a93935d7e85bb6d8e7 Reviewed-on: https://chromium-review.googlesource.com/1168466Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#581788}
-
Noel Gordon authored
Use the menu #file-context-menu prefix in file menu command queries to avoids CSS matching hidden menus that have identical command |id|, for example cut/copy/paste. Minor: zip_files.js's #zip-selection menu case is specific enough that we don't need the :not([hidden]) if we add remote call result checking to the zip test code to verify #zip-selection command clicks. Remove old TODO(), reviewers advised the issue was fixed with the meta data mambo jambo cleanup/changes/fixes (see issue 867974). Bug: 872119 No-try: true Change-Id: I611f3a5403cbe724fa0687204c046ed2e6fffd89 Reviewed-on: https://chromium-review.googlesource.com/1167344 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Darren Shen authored
In a previous patch [1], we changed the anchor insets for tray bubbles so that when the keyboard is shown, bubbles show above the keyboard. However, this causes a subtle bug with the accessibility virtual keyboard. When we open the accessibility VK, the status area / shelf moves downwards. We then show a bubble, which is positioned correctly relative to the VK due to [1]. However, when we hide the VK, the status area / shelf moves upwards. Because the bubble is anchored to the status area / shelf and still has the same insets, it will move up as well. To fix this, we change the bubble anchor bounds to return either the status area bounds or the virtual keyboard bounds depending on whether the keyboard is visible. [1] https://crrev.com/3e3220d49f21fc41dcc51e21c3680d7853fb3d38 Bug: 871718 Change-Id: I8f24e2ff26f8912f579c386755de8af512c6ed1d Reviewed-on: https://chromium-review.googlesource.com/1166766Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#581786}
-
Noel Gordon authored
Use the menu #tasks-menu:not([hidden]) prefix to ensure that the menu is visually displayed. Bug: 872119 Change-Id: Ia601f3e601b7a243d7613f798696da09763fc308 Reviewed-on: https://chromium-review.googlesource.com/1167346Reviewed-by:
-
Ramin Halavati authored
Preferences related to ChromeOS Drive are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: Ic2be139b20c90b7a372560c682d34dad527c9e62 Reviewed-on: https://chromium-review.googlesource.com/1166824Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#581784}
-
Ramin Halavati authored
Preferences related to ChromeOS language remap are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I86da7605639c1d7f8bc0baf5bfbcd4aac573f020 Reviewed-on: https://chromium-review.googlesource.com/1166822Reviewed-by:
-
yiyix authored
Added frame metrics analysis to LayerTreeHostImpl. The frame presentation callback times are sent to frame metrics for every nth scrolling. Bug:851088 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I32aee9b5401c056ed3be64e17a45cc1958188199 Reviewed-on: https://chromium-review.googlesource.com/1147921 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#581782}
-
Stefan Zager authored
Previously, when EventHandler propagated the hit test up to the local root frame, it failed to propagate the no_lifecycle_update flag, which inadvertently triggered a lifecycle update (causing DCHECK failures in some cases). Also, when the hit test code traversed into a child document inside an iframe, it didn't propagate the stop_node field from the original hit test request, so the hit test inside the iframe didn't honor the stop node. BUG=827639 R=chrishtr@chromium.org Change-Id: Ib29f26e41b945b53db6e427d41a03742af0ee4db Reviewed-on: https://chromium-review.googlesource.com/1167746Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#581781}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/964e15665fbc..74182d1df594 git log 964e15665fbc..74182d1df594 --date=short --no-merges --format='%ad %ae %s' 2018-08-08 primiano@google.com Merge "Hover CPU slices" 2018-08-08 primiano@google.com Merge "Overview timeline panning and bounds clipping" 2018-08-08 primiano@google.com TraceProcessor: implicitly add main thread to each process Created with: gclient setdep -r src/third_party/perfetto@74182d1df594 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ic54b7ce48c6cb4f6aa22dee02db42794a19ac456 Reviewed-on: https://chromium-review.googlesource.com/1167871Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581780}
-
Ken Rockot authored
This causes blink::ResourceLoader::Dispose() to close the object's blink.mojom.ProgressClient binding, preventing incoming IPCs from being dispatched to the finalized object in the interim between finalization and actual destruction. Bug: 867370 Change-Id: I9a14c51cb5d75e11b211006d094d73beafab8922 Reviewed-on: https://chromium-review.googlesource.com/1168289Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#581779}
-
Mounir Lamouri authored
Bug: 870853 Change-Id: Ib1621a1016d226f03d10a745dfb35a2c9cfe5dec Reviewed-on: https://chromium-review.googlesource.com/1166337 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#581778}
-
Alexander Alekseev authored
This CL fixes problem with owner account_id, which some time was initialized to legacy email-only version. This Cl ensures it has full account_id of a known user. Bug: 871931 Change-Id: Ie8bdbeddac31c540f67869333efc9f7b921c80e0 Reviewed-on: https://chromium-review.googlesource.com/1168192Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#581777}
-
Charlie Andrews authored
This API is similar to the way that overriding is currently done in Blink (e.g. https://goo.gl/2Fj8sB) and should help pave the way for a migration off of Blink's ScopedMockClock. Blink's ScopedMockClock is especially awkward because it relies on code throughout Blink to use CurrentTimeTicks() instead of TimeTicks::Now(). If TimeTicks::Now() is used directly (as it is in numerous places throughout Blink - see https://goo.gl/B42P1P), then the override is ignored, causing strange behaviors in test. ScopedTimeClockOverrides is also awkward for the typical case of setting a global mock clock and periodically advancing it in tests. This new ScopedMockClockOverride obviates the need for a helper global variable or function to override Time or TimeTicks in tests. This solution was discussed with jbroman@ and others in https://goo.gl/AT4qs5 and I volunteered to take it on. Bug: 866930 Change-Id: I14ba5a7eab8a246851477357d34bae7fb4ca5c50 Reviewed-on: https://chromium-review.googlesource.com/1148581Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#581776}
-
Eric Roman authored
Use blink::Platform::CreateMainThreadAndInitialize() to create and own the main thread. Bug: 872240 Change-Id: I53c8ad6875aecf83246f8077e03eed6482d36be4 Reviewed-on: https://chromium-review.googlesource.com/1168194Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#581775}
-
Takuto Ikuta authored
If data dependency contains entire pytwebsocket directory, input for test execution on swarming contains .git directory. https://bugs.chromium.org/p/chromium/issues/detail?id=869348#c29 This makes it difficult to do test execution cache sharing between different builds. This CL changed only depend on src/mod_pywebsocket instead. R=yhirano@chromium.org, jam@chromium.org Bug: 869348 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I435874f73063ec6cc14b2285806b0e237cd2a940 Reviewed-on: https://chromium-review.googlesource.com/1167009Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Wenzhao Zang authored
The name and comments of these methods are outdated, and it has caused some confusion for the overview mode and views-based login development. Bug: NONE Change-Id: I76add69fc0ad7c00216e10c687862411abc9b519 Reviewed-on: https://chromium-review.googlesource.com/1168000Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#581773}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I8e4a8405c4b21e32f00348fa0144566551a8fd92 Reviewed-on: https://chromium-review.googlesource.com/1168451Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#581772}
-
Koji Ishii authored
This patch changes the constructor to take a StringView, so that callers can create the iterator without allocating a string. Bug: 636993 Change-Id: I68952e2d685a1c2712700a999f98ad6c9c06f4a0 Reviewed-on: https://chromium-review.googlesource.com/1165276 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#581771}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e41df534852b..7b17cdf98449 git log e41df534852b..7b17cdf98449 --date=short --no-merges --format='%ad %ae %s' 2018-08-08 vapier@chromium.org infra_libs: drop dead code 2018-08-08 haddowk@chromium.org generic_stages: Restrict pre-cq image copies from moblab buckets. 2018-08-08 gmeinke@google.com default GetLuciAuth to latest SHA1 version Created with: gclient setdep -r src/third_party/chromite@7b17cdf98449 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I749c8732480919a941c8fea47a81d378fbb072c3 Reviewed-on: https://chromium-review.googlesource.com/1167868Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581770}
-
Noel Gordon authored
Use the menu #directory-tree-context-menu:not([hidden]) prefix when we execute directory tree menu commands: avoids CSS matching hidden menus that have identical command |id| (e.g., cut/copy/paste). Minor: add chrome.test.assertTrues to verify remote call return values for the #directory-tree-context-menu focus/click operations. Bug: 872119 Change-Id: I6ae20e3f9ae20e9826bc16a97afbfa97a1b8b46f Reviewed-on: https://chromium-review.googlesource.com/1167345Reviewed-by:
-
Christian Biesinger authored
The float->LayoutUnit conversion is surprisingly expensive R=eae@chromium.org Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0aeb88ed69e9324512017cc7b376d2313eaa4b58 Reviewed-on: https://chromium-review.googlesource.com/1168088Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c86c8b0cecf0..c43cdad25851 git log c86c8b0cecf0..c43cdad25851 --date=short --no-merges --format='%ad %ae %s' 2018-08-08 jmadill@chromium.org StateCache: Make external API easier to understand. 2018-08-08 jmadill@chromium.org Validate transform feedback conflicts on zero draw. 2018-08-08 jmadill@chromium.org Refactor ValidateDrawBase. 2018-08-08 jmadill@chromium.org Add a perf test for draw calls with texture changes. 2018-08-08 jmadill@chromium.org Fix vertex array element limit condition. 2018-08-08 jmadill@chromium.org Don't use ErrorOrResult in VertexBuffer.h. Created with: gclient setdep -r src/third_party/angle@c43cdad25851 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: If3f30a2ba53ee0d4a877ba36059d269d79bd9814 Reviewed-on: https://chromium-review.googlesource.com/1167866Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581767}
-
Yue Cen authored
show when the page is first loaded. Bug: 835029 Change-Id: If48f9d793c23f28b76d010683f48dd4718940742 Reviewed-on: https://chromium-review.googlesource.com/1161549 Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#581766}
-
Travis Skare authored
Remove an unneeded request - will need 1157167 to be merged at the same time. Bug: 869687 Change-Id: Ic6f2d46a4aba1cb3535b9003c557e38080ccb7de Reviewed-on: https://chromium-review.googlesource.com/1165955Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#581765}
-
Cathy Li authored
Bug: 867488 Change-Id: Id45577a66f505af903e77c6bcc4771eab9e12e9c Reviewed-on: https://chromium-review.googlesource.com/1161091 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#581764}
-
Chris Harrelson authored
This is no longer necessary because, in SPv175: a) Object visual rects are stored relative to their transform ancestor, which is not affected by change of that scroll transform. b) Raster invalidations happen on paint chunks, which takes care of descendants which don't scroll. We do, however need to set NeedsRepaint on the scrolling PaintLayer, because its descendants could have been affected by a changed cull rect. Bug: 823751 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9865e336233a92e1aac9c25ea221cec039f6abb1 Reviewed-on: https://chromium-review.googlesource.com/1159382 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#581763}
-
Tetsui Ohkubo authored
According to QA, when concatenating user name and email, we should put email in parentheses. TEST=manual BUG=857456 Change-Id: I8d28ea21dc6c76fb3079d099741019f9285e079e Reviewed-on: https://chromium-review.googlesource.com/1166758Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#581762}
-
