- 07 Aug, 2020 40 commits
-
-
Yu Han authored
Prior to this CL, the date, time and meter colors in dark mode don't match spec. Updated date, time and meter colors for dark mode. Bug: 1111922,1107290 Change-Id: I1b5aac854fd7fd99e9f2fbe236c4b7412debc249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340346Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796158}
-
Dana Fried authored
See go/newlabel for more information. This CL adds "this is a new feature" to the text read by the screen reader, after the hotkey but before the "item M of N" description. So for example, a tab context menu item might look like this: ... Add tab to Read Later [New] CTRL+SHIFT+Z Move tab to new group [New] ... As you scroll through, you will hear: "Add tab to read later, control plus shift plus Z, this is a new feature, item 4 of 7" "Move tab to new group, this is a new feature, item 5 of 7" Note: The screenshot in the associated png file is of the visual presentation of the badge, as the actual text read does not appear on-screen. Bug: 1114082 Change-Id: I758d0b6cb92856e62bde87f9cd55553feb281b3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343008Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#796157}
-
Mark Pearson authored
Change-Id: I19c404a181555dcf8ca65b4efaedf2e74ac1533f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340269 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#796156}
-
Miguel Casas authored
VaapiVideoDecoder lives in a single SequencedTaskRunner, so this CL removes the comments' references to 'on [the] decoder thread'. Also s/decoder_sequence_checker_/sequence_checker_/ since there's only one TaskRunner. Finally, this CL also flips the DVLOG()s and the DCHECK_CALLED_ON_VALID_SEQUENCE() so that a potential CHECK happens after the printout, not before. No new code intended. Bug: b:162962069 Change-Id: I500acc380a0d3ac83fc5027217d6735198a2f1bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340365 Commit-Queue: Miguel Casas <mcasas@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#796155}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/24289f2e94f3..0fa91d0f3563 2020-08-07 saagarsanghavi@google.com ResultDB wrapping for CQ/CI builds. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I812c6d934f3de96d12acd1f6e416a7c21aac2ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339944Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796154}
-
yjliu authored
Removing the items from the container one by one is inefficient, and at shutting down, this can be done by emptying the container directly. Bug: 1112835 Change-Id: Ib7529963763b1e772b6ba330eda3a3a3e2f6d380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340319Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Jun Liu <yjliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796153}
-
Xianzhu Wang authored
This makes them consistent to use the same skipping conditions as what we do during PrePaint, to avoid access of null or stale layer states. Bug: 1110232 Change-Id: I50e3d997476e8fc8532c2b3cb931c5639c71044d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342468Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796152}
-
Dan Harrington authored
- FEED_SCROLLED was mis-documented as being reported for every scroll, when it was actually being reported only once per chrome start. I changed this so that it's reported once per Feed 'visit', as the other engagement types are. This changes both the documentation and the reporting code in v1 and v2. Since this is a change in behavior, I'm using a new enumeration value, and no longer reporting the old one. - Use absolute value for scroll distance in feedv1, to match v2. Bug: 1044139 Change-Id: Iabea46a016f57ef6dec77932e0ff00f0cb5d0a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337235Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#796151}
-
Wan-Teh Chang authored
This bug was introduced in https://crrev.com/c/2321307. It was detected by the new Web platform test in my pending CL https://crrev.com/c/2304961. The following return statement in IsColorSpaceSupportedByPCVR() if (!image->alphaPlane) return true; actually elided a check that yuv_color_space was one of the four SkYUVColorSpace values supported by media::PaintCanvasVideoRenderer (PCVR). At that time (before https://skia-review.googlesource.com/c/skia/+/305596) SkYUVColorSpace had only those four values (except for kIdentity_SkYUVColorSpace) and our own GetSkYUVColorSpace() function returned only those four values on success, so it was fine to elide that check. After we switched from our own GetSkYUVColorSpace() function to gfx::ColorSpace::ToSkYUVColorSpace() in https://crrev.com/c/2321307, the newly added SkYUVColorSpace values may be returned, so it is no longer fine to elide the check. Also make two cleanup changes: 1. Replace the deprecated SkYUVColorSpace enumerators with the new more verbose ones. 2. Do not declare the yuv_color_space_ member as base::Optional. base::Optional made sense because our own GetSkYUVColorSpace() function returned base::Optional instead of using an output parameter. Since gfx::ColorSpace::ToSkYUVColorSpace() uses an output parameter, it is cumbersome to pass a base::Optional as an output parameter. Bug: 1108626 Change-Id: I96dba5c54dbe1b826be714141665adcaee47bccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343535Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#796150}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/63a1a8309814..e0dd3df0934a 2020-08-07 herb@google.com remove unused Arena reset() 2020-08-07 brianosman@google.com Revert "Untangle dependency cycle in sksl dehydration" 2020-08-07 bungeman@google.com Allow CoreText axis hidden value to be CFNumber. 2020-08-07 reed@google.com SkPathView for ownerless (can live on stack) SkPaths 2020-08-07 johnstiles@google.com Fix GrImprovedPerlinNoiseEffect::onIsEqual to compare properly. 2020-08-07 brianosman@google.com Untangle dependency cycle in sksl dehydration 2020-08-07 robertphillips@google.com Update how the GrSmallPathRenderer's cache entries are created and destroyed 2020-08-07 mtklein@google.com split getPaint() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1113444 Tbr: herb@google.com Change-Id: I4a68f9b5dcf29e497332574d90e33c8e3ab91516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343579Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I9e4b7c59e9edb04e7667b5c51b45b226991157ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343669 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Keren Zhu authored
Also remove static Create() in favor of a public constructor. Historically, MdTextButton had three factory methods and prohibited the direct use of the constructor. A recent cleanup unified three factories into one, and this one does no more than a constructor. This CL is part of the effort to make Views default constructible, allowing UI to be built in a declarative fashion. Bug: 1108460 Change-Id: Id1901dd2a96378927c94fc2663a53f14ea1b708e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340880Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Antonio Gomes authored
This prevents the developer from accidentally enabling use_gtk=true on the lacros/chrome build, and diverge from the ChromeOS environment. BUG=None R=jamescook@chromium.org Change-Id: Idc204d85b970d47fe96dc21dec55c1ac091b8484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343488 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Auto-Submit: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#796146}
-
Gang Wu authored
This CL add "Managed by your organization" menu item in the overflow menu if the users is an enterprise user and the profile is managed by the policies. Bug: 997053 Change-Id: I7fc9d7ea091a9ebfc5c9b3a25be848888c29d58a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339280 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#796145}
-
rbpotter authored
The download button should be highlighted when the action menu is open, similar to the highlight on the bookmarks icon when the bookmarks menu is open. Also changing the menu to be light when the PDFViewerUpdate feature flag is not enabled, for the same reason (matching the bookmarks menu). Bug: 1113519 Change-Id: I86dc1b7a569688532a2bbce1b8b639e79932d325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340447 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#796144}
-
Brian Sheedy authored
Skips the expected crash check in Pixel_Video_Context_Loss_VP9 on Windows machines so that we can determine if the test is only failing because of the check. TBR=kbr@chromium.org Bug: 1061298 Change-Id: I06fc190f49cc106daca0fd794a1bbecc3cca6403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343628Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#796143}
-
Matthias Körber authored
Change-Id: I5c7d6f2d2d33127b2e2b13b1b48c9213469a53c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339633Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
-
Numfor Mbiziwo-Tiapo authored
This is a reland of 051f1395 The perf test idb-put-all.html was failing because idb_request HandleResponse was checking to never receive empty blob handles. Fixing by clearing the blob handles instead of using a DCHECK. Original change's description: > Updating the putAll implementation to return one request. > > This change updates the existing putAll implementation to match > the explainer more. It does not yet support the put-all-or-none > behavior, but it does only return one request now. > > Design Doc: > https://docs.google.com/document/d/1wawQ8Pl-Vi6GQN5-y2UVkcghipcOGg0WRAC0ZyBkezg/edit# > > Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1087927 > > Change-Id: I2c5e9d2d71801eaab3c1c9e94a3968afb8d109b2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310110 > Commit-Queue: Numfor Mbiziwo-tiapo <nums@google.com> > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: Olivier Yiptong <oyiptong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793656} Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1087927 Change-Id: I26e977d2b307dde33a78fdb4869116a25c56dde7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335633 Auto-Submit: Numfor Mbiziwo-tiapo <nums@google.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#796141}
-
ssid authored
BUG=1109349 Change-Id: I36b995847a37f20d32ab5892c580797f1436e0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328804 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#796140}
-
Sammie Quon authored
In crrev.com/c/2238652, we modified the drag window copy to share codes with WindowMirrorView. For this case, we skipped setting a transform in Layout but we actually need to set it to identity since mirroring layers will copy transforms (case for dragging overview windows). Copies some more layer properties that may be on the original window. Test: added test, manual Bug: 1113429 Change-Id: I7874d733be5026c0785c32cc5ceafb529653b4cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340791 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#796139}
-
Sven Zheng authored
The test suite is stable now. Should be safe to get out of experimental. Bug: 1102894 Change-Id: If57be8cd0f5c5b56470e15df3cc389931ae7e8bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336310 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#796138}
-
Justin DeWitt authored
Already marked flaky, still causing failures on bots such as android-arm-beta-tests. Bug: 1108684 Change-Id: I46fdce13c1d29c854093d4aa0cb3fa020243d424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343754Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#796137}
-
Qiaofei Ye authored
... to XInputDataFetcherWin. This CL is part of the feature to make Windows.Gaming.Input (WGI) turned on by default on Chromium. WGI will provide game controller support on Windows 10 desktop. The WGI also provides support for gamepad-specific Plug & Play APIs, even on WCOS devices. This feature can work on both Windows Desktop (win32 apps) and Windows 10X. This change performed the renaming of gamepad_platform_data_fetcher to XInputDataFetcherWin as suggested in previous CL indicated below. Thus we will have separate data fetchers for separate APIs (XInput & WGI). https://chromium-review.googlesource.com/c/chromium/src/+/2293615/1/device/gamepad/BUILD.gn#159 Bug: 1098876 Change-Id: I5ecca34a7b10dd612df8dff4fa2eab9cb869b353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340711 Commit-Queue: Qiaofei Ye <qiaye@microsoft.com> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#796136}
-
Jesse Schettler authored
Create a ZeroconfScannerDetector to detect network scanners using mDNS and DNS-SD. The detector detects eSCL and eSCLS scanners. The detector stores information for each detected scanner, but clients receive a deduplicated list of scanners (i.e. if the same scanner is reported for more than one service type, the information from each detection is merged before being sent to clients). Bug: b:153541027 Change-Id: Ia69d98ca176f2d6d09f8c6db94ce30d8f96b9249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307619Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
-
Pete Williamson authored
Bug: 1114249 Change-Id: Ib2c17f81db046ab83d3e7de696abc732e78607ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342996Reviewed-by:
Vincent Boisselle <vincb@google.com> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#796134}
-
Emily Stark authored
This reverts commit 8ea67049. Reason for revert: I noticed that this change causes the omnibox to be in ELIDE_TAIL mode during editing, which causes a DCHECK failure. Original change's description: > Restore omnibox bounds when resetting if not eligible for eliding > > This CL fixes a bug in the code that resets to the on-page-load state > for the simplified domain hide-on-interaction field trial. > > The bug is that this reset code let the omnibox bounds go unchanged > if the new text was not eligible for simplified domain eliding. > For example, when switching to a new tab (as shown in > https://bugs.chromium.org/p/chromium/issues/detail?id=1112577#c4), the > placeholder text could get cut off because the omnibox was remaining > at the bounds used for the last simplified domain elision. The fix is > to restore the omnibox to its local bounds, with ELIDE_TAIL behavior, > when the text is not eligible for simplified domain eliding. > > Bug: 1107912, 1112577 > Change-Id: I36c359831fc1f7b18c814d9144b801655bd3b1c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342123 > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Commit-Queue: Emily Stark <estark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795953} TBR=jdonnelly@chromium.org,estark@chromium.org Change-Id: Id44cd8e39064af890399109fcca8ca729ddba5d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1107912 Bug: 1112577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343153Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#796133}
-
Darin Fisher authored
Bug: 1111856 Change-Id: I82d7f939bb9f8f9c4c35c6c0183edb8af43851cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341834Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
-
Rahul Singh (EDGE) authored
shortcut_infos() is populated. This fixes an issue where we were calling RegisterShortcutsMenuWithOs() even when shortcuts weren't provided in the PWA's web app manifest. Bug: 1113324 Change-Id: Ib3965ee85643c12f29dbebf67db2f3862bba57e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339704Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Rahul Singh <rahsin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#796131}
-
John Williams authored
There isn't a known repro, so this CL is a best effort to fix the likely cause of the crashes. Bug: 1114067 Change-Id: I2416be1f2eddef8c3a954146ea9c905f78421a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343596 Commit-Queue: John Williams <jrw@chromium.org> Auto-Submit: John Williams <jrw@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#796130}
-
spdonghao authored
The sign-in box shows earlier than the Feed articles, and the Feed placeholder looks strange during this period of time. This CL delays the sign-in box and makes it fade in together with the Feed articles. Bug: 1114190 Change-Id: Ifd353fe5bf318baaf61b7419e561b673a5852b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314267 Commit-Queue: Hao Dong <spdonghao@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#796129}
-
Alexander Timin authored
Add RenderFrameHost::AsValueInto to allow capturing of the main RenderFrameHost parameters (routing id, process id, url, origin, lifecycle state, etc). Also add TracedValue::SetPointer to make tracing pointers easier. R=nasko@chromium.org,eseckler@chromium.org,karelkral@google.com BUG=1043616 Change-Id: Icec6ee889002d7ee26de7ebe990f2a8d88ad753a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339348 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#796128}
-
Thomas Guilbert authored
From certain crash reports, it appears that we are getting calls to OnAudioDataRequestedCallback() after destroying AAudioOutputStream. This shouldn't happen, but there might be underlying issues in AAudio. This CL waits for our AAudio stream to transition to a target state, before allowing the stream to be destroyed. This means waiting for STOPPED and CLOSED when stopping and closing. Change-Id: I0e7fb332a1da9b4709a14b3206503be8434af534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340061Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#796127}
-
Nicolas Ouellet-Payeur authored
Previously, the toggle would be hidden for force-installed extensions because it didn't work. With this patch, it is visible again, and won't throw a "cannot modify" error when the user tries to change it. Bug: 173640 Change-Id: Iae7cf94b69da975449935ee4c7b8f68aebbe7fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340317 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796126}
-
Thomas Lukaszewicz authored
This CL creates the initial NewTabButton subclass for the TabSearchButton. While the Tab Search experiment is running this is intended to be a transitionary state. The aim is to eventually have both the NewTabButton and TabSearchButton inherit from a common base class and specialize where appropriate. Follow up CLs will add further tweaks including locking the button highlight while the async button loads invisibly in the background. Bug: 1099917 Change-Id: Ib1c087c90ef4738500ed28583049ba53bda897c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343384 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#796125}
-
Matthias Körber authored
Change-Id: I9ec22adf47f6f1e15d0a055844ac4cd9e518f0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341133 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
-
Kyle Milka authored
This property is no longer needed since switching to vector icons. Bug: None Change-Id: I01e92a838c2bba16516b77f10572e3a9f7875fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219350 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#796123}
-
Robert Ma authored
Also switch to loading *.mojom.js from /gen/ instead of resources/chromium in preparation for launching official MojoJS support in WPT. This would not change the test results on Chromium waterfall (everything should continue to pass) or upstream WPT (tests currently fail because MojoJS isn't enabled). Move web_tests/usb to web_tests/wpt_internal/webusb so that these tests are served the same was as web_tests/external/wpt/webusb, making the resource URLs consistent and saving a special case in the helper function. Finally, remove unused .mojom.js files from WPT. Bug: 1094512 Change-Id: I75f3d1a7acf494e2c881c527618a496e907a9596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276999 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#796122}
-
Wenhan (Han) Zhang authored
First step in migrating to a more flexible histogram naming syntax using tokens and variants and instead of suffixes. Changed one UMA histogram to using token instead of suffixes, and made corresponding changes and tests in the model and extract_histograms.py. Change-Id: I57c20d3c172f5d3e2742b1f3459fd4f7cacf848e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333508Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Wenhan (Han) Zhang <zwenhan@google.com> Cr-Commit-Position: refs/heads/master@{#796121}
-
Daniel Rubery authored
This CL extends the following histograms, which are expected to be important when diagnosing a regression: SoftwareReporter.Cleaner.TimeToCompleteDownload SoftwareReporter.Cleaner.TimeToCompleteDownload_DownloadFailure SoftwareReporter.Cleaner.TimeToCompleteDownload_DownloadSuccess SoftwareReporter.Cleaner.TimeToCompleteDownload_NetworkError SoftwareReporter.FoundUwSReadError SoftwareReporter.FoundUwSReadError_ESET SoftwareReporter.FoundUwSReadError_URZA SoftwareReporter.LastUploadResult SoftwareReporter.MajorVersion SoftwareReporter.MajorVersion_ESET SoftwareReporter.MajorVersion_URZA SoftwareReporter.MinorVersion SoftwareReporter.MinorVersion_ESET SoftwareReporter.MinorVersion_URZA SoftwareReporter.MemoryUsed SoftwareReporter.MemoryUsed_ESET SoftwareReporter.MemoryUsed_URZA SoftwareReporter.RunningTimeAccordingToChrome SoftwareReporter.RunningTimeAccordingToChrome_ESET SoftwareReporter.RunningTimeAccordingToChrome_URZA And marks the following as obsolete: SoftwareReporter.Cleaner.HasCompleted SoftwareReporter.Cleaner.Version SoftwareReporter.PromptDialog.TimeUntilDone SoftwareReporter.PromptDialog.TimeUntilDone_Accepted SoftwareReporter.PromptDialog.TimeUntilDone_Canceled SoftwareReporter.PromptDialog.TimeUntilDone_DetailsButtonClicked SoftwareReporter.PromptDialog.TimeUntilDone_Dismissed SoftwareReporter.ReporterSequenceResult SoftwareReporter.ReporterSequenceResult_Periodic SoftwareReporter.ReporterSequenceResult_UserInitiated SoftwareReporter.RunningTime SoftwareReporter.RunningTimeRegistryError SoftwareReporter.RunningTimeRegistryError_ESET SoftwareReporter.RunningTimeRegistryError_URZA SoftwareReporter.RunningTime_ESET SoftwareReporter.RunningTime_URZA SoftwareReporter.Step SoftwareReporter.Step_ESET SoftwareReporter.Step_URZA SoftwareReporter.UploadFailureCount SoftwareReporter.UploadLongestFailureRun SoftwareReporter.UploadSuccessCount Fixed: 1066069 Change-Id: I03b62a4466a1a5939563a75774d68e1e6b48664b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311036 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#796120}
-
Sahel Sharify authored
Bug: 1098881 Change-Id: Ic1a9a78731c9cf7c4c939578a966233f4e187a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343144Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#796119}
-
