GitLab

Changes:
As from discussion with UX writer, updating the label name here.

BUG=658048
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2847173003
Cr-Commit-Position: refs/heads/master@{#468248}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/144ff1bd..4aa32418

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2851963002
Cr-Commit-Position: refs/heads/master@{#468247}

Adding COMPONENT/TEAM information into OWNERS file.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
List of components
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=wfh@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2703443002
Cr-Commit-Position: refs/heads/master@{#468246}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bfd28fa6..144ff1bd

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2849033002
Cr-Commit-Position: refs/heads/master@{#468245}

The interface taking a raw pointer is deprecated and being removed.

BUG=690937

Review-Url: https://codereview.chromium.org/2848163002
Cr-Commit-Position: refs/heads/master@{#468244}

Currently ToCoreProbe code checks the given ExecutionContext's type
and calls different code to get its CoreProbeSink, but in this way
we need to keep adding new ToCoreProbe code every time we add
new ExecutionContext, which sounds a bit cumbersome.

This CL adds ExecutionContext::GetProbeSink() virtual method
to mitigate that.

BUG=538751

Review-Url: https://codereview.chromium.org/2847703002
Cr-Commit-Position: refs/heads/master@{#468243}

Adds labels describing missing information (e.g., "Add Email Address") to shipping + contact info views. Adds validation for shipping addresses. Adds cacheing to PaymentsProfileComparator, and adds an instance to PaymentRequestState so that cached values can be used throughout the request.

BUG=711358,709454,
TBR=mahmadi@chromium.org

Review-Url: https://codereview.chromium.org/2847503002
Cr-Commit-Position: refs/heads/master@{#468242}

Some metrics about encryption migration are already recorded in cryptohomed.
In this CL, I'd like to add following UI-related UMA metrics on the app.

Cryptohome.MigrationUI.FirstScreen
Cryptohome.MigrationUI.UserChoice
Cryptohome.MigrationUI.ConsumedBatteryPercent

BUG=714887
TEST=Disable reboot after the migration by modifying the code, and check that chrome://histograms shows the added metrics.

Review-Url: https://codereview.chromium.org/2849833002
Cr-Commit-Position: refs/heads/master@{#468241}

The interface taking a raw pointer is deprecated and being removed.

BUG=690937

Review-Url: https://codereview.chromium.org/2846413002
Cr-Commit-Position: refs/heads/master@{#468240}

This is a single character change to temporarily switch Chrome to
building with VC++ 2017. This CL is currently purely for testing
purposes and will be landed for the weekend in order to flesh out any
remaining bugs.

This is a retry of crrev.com/2762093003 which failed due to a compiler
warning which was missed in local testing and the try bots. That warning
has been resolved and a local build of 'all' completed cleanly.

BUG=683729

Review-Url: https://codereview.chromium.org/2852433005
Cr-Commit-Position: refs/heads/master@{#468239}

During the emulation of srgb for generateMipmap, we tried to generate all
levels of the original texture. But if the texture is immutable texture,
we can't generate mipmaps exceed the original range.
Also, when the width and height are not equal, they should be at least one
during the emulation.

BUG=712096
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2841503002
Cr-Commit-Position: refs/heads/master@{#468238}

I ran check_gn_headers.py on linux and android full builds, merged the
extra header file lists, fed to "fix_gn_headers.py --remove", and
chose which matches to apply interactively.

8 missing headers in the build were fixed because they were moved.

BUG=716359

Review-Url: https://codereview.chromium.org/2849763002
Cr-Commit-Position: refs/heads/master@{#468237}

This changes some method names to make them more accurate, and splits
out ResizeAfterLayout from LayoutUpdated.  In a subsequent patch, these
two methods will be called independently through ChromeClient.

BUG=701575

Review-Url: https://codereview.chromium.org/2848043002
Cr-Commit-Position: refs/heads/master@{#468236}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/733cb1f1..bfd28fa6

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2847373002
Cr-Commit-Position: refs/heads/master@{#468235}

BUG=577685

Review-Url: https://codereview.chromium.org/2643183002
Cr-Commit-Position: refs/heads/master@{#468234}

This method disallows PaintLayer creation inside a LayoutSVGHiddenContainer,
even for overflow-clipping elements that would normally require a PaintLayer.

This wreaks havoc in the layout code which assumes in numerous places that
HasOverflowClip() implies GetScrollableArea() != nullptr.

It was added in http://crrev.com/88e9d056 to fix a paint bug, but it seems
unnecessary now.  The svg/foreignObject layout tests all pass and the original
test case on http://wkbug.com/41386 still renders correctly after this change.

BUG=710087

Review-Url: https://codereview.chromium.org/2851763004
Cr-Commit-Position: refs/heads/master@{#468233}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/eccd93f7..733cb1f1

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2849013002
Cr-Commit-Position: refs/heads/master@{#468232}

This CL is a refactor and has no intended behavior change.

NullHandle() has two use cases:
  * Create an invalid handle.
  * Return an object that can be compared against a handle to check validity.
The former is also the behavior of the default constructor of
base::SharedMemoryHandle, and the latter should be done with the member
IsValid().

Fixing the latter also allows the removal of operator== and operator!=.

BUG=713763
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2849633002
Cr-Commit-Position: refs/heads/master@{#468231}

BUG=716359

Review-Url: https://codereview.chromium.org/2846593007
Cr-Commit-Position: refs/heads/master@{#468230}

BUG=546953

Review-Url: https://codereview.chromium.org/2840993003
Cr-Commit-Position: refs/heads/master@{#468229}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/10b9a3e5..eccd93f7

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2851023002
Cr-Commit-Position: refs/heads/master@{#468228}

NetworkListDelegate was introduced when parts of network UI were living
in a different component. Now that everything is in //ash/system/network
there is no need for the delegate. NetworkListView and VPNListView can
access its methods directly from NetworkStateListDetailedView. Also,
some of the functionality was only used in NetworkListView and moved to
that class.

This is the first step to clean up code for network and VPN detailed
views necessary to share code between all detailed views.

BUG=686343
TEST=none

Review-Url: https://codereview.chromium.org/2843163003
Cr-Commit-Position: refs/heads/master@{#468227}

The interface taking a raw pointer is deprecated and being removed.

BUG=690937

Review-Url: https://codereview.chromium.org/2845293004
Cr-Commit-Position: refs/heads/master@{#468226}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/fa1d11d0530d..1c3f4b921788

$ git log fa1d11d05..1c3f4b921 --date=short --no-merges --format='%ad %ae %s'
2017-04-28 lpy [ESLint] Turn on object-shorthand.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I737cce5d41f98e9b2eae90a024bdb68d402fd8fa
Reviewed-on: https://chromium-review.googlesource.com/490523
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468225}

Added a feature and a chrome://flags entry to hide the new remote playback
pipeline behind it. Created a virtual test folder for the relevant
LayoutTests with the flag enabled.
Moved some of these tests to media/controls/ to avoid running all the media
tests twice.

BUG=517102
TEST=run the new virtual tests with the flag enabled

Review-Url: https://codereview.chromium.org/2846713002
Cr-Commit-Position: refs/heads/master@{#468224}

wrt the cast buttons.

OnRemotePlaybackAvailabilityChanged, OnRemotePlaybackConnecting,
and OnRemotePlaybackDisconnected are replaced by MediaControlsMediaEventListener
via an availability callback and listening for connect, connecting and disconnect
events on the RemotePlayback object off the MediaElement.

OnDisableRemotePlaybackAttributeChanged is replaced by a MutationObserver kept by
MediaControlsImpl.

RemotePlayback has methods that allow it to be used from C++ directly.

BUG=517102
TEST=existing and new tests + manual

Review-Url: https://codereview.chromium.org/2782373002
Cr-Commit-Position: refs/heads/master@{#468223}

Removed the "Persistent Open State" behavior and changed
the "app-menu-icon" flag to "enable-new-app-menu-icon".

Fixed an issue with the animation where it transitions between
different severity levels with an incorrect color.

BUG=704786

Review-Url: https://codereview.chromium.org/2843413003
Cr-Commit-Position: refs/heads/master@{#468222}

One minute was a completely ridiculous timeout length as this means that
Chrome will behave as if the device simply doesn't exist until the bad
transfer times out. If the device isn't responding in a couple seconds
it likely never will.

BUG=None

Review-Url: https://codereview.chromium.org/2849893003
Cr-Commit-Position: refs/heads/master@{#468221}

client_cached_cert_hashes to nullptr in default
QuicCompressedCertsCache::UncompressedCerts constructor.

BUG=716026

Review-Url: https://codereview.chromium.org/2848883006
Cr-Commit-Position: refs/heads/master@{#468220}

Very flaky on linux_android_rel_ng.

BUG=713895
TBR=wychen@chromium.org

Review-Url: https://codereview.chromium.org/2850853005
Cr-Commit-Position: refs/heads/master@{#468219}

This was previously fixed for seed processing in http://crrev.com/2612243003,
but was accidentally omitted for the simulation code.

BUG=716493
R=asvitkine@chromium.org

Review-Url: https://codereview.chromium.org/2851703004
Cr-Commit-Position: refs/heads/master@{#468218}

Cr-Commit-Position: refs/heads/master@{#468217}

instead of waiting for it be be destroyed.

Add tests for the cases where a connection is close before a StreamRequest
completes (both sync and async).

BUG=716563

Review-Url: https://codereview.chromium.org/2854443003
Cr-Commit-Position: refs/heads/master@{#468216}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7d568a76..10b9a3e5

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2853673002
Cr-Commit-Position: refs/heads/master@{#468215}

When this is statically known at compile time, there's no need to do
dynamic dispatch.

Bug: 709815
Change-Id: I8cdd314d306c3b5557951b6bf94911be24c73d7a
Reviewed-on: https://chromium-review.googlesource.com/489642Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468214}

This CL is *mostly* a refactor with no intended behavior change.

Previously, PlatformFileForTransit had the same semantics as SharedMemoryHandle,
so it was typedef-ed to SharedMemoryHandle. However, the semantics for
SharedMemoryHandle are changing, so it's no longer appropriate to do so.

This CL includes a small fix to ppb_nacl_private_impl.cc, which previously
leaked a HANDLE on Windows, but not on an fd on POSIX.

The leak was introduced by "Make PlatformFileForTransit a class on Windows."
[commit: 19e5f690]. Prior to that CL:
  On Windows, NaCl would duplicate the handle into the destination process
  [closing the original handle in the process], and then pass the result as a
  raw int.

  On POSIX, NaCl would duplicate the handle using Chrome IPC, using
  base::FileDescriptor.auto_close = true, which would cause the IPC subsystem
  to close the handle.

After that CL:
  On Windows, NaCl would let Chrome IPC transport the handle, but failed to
  call PlatformFileForTransit::SetOwnershipPassesToIPC(true) [the equivalent of
  base::FileDescriptor.auto_close]. This caused a leak of the handle in the
  browser process.

In this CL:
  PlatformFileForTransit is now its own class, with no auto_close parameter
  because the IPC subsystem always closes the handle in the source process.

BUG=713763

Review-Url: https://codereview.chromium.org/2846293002
Cr-Commit-Position: refs/heads/master@{#468213}

https://pdfium.googlesource.com/pdfium.git/+log/3b91290ba31e..ce8e51e6c444

$ git log 3b91290ba..ce8e51e6c --date=short --no-merges --format='%ad %ae %s'
2017-04-28 rbpotter Fix rotations
2017-04-28 thestig Clean up private methods in CBC_C40Encoder.
2017-04-28 tsepez Remove some more |new|s, part 4.
2017-04-28 thestig Limit recursion in CXML_Parser::ParseElement().
2017-04-28 thestig Disallow CPDF_FormField with deep node trees.

Created with:
  roll-dep src/third_party/pdfium
BUG=713197,716526


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I81ccbaaacbb34cc9923714ca87841f2c756d6b3c
Reviewed-on: https://chromium-review.googlesource.com/490699
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468212}

BUG=712416

Review-Url: https://codereview.chromium.org/2844143002
Cr-Commit-Position: refs/heads/master@{#468211}

The current situation is that using ScopedFeatureList resets to an
empty feature list and then enables/disables an explicit list of
features.

That's never what you want for browser tests (or other higher-level
tests) since it effectively overrides higher-level test configurations
(e.g. those in fieldtrial_testing_config.json, or a bot set up to
specifically test a feature).

In this patch:

1. Keep SFL::Init, SFL::InitWithFeatureList,
   SFL::InitFromCommandLine reset to empty list but add warning to
   remind developer should use them with care.
2. Change SFL::InitAndEnableFeature, SFL::InitAndDisableFeature and
   SFL::InitWithFeatures to not reset but override current FeatureList
   with given enables/disables.

We also add unit tests for ScopedFeatureList.

BUG=713390

Review-Url: https://codereview.chromium.org/2834583002
Cr-Commit-Position: refs/heads/master@{#468210}

BUG=656015

Review-Url: https://codereview.chromium.org/2816733002
Cr-Commit-Position: refs/heads/master@{#468209}