Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 11 Nov, 2019 3 commits
    • Meredith Lane's avatar
      [AOM] Remove validation upon getting element refs · 93525051
      Meredith Lane authored 
      In order to comply with the current version of the spec, elements are
no longer validated on retrieval or getting. This means that explicitly
set elements are still able to be the attr-associated-element, even if
they have been moved into an invalid scope, such as a deeper shadow
root, or a different tree scope or removed entirely.

This is likely to change in future, but as the spec is still being
actively discussed it is better to comply with the current version.

BUG=981423

Change-Id: I496c06cfad5f056c49dedb3e9821781c755538b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898889Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Reviewed-by: default avatarAlice Boxhall <aboxhall@chromium.org>
Commit-Queue: Meredith Lane <meredithl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714126}
      93525051
    • Fergal Daly's avatar
      Reland "bfcache: Save back-navigation's navigationStart in pageshow event's timestamp" · 87f79d68
      Fergal Daly authored 
      This is a reland of d6cbc51d.

Landing this unblocks others to use this new times.

The difference with the reland is that it disables
BackForwardCacheBrowserTest.SubframeWithNoStoreCached on win. The cause of the
20ms difference in timestamps is unknown but seems likely to just a platform-difference between
linux and windows that just impacts this test. We will investigate that later.

The test can be seen failing in patchset 1 (no diff vs the original change) on the
win_chromium_dbg_ng trybot and then passing in patchset 2 (both runs have problems with infra
and tests that seems entirely unrelated, they are runs 2536 and 2537 on
https://ci.chromium.org/p/chromium/builders/try/win_chromium_dbg_ng and they are preceded
by a lot of other failures, all that matters to us is the result of this 1 test)


Original change's description:
> bfcache: Save back-navigation's navigationStart in pageshow event's timestamp
>
> When a page is restored from the back forward cache, there is
> currently no way to know its navigationStart time since we aren't
> updating performance.timing.navigationStart (which is undesirable),
> even though users of bfcache might want to know the navigationStart
> time to measure latency. To solve this, we are modifying the
> pageshow event’s timeStamp to correspond to the navigation start of
> the history navigation. Note as event.timeStamp is defined as time
> elapsed since the beginning of the document lifetime [1], this is
> effectively the difference between the initial navigationStart and
> the navigation start of the last navigation.
>
> [1] https://developer.mozilla.org/en-US/docs/Web/API/Event/timeStamp
>
> Note that we are only updating this for pageshow events for pages
> that were persisted (restored from the back forward cache).
>
> For more background, see doc at https://docs.google.com/document/d/1XlZhphHW-bNcUPD98T-rfTa-TASI-3xUtxZzThZLJCA/edit?usp=sharing
>
> Change-Id: I81e399492eaa377ac56c4325e3134b1ff50ae451
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888627
> Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
> Auto-Submit: Rakina Zata Amni <rakina@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: Fergal Daly <fergal@chromium.org>
> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#713147}

BUG=1022191

Change-Id: Ia916db46c6b5245d22a184d169c94fc0a58bfc4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903185
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: default avatarAlex Moshchuk <alexmos@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714125}
      87f79d68
    • Anand K. Mistry's avatar
      Export a D-Bus service used to bootstrap Mojo IPC for SmbFs. · 3c22484f
      Anand K. Mistry authored 
      When mounting SmbFs through cros-disks, there is currently no ability to
pass a file descriptor (eg. for a socket) over the D-Bus Mount() method.
Instead, a random string is generated and provided to SmbFs as part of
the mount source path. SmbFs will then generate a socket pair and pass
one end back to Chrome, along with the random string as an identifier,
through this D-Bus service.

This service is an exact duplicate of org.chromium.DriveFileStream.

Bug: 939235
Change-Id: Ideaec725a50ab7a1dba6e11b152fb08280c3a75b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890378Reviewed-by: default avatarJorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: default avatarAlexander Alekseev <alemate@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714124}
      3c22484f
  3. 10 Nov, 2019 15 commits
  5. 09 Nov, 2019 22 commits