- 27 Mar, 2019 40 commits
-
-
chrome://flagsJonathan Backer authored
Change-Id: I7da6fbcf9e935c88057e71190089883a4cb18fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539875 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#644780}
-
Olivier Robin authored
These methods can be calle asynchronously. It is necessary to check that the web_frame was not destroyed before processing it. Bug: 942427 Change-Id: Icc46dae9193c4fd9ef9612ce47239bd50eef33d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538194 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#644779}
-
David 'Digit' Turner authored
The crazy linker used to parse /proc/self/exe and /proc/self/maps in order to find the value of the process-global |r_debug| variable maintained by the system linker. Unfortunately, this operation is flaky on Android L (see attached bug for details). In the end this prevents Crashpad from generating valid stack traces, because it will not see libchrome.so in the current process when this happens. This CL uses getauxval() instead to get the same address, since this function is available from the C library starting with API level 18 / Android KitKat. + Add new unit-test to check that RDebug::GetAddress() works correctly. BUG=946380 R=pasko@chromium.org, agrieve@chromium.org, jperaza@chromium.org Change-Id: I90212f94206fda05be515bdbd6fc7f1285f041a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541117Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#644778}
-
Leonard Grey authored
This was broken by the GM2 style update. Since these constants are only used in the infobar, we can unconditionally use dark mode style. Bug: 940900 Change-Id: I9da25d945da94e72c4e0c7d8a08dfd8ca021196c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539125 Auto-Submit: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#644777}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ffaffb18986d..58cb9bcb7e0a Created with: gclient setdep -r src-internal@58cb9bcb7e0a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=robertocn@chromium.org,noel@chromium.org,eirage@chromium.org Change-Id: Ic7e081131f497d8ef2c59d831076cd1309c1ef8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541576Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644776}
-
Richard Townsend authored
This reverts commit 7ff0fd56. Reason for revert: Caused timeouts on chrome's perf builders. Original change's description: > benchmark: add basic partition allocator coverage > > Intention of this benchmark is to collect profiling data of hotspots > within the partition allocator and a performance baseline for > work on thread-local caches. > > Bug: 907444 > Change-Id: Ia112fad5e23dfdf47f44077ed3ab776b13ddf0b3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1350878 > Commit-Queue: Richard Townsend <richard.townsend@arm.com> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642530} TBR=fdoray@chromium.org,haraken@chromium.org,richard.townsend@arm.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 907444 Bug: 946034 Change-Id: I8ba16efc8aa749b2c72592a659fcbc6cd10bb4ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539980 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#644775}
-
Karolina Soltys authored
All of it is purely mechanical except for chrome/android/javatests/src/org/chromium/chrome/browser/fullscreen/FullscreenManagerTestUtils.java Bug: 863341 Change-Id: I3f352e9f02a49bc894f2d9a917a8aa4332c8e0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532016Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#644774}
-
Tanja Gornak authored
Currently messages are not persisted for the FCM invalidations, because the sender id for which invaliations are marked lazy mismatches the id received in the incoming messages. In addition, messages are replayed before app handler is knows, so they aren't passed to it. This patch implements the fix. Bug: 882887, 944484 Change-Id: I6f53d65488f196f76dedc0b8ae23f9889d5c13a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533875Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#644773}
-
Alessio Bazzica authored
NOTRY=True Bug: webrtc:9577 Change-Id: I6c045db1ccb087634277fa5a2d444cbd6bfdde45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541182 Commit-Queue: Ale Bzk <alessiob@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#644772}
-
Brian Osman authored
Skia's NullGL interface is deprecated, and soon to be removed. For some unit tests in other modules, the Mock GrContext is a drop-in replacement. Here, we end up testing the same path in PaintCanvasVideoRenderer, but with slightly different behavior inside Skia. Ultimately, NewSkImageFromVideoFrameNative returns nullptr. Previously, this was due to the context being abandoned. Now, it fails because the Mock context doesn't support adopted textures at all. (The new code would test the same code path even without the abandonContext call). See also: https://cs.chromium.org/chromium/src/media/renderers/paint_canvas_video_renderer.cc?l=239 Change-Id: Ida0b22c7c60fc5217d5931b79f44a61cc80992b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540357 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#644771}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2b058ca0584c..bc2a48ba8635 git log 2b058ca0584c..bc2a48ba8635 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 perezju@chromium.org [tracing] Restrict writing unstructured trace data Created with: gclient setdep -r src/third_party/catapult@bc2a48ba8635 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:928278 TBR=sadrul@chromium.org Change-Id: I8e6796bc485064108e410bce22f32c0ae8e20ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541337Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644770}
-
Noel Gordon authored
Text diff --- C:\b\s\w\iomudyw9\layout-test-results\paint/invalidation/scroll/scrollbar-damage-and-full-viewport-repaint-expected.txt +++ C:\b\s\w\iomudyw9\layout-test-results\paint/invalidation/scroll/scrollbar-damage-and-full-viewport-repaint-actual.txt @@ -4,11 +4,21 @@ "name": "LayoutView #document", "bounds": [1000, 600], "drawsContent": false, + "backgroundColor": "#FFFFFF" + }, + { + "name": "Scrolling Layer", + "bounds": [1000, 600], + "drawsContent": false + }, + { + "name": "Scrolling Contents Layer", + "bounds": [1000, 600], "contentsOpaque": true, "backgroundColor": "#FFFFFF", "paintInvalidations": [ { - "object": "LayoutBlockFlow DIV id='container'", + "object": "HorizontalScrollbar", "rect": [1, 236, 185, 15], "reason": "scroll control" } Tbr: wangxianzhu@chromium.org No-try: true Bug: 919789 Change-Id: Id2bbe29d28fae1b72f64b1deed5649e4ee5ece3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541616Reviewed-by:Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#644769}
-
Noel Gordon authored
Tbr: foolip@ Bug: 626703 Change-Id: Iea612e6bed06bea1799d51b59c770d230b1dfd44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541396Reviewed-by:
-
arthursonzogni authored
This test is still flaky. Error: ``` Value of: trace_receiver_helper.TraceHasMatchingString("TestEarlyEvent") Actual: false Stack trace: ``` Expected: true Tbr: oysteine@chromium.org Bug: 1534867 Change-Id: Id5c1111d1e5dc8dfc97b09c835caae24457bf28c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541179Reviewed-by:Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#644767}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c8ba8b240967..8f22a28e30b0 git log c8ba8b240967..8f22a28e30b0 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 phensman@webrtc.org Check render size instead of frame size. 2019-03-27 brandtr@webrtc.org Change VideoCodecTestStats API. Created with: gclient setdep -r src/third_party/webrtc@8f22a28e30b0 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I477b4d0f25c1026e1064eb3ea71d4db7cf931a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541336Reviewed-by:
-
Justin Cohen authored
Bug: 930123, 943569 Change-Id: If434286ed7188e83966ff97acb5f441bbc70ae4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540103Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#644765}
-
Brian Salomon authored
Bug: skia:8193 Change-Id: Ic261aaebaae07ddc5c710f422f2a7bdfa3cd611d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536814Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#644764}
-
Javier Ernesto Flores Robles authored
TBR=rohitrao@chromium.org,kkhorimoto@chromium.org Bug: 946461 Change-Id: Id255939ef535ef51d0c7807de8b5fda7b9b809e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541181Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/010355d08889..ffaffb18986d Created with: gclient setdep -r src-internal@ffaffb18986d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=robertocn@chromium.org,noel@chromium.org,eirage@chromium.org Change-Id: I8de8e809e0ec3864b234babc28758d90cabdb378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540754Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/eec23d98..0a9ce6e0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iffc3c2efff83dc4672dc5af83c692d4a642aea64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540389Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644761}
-
Mike West authored
https://mikewest.github.io/sec-metadata/#sec-fetch-site-header defines a `none` value for `Sec-Fetch-Site`, which should be delivered along with navigational requests which were initiated directly from the browser, and not from a user's interaction with websites. This patch implements this new value in `NavigationRequest::AddAdditionalRequestHeaders`, and adds tests for some of the core use cases we expect servers to care about when examining this header: address bar navigations, and bookmark navigations. We'll add additional test cases in future patches as we work out the right answers to the questions raised in [1] and [2]. [1]: https://mikewest.github.io/sec-metadata/#directly-user-initiated [2]: https://docs.google.com/document/d/1YdakWfCR29pVNHURgceKrM_zjGN61xdnCXdZIGpQzxQ Bug: 868286 Change-Id: I4866daba27a8763966cf3b213d0c0e916c0db787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520667Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#644760}
-
Jan Wilken Dörrie authored
This reverts commit 97a9b2cf. Reason for revert: Flag is in wrong position Original change's description: > [Passwords] Create iOS UI Flag for HTTP FOAS > > TBR=vasilii@chromium.org > > Bug: 914765 > Change-Id: Id318bd708fd718ebbec0bcd3fad245155eec5e5e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539999 > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644446} TBR=vasilii@chromium.org,jdoerrie@chromium.org Change-Id: I7f230259d55412af1a2c7617cd0b9738dc7ea59a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 914765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541180Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#644759}
-
Stephen Nusko authored
This will process perfetto::TracePacket sequences and output the data in the old legacy json trace format used by chromium. Change-Id: I8facc1b7371e66c0f444ed6010b379ac407b5c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514834 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#644758}
-
Noel Gordon authored
Test has become a persistent flake in Release mode Linux & Win. Update test expectations, [ Crash Pass Failure Timeout ] Tbr: jsbell@ No-try: true Bug: 835943 Change-Id: Ic3e3bcaff34c4bbcff6b8ec7cf17390dadb7584d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538275Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I599d489c58438194684c19fafdc3c342420063a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540755Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/003e9f14f665..c476e5da4fef git log 003e9f14f665..c476e5da4fef --date=short --no-merges --format='%ad %ae %s' 2019-03-27 robertphillips@google.com Fix bug in GrResourceAllocator's intermediate flushing (take 2) Created with: gclient setdep -r src/third_party/skia@c476e5da4fef The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:942538 TBR=stani@chromium.org Change-Id: I18767949ddeb37389b20d787df9b4f3bbc43634a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540753Reviewed-by:
-
Justin Cohen authored
The KeepRenderProcessAlive webState flag allows the ios/web webView container to track it's |window| status, and instructs the WebClient to attach the webView back to a window if it's hidden. For ios/chrome, this is simply the keyWindow. This prevents the WebProcess and NetworkProcess from suspending for active views. ios/chrome set KeepRenderProcessAlive to true for the active webState with the BVC (or sub-presented view controllers)), or for one-off webState's like DOMDistiller and Preload. See go/prevent-wkwebview-suspend for details. Bug: 930123, 943569 TBR: noyau Change-Id: I0e8e5cb0f13e21091a3fefcc4e79685d86fe352c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529921 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#644754}
-
Rayan Kanso authored
Add an origin checkbox for filtering between events belonging to the current origin or all origins. Also replaces the Service Worker ID with the Service Worker source (script name) to be more user-friendly. Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=942174#c2 Bug: 942174, 927726 Change-Id: I5afb9929d1693d8c1faf0b166b671dddc8111d1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526261 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#644753}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/712fb89ca86b..c8ba8b240967 git log 712fb89ca86b..c8ba8b240967 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 alessiob@webrtc.org Restrict RNN VAD and PFFFT wrapper visibility 2019-03-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 69e6e3c1..d3647303 (644573:644705) Created with: gclient setdep -r src/third_party/webrtc@c8ba8b240967 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0c04fb1e458f962ecd756ae82e62b1ef7f89992b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540752Reviewed-by:
-
Noel Gordon authored
Test failing on various bots. Regression range chromium: 644626-644650 update expectations. Tbr: foolip@chromium.org Bug: 626703 Change-Id: Ia8c846ac2b50bbf5da36182660124548e32e72aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541137Reviewed-by:
-
Noel Gordon authored
Flaky external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/counter-styles-3/system-cyclic-invalid.html Flaky test, update expectation [ Pass Failure Timeout ]. Regression range chromium: 644626-644650 Tbr: foolip@chromium.org Bug: 626703 Change-Id: I73f9be263f0e5f21937ec101ae7eeb98be4ab765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538269Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium d82b2e82. With Chromium commits locally applied on WPT: 685a1df9 "Extend canvas getContextAttributes WPTest" 11eae161 "HTMLVideoElement: implement playsinline and auto-fullscreen." 1bf12f7c "Revert "Fix external/wpt/event-timing/event-timing-onloadobserve.html to be more deterministic"" efbe41b8 "Change unoptimized-images feature policy to unoptimized-lossy-images." 34ea864a "Revert "Change unoptimized-images feature policy to unoptimized-lossy-images."" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ibd5c5a57bff1d7452d6fe9344adc932bc75c34df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540343Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644749}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fded4f609520..5fa32da9cc18 git log fded4f609520..5fa32da9cc18 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 fmayer@google.com Log stats in tests. 2019-03-27 fmayer@google.com Count total samples and map reparses in stats. 2019-03-27 fmayer@google.com Add some metadata to heap dumps. Created with: gclient setdep -r src/third_party/perfetto@5fa32da9cc18 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:129054982 TBR=perfetto-bugs@google.com Change-Id: I7f2cbdacb3da3017e33dee123001854bb2931723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540750Reviewed-by:
-
Denis Kuznetsov authored
After deprecation of gaia_auth extension in https://codereview.chromium.org/2686683002, there is no more listener of a clearOldAttempts message from GAIA in chrome codebase. So in current code the only effect of this message is warning in JS console triggered by authenticator.js:637 during tests. Change-Id: I1d734b99c44c8f48d41dac737325cb4e859aa057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534166Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#644747}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f55ec9869d22..010355d08889 Created with: gclient setdep -r src-internal@010355d08889 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=robertocn@chromium.org,noel@chromium.org,eirage@chromium.org Change-Id: I173e86692fa5fefd66fea369b3d2a2df3df1ffd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540751Reviewed-by:
-
Rayan Kanso authored
Events are shown in a data grid. Clicking on a row will create a popover to show metadata. This CL also adds functionality for the refresh/clear buttons. Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=942174#c1 Bug: 942174, 927726 Change-Id: Id6fc6dba7ddbc2e175992e76ffea3e29da947753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524290 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
The string "Bookmark" used in the tools menu was translated as a noun in some languages. This CL adds a meaning field specifying that it is a verb. Adding a meaning field will trigger a new translation. Bug: 940876 Change-Id: Iee06126153692b22a3be75fc550e0af189faa601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541097Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#644744}
-
Boris Sazonov authored
This CL simplifies the code in FreIntentCreator by using better suited Intent ctors and by moving addPendingIntent calls to create method. Also, createInternal method is extracted so subclasses can override it. Bug: 942175 Change-Id: Ifb95fce6597739c59e925e865b693eda46841f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538497Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#644743}
-
Andreas Haas authored
A wpt test showed that for WebAssembly streaming compilation, we did not handle the abort of a {fetch} correctly. With this CL we throw a DOMException in that case. I am not an expert of the FetchDataLoader API, and of the blink GC. Please take a closer look at these aspects. R=ricea@chromium.org Bug: chromium:943487 Change-Id: I3038415265928947233664653a6e64316d240405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535877 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#644742}
-
Henrique Ferreiro authored
This change allows to change the loop: for (int id = kIntFirstCSSProperty; id <= kIntLastCSSProperty; ++id) CSSPropertyID property_id = static_cast<CSSPropertyID>(id); for the simpler: for (CSSPropertyID property_id : CSSPropertyIDList()) Additionally, remove unneeded static casts from kCSSPropertyAliasList. Bug: 936369 Change-Id: I4ebcd57cce26d2021da04f9f02e0dbca7a3c4585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538287Reviewed-by:Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#644741}
-
