- 19 Sep, 2014 40 commits
-
-
stevenjb authored
This is a follow up CL for 414417 that includes the ONC translation necessary for the Wimax UI and fixes the JS to use the new WiMAX capitalization. It also adds a WiMAX entry to the HTML doc. BUG=414417 Review URL: https://codereview.chromium.org/581213003 Cr-Commit-Position: refs/heads/master@{#295774}
-
gpdavis.chromium authored
Screenshots: Ubuntu: http://i.imgur.com/FuzZfcr.jpg OSX: http://i.imgur.com/ylHBVCx.png BUG=407453 Review URL: https://codereview.chromium.org/501273002 Cr-Commit-Position: refs/heads/master@{#295773}
-
dnicoara authored
Scroll events are mouse events as well. On debug builds this DCHECK would otherwise get triggered. BUG=none NOTRY=true Review URL: https://codereview.chromium.org/590523004 Cr-Commit-Position: refs/heads/master@{#295772}
-
wjmaclean authored
The test MediaGalleriesPlatformAppBrowserTest.MediaGalleriesRead is flaky on MacOSX bots. BUG=416128 NOTRY=true TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/588663003 Cr-Commit-Position: refs/heads/master@{#295771}
-
scottmg authored
The linker is coalescing sections incorrectly (x64-only, incremental-only), so disable these tests for now in that configuration. See crbug.com/251251 for more details. Upstream toolchain bug at https://connect.microsoft.com/VisualStudio/feedbackdetail/view/967992 R=wfh@chromium.org BUG=251251 Review URL: https://codereview.chromium.org/580213002 Cr-Commit-Position: refs/heads/master@{#295770}
-
eakuefner authored
R=dsinclair Review URL: https://codereview.chromium.org/587733002 Cr-Commit-Position: refs/heads/master@{#295769}
-
Hans Wennborg authored
When 216630 was rolled in, there was one roll that got reverted, and then we re-built packages for the next one. However, some devs and maybe bots who didn't sync to the revert got stuck with the old binaries which would now mismatch against goma's checksum. No behavior change. BUG=415883 R=thakis@chromium.org Review URL: https://codereview.chromium.org/583233004 Cr-Commit-Position: refs/heads/master@{#295768}
-
John Abd-El-Malek authored
R=vadimsh@chromium.org Review URL: https://codereview.chromium.org/583343002 Cr-Commit-Position: refs/heads/master@{#295767}
-
danakj authored
IsIdentityOrTranslation, IsScaleOrTranslation, and HasPerspective are now provided by SkMatrix44 so use those. R=vollick BUG=408710 Review URL: https://codereview.chromium.org/590553002 Cr-Commit-Position: refs/heads/master@{#295766}
-
jbroman authored
Revert of Telemetry: Use the leftmost argument to find the test to parse flags. (patchset #2 id:20001 of https://codereview.chromium.org/582793002/) Reason for revert: Broke Android debug gpu bot: http://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%207%29/builds/12692 This bot relies on being able to supply some flags before the test name; it runs: content/test/gpu/run_gpu_test.py --browser=android-content-shell webgl_conformance --webgl-conformance-version=1.0.1 Original issue's description: > Telemetry: Use the leftmost argument to find the test to parse flags. > > Previously it would check all of the arguments, and use the last test found. > This is causes problems as different tests can be used to create the parser and > accepts the parsed flags. > > SHERIFFS: If errors related to parsing flags for run_measurement, run_benchmark > or run_gpu_test.py appear, this is likely the cause. It is safe to revert. > > BUG=413334 > > Committed: https://crrev.com/5afe5a61f03743bd523dae66f662ad773f8befb9 > Cr-Commit-Position: refs/heads/master@{#295738} TBR=nednguyen@google.com,kbr@chromium.org,tonyg@chromium.org,dtu@chromium.org,ariblue@google.com NOTREECHECKS=true NOTRY=true BUG=413334 Review URL: https://codereview.chromium.org/584023003 Cr-Commit-Position: refs/heads/master@{#295765}
-
davidben authored
Align with SSLClientSocketNSS's behavior around the PeerCertificate object. Within the sandbox for Chromoting, the platform certificate may be unavailable while the SSL-layer certificate is. Match NSS in using the SSL-layer certificate for many operations. Also check appropriately for the platform certificate being NULL in DoVerifyCert rather than simply crashing. BUG=414315 TEST=Install Chromoting app. Connecting to another computer works. Review URL: https://codereview.chromium.org/576233002 Cr-Commit-Position: refs/heads/master@{#295764}
-
chrisha authored
This modifies the gclient hook to remove files that were inadvertently downloaded by a previous version of the script. BUG=414826 Review URL: https://codereview.chromium.org/586063002 Cr-Commit-Position: refs/heads/master@{#295763}
-
thestig authored
Although uncommon, 294 files in /bin and /usr/bin has this pattern. Compared with 1300 files that starts with #!/path. Review URL: https://codereview.chromium.org/587463002 Cr-Commit-Position: refs/heads/master@{#295762}
-
spang authored
https://chromium.googlesource.com/chromiumos/chromite/+log/1ae4638a4cd3313799f2d2598c39ff0e8941aef6..8e92d5c24da7967e27ab2498abc2d2f7ac6ec65a TBR=marcheu BUG=412508 Review URL: https://codereview.chromium.org/590543002 Cr-Commit-Position: refs/heads/master@{#295761}
-
sergeyu authored
Previously VideoReader/Writer were abstract interfaces with single implementation. Now both the reader and writer are concrete implementations reusing ChannelDispatcherBase, which significantly simplified both. BUG=402993 Review URL: https://codereview.chromium.org/577473002 Cr-Commit-Position: refs/heads/master@{#295760}
-
jamiewalch authored
This is a minimal fix suitable for merging to M38. The underlying problem is that we create a new MenuButton instance (with its own click handler) for every connection. I recently changed the behaviour of MenuButton so that it toggles the 'active' class instead of adding it so that clicking on the button while a menu is open will dismiss it. However, this breaks if there an even number of MenuButton instances for a single DOM element. The correct fix is to make the tool-bar buttons owned by the tool-bar, which is a singleton. However, this minimal fix, which restores the M37 behaviour, is a better option for merging to M38. BUG=415410 Review URL: https://codereview.chromium.org/584693003 Cr-Commit-Position: refs/heads/master@{#295759}
-
guoweis authored
Move FindFullName outside LIBPEERCONNECTION_LIB definition block. This is to solve a link break when new finch experiment is defined inside peerconnection.cc while libpeerconnection.so is built as a shared library. BUG= Review URL: https://codereview.chromium.org/582133002 Cr-Commit-Position: refs/heads/master@{#295758}
-
n.bansal authored
Currently there are no keyboard shortcuts to rotate pdf documents. This patch adds the following keyboard shortcuts to rotate pdf documents : Rotate counterclockwise : Control + [ Rotate clockwise : Control + ] BUG=111232 Review URL: https://codereview.chromium.org/581913003 Cr-Commit-Position: refs/heads/master@{#295757}
-
thestig authored
BUG=415382 Review URL: https://codereview.chromium.org/583873003 Cr-Commit-Position: refs/heads/master@{#295756}
-
vmiura authored
Moves debug logging and tracing logic off the command processing path when they are disabled. BUG=394570 Review URL: https://codereview.chromium.org/553293002 Cr-Commit-Position: refs/heads/master@{#295755}
-
John Abd-El-Malek authored
BUG=414808 R=scottmg@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/589633002 Cr-Commit-Position: refs/heads/master@{#295754}
-
davidben authored
BufferedResourceHandler passes the response to both the old and the new handler, so there is a race where the streams logic could access headers on the UI thread while the old handler (AsyncResourceHandler) is busy modifying them (via ChromeResourceDispatcherHostDelegate). BUG=none Review URL: https://codereview.chromium.org/588643002 Cr-Commit-Position: refs/heads/master@{#295753}
-
jmedley authored
BUG=none R= TEST=none NOTRY=true (documentation only change) Review URL: https://codereview.chromium.org/587773002 Cr-Commit-Position: refs/heads/master@{#295752}
-
marshall authored
WebRTCInternals uses NotificationRegistrar which must be deleted on the UI thread. In cases where the UI thread is not the same as the main thread (like in Chromium Embedded Framework) the destruction of WebRTCInternals via AtExitManager at shutdown will cause a CalledOnValidThread() check failure. There's no particular reason why the object needs to be deleted at shutdown so just leak it instead. BUG=none TEST=none Review URL: https://codereview.chromium.org/575283004 Cr-Commit-Position: refs/heads/master@{#295751}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/43d361f..87e2437 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=stephana@google.com Review URL: https://codereview.chromium.org/589593002 Cr-Commit-Position: refs/heads/master@{#295750}
-
scottmg authored
On trybots, the viewer shutdown is frequently taking 16s, making ash_unittests as a whole take ~20m. Killing the viewer more aggressively makes all the tests run at the "normal" time in the 1-500ms range, dropping total time to 5-6m. R=cpu@chromium.org BUG=411147 Review URL: https://codereview.chromium.org/584513004 Cr-Commit-Position: refs/heads/master@{#295749}
-
kulkarni.a authored
Review URL: https://codereview.chromium.org/492773002 Cr-Commit-Position: refs/heads/master@{#295748}
-
dougsteed authored
Generalize crypto::SignatureCreator to allow choice of hash function, so as to support SHA256 (not just SHA1). BUG=412531 R=rsleevi@chromium.org,davidben@chromium.org TBR=pfeldman@chromium.org Review URL: https://codereview.chromium.org/560583002 Cr-Commit-Position: refs/heads/master@{#295747}
-
newt authored
Chrome for Android can use the same code for displaying the application version on the about:version page as other platforms. There's no need to special-case it. Review URL: https://codereview.chromium.org/583003002 Cr-Commit-Position: refs/heads/master@{#295746}
-
jmadill authored
This should be consistent with the other targets in the builder. BUG=391895 Review URL: https://codereview.chromium.org/584953002 Cr-Commit-Position: refs/heads/master@{#295745}
-
mlerman authored
BUG=NONE Review URL: https://codereview.chromium.org/584153002 Cr-Commit-Position: refs/heads/master@{#295744}
-
adamk authored
This brings in <paper-ripple> implemented with CSS instead of <canvas>, and presumably a slew of other changes. TBR=ykkyip@chromium.org,nduca@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/586823002 Cr-Commit-Position: refs/heads/master@{#295743}
-
n.bansal authored
This patch adds the enterprise policy changes for ImportAutofillFormData preference. BUG=415975 Review URL: https://codereview.chromium.org/581583004 Cr-Commit-Position: refs/heads/master@{#295742}
-
sergiyb authored
BUG=387410 R=qyearsley@chromium.org, ojan@chromium.org Review URL: https://codereview.chromium.org/560123004 Cr-Commit-Position: refs/heads/master@{#295741}
-
pneubeck authored
BUG=415409 TEST=Logged in as regular user, checked that "Import and bind to device" button is enabled. Installed a cert using platformKeys API and it was listed on chrome://settings/certificates. chrome://network listed "Certificates Loaded". Review URL: https://codereview.chromium.org/585823002 Cr-Commit-Position: refs/heads/master@{#295740}
-
mukai authored
BUG=None R=sadrul@chromium.org TEST=manually Review URL: https://codereview.chromium.org/582923002 Cr-Commit-Position: refs/heads/master@{#295739}
-
jbroman authored
Previously it would check all of the arguments, and use the last test found. This is causes problems as different tests can be used to create the parser and accepts the parsed flags. SHERIFFS: If errors related to parsing flags for run_measurement, run_benchmark or run_gpu_test.py appear, this is likely the cause. It is safe to revert. BUG=413334 Review URL: https://codereview.chromium.org/582793002 Cr-Commit-Position: refs/heads/master@{#295738}
-
dtu authored
This allows us to read MSRs on Windows Vista+. Also move ReadMsr into PlatformBackend. BUG=336558 TEST=tools/telemetry/run_tests msr Committed: https://crrev.com/2156b0323c83d6f11e68344ecf7e7e0c833cfa14 Cr-Commit-Position: refs/heads/master@{#295634} Review URL: https://codereview.chromium.org/578123002 Cr-Commit-Position: refs/heads/master@{#295737}
-
jri authored
BUG=413370 Review URL: https://codereview.chromium.org/585003002 Cr-Commit-Position: refs/heads/master@{#295736}
-
hjd authored
Third side of crrev.com/552293002/ BUG=408636 Review URL: https://codereview.chromium.org/584833002 Cr-Commit-Position: refs/heads/master@{#295735}
-