- 26 Apr, 2018 40 commits
-
-
Max Morin authored
This reverts commit eebeab84. Reason for revert: Reverting due to failing test (crbug.com/836623). Original change's description: > Scroll documentElement using LayoutView natively > > When computing the scroll-chain for a gesture, only Elements can be > added to the chain. However, the document element (i.e. <html>) doesn't > have a ScrollableArea itself. Its scrolling is delegated to the > document *node* (i.e. the LayoutView) which cannot be added to the > chain. Thus, we use the documentElement to represent scrolling the > LayoutView. See ScrollManager::RecomputeScrollChain to see this > explicitly in code. > > When actually performing the scroll we need to reverse the above > substitution but we currently have a bug: in Element::NativeApplyScroll > we apply this substitution if we're scrolling the effective root > scroller rather than the document element. If the root scroller API is > enabled and the root scroller is changed to a different element, the > document can no longer be scrolled since it will fail to reverse the > documentElement<->LayoutView substitution and try to use the document > element's ScrollableArea which doesn't exist. > > A similar fix is needed in LogicalScroll for keyboard scrolls. This > complicated logic is encoded in the scroll-chain calculation so I've > rewritten that method to use the scroll chain for consistency. > > An additional change is needed since LayoutView::Scroll uses > LocalFrameView::GetScrollableArea to scroll. In the main frame, this > will be the RootFrameViewport which uses the global root scroller as > the layout viewport. Thus, if the root scroller is set to another > element, scrolling the LayoutView would actually scroll that element. > The global root scroller will always be scrolled using the correct > ScrollableArea via the ViewportScrollCallback so LayoutView shouldn't > be treated specially in this case. In fact, I've removed > LayoutBox::Scroll and its overrides altogether and replaced its > call sites with ScrollableArea directly. > > Bug: 813747 > Change-Id: I9e9a27ff684abf969c27ac152c860778a7e00e39 > Reviewed-on: https://chromium-review.googlesource.com/1018880 > Reviewed-by: Steve Kobes <skobes@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553303} TBR=bokan@chromium.org,skobes@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. No-Try: true Bug: 813747, 836623 Change-Id: Iaa92fdb566bec60fcdc2f03e9990fc4aacab0be1 Reviewed-on: https://chromium-review.googlesource.com/1029971 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553981}
-
Noel Gordon authored
Test disabled. Test is broken when re-enabled. Add TODO note about it, comment only change. Bug: 836254 Change-Id: I76d0e8b3bb7f1491a05b55ceb6f3d3adc46f497c Reviewed-on: https://chromium-review.googlesource.com/1029398Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553980}
-
Max Morin authored
This reverts commit 1e3550d5. Reason for revert: Failing tests, see crbug.com/837201 Original change's description: > Migrate Arc unit tests to IdentityManager > > identity::IdentityManager is the new API that replaces SigninManager[Base]. > > This includes ArcTermsOfServiceDefaultNegotiatorTest and ArcSupportHostTest. > > Bug: 825190, 731023 > Change-Id: I316c90c6d278e52d723468d63bc21cd288b2642b > Reviewed-on: https://chromium-review.googlesource.com/1025898 > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553949} TBR=yusukes@chromium.org,treib@chromium.org Change-Id: Iba9649631ec8633c0b89b867a60e89d3d63a01ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 825190, 731023, 837201 Reviewed-on: https://chromium-review.googlesource.com/1030150Reviewed-by:
-
Noel Gordon authored
Disabled test: re-enable all bots. Fixed on issue 804413 and related. Tbr: slangley No-Presubmit: true Bug: 836254 Change-Id: Ia6760b8bb73a584f85bf893a448897c44b2fa169 Reviewed-on: https://chromium-review.googlesource.com/1029395Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553978}
-
Lukasz Anforowicz authored
WebDriverSitePerProcessPolicyBrowserTest attempts to calculate the default state of site isolation before the test starts. This calculation needs to take into account the official builds, where testing/variations/fieldtrial_testing_config.json does not apply. Bug: 836261 Change-Id: I0526969892a39a54a88258d00ee2e66625aa35f8 Reviewed-on: https://chromium-review.googlesource.com/1028227 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#553977}
-
Michael Lippautz authored
The stressbot now runs with HeapIncrementalMarkingStress No-try: true Tbr: haraken@chromium.org Bug: chromium:757440 Change-Id: Ieb520b74417a635ff91ea9db2be7bcc6a875e19b Reviewed-on: https://chromium-review.googlesource.com/1030090Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#553976}
-
Noel Gordon authored
After crrev.com/552575 tests in test extension testcase namespace must be anon Function so the test case name is shown on success/failure, so change the ShareDialog testcase code to conform to that rule. Bug: 836254 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib152ff792837cd21420eed6b9918e15d03f6f95c Reviewed-on: https://chromium-review.googlesource.com/1029394Reviewed-by:
-
https://skia.googlesource.com/skia.git/+log/e56ced15da1d..5c9369eb14f5 $ git log e56ced15d..5c9369eb1 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I0e88769e2bead364620ec62ad48a484572fbdb07 Reviewed-on: https://chromium-review.googlesource.com/1029493Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553974}
-
Marc Treib authored
This CL migrates ProfileSyncService to IdentityManager for getting info on the primary account. This includes switching from SigninManagerBase::Observer to IdentityManager::Observer. The only remaining use of SigninManager within PSS it to call SignOut() which isn't exposed by IdentityManager yet. Bug: 825190 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icf9398d63794cab03cb559adba5c767e18c31c0a Reviewed-on: https://chromium-review.googlesource.com/983914 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#553973}
-
Max Morin authored
Tbr: robertma Bug: 836627 Change-Id: I956f30dcc13087ee16a655102d8bbd706dab296e Reviewed-on: https://chromium-review.googlesource.com/1029953 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
-
Max Morin authored
This reverts commit 5f7ad258. Reason for revert: Still flaky, see bug. Original change's description: > Fix the flaky failure of WebContentsImplBrowserTest.PausePageScheduledTasks > > The flaky failure of the test seems to be due to not waiting long enough after > resuming work again. This Cl changes the workaround logic to actually wait until > the javascript work again (or let the test fail by timing out otherwise). > > Bug: 832191 > Change-Id: I3c2f04ccf4d00cee6505e607566628d690f4ef00 > Reviewed-on: https://chromium-review.googlesource.com/1011744 > Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553927} TBR=kinuko@chromium.org,kmarshall@chromium.org,piman@chromium.org,gyuyoung.kim@lge.com Change-Id: Ie9e39f441305ac022494325ed7756be50574a401 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 832191 Reviewed-on: https://chromium-review.googlesource.com/1029972Reviewed-by:
-
Dan Elphick authored
Also replaces some tabs in file with spaces. R=peter Change-Id: I9bad8a3094c03736df6cbf51ee4a12ee95d2106c Reviewed-on: https://chromium-review.googlesource.com/1029957 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#553970}
-
Max Morin authored
This reverts commit 9f9200be. Reason for revert: browser tests are failing https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/7273 Log: [ RUN ] UserImageManagerTest.SaveUserImageFromProfileImage HTTPS server started on 127.0.0.1:42101... sending server_data: {"host": "127.0.0.1", "port": 42101} (36 bytes) [6522:6522:0426/022529.925055:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [6522:6522:0426/022529.925165:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [6522:6522:0426/022529.925262:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [6522:6522:0426/022529.925291:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [6522:6522:0426/022530.089783:WARNING:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source: (0) [6522:6522:0426/022530.945689:INFO:CONSOLE(9811)] "Loading asset bundle oauth-enrollment", source: chrome://oobe/login.js (9811) [6522:6522:0426/022530.996180:INFO:signin_screen_handler.cc(1473)] Login WebUI >> active: 1, source: account-picker [6522:6522:0426/022531.033848:ERROR:proximity_auth_local_state_pref_manager.cc(154)] Failed to find prefs for current user. [6522:6522:0426/022531.033881:ERROR:proximity_auth_local_state_pref_manager.cc(89)] Failed to get easyunlock_allowed. [6522:6522:0426/022531.033890:ERROR:proximity_auth_local_state_pref_manager.cc(154)] Failed to find prefs for current user. [6522:6522:0426/022531.033896:ERROR:proximity_auth_local_state_pref_manager.cc(100)] Failed to get easyunlock_enabled. [6522:6522:0426/022531.039781:ERROR:proximity_auth_local_state_pref_manager.cc(154)] Failed to find prefs for current user. [6522:6522:0426/022531.039814:ERROR:proximity_auth_local_state_pref_manager.cc(100)] Failed to get easyunlock_enabled. [6522:6722:0426/022531.042728:ERROR:account_manager.cc(37)] Failed to read tokens file [6522:6522:0426/022531.053581:WARNING:user_session_manager.cc(1086)] Attempting to save user password for non enterprise user. [6522:6522:0426/022531.093063:INFO:chrome_cryptauth_service.cc(153)] Refresh token not yet available; waiting before starting CryptAuth managers. [6522:6522:0426/022531.093093:INFO:remote_device_loader.cc(73)] Loading 0 remote devices [6522:6522:0426/022531.093117:INFO:tether_service.cc(164)] TetherService has started. Initial user preference value: 1 [6522:6522:0426/022531.093132:INFO:tether_service.cc(420)] Tether state has changed. New state: [BLE is not present on the device], Old state: [TetherService initializing] [6522:6522:0426/022531.094248:WARNING:auth_sync_observer.cc(93)] Invalidate OAuth token because of an auth error: Invalid credentials (3). [6522:6522:0426/022531.096077:INFO:tether_service.cc(420)] Tether state has changed. New state: [no potential Tether hosts], Old state: [BLE is not present on the device] [6522:6522:0426/022531.137699:ERROR:account_info_fetcher.cc(58)] OnGetTokenFailure: Not authorized. [6522:6522:0426/022531.137776:WARNING:account_fetcher_service.cc(321)] Failed to get UserInfo for test-user@gmail.com [6522:6713:0426/022531.181952:ERROR:service_manager_context.cc(258)] Attempting to run unsupported native service: /b/s/w/ir/out/Release/chrome_renderer.service [6522:6838:0426/022531.196256:ERROR:fake_gaia.cc(322)] Unhandled request /avatar.jpg [6522:6522:0426/022531.274035:INFO:CONSOLE(9795)] "Finished loading asset bundle oauth-enrollment", source: chrome://oobe/login.js (9795) ../../chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc:158: Failure Value of: ReadFileToString(test_data_dir.Append("chromeos").Append("avatar1.jpg"), &profile_image_data) Actual: false Expected: true Stack trace: #0 0x000001db18ec testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x000001db12c9 testing::internal::AssertHelper::operator=() #2 0x00000152186a chromeos::UserImageManagerTest::HandleRequest() #3 0x00000068b60a _ZN4base8internal7InvokerINS0_9BindStateIMN8autofill24FormStructureBrowserTestEFNSt3__110unique_ptrIN3net11test_server12HttpResponseENS5_14default_deleteIS9_EEEERKNS8_11HttpRequestEEJNS0_17UnretainedWrapperIS4_EEEEEFSC_SF_EE3RunEPNS0_13BindStateBaseESF_ #4 0x00000394cf2e net::test_server::EmbeddedTestServer::HandleRequest() #5 0x00000394de16 _ZN4base8internal7InvokerINS0_9BindStateIMN3net11test_server18EmbeddedTestServerEFvPNS4_14HttpConnectionENSt3__110unique_ptrINS4_11HttpRequestENS8_14default_deleteISA_EEEEEJNS0_17UnretainedWrapperIS5_EEEEEFvS7_SD_EE3RunEPNS0_13BindStateBaseES7_OSD_ #6 0x00000394e2bc net::test_server::HttpConnection::ConsumeData() #7 0x00000394dd04 net::test_server::EmbeddedTestServer::OnReadCompleted() #8 0x000003f5d160 net::TCPClientSocket::DidCompleteRead() #9 0x000003a3bdac _ZN4base8internal7InvokerINS0_9BindStateIM31PlatformNotificationServiceImplFvNS_12OnceCallbackIFvvEEEN7content28PersistentNotificationStatusEEJNS0_17UnretainedWrapperIS3_EES6_EEEFvS8_EE7RunOnceEPNS0_13BindStateBaseES8_ BrowserTestBase received signal: Terminated. Backtrace: #0 0x00000391bcdc base::debug::StackTrace::StackTrace() #1 0x000003d96185 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7fdaf5afdcb0 <unknown> #3 0x7fdaf5bc56d3 epoll_wait #4 0x0000043073bd epoll_dispatch #5 0x000004304e9c event_base_loop #6 0x000003928341 base::MessagePumpLibevent::Run() #7 0x0000038d5025 base::RunLoop::Run() #8 0x00000151abd8 chromeos::UserImageManagerTest::CompleteProfileImageDownload() #9 0x000001519dd9 chromeos::UserImageManagerTest_SaveUserImageFromProfileImage_Test::RunTestOnMainThread() #10 0x000003d95ee3 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #11 0x0000039bffaf ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #12 0x0000039bef2a ChromeBrowserMainParts::PreMainMessageLoopRun() #13 0x0000019def36 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #14 0x0000026a9af1 content::BrowserMainLoop::PreMainMessageLoopRun() #15 0x0000029cf9f7 content::StartupTaskRunner::RunAllTasksNow() #16 0x0000026a8652 content::BrowserMainLoop::CreateStartupTasks() #17 0x0000026abd13 content::BrowserMainRunnerImpl::Initialize() #18 0x0000026a6454 content::BrowserMain() #19 0x000003861bb8 content::ContentMainRunnerImpl::Run() #20 0x00000546c6cd service_manager::Main() #21 0x00000385ff24 content::ContentMain() #22 0x000003d95b02 content::BrowserTestBase::SetUp() #23 0x000003981476 InProcessBrowserTest::SetUp() #24 0x0000014c652a chromeos::LoginManagerTest::SetUp() #25 0x000001db6f8d testing::Test::Run() #26 0x000001db7b70 testing::TestInfo::Run() #27 0x000001db8077 testing::TestCase::Run() #28 0x000001dc3587 testing::internal::UnitTestImpl::RunAllTests() #29 0x000001dc310e testing::UnitTest::Run() #30 0x000003993f72 base::TestSuite::Run() #31 0x00000389a095 ChromeTestSuiteRunner::RunTestSuite() #32 0x000003db2ee9 content::LaunchTests() #33 0x00000389a554 LaunchChromeTests() #34 0x00000389a02e main #35 0x7fdaf5ae8f45 __libc_start_main #36 0x0000005ead2a _start [ RUN ] UserImageManagerTest.ProfileImageDownloadDoesNotClobber HTTPS server started on 127.0.0.1:46841... sending server_data: {"host": "127.0.0.1", "port": 46841} (36 bytes) [6959:6959:0426/022532.248974:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [6959:6959:0426/022532.249098:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [6959:6959:0426/022532.249185:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [6959:6959:0426/022532.249203:ERROR:network_type_pattern.cc(134)] NetworkTypePattern: wifi: Can not match empty type. [6959:6959:0426/022532.374425:WARNING:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source: (0) [6959:6959:0426/022533.138137:INFO:CONSOLE(9811)] "Loading asset bundle oauth-enrollment", source: chrome://oobe/login.js (9811) [6959:6959:0426/022533.193014:INFO:signin_screen_handler.cc(1473)] Login WebUI >> active: 1, source: account-picker [6959:6959:0426/022533.226604:ERROR:proximity_auth_local_state_pref_manager.cc(154)] Failed to find prefs for current user. [6959:6959:0426/022533.226648:ERROR:proximity_auth_local_state_pref_manager.cc(89)] Failed to get easyunlock_allowed. [6959:6959:0426/022533.226661:ERROR:proximity_auth_local_state_pref_manager.cc(154)] Failed to find prefs for current user. [6959:6959:0426/022533.226671:ERROR:proximity_auth_local_state_pref_manager.cc(100)] Failed to get easyunlock_enabled. [6959:6959:0426/022533.231525:ERROR:proximity_auth_local_state_pref_manager.cc(154)] Failed to find prefs for current user. [6959:6959:0426/022533.231562:ERROR:proximity_auth_local_state_pref_manager.cc(100)] Failed to get easyunlock_enabled. [6959:7142:0426/022533.235423:ERROR:account_manager.cc(37)] Failed to read tokens file [6959:6959:0426/022533.251976:WARNING:user_session_manager.cc(1086)] Attempting to save user password for non enterprise user. [6959:6959:0426/022533.280591:INFO:chrome_cryptauth_service.cc(153)] Refresh token not yet available; waiting before starting CryptAuth managers. [6959:6959:0426/022533.280634:INFO:remote_device_loader.cc(73)] Loading 0 remote devices [6959:6959:0426/022533.280674:INFO:tether_service.cc(164)] TetherService has started. Initial user preference value: 1 [6959:6959:0426/022533.280698:INFO:tether_service.cc(420)] Tether state has changed. New state: [BLE is not present on the device], Old state: [TetherService initializing] [6959:6959:0426/022533.283167:INFO:tether_service.cc(420)] Tether state has changed. New state: [no potential Tether hosts], Old state: [BLE is not present on the device] [6959:6959:0426/022533.329775:WARNING:auth_sync_observer.cc(93)] Invalidate OAuth token because of an auth error: Invalid credentials (3). [6959:6959:0426/022533.336889:ERROR:account_info_fetcher.cc(58)] OnGetTokenFailure: Not authorized. [6959:6959:0426/022533.336917:WARNING:account_fetcher_service.cc(321)] Failed to get UserInfo for test-user@gmail.com [6959:7130:0426/022533.360619:ERROR:service_manager_context.cc(258)] Attempting to run unsupported native service: /b/s/w/ir/out/Release/chrome_renderer.service [6959:7211:0426/022533.378097:ERROR:fake_gaia.cc(322)] Unhandled request /avatar.jpg [6959:6959:0426/022533.439723:INFO:CONSOLE(9795)] "Finished loading asset bundle oauth-enrollment", source: chrome://oobe/login.js (9795) ../../chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc:158: Failure Value of: ReadFileToString(test_data_dir.Append("chromeos").Append("avatar1.jpg"), &profile_image_data) Actual: false Expected: true Stack trace: #0 0x000001db18ec testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x000001db12c9 testing::internal::AssertHelper::operator=() #2 0x00000152186a chromeos::UserImageManagerTest::HandleRequest() #3 0x00000068b60a _ZN4base8internal7InvokerINS0_9BindStateIMN8autofill24FormStructureBrowserTestEFNSt3__110unique_ptrIN3net11test_server12HttpResponseENS5_14default_deleteIS9_EEEERKNS8_11HttpRequestEEJNS0_17UnretainedWrapperIS4_EEEEEFSC_SF_EE3RunEPNS0_13BindStateBaseESF_ #4 0x00000394cf2e net::test_server::EmbeddedTestServer::HandleRequest() #5 0x00000394de16 _ZN4base8internal7InvokerINS0_9BindStateIMN3net11test_server18EmbeddedTestServerEFvPNS4_14HttpConnectionENSt3__110unique_ptrINS4_11HttpRequestENS8_14default_deleteISA_EEEEEJNS0_17UnretainedWrapperIS5_EEEEEFvS7_SD_EE3RunEPNS0_13BindStateBaseES7_OSD_ #6 0x00000394e2bc net::test_server::HttpConnection::ConsumeData() #7 0x00000394dd04 net::test_server::EmbeddedTestServer::OnReadCompleted() #8 0x000003f5d160 net::TCPClientSocket::DidCompleteRead() #9 0x000003a3bdac _ZN4base8internal7InvokerINS0_9BindStateIM31PlatformNotificationServiceImplFvNS_12OnceCallbackIFvvEEEN7content28PersistentNotificationStatusEEJNS0_17UnretainedWrapperIS3_EES6_EEEFvS8_EE7RunOnceEPNS0_13BindStateBaseES8_ BrowserTestBase received signal: Terminated. Backtrace: #0 0x00000391bcdc base::debug::StackTrace::StackTrace() #1 0x000003d96185 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7ff6e7e3ccb0 <unknown> #3 0x7ff6e7f046d3 epoll_wait #4 0x0000043073bd epoll_dispatch #5 0x000004304e9c event_base_loop #6 0x000003928341 base::MessagePumpLibevent::Run() #7 0x0000038d5025 base::RunLoop::Run() #8 0x00000151abd8 chromeos::UserImageManagerTest::CompleteProfileImageDownload() #9 0x00000151aeb0 chromeos::UserImageManagerTest_ProfileImageDownloadDoesNotClobber_Test::RunTestOnMainThread() #10 0x000003d95ee3 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #11 0x0000039bffaf ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #12 0x0000039bef2a ChromeBrowserMainParts::PreMainMessageLoopRun() #13 0x0000019def36 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #14 0x0000026a9af1 content::BrowserMainLoop::PreMainMessageLoopRun() #15 0x0000029cf9f7 content::StartupTaskRunner::RunAllTasksNow() #16 0x0000026a8652 content::BrowserMainLoop::CreateStartupTasks() #17 0x0000026abd13 content::BrowserMainRunnerImpl::Initialize() #18 0x0000026a6454 content::BrowserMain() #19 0x000003861bb8 content::ContentMainRunnerImpl::Run() #20 0x00000546c6cd service_manager::Main() #21 0x00000385ff24 content::ContentMain() #22 0x000003d95b02 content::BrowserTestBase::SetUp() #23 0x000003981476 InProcessBrowserTest::SetUp() #24 0x0000014c652a chromeos::LoginManagerTest::SetUp() #25 0x000001db6f8d testing::Test::Run() #26 0x000001db7b70 testing::TestInfo::Run() #27 0x000001db8077 testing::TestCase::Run() #28 0x000001dc3587 testing::internal::UnitTestImpl::RunAllTests() #29 0x000001dc310e testing::UnitTest::Run() #30 0x000003993f72 base::TestSuite::Run() #31 0x00000389a095 ChromeTestSuiteRunner::RunTestSuite() #32 0x000003db2ee9 content::LaunchTests() #33 0x00000389a554 LaunchChromeTests() #34 0x00000389a02e main #35 0x7ff6e7e27f45 __libc_start_main #36 0x0000005ead2a _start Original change's description: > Migrate ProfileDownloader from URLFetcher to URLLoader > > BUG=773295 > > Change-Id: Ia199631a83a21b3210baa7741f6591875075a3b5 > Reviewed-on: https://chromium-review.googlesource.com/1024992 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553719} TBR=xiyuan@chromium.org,alemate@chromium.org,mmenke@chromium.org,tonikitoo@igalia.com Change-Id: I8eead0b4e3040fd8bc8dbb708099b373a4ffd217 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773295 Reviewed-on: https://chromium-review.googlesource.com/1029956 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
-
Max Morin authored
This reverts commit 3a01c225. Reason for revert: New test is flaky: crbug.com/837124. Original change's description: > webauthn: require focused tab, rather than focused frame. > > Kim points out in the bug that the current logic (see > https://chromium-review.googlesource.com/c/chromium/src/+/991073) > doesn't allow dev tools to be focused, so it's not possible to trigger > webauthn requests from the dev tools console. > > Nasko thought that the addition of a ContentBrowserClient API was too > large a hammer too. I've not been able to come up with any cleaner > solution however, but this change perhaps makes the hammer more > reasonable: > > In order to address the devtools issue, this change switches the focus > check to requiring that the tab be active in the focused window. (This > also matches what the cryptotoken extension does.) This means that it > has to chrome/ logic, rather than content/ logic, but we already had to > add an API to ContentBrowserClient for this and we can reuse that to > solve this problem too. > > Additionally, this change adds an interactive_ui_test to ensure that we > don't regress. > > Bug: 827266,836203 > Change-Id: I62226fc0366a83dc69d9cb32016108bdbe590d29 > Reviewed-on: https://chromium-review.googlesource.com/1007637 > Commit-Queue: Adam Langley <agl@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553838} TBR=nasko@chromium.org,thestig@chromium.org,agl@chromium.org,engedy@chromium.org No-Try: true Bug: 827266, 836203, 837124 Change-Id: I9a243c93eac8d27eb33fae22c703f1faaeb7b83e Reviewed-on: https://chromium-review.googlesource.com/1029970 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
-
Marina Ciocea authored
audio::UserInputMonitor overrides audio::UserInputMonitor::GetKeyPressCount() to read key press count (computed in browser process) from shared memory. Read only handle to key press count shmem is passed over IPC on audio service input stream creation. Design doc: https://docs.google.com/document/d/1GHL4uMlIFox2eAqsjUQVA8eJ7HYU3g2AoyAqyx3pxMA/edit?usp=sharing Notes: - Browser side implementation of key press count share memory, and wrapping of memory handle into a Mojo handle will be added in dependent CL https://crrev.com/c/1025754. - UserInputMonitor is enabled in MojoAudioInputStreamObserver constructor, when a stream is created, and disabled on connection error, called when the observed stream is destroyed. - audio:: and media:: UserInputMonitor implementations inherit from media::UserInputMonitorBase in order to keep media::AudioInputController unchanged for now. Inheritance will be removed when switching to audio service input streams. Streams design diagram: http://drawings/1_ZIKj6lihGKRjq4Mflduitmkn_REqpHFeqVNelBGHHk Bug: 828864 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0219494d73df2fd275d2b7ccb5bf01f81a1ff11c Reviewed-on: https://chromium-review.googlesource.com/1011605 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Fix compilaton broken by stricter compile-time checks. No-try: true Tbr: haraken@chromium.org Bug: chromium:757440 Change-Id: Ib4444900e0fc68ab915683ec68d598aaf73a27fd Reviewed-on: https://chromium-review.googlesource.com/1029862Reviewed-by:
-
Max Morin authored
Original description, (original code is PS 1): Currently, errors from the platform (e.g. device disconnected), are sent directly to the renderer (AudioOutputStreamClient). When moving to the audio service, this becomes suboptimal. It is tricky to signal an error occurring before the ClientPtr is set up, and sometimes we may not want it torn down due to a platform error (in case we want to try some sort of recovery operation such as restarting the audio service). This CL instead signals the error to the browser (AudioOutputStreamObserver), which signals it to the client through the new AudioOutputStreamProviderClient interface. That interface also gets the "stream created" callback as a method rather than a mojo response, so that we will be able to call it multiple times in the future. Diff PS 1 -> PS 2 removes a call to a sequence checker that was accidentally added when rebasing the original CL. Diff PS 2 -> last PS fixes an issue when pepper would call Start before the stream is created. This is solved by storing the state that the client expects in the MojoAudioOutputIPC object. That object then initializes the state when the stream has been created. As an aside, it is a great preparation for restarting stream, since MojoAudioOutputIPC will be able to restore the volume and playing state without involvement from AudioOutputDevice. Bug: 787806,830493,834242 Change-Id: Iee3a3902e9086cc9df4c5d210e43e65c162273fe Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1023397 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
-
Marc Treib authored
identity::IdentityManager is the new API that replaces SigninManager[Base]. The changes here are copied almost verbatim from crrev.com/c/1025751. Bug: 825190, 814307 Change-Id: If68afd361fd457284fdb0ed7ef41a4d121055a84 Reviewed-on: https://chromium-review.googlesource.com/1025693 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#553964}
-
Stephan Herhut authored
The original code has the condition for logging inversed. Change-Id: I3358cf18c42c2ab914a9895c6ed9de6a13fa50f1 Reviewed-on: https://chromium-review.googlesource.com/1009946Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Stephan Herhut <herhut@chromium.org> Cr-Commit-Position: refs/heads/master@{#553963}
-
Yoichi Osato authored
This patch updates LayoutSelectionStartEndForNG signature by 1. Introducing LayoutSelectionStatus structure for return type consisting of start/end. 2. Change argument type from NGPhysicalTextFragment to NGPaintFragment. This is a preparation for line break selection painting: crbug.com/c/896780 Bug: 708452 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Idca785e841a577b1a591ae10cf3d9771d21c6ce1 Reviewed-on: https://chromium-review.googlesource.com/1029563 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553962}
-
Yuki Shiino authored
This is a follow-up after: https://chromium-review.googlesource.com/c/chromium/src/+/989693/10/third_party/WebKit/Source/core/execution_context/OWNERS#5 Change-Id: Ief8ee8755876bedd5241d3e5977dc37cea669e12 Reviewed-on: https://chromium-review.googlesource.com/1029995Reviewed-by:
-
Michał Pichliński authored
After recent changes TestCompositorHostMac started requiring a real AcceleratedWidgetMac, otherwise it would crash while trying to Show. After fixing that, there was another issue that ImageTransportSurface started crashing, because of skipped SetAllowOSMesaForTesting in compositor test_suite. Tests affected: LayerWithRealCompositorTest.* Change-Id: I60b84611406744989e2f00f13e20c1177912814f Reviewed-on: https://chromium-review.googlesource.com/1014101Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Michal Pichlinski <mpichlinski@opera.com> Cr-Commit-Position: refs/heads/master@{#553960}
-
Jérôme Lebel authored
|selectedIdentity| has to be set when starting UnifiedConsentCoordinator. This API is required to support sign-in promo with the "Continue as" button. Also the avatar has to be updated when an update notification is received by ChromeIdentityServiceObserver. Related to: crrev.com/c/1009906 crrev.com/c/1010346 Bug: 827072 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I800294f36178a2776e03d28c625f234e4ecc1d2b Reviewed-on: https://chromium-review.googlesource.com/1025895 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#553959}
-
Bailey Berro authored
This change removes an unnecessary call to std::move in AuthPolicyClient::ConnectToSignal. Bug: none Change-Id: Id7fcb10e6b188d0a3058815c3078405f9634801a Reviewed-on: https://chromium-review.googlesource.com/1028229Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Roman Sorokin <rsorokin@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553958}
-
Yuichiro Hanada authored
This reverts commit 01873a4e. Reason for revert: This CL was cherry-picked to M-67 release branch. Let's revert this on master. Original change's description: > Disable enable-floating-virtual-keyboard flag by default. > > This feature is not ready for M-67 stable. > This CL will be reverted shortly after merging it to M-67 branch. > > Bug: 771466, 836109 > Test: Manual testing on the device. Confirmed that the feature is disabled by default. > Change-Id: I295319b4bdd6ae2cec18b5690308df96cff669dd > Reviewed-on: https://chromium-review.googlesource.com/1025352 > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553395} TBR=sadrul@chromium.org,yhanada@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 771466, 836109 Change-Id: Ia0b300bd06d6ed0e25d8cb15dfe48013e611b592 Reviewed-on: https://chromium-review.googlesource.com/1029810Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#553957}
-
Noel Gordon authored
Flakiness cause in the FileManagerBrowserTests was resolved on issues: issue 831074 issue 804413 issue 829310. Allow these tests to run in DEBUG/MSAN/ASAN after the previous patches on the bug selectively enabled subsets of the GalleryBrowserTest tests on those bots and are working well [1]. [1] https://bit.ly/2HKT7kc Bug: 835794 Change-Id: I4cf7c412c51cf051283a8f8fea9a5d1118af8f51 Reviewed-on: https://chromium-review.googlesource.com/1025854Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553956}
-
Alexandr Ilin authored
This CL temporarily disables the SpeculativePreconnectValidation field trial in order to assess its impact on the perf dashboard. This feature is planned to be turned on by default after the performance evaluation. Bug: 808036 Change-Id: I69de5a26eba86b8e4cad11c4cf534c3d13e73894 Reviewed-on: https://chromium-review.googlesource.com/1028052Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553955}
-
Kent Tamura authored
Bug: 622551 Change-Id: Ib31bd4189957bad107090db694a6857211e581d1 Reviewed-on: https://chromium-review.googlesource.com/1029930Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#553954}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3e3ab788. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" afb472c0 "Try to fix crash when terminating a worker while it is XHR-ing to a blob." 52308ad8 "Deprecate document.origin" 7c13f644 "Subtract scrollbar in PerpendicularContainingBlockLogicalHeight" a8385691 "Make web font timeouts work for preloaded fonts" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16266 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/encoding TBR=qyearsley No-Export: true Change-Id: I8cfc93a0c40f72a054b46cd6e561a0f729fa645b Reviewed-on: https://chromium-review.googlesource.com/1029674 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#553953}
-
Yoichi Osato authored
This patch removes the redundant invalidation because each LayoutObject now has invalidation for LayoutNG. This patch is a just revert of crrev.com/c/821394 ([LayoutNG] Have LayoutText invalidating NGPaintFragments) Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I37373ed9015c476544c2d719fcf7cfcf7ab1ecc7 Reviewed-on: https://chromium-review.googlesource.com/1027592Reviewed-by:
-
Boris Sazonov authored
This CL removes XML attribute that sets objectAnimator valueType to floatType. Both Android Framework and Support Library specify floatType as the default valueType for objectAnimator, so removing explicit attributes doesn't change the behavior, while improving readability and reducing resources size. Bug: 814728 Change-Id: Iea356ca491d23fae3ed9a54339fb746a5259f33e Reviewed-on: https://chromium-review.googlesource.com/1027812Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#553951}
-
Tatsuhisa Yamaguchi authored
Currently Zip Archiver run in the normal and incognito contexts in parallel when opening a single ZIP file in the Files app. The instance in the incognito context also received and processed events in onGetMetadataRequested, but it always fails because it doesn't run the normal initialization procedure. (i.e. loading volume and filling unpacker.app.volumeLoadedPromises) It once had worked harmlessly because error was ignored, but now the error in the incognito context triggers unmounting of the file. It can cancel out the volume mounted by the other instance in the normal context right before it. Bug: 833603 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I712a974ca4fe287d795256fc22a62d5c85d66401 Reviewed-on: https://chromium-review.googlesource.com/1018624 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#553950}
-
Marc Treib authored
identity::IdentityManager is the new API that replaces SigninManager[Base]. This includes ArcTermsOfServiceDefaultNegotiatorTest and ArcSupportHostTest. Bug: 825190, 731023 Change-Id: I316c90c6d278e52d723468d63bc21cd288b2642b Reviewed-on: https://chromium-review.googlesource.com/1025898Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#553949}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/48a13aacf880..aa6cca46950b $ git log 48a13aacf..aa6cca469 --date=short --no-merges --format='%ad %ae %s' 2018-04-19 lepton cros_vm: Use a smaller virtual network. 2018-04-24 laszio afdo: refining codes 2018-04-10 dgarrett chromeos_config: TRYBOT -> SWARMING. 2018-04-24 rockot Include libmojo_core.so in Chrome deployment 2018-04-19 pberny chromeos_config: Add sign_types to meowth release 2018-04-20 achuith cros_run_vm_test: Support for fetching results. 2018-04-17 bmgordon cbuildbot: Add --previous-build-state option 2018-04-13 bmgordon build_summary: Helper class to represent build summaries 2018-04-24 dgarrett cros tryjob: Always use PRODUCTION_TRYJOB display label. Created with: roll-dep src/third_party/chromite BUG=chromium:808045,chromium:829170,chromium:None,chromium:822034,chromium:835061,chromium:829665,chromium:829665,chromium:832768 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I7d1aa5c4c4bd153fd47f6d7cc7532ac35cdff73b Reviewed-on: https://chromium-review.googlesource.com/1029771 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553948}
-
Max Morin authored
Tbr: wychen Bug: 837130 Change-Id: Iabc0c4f12266865ff91cd337461830db30f6067f Reviewed-on: https://chromium-review.googlesource.com/1029850Reviewed-by:
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2acf49579846..3b9bb8131796 $ git log 2acf49579..3b9bb8131 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I7e716957db30bc61f1c23751a5787888c55bc3b5 Reviewed-on: https://chromium-review.googlesource.com/1029548Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553946}
-
Timothy Loh authored
This patch adds install_time and last_launch_time fields to the Crostini registry. These will be used in the app launcher's recently launched apps list, where currently Crostini apps do not appear. As we would also like the Terminal to appear in the recents list, this patch makes the registry support the Terminal, returning it in both GetRegistration and GetRegisteredAppIds. We don't need to keep track of Terminal install time as it is just a fallback for apps that haven't been launched. Internally, we only store the last launched time, so methods in the registry need to be careful they don't expect all pref entries will have all the standard fields. Bug: 821662, 836137 Change-Id: I43f34434afe61bd80c165c3a42047b184f96fcbe Reviewed-on: https://chromium-review.googlesource.com/1027292 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#553945}
-
Nicholas Verne authored
The install progress now has feedback messages in the dialog. The view also closes automatically on completion Bug: 822507 Change-Id: I962c9975a19fb322c611c9a02c5e2cc7ab21e06b Reviewed-on: https://chromium-review.googlesource.com/1029559 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#553944}
-
Hayato Ito authored
http/tests/devtools/elements/shadow is running several tests for shadow dom's distribution used in devtools. shadow-distribution.js is failing with the IncrementalShadowDOM flag. TBR=kochi,rakina Bug: 776656 Change-Id: Id780279b397c91bf3af7136727d36f83e1179565 Reviewed-on: https://chromium-review.googlesource.com/1029392 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#553943}
-
Mike West authored
Currently, we're setting the "site for cookies" only by looking at the top-level document. We ought to be verifying that the ancestor frames are same-site before doing so. We do this correctly in Blink (see `Document::SiteForCookies`), but didn't do so when navigating in the browser. This patch addresses the majority of the problem by walking the ancestor chain when processing a NavigationRequest. If all the ancestors are same-site, we set the "site for cookies" to the top-level document's URL. If they aren't all same-site, we set it to an empty URL to ensure that we don't send SameSite cookies. Bug: 833847 Change-Id: Icd77f31fa618fa9f8b59fc3b15e1bed6ee05aabd Reviewed-on: https://chromium-review.googlesource.com/1025772Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#553942}
-
