- 12 Feb, 2020 40 commits
-
-
Hiroshige Hayashizaki authored
This CL adds HTTPS->HTTP direct cases for mixed-content tests. The requests are rejected not in initial requests, but during redirect handling. The added tests expose the following issues on Chromium: Issue 1048619: - gen/top.http-rp/opt-in/sharedworker-import-data/cross-https.swap-scheme.https.html - gen/top.http-rp/opt-in/sharedworker-import-data/same-https.swap-scheme.https.html Issue 1050826: Requests are blocked as expected but no events are fired, causing test timeout. - gen/top.http-rp/opt-in/object-tag/cross-https.swap-scheme.https.html - gen/top.http-rp/opt-in/object-tag/same-https.swap-scheme.https.html Bug: 1048619, 1050826, 906850 Change-Id: I0aaa88788a28a20cd95b3dbfb078481c20786bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047823Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#740792}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/16cb8948..f4ae4cac Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2ce695d88e7c5dbd782768c2bd0524f9fe8cfe5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051199Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740791}
-
Morten Stenshorne authored
That virtual testsuite already runs with LayoutNGFragmentItem enabled, so it's not useful to run them on the layout-ng-fragment-item bot. Change-Id: Ic83a90c42452501cd004bb974c5538741e84cd26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050282Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#740790}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/4a19a53d5a89..8930cc96188c git log 4a19a53d5a89..8930cc96188c --date=short --first-parent --format='%ad %ae %s' 2020-02-12 wl@gnu.org * src/sfnt/ttcmap.c (tt_face_build_cmaps): Ignore version (#57708). Created with: gclient setdep -r src/third_party/freetype/src@8930cc96188c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Bug: None Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Ia60d72bf6ce474bd5b145b43600c47f5ac89005b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051715Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#740789}
-
Lily Chen authored
Bug: None Change-Id: I4ef11b0de0221d0350986b1701d7d841a71593f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051539 Commit-Queue: Lily Chen <chlily@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Auto-Submit: Lily Chen <chlily@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#740788}
-
Philip Rogers authored
When an intersection observation update is required, frames are temporarily un-throttled with a "forced" update until viewport intersections are updated post-lifecycle. These forced updates only need to run to LayoutClean so ShouldThrottleRendering returns true only if the local frame root is in a lifecycle update and is >= LayoutClean. This means that ShouldThrottleRendering returns different values depending on if it is called inside a lifecycle update. A call to LocalFrameView::UpdateAllLifecyclePhases can return true after updating all non-throttled frames but a subsequent loop over non-throttled frames can find frames that are not in the PaintClean lifecycle state. This leads to crashes (e.g., go/crash/dfb200b07b15575b). This patch changes the intersection observer throttling override to only apply during lifecycle updates. Outside of lifecycle updates, frames that did partially-throttled lifecycle updates are still considered throttled. Bug: 1041252 Change-Id: I1219df0dfbf6c3ca575f5ac6bb5214e3bebeb346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045586Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#740787}
-
Reilly Grant authored
This reverts commit 00f576f2. Reason for revert: Failed build was missing the expectation changes from this CL. Original change's description: > Revert "[Shape Detection] Use IDL dictionaries for result types" > > This reverts commit bae2a7ee. > > Reason for revert: Suspect for failing webkit_layout_tests on (none) > GPU on Mac > https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/51385 > > Original change's description: > > [Shape Detection] Use IDL dictionaries for result types > > > > This change updates the DetectedBarcode, DetectedFace and DetectedText > > types to be dictionaries rather than interfaces. This is okay because > > they have only attributes and no methods. This reduces the amount of > > manually written code necessary to implement them. > > > > This enables implementing a new field for issue 1023177 without having > > to update the manual serialization and deserialization routines. > > > > Spec PR: https://github.com/WICG/shape-detection-api/pull/86 > > > > Bug: 1023177 > > Change-Id: I3b93d1869c5457e2ce3da5b5690a5ff968a3c77c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040378 > > Auto-Submit: Reilly Grant <reillyg@chromium.org> > > Reviewed-by: Victor Costan <pwnall@chromium.org> > > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Commit-Queue: Reilly Grant <reillyg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#740356} > > TBR=yukishiino@chromium.org,jbroman@chromium.org,reillyg@chromium.org,haraken@chromium.org,pwnall@chromium.org > > Change-Id: Ib2075266871bdae5651e684ac652617de91e2bb2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1023177 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049945 > Reviewed-by: Kristi Park <kristipark@chromium.org> > Commit-Queue: Kristi Park <kristipark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740493} TBR=yukishiino@chromium.org,jbroman@chromium.org,reillyg@chromium.org,haraken@chromium.org,pwnall@chromium.org,kristipark@chromium.org Change-Id: Ib66d8b28cff5650c608c4e995fea350cedcf313f Bug: 1023177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049947Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#740786}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/55b137ca7dd9..79f336d0743a git log 55b137ca7dd9..79f336d0743a --date=short --first-parent --format='%ad %ae %s' 2020-02-12 csmartdalton@google.com Remove GrPrimitiveType from GrMesh 2020-02-12 robertphillips@google.com Remove legacy debugging print outs 2020-02-12 egdaniel@google.com Have GrProcessorTestData hold views instead of proxies. 2020-02-12 mtklein@google.com try release MSAN jobs 2020-02-12 mtklein@google.com make SkBBH a public interface 2020-02-12 mtklein@google.com calculate root bounds directly Created with: gclient setdep -r src/third_party/skia@79f336d0743a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: If6f96b15643b75c75f283ddb98b44b168b947465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052189Reviewed-by:
-
John Emau authored
Problem: When an element with aria role "menu" is made a direct child of a shadow root the browser will crash with a DCHECK. Root cause: The FlatTreeTraversal class [asserts shadow roots are not visited during traversal][1]. AxNodeObject::SiblingWithAriaRole passes will pass a shadow root to the FlatTreeTraversal via LayoutTreeBuilderTraversal if the node starting the search as a shadow root for a parent. Solution: Use LayoutTreeBuilderTraversal::Parent(*node) instead of node->parentNode() to get the parent of sibling nodes in AxNodeObject::SiblingWithAriaRole. Additionally this change adds a test to ensure there is no crash when an element with aria-role menu has a shadow root parent. [1]: https://crrev.com/d9756248c2/third_party/blink/renderer/core/dom/flat_tree_traversal.h?#48 Bug: 972755 Change-Id: I5db1ca1cc93bc499d555c9d042a059588f376578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652305Reviewed-by:
John Emau <John.Emau@microsoft.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: John Emau <John.Emau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#740784}
-
Dongheun Kang authored
The existing code had problems when parsing parameter's attribute that included multi-parameters or parameter names. Improved to handle all parameters. Bug: 1041986 Change-Id: I8ddd97e1d53be84b095d9dcdd487cef24000d86c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989298 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#740783}
-
Kai Ninomiya authored
e.g.: wpt_internal/webgpu/cts.html?worker=0&q=cts:validation/ERROR becomes: wpt_internal/webgpu/cts.html?worker=0&q=cts:validation/createBindGroupLayout: Bug: None Change-Id: I40378b9fa31054b0ce34adba1228482b23d476cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051297 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#740782}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2fede4e54026..28b3e362d5ed Created with: gclient setdep -r src-internal@28b3e362d5ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1041701 Tbr: jbudorick@google.com Change-Id: I31ce35b1ed60c701c0773b7ee5d9f32541d6675c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052186Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740781}
-
Kristi Park authored
Workaround to prevent screenreaders from announcing a useless alert (e.g. "alert Send") when the initial "Send" animation is shown. Bug: 1016787 Change-Id: I62fd2119d56edd86b77729999a38936ee5c509e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049835 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#740780}
-
Rossana Monteriso authored
This CL adds the grid-gutters-and-alignment test to the WPT project, adapted from browser specific tests. The corresponding outdated test is being removed from the fast/css-grid-layout folder. Change-Id: I07acf8ad8ccdd7e2ec8b12e76899e2135b99e068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047031 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#740779}
-
Li Lin authored
Bug: 1050763 Test: unit tests Change-Id: Ib0b2f97ee7233789b4209cc3a72833a5c07ac5a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048026Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#740778}
-
Daniel Rubery authored
This CL makes two improvements to the CSD model management. First, it allows a customizable threshold in the ClientSideModel, rather than hard-coding 0.5. It also allows the user to run a custom model for testing with the command-line flag: --csd-model-override=/path/to/model Fixed: 1029975, 1030723 Change-Id: I0bd5814ca1c0ba615c292b4566b731629f70bd88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040432 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#740777}
-
Kenichi Ishibashi authored
ServiceWorkerDatabase::RegistrationData will become a mojo struct. As a preparation, this CL changes the type of |used_features| from std::set to std::vector as the mojo IDL doesn't provide a set. Bug: 1046335 Change-Id: I6fdcb12e2930f3f74e8b2e4eeae9a52efc072a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040795 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#740776}
-
Xing Liu authored
NotificationIntentInterceptorTest is used to be an instrumentation test that calls into real Android notification API to show notification in tray. This is super flaky due to unexpected behavior or bugs in Android code. Now we change this to junit tests with Robolectric shadows which is much more flexible than current instrumentation setup. Also improve the test coverage. Bug: 910870 Change-Id: Ifd759b57c82010349316f2b6a928ad67799348ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045142Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#740775}
-
Manu Cornet authored
Change-Id: Iebcfc406962d222d2f652cc21774f60686813dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050000Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#740774}
-
Vladislav Kuzkokov authored
Every other function in JSONReader already uses JSON_PARSE_RFC. Change-Id: I04f00f1df8c6e46626c0341721dbad8f965d8608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052124 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#740773}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/33b1e31e7efa..92b00ca88263 git log 33b1e31e7efa..92b00ca88263 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 courtneygo@google.com Roll deqp to get some test fixes 2020-02-12 amaiorano@google.com Update comment to reflect changes in ea0dcd4bda188 Created with: gclient setdep -r src/third_party/angle@92b00ca88263 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I69633a45ef771a68f789da023baefee8ab6d06fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052094Reviewed-by:
-
James Vecore authored
Fixes warnings in network_proxy.js produced when this CL is patched in https://crrev.com/c/2006413 which does stricter type checking on mojom structs from colsure. Fixed: 1047848 Change-Id: If699e69a2df7f285aec848ba01c8d24dc4138462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049829Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#740771}
-
Yu Han authored
Previous to this CL, adding carriage returns to placeholder text either via attribute or through javascript don't display. This error happens for both string char "\r", unix code hex "
 and "\r\n" pairs. The spec, https://html.spec.whatwg.org/multipage/form-elements.html#attr-textarea-placeholder, "All U+000D CARRIAGE RETURN U+000A LINE FEED character pairs (CRLF) in the hint, as well as all other U+000D CARRIAGE RETURN (CR) and U+000A LINE FEED (LF) characters in the hint, must be treated as line breaks when rendering the hint." The problem is that carriage returns are treated as white spaces and they are removed when placeholder text are inserted into DOM as a text node. The fix to replace them with new line characters "\n". Bug: 791194 Change-Id: Ifc947048bc858ade91827cd49460a579fd11245e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051175Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#740770}
-
Hidehiko Abe authored
So that we can control this feature by gn args. BUG=chromium:1043804 TEST=Build chrome. Change-Id: I1e405faf404cc7ae75d4a5af851cdcf1e2f7227f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051790Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#740769}
-
Rahul Arakeri authored
CL updates the default body of the constructor/destructor to "=default" Change-Id: I10a76e8825e594488a9f7dd96b3b302d743766d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049832Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#740768}
-
Marc Treib authored
All invalidations clients have migrated to the new infrastructure, so the old implementation is now unused and can be cleaned up. This CL deletes *most* of the code. Still left to be done: - DeprecatedInvalidatorRegistrar is still used by some tests (via FakeInvalidationService), which should be migrated off. - InvalidationServiceAndroid and the corresponding Java code is still around. This reduces Android binary size by about 4kB: Normalized APK Size: -4184 bytes Bug: 1029481 Change-Id: Ic414f0b099eb5ad76bcded15a75e84299ba5f746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989750Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#740767}
-
Wez authored
Change-Id: Ide75f4dd1a30f343b6de33753e496e7ecba185a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051274 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#740766}
-
Nikita Podguzov authored
Deprecate the policy and remove all internal usages of it. Bug: 813107 Change-Id: I44134d5fedbbb53a92ed144b63f139979a24b9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041755Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#740765}
-
Daniel Cheng authored
Blink allows use of the //base histogram helpers, so switch away from the Blink-specific histogram helpers and standardize on //base. The long-term goal is to remove the Blink helpers, which differ from the //base ones in some interesting and surprising ways. Miscellaneous cleanup: - use the histogram functions where appropriate (i.e. for metrics that aren't recorded on performance-critical paths) - simplify enum histogram recording by changing the enum metric to be an enum class and defining kMaxValue where needed. Bug: 742517, 1047547 Change-Id: I8db8405076975992a02efb8a73e6a692e3678d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046534Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#740764}
-
Alex Cooper authored
When the Permissions Prompt is dismissed due to navigation, the callback passed to it may not be run. Due to the fact that this callback owns the mojo RequestSessionCallback, that callback ends up getting dropped, and then DCHECKs since the associated pipe is still open. This change causes the SessionRequestData struct to attempt to run the callback when it is destroyed. Given that the exact reason for the callback being dropped is unknown, a new generic error type is also introduced. Bug: 1051228 Change-Id: Ib388c7c7a513759d373fed2af1a040adf9d3cd03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050035Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#740763}
-
Oleh Lamzin authored
Change BatteryChargeMode default value from Standard to Adaptive. BUG=b:147869098 TEST=chromeos_unittests && ash_unittests Change-Id: I3163b5c16b54af23d5b3b29f2d779f97a07a0c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007410Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
Kristi Park authored
[Sheriff] Disable SignedExchangePrefetchBrowserTest.PrefetchMainResourceSXG_SignatureExpire on Linux TSan Example flakes: https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/50958 https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/50960 TBR=horo@chromium.org Bug: 1050879 Change-Id: I2f03a1d714d06759947ce54847c2ec78bfe1dd0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052203Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#740761}
-
Michael Spang authored
This removes libevdev and gestures from third_party. Nobody should be using these; they haven't been updated since being added 3 years ago. Having them is causing confusion as we actually use these libraries via sysroot (either Chrome SDK or Chrome OS chroot environment). We can add them back later if we need them, but they need some portability fixes before we can even do that (I tried rolling them first, but they don't even compile with our compiler). This reverts commit 968d2048. Bug: 888172 Change-Id: I297ce60796225e32e947ef9977c8c63207f0a2fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048906 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Sean O'Brien <seobrien@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#740760}
-
Daniel Cheng authored
Change-Id: I7f751a0fbfc049636a110b1edf0f5515ec1f6108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048275 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#740759}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e54f66edc586..378c0f1b0817 git log e54f66edc586..378c0f1b0817 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 jacktfranklin@chromium.org [Unittests] Add tests to `StaticContentProvider` 2020-02-12 tvanderlippe@chromium.org Add test for showing document storage values 2020-02-12 szuend@chromium.org [utilities] Replace {valuesArray} with {values} and/or spread operator 2020-02-12 tvanderlippe@chromium.org Migrate protocol_monitor/ to import cross-module 2020-02-12 tvanderlippe@chromium.org Migrate resources/ to import cross-module 2020-02-12 tvanderlippe@chromium.org Migrate security/ to import cross-module 2020-02-12 tvanderlippe@chromium.org Add test to verify multiple workers are shown as different entrypoints 2020-02-12 liviurau@chromium.org [doc] Updated branches handling Created with: gclient setdep -r src/third_party/devtools-frontend/src@378c0f1b0817 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1009443,chromium:1044632,chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I259d7e39d7a2c72b516794f299b77348c9bb88a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052187Reviewed-by:
-
Victor Costan authored
This CL adds a crbug component and team mailing list for the Storage Service. It also fixes the crbug component for //components/services. Bug: 994911 Change-Id: I8c3448ca350e7534aba02336c09ea4065925725d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051814 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#740757}
-
Aaron Leventhal authored
The property aria-goog-editable was really added for a single odd case in Google Slides, and isn't a great candidate for a new ARIA property. It exists to avoid double speaking in NVDA with the tree view used for Google Slides' thumbnail view. This issue goes away if the tree items are not considered editable (they really aren't), but there is no standard ARIA attribute to state that. The reason the tree items need to inside a contenteditable is because that enables pasting in slides to work. This also requires setting DOM selection on each tree item / thumb. The double speaking occurs because aria-activedescendant is also used to point to the currently active tree item. This is necessary in order to get more than just the selected text to be spoken -- to get the full tree item treatment. This CL removes aria-goog-editable, and instead clears IA2_STATE_EDITABLE in the odd situation where an editor has a subwidget like a tree item or list option, and the editor uses an active descendant. The requirement for an active descendant on the editor means that a subwidget can still be made editable in an HTML editor use case. Bug: 1049746 Change-Id: Icd67b825b49712ac3fda7ba57f7ba93b4cd99a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042282 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7270d81dce8a..f440b92c2422 git log 7270d81dce8a..f440b92c2422 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 fmayer@google.com Fix query for unsymbolized frames. 2020-02-12 treehugger-gerrit@google.com Merge "profiling: put proto enums into namespace" 2020-02-12 fmayer@google.com Merge "Improve error message when llvm-symbolizer is missing." 2020-02-12 skyostil@google.com Increase timeout for PerfettoTest.VeryLargePackets 2020-02-12 treehugger-gerrit@google.com Merge "traced_perf: add to android build by default (initially disabled)" Created with: gclient setdep -r src/third_party/perfetto@f440b92c2422 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0986ce588bdc4f87ab01d371d8249c4518e9a7cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050730Reviewed-by:
-
Hongchan Choi authored
The repro case creates an AudioWorkletNode after the ExecutionContext goes away. (detached iframe) AudioWorkletNode is equipped with a MessageChannel which requires a valid ExecutionContext. AudioWorkletNode is not fully functional without message ports anyway, so we can throw an exception in this case. Test: Locally confirmed the ASAN build doesn't crash with the repro anymore. Bug: 1050419 Change-Id: I52af9f877e2ad31923c6380dc0732eb6c97ab407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051386Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#740754}
-
Shimi Zhang authored
This reverts commit 9c078ea7. Reason for revert: The fix isn't memory efficient enough. Original change's description: > [Printing] Write file to file descriptor directly on Android > > Android's policy doesn't allow to exchange file ownership. It should be > caught by our test but we don't have up-to-date bots setup in Chromium > yet. > > Bug: 1050064 > Change-Id: I26c82e538817e68fd49f40c0c7c414c5a76078b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048271 > Commit-Queue: Shimi Zhang <ctzsm@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740491} TBR=thestig@chromium.org,ctzsm@chromium.org Change-Id: Ie33bf740f4221072059e2cd82eedc53c1974286f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049836Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#740753}
-
