GitLab

In addition to the current functionality, this adds:
* Detection of default capture devices (communication and console).
* Detection of changes to the default communication render device.

While doing this, I decided to also make 'effects' visible in the media-internals page which was very helpful in tracking down the source of the problem I was running into.

BUG=347531

Review URL: https://codereview.chromium.org/187593004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255687 0039d316-1c4b-4281-b951-d872f2087c98

Failure to do so leads to a CHECK() in the browser under the IPC fuzzing
tests, which generates a lot of false positives.  Instead, we can invert
the situation and blame the renderer.

BUG=349572

Review URL: https://codereview.chromium.org/183023016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255686 0039d316-1c4b-4281-b951-d872f2087c98

Suspected as crasher.

> Bind before sandbox lockdown on Windows.
> Linux is unaffected. All changed code already is inside sandbox.
> 
> BUG=348692
> 
> Review URL: https://codereview.chromium.org/185293014

TBR=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/191403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255685 0039d316-1c4b-4281-b951-d872f2087c98

It's no longer needed.

BUG=350416
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/190543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255684 0039d316-1c4b-4281-b951-d872f2087c98

The feature has been stable a long time now.

(This CL is part of the command line flag removal effort.)

BUG=

Review URL: https://codereview.chromium.org/190603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255682 0039d316-1c4b-4281-b951-d872f2087c98

> base: Disable win::ScopedHandle
> 
> This patch is intended for M34
> 
> BUG=350063
> TBR=cpu@chromium.org
> 
> Review URL: https://codereview.chromium.org/188793004

TBR=rvargas@chromium.org

Review URL: https://codereview.chromium.org/191133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255681 0039d316-1c4b-4281-b951-d872f2087c98

In this way, more information can be added (currently added 'description' and 'owner' for each action) 

A few functions are moved from tools/metrics/histograms to tools/metrics/common to be shared by tools/metrics and tools/histograms.

CL 149503005 broke in http://crrev.com/255357. Add a patch to fix histograms presubmit. 

BUG=340735
NOTRY=true

Review URL: https://codereview.chromium.org/180743027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255680 0039d316-1c4b-4281-b951-d872f2087c98

Fix SDP filtering issue on Android. rtpmap 101 is a data codec and it shouldn't be removed.

Some tests are fixed by this patch:
WebRtcBrowserTest.CanSetupLegacyCall
WebRtcBrowserTest.CallWithDataOnly
WebRtcBrowserTest.CallWithDataAndMedia
WebRtcAecDumpBrowserTest.CallWithAecDump

Some tests have been disabled in the source code:
WebRtcBrowserTest.CanMakeEmptyCallThenAddStreamsAndRenegotiate
WebRtcBrowserTest.CallWithDataAndLaterAddMedia
WebRTCInternalsBrowserTest.WithRealPeerConnectionCall

Some tests are no longer there:
WebRTCInternalsBrowserTest.NegotiateUnsupportedVideoCodec
WebRTCInternalsBrowserTest.NegotiateNonCryptoCall

BUG=181069
R=ronghuawu@chromium.org

Review URL: https://codereview.chromium.org/189433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255679 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347424

Review URL: https://codereview.chromium.org/188293005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255678 0039d316-1c4b-4281-b951-d872f2087c98

Stale, unused debugging code.

BUG=None
R=jennyz@chromium.org

Review URL: https://codereview.chromium.org/189173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255677 0039d316-1c4b-4281-b951-d872f2087c98

Modify the existing EME browser tests to include testing EME WD.

BUG=224791
TEST=new browser tests pass

Review URL: https://codereview.chromium.org/182113005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255676 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350323

Review URL: https://codereview.chromium.org/190473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255675 0039d316-1c4b-4281-b951-d872f2087c98

BUG=348003

Review URL: https://codereview.chromium.org/189093007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255674 0039d316-1c4b-4281-b951-d872f2087c98

Chrome introduced a transaction timeout to deal with potentially wedged
renderers (e.g. JS execution halted, etc) failing to complete transactions,
leaving the browser's transaction queue in a bad state. This was done
for all transactions, but since read-only transactions don't hold up
the queue it's safe to ignore them, which can reduce false-positives.

BUG=339229

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254846

Review URL: https://codereview.chromium.org/180163010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255673 0039d316-1c4b-4281-b951-d872f2087c98

RenderViewContextMenu has recently become aware of the frame it is being called for. This makes it possible direct the InspectElement message to the correct renderer which is necessary of the "Inspect Element" action to work correctly with OOP iframes.

This automatically works correctly for BrowserPlugin as well, so WebContents::GetRenderViewHostAtPosition and all supporting code across can be removed now.

BUG=345700

Review URL: https://codereview.chromium.org/187673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255672 0039d316-1c4b-4281-b951-d872f2087c98

BUG=284553
R=kalman@chromium.org, mkearney@chromium.org

Review URL: https://codereview.chromium.org/145443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255671 0039d316-1c4b-4281-b951-d872f2087c98

When the center is off the tiling, then the unclamped calculations
are incorrect. That is, instead of values being rounded down in
integer divides, they are instead rounded toward zero.

This patch reworks the way the around coordinates are calculated.
Instead of relying on unclamped version of existing functions,
we instead explicitly check whether the src coord is within the
tiling total size.

R=enne

Review URL: https://codereview.chromium.org/188863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255670 0039d316-1c4b-4281-b951-d872f2087c98

BUG=270362
R=lambroslambrou@chromium.org

Review URL: https://codereview.chromium.org/187313007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255669 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350124
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/189383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255668 0039d316-1c4b-4281-b951-d872f2087c98

Now we use clang-format in the end, so no need to format it before.

BUG=
TEST=bots
R=bajones@chromium.org, dmichael@chromium.org

Review URL: https://codereview.chromium.org/189373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255666 0039d316-1c4b-4281-b951-d872f2087c98

> Style nits
> 
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/189293003

TBR=matthew@dempsky.org

Review URL: https://codereview.chromium.org/190543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255665 0039d316-1c4b-4281-b951-d872f2087c98

For the moment, extension and internal code relies on navigator.language
to return the browser UI language but it should return the preferred
language for fingerprinting reasons, see http://crbug.com/101138.

BUG=348402

Review URL: https://codereview.chromium.org/185423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255663 0039d316-1c4b-4281-b951-d872f2087c98

Currently the visible_rect is implicitly set to the quad's |rect| value
then later changed by the occlusion/culling code. Instead we want to
compute this value up front and set it on the quad when the quad is
created. So add it to the SetNew() method. Currently it should always
be set to the same value as the |rect|.

R=enne
BUG=344962

Review URL: https://codereview.chromium.org/185563008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255662 0039d316-1c4b-4281-b951-d872f2087c98

These are unit tests so they should be in the unit_tests target. A
TODO says this did not work before, but they appear to pass as unit
tests now, so this is just a code move.

BUG=270918
R=droger@chromium.org, hajimehoshi@chromium.org

Review URL: https://codereview.chromium.org/186063007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255661 0039d316-1c4b-4281-b951-d872f2087c98

This change is in support of later changes moving the bookmarks_ui
manifest key from chrome_settings_overrides to chrome_ui_overrides.

BUG=349049
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/188813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255660 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338855
TEST=manual
NOTRY=true
R=jhawkins@chromium.org, zork@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255380

Review URL: https://codereview.chromium.org/187983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255659 0039d316-1c4b-4281-b951-d872f2087c98

The current content/renderer/webcrypto implementation is really generalizable to both
renderers and workers. This commit moves content/renderer/webcrypto to
content/child/webcrypto. Additionally, it adds support in WebKitPlatformSupportImpl for WebCrypto, so both workers and renderers can use it.

BUG=349514

Review URL: https://codereview.chromium.org/188203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255658 0039d316-1c4b-4281-b951-d872f2087c98

BUG=304341
TEST=no change

Review URL: https://codereview.chromium.org/188923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255657 0039d316-1c4b-4281-b951-d872f2087c98

Cache entry cannot be removed when mounted.
This check should be performed before removing metadata entry.

BUG=349380

Review URL: https://codereview.chromium.org/187893006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255656 0039d316-1c4b-4281-b951-d872f2087c98

The new tests are failing:
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%285%29/builds/25532/steps/browser_tests/logs/stdio

> Persist browseraction properties across restarts
> Persist browser action properties across restarts even if other properties are modified before the old ones are loaded. (Note: only properties which are NOT modified are persisted.)
> BUG=348775
> 
> Review URL: https://codereview.chromium.org/186013003

TBR=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/189873005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255655 0039d316-1c4b-4281-b951-d872f2087c98

The format of the license field in
third_party/readability/README.chromium makes the license checker
erroneoulsy flag it as incompatible as it doesn't fit the regex.

Android WebView is now depending on third_party/readability (another
discussion perhaps) and there's no good reason to exclude it from
the WebView build right now.

TBR=nyquist@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/189463006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255651 0039d316-1c4b-4281-b951-d872f2087c98

In the case where there are tasks scheduled to run and we enter
ALLOW_NOTHING mode, we would early out from DidFinishRunningTasks
and keep resources on tasks that were finished between the last schedule
and entering ALLOW_NOTHING mode.

BUG=349553

Review URL: https://codereview.chromium.org/188153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255650 0039d316-1c4b-4281-b951-d872f2087c98

Migrate changes from codereview.chromium.org/181433022.

BUG=344486
TEST=build and run the test on link

Review URL: https://codereview.chromium.org/176843019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255649 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes a crash happening when Chrome shuts down or a capture
device is removed from the system while there are observers observing
the "suspended" property of the AVCaptureDevice going out of scope --
basically leaving the observer observing a zombie.

For that, the CrAVFoundationSuspendObserver registers to observe both
"suspended" and "connected". In the case of "connected" received, it
can only mean disconnected, so both observers are removed. The |device|
pointer is passed to -addObserver:forKeyPath:options:context: as the
|context|, and is received then in the -observeValueForKeyPath:... .

CrAVFoundationSuspendObserver renamed to CrAVFoundationDeviceObserver.

BUG=288562, 348917

Review URL: https://codereview.chromium.org/188383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255648 0039d316-1c4b-4281-b951-d872f2087c98

Previously, tests that involved incognito profiles needed to manually
create them and add them to the parent profile before
GetOffTheRecordProfile was ever called.  However, the documentation for
Profile explicitly states that the incognito profile will be created if
it doesn't already exist when GetOffTheRecordProfile is called. Further,
it was prohibitvely invasive to test code that creates a profile and
expects to be able to do something with its associated incognito
profile.

This commit also updates existing tests to remove unnecessary manual
incognito profile creation.

BUG=318803
R=atwilson@chromium.org, dpolukhin@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/181403006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255647 0039d316-1c4b-4281-b951-d872f2087c98

Our code has dependencies on the Windows implementation of this API until M33 and a recent unexpected change broke it, we need to make sure to be notified of any other potential changes.

We can remove this after M33 is out of stable.

NOTRY=True
BUG=350028

Review URL: https://codereview.chromium.org/189093011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255645 0039d316-1c4b-4281-b951-d872f2087c98

BUG=348006

Review URL: https://codereview.chromium.org/189203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255644 0039d316-1c4b-4281-b951-d872f2087c98

There was this TODO(sky): convert this and InitMessagePumpForUIFactory() to return a
scoped_ptr.

This patch is for doing the same.

R=darin@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/185413019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255643 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332315
TEST=none

Review URL: https://codereview.chromium.org/183923037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255639 0039d316-1c4b-4281-b951-d872f2087c98

These utility functions are now only used in
discardable_memory_allocator_android.cc so they have no reason anymore to live
in discardable_memory_android.cc.

TBR=willchan@chromium.org
BUG=347919

Review URL: https://codereview.chromium.org/189113006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255638 0039d316-1c4b-4281-b951-d872f2087c98