- 13 Feb, 2020 7 commits
-
-
Victor Costan authored
We'll monitor the fix as it goes through the Chrome release waterfall, instead of doing a Finch-based trial. This frees us from having to reason about enterprises that may disable Finch. Bug: 989611 Change-Id: I50389c12d31f63fa6257d879f3d840ffde2cb27e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052245 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#740894}
-
Kristi Park authored
This reverts commit 64cf44e2. Reason for revert: Tentative suspect for DriveIntegrationServiceWithGaiaDisabledBrowserTest.DriveDisabled linux-chromeos-chrome browser_test failure https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3090 Original change's description: > Add a new test case for |AssistantManagerServiceImpl|. > > This CL adds a new test case to ensure we update the supported action > list stored in |AssistantManagerServiceImpl| when ambient mode state has > changed. > > Bug: b/149237062 > Test: run the new unit test added in this change. > > Change-Id: Idc3c538e023cb59e76fb6c71219e4846da6d9c30 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969777 > Commit-Queue: Meilin Wang <meilinw@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740817} TBR=xiaohuic@chromium.org,meilinw@chromium.org,jeroendh@google.com Change-Id: I596dc72fa1422ee85925f2616557dfbb9b705bad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/149237062, 1051728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053283Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#740893}
-
Kristi Park authored
This reverts commit 75161d96. Reason for revert: Tentative suspect for DriveIntegrationServiceWithGaiaDisabledBrowserTest.DriveDisabled linux-chromeos-chrome browser_test failure https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3090 Original change's description: > assistant: Fix mic button doesn't work with fake gaia account. > > |Service| stores the current account info and later registered as a > session activation observer for this account, so that it can enable > listening when the session becomes active. Previously when the login > account was a fake gaia account, e.g. in Tast tests, we did not update > the stored account info with the latest primary account when requesting > access token. In this way, |Service| couldn't receive any session active > signals because it was not observing a valid account. > > Bug: b/147442943 > Test: run the service in signed-out mode and manually verified. > > Change-Id: Iaaef86303686291b419754505ead9b14cca0adbc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033642 > Commit-Queue: Meilin Wang <meilinw@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740818} TBR=xiaohuic@chromium.org,wutao@chromium.org,meilinw@chromium.org Change-Id: I0c369b2ec7b41207cd1bb4d7e1953f758136f887 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/147442943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053164Reviewed-by:
-
Ken Buchanan authored
Content APIs were added that exposed the ability to perform security checks in the browser process in Android. See: https://chromium-review.googlesource.com/c/chromium/src/+/2031548 Callers were added to Clank internal code. https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2539385 This is the final cleanup CL to deduplicate the checks. Bug: 827542 Change-Id: Ia17bf8effe37ad069316315d7c866b41d0b13641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048283 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#740891}
-
Mike Wittman authored
Adds a function on the ProfileBuilder interface to apply metadata to already collected samples using on a time window, and implements it in CallStackProfileBuilder. Bug: 1034758 Change-Id: I5022f55684fb74397146a1d81ec7487a35a6f787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018449 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#740890}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0844b9a3b625..1c5647025500 git log 0844b9a3b625..1c5647025500 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 tsepez@chromium.org Small cleanup to CFX_CSSSyntaxParser. 2020-02-12 thestig@chromium.org Use size_t in CFX_CSSStyleSheet. 2020-02-12 thestig@chromium.org Roll third_party/freetype/src/ 4a19a53d5..8930cc961 (1 commit) 2020-02-12 tsepez@chromium.org Test uncovered comment handling paths in CSS parser. Created with: gclient setdep -r src/third_party/pdfium@1c5647025500 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I98e3f3145246f63ce283c5b7f43bb825d149a8d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052765Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740889}
-
Benjamin Beaudry authored
In Blink, we create word boundaries based on two principles: 1) The WordBreakIterator needs to stop at what it believes is a boundary. https://unicode.org/cldr/utility/breaks.jsp is a helpful tool to understand where the iterator breaks. 2) The boundary must not be on a "skippable word", e.g., punctuations, whitespaces, special characters, etc. For more info about the skippable words, see base/i18n/break_iterator.h. When a node's text is a string containing only the bullet character ("•"), no word boundaries are created since a bullet is considered as a skippable word. Because of this, we can't create a word start/end position in that node. This causes issues with word navigation, where we jump over this node instead of creating a position inside of it. Also, Narrator's Scan Mode doesn't work when the first element of a web page is a text node with no word boundary. This happens on all Office 365 web apps, where the top left menu icon is exposed to the text pattern by the "•" string. This CL fixes this issue by "faking" word boundaries around a node that has no word boundary but has at least one character offset. It also adds a unit test and enables two browser tests related to bulleted lists that were commented out because of this issue. Bug: 928948, 1015100 Change-Id: I5e8c4af47d007e00015f9c60d697e00b2dba8efe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045891 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#740888}
-
- 12 Feb, 2020 33 commits
-
-
Aaron Krajeski authored
NullImage is a static ref that probably saves createPattern some time and memory if it's creating the same invalid pattern over and over again. Unfortunately it is not thread safe and createPattern needs to run in OffscreenCanvas workers as well. BitmapImage::Create has the same functionality, though perhaps some slight performance implications. Bug: 1045346 Change-Id: Iee5287321555ae0e4b7514305254fff97ae20fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050674Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#740887}
-
Nicholas Verne authored
Set/GetInstallerViewStatus migrated to new api. Using base::flat_set instead of std::set for open dialogs. Bug: 1024693 Change-Id: I71812535b213b270b6cfeb38f057caa7d2645a6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050293 Auto-Submit: Nicholas Verne <nverne@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#740886}
-
Benjamin Beaudry authored
Ignored nodes can affect format boundaries in two ways: 1. When an ignored node is directly next to the current position. 2. When an ignored node (or many) is right next to the next/previous format boundary. The first case has been fixed a few weeks ago by CL:1987700. This current CL fixes the second case. _______________________________________________________________________ DETAILED DESCRIPTION OF CASE 2 Consider this tree structure, inspired by a pattern seen on bing.com: 1 ______|_________ 2 9 _____|_____ | 3 6 8(i) 10 | | | 4 7 11 | | 5 12 Where nodes {3,10} are headings, nodes {4,5,6,7,11,12} are text nodes and other nodes are generic content. Node 8 is ignored. If our current position is at the end of node 5, the next format boundary should be detected at the end of node 7 because node 8 is ignored and node 10 will create a format boundary (since it's a heading). However, with the issue observed, the next format boundary was created at the end of node 12 instead of node 7. This caused the text pattern to skip some headings when the node right before it was ignored. The same issue was observed when going backward with the inverted above tree structure. Also added a unit test with this specific tree structure. Bug: 928948 Change-Id: I3d0a5d5aaf4fb5ff5ee40e33724bb38a6755cb98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045325 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by: -
Lukasz Anforowicz authored
We allows CORS requests if the origin pairs are registered in the given |shared_cors_origin_access_list_|. This patch adds tests for the case. Bug: 1049604 Change-Id: I90d9f80cca8be15fcc4f79186730efeb3422eac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051470 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#740884}
-
James Cook authored
Nothing in //chromeos uses the service manager, so clean up the build files and eliminate an unnecessary include. Bug: none Change-Id: I0b8262a9c3c7bccdc319329ee6018686555cee18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052607 Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#740883}
-
Jordan Taylor authored
Initial hold time for scroll-linked animations now accounts for playback rate. Added test for setting playback rate on scroll linked animations Bug: 916117 Change-Id: Ibd7e80ce60346d2f13155b13b8cc14252afc0c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970911 Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#740882}
-
behdad authored
After recent changes to representative test the upper limits for representative perf tests need to be updated. Values are updated using the 95 percentile of the values in last 50 chromium.gpu.fyi runs. TBR=sadrul@chromium.org Bug: none Change-Id: Icebecad5bdbd3516912d74b3e33cc036f83ac62a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052569Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Auto-Submit: Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#740881}
-
Brandon Wylie authored
This reverts commit 96d43c20. Reason for revert: Broke render tests, see https://ci.chromium.org/p/chromium/builders/ci/Nougat%20Phone%20Tester and crbug.com/1051635 Original change's description: > Switch Android VR tests to use embedded test server > > As part of the work to use the permissions prompt by default, instead of > the custom consent dialogs, tests will need to be updated to use the > embedded test server rather than directly navigating to a file. This is > due to the fact that the Permissions code will DCHECK if saving the > permission for a file-type URL. > > TODO:Revert changes to PermissionUtil and content_features, these are > currently loaded to validate that the tests will pass with these > changes. > > Bug: 1043241 > Change-Id: Iaa820812fac0bc389af47c22f8e069e81929b05a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047987 > Commit-Queue: Alexander Cooper <alcooper@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740399} TBR=bsheedy@chromium.org,alcooper@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1043241 Change-Id: I65d0ab0c5f5ef1f16c407bacaffa5b647bc18484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052603Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#740880}
-
Dave Tapuska authored
Use gfx::Size directly. No functional changes intended. Change-Id: I176a843d63e6ca2ee2de40dd89e8db367dc301b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050734Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#740879}
-
Luciano Pacheco authored
CL:2043519 moved the background-color too far up in the CSS creating grey backgrounds in some type of icons. This CL fixes by moving the background-color to [file-type-icon='folder'] and its sub-types that are used for Drive entities: shared folder, shared drive, computers, etc. Also add the background-color to some icons that *doesn't* have [file-type-icon='folder']. Bug: 992821 Change-Id: Iafac396941fca601d9318fcd58c8620540c9038b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050288 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#740878}
-
Hiroshige Hayashizaki authored
This CL adds support for {classic|module} {http(s):|data:} SharedWorkerGlobalScope as source contexts, namely: "sharedworker-classic", "sharedworker-module", "sharedworker-classic-data", "sharedworker-module-data" Actual tests for such cases will be added by subsequent CLs. Bug: 1048619, 881202, 906850 Change-Id: I72c71c303430014a68cecfa65a08dcaf9a23b6c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048118 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#740877}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/4ab0c36c448d..267593067f71 git log 4ab0c36c448d..267593067f71 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 btolsch@chromium.org Add Cast app availability tracker Created with: gclient setdep -r src/third_party/openscreen/src@267593067f71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I5820cb452aa4678d5acc15ecfec823150b543d27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052202Reviewed-by:
-
Joshua Pawlicki authored
Bug: 1035895 Change-Id: I4a046621f5a10e89033fac893fffdbb061fa8fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052469 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#740875}
-
Brian Ho authored
The original CL broke fuchsia compiles because it calls dawn_native::GetProcs() even though fuchsia does not yet link Dawn in Chromium builds. This CL relands the original SharedImageBackingFactoryOzone CL but also gates the call around GetProcs with a USE_DAWN check. Change-Id: I8d7b19f89a60eafbf6cce1ebacddc567675d96c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050570 Commit-Queue: Brian Ho <hob@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#740874}
-
Nasko Oskov authored
WebUI process should never be allowed to commit a web URL. This is guaranteed by site isolation, which places the web navigation in a separate process. The goal of this CL is to verify that even in the case of renderer bugs, browser-side code correctly terminates a WebUI renderer process attempting to send a DidCommitNavigation message for a web URL. Bug: 1002276 Change-Id: Ib3179e1ef41ccd867b62c8ee95d87ec44b99504f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051300 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
Anand K. Mistry authored
Bug: 1007788 Change-Id: Ib1eccbbacf70602948a57eb4373ff7762765b7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050290Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#740872}
-
Ayu Ishii authored
Part 1 of cleanup. Bug: 1007660 Change-Id: I458bfacf87f99cb03ae117e05d9a2c8587383f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047992Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#740871}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/35b70cac5639..3d37f4f72c61 git log 35b70cac5639..3d37f4f72c61 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 jbudorick@chromium.org Revert "cros: switch CrOS programs to python3" Created with: gclient setdep -r src/third_party/depot_tools@3d37f4f72c61 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:997354 Tbr: agable@chromium.org Change-Id: Iab2463af33791237f5dc2ef7118bc32a7be4774b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052398Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/92b00ca88263..593706bcc066 git log 92b00ca88263..593706bcc066 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 jmadill@chromium.org Test Runner: Increase default timeouts. 2020-02-12 lexa.knyazev@gmail.com Move dither from blend state to rasterizer state Created with: gclient setdep -r src/third_party/angle@593706bcc066 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I6f532c78ee20eaa8c7d33013edd410b19eb6f55c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052392Reviewed-by:
-
Liviu Tinta authored
Some native events do not carry location information. Introduce a check in EventLocationFromMSG for this situation. If there is no way to get a location out of MSG from event, or from system calls then return a flag to inform upper layers. Use the last located event's location in this case. This requires to keep track of the last LocatedEvent. Bug: 540840 Change-Id: I7039c595ed7fa1bbcd74baad01aae079050ad3ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032036Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#740868}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/66356c20b819..251eff6f1ff6 git log 66356c20b819..251eff6f1ff6 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 herb@google.com Multithread SkStrike test 2020-02-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-12 egdaniel@google.com Pass origin into GrCoordTransform. 2020-02-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@251eff6f1ff6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: Idc618abac7e70187a894463465e19de9cba57cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051245Reviewed-by:
-
Rainhard Findling authored
* Introduces safety check page skeleton * Adds safety check element to settings in |basic_page| Bug: 1015841 Change-Id: Ib9d74ee53da3fb110a9296f65d3cec2335775143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959036 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#740866}
-
Ben Joyce authored
Needed to add some local modifications as seen in the README. Namely added META-INF files and need to remove Jellybean from SDKprovider. Also needed to use our customshadowasync. Two test sets (platofrmsensor and NFC) needed to have sdk=21 set, otherwise it uses sdk=19 and it complains the methods that we're trying to mock don't exist. GtestComputer needed to be changed as the test seems to no longer exist after running, so can't query it for the description as was done before. Update androidx.test libraries to: androidx.test:core:1.2.0 androidx.test:monitor:1.2.0 androidx.test:rules:1.2.0 androidx.test:runner:1.2.0 androidx.test.ext:junit:1.1.1 Bug: 965286 Change-Id: Ia0fe69a788d2662b85c4ce95a0ccb8b987a98510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966580 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#740865}
-
Scott Violet authored
Without this WebLayer won't use the right settings, which causes problems with layout tests. BUG=1051166 TEST=covered by wpt tests (such as wpt/css/css-grid/alignment/grid-alignment-implies-size-change-019.html) Change-Id: I88d5b8cfa059f09c1725f9fedb0b25c24c972eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052606Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#740864}
-
Anand K. Mistry authored
Bug: 634140 Change-Id: I9ec201c3e47c19c3ebc2c3533fb9446011f34527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035473Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#740863}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/97f260fb71e6..23c34724b2bf Created with: gclient setdep -r src-internal@23c34724b2bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:979082 Tbr: jbudorick@google.com Change-Id: I11f460fc67d696e9979016f4dcc6177b8447843b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052605Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740862}
-
James Vecore authored
This CL only fixes the crash, it does not address the fact that the user should not be able to get to the add network dialog as a secondary user, see: https://crbug.com/1045324. Fixed: 1048122 Change-Id: I1c674e6b8441260fd959131f71b9c8712200345f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052604Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#740861}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/56690232104c..021ee4d7bbcf git log 56690232104c..021ee4d7bbcf --date=short --first-parent --format='%ad %ae %s' 2020-02-12 Rob.Paveza@microsoft.com Issue 1050999: Properties Tab 2020-02-12 tvanderlippe@chromium.org Add e2etest for breakpoints in sources panel Created with: gclient setdep -r src/third_party/devtools-frontend/src@021ee4d7bbcf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1044632,chromium:1050999 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib96062b2c1e26565c7e790d0f6471e31aa914b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052391Reviewed-by:
-
Nick Diego Yamane authored
In X11, TouchEvent::PointerDetails initialization involves allocating a tracking_id/slot entry in TouchFactory internal ID map. Such mapping entry must be cleared when the corresponding touch release/cancel event object is destructed. While this is how it has been working in Aura/X11, in Ozone/X11 such cleanup is not done. This issue has been caught while enabling EventsXTest.* unit tests in Ozone/X11, which is part of this change, in order to increase test coverage in ozone/linux events code. This patch fixes it by slightly extending TouchEvent to override its dtor behavior to do what's needed in a simple way that works for both Aura and Ozone X11, taking advantage of the fact that all XEvent-based ui::Events creation code is now unified at x11_event_translation.{h,cc} (after crrev.com/c/2022280). Also this removes one more platform specific #ifdef from event.cc. R=sadrul@chromium.org, spang@chromium.org Bug: 1049460, 700309 Test: ozone_x11_unittests --gtest_filter='EventsXTest.TouchEventNotRemovingFromNativeMapping' Change-Id: I8aec8aceeec14b7024683df55b9befeb3ba639a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040559 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#740859}
-
Yury Semikhatsky authored
Bug: 1051186 Change-Id: Ib5094ad8617940e70dcb61833c64c89faab76002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051176Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Yury Semikhatsky <yurys@chromium.org> Cr-Commit-Position: refs/heads/master@{#740858}
-
Rayan Kanso authored
Send the image data for the best shortcut icon to the WebAPK server. Duplicates are not sent, and a per-icon limit of 512KB is enforced. Bug: 1045588 Change-Id: I2557584c32dc872013ecf1da3b3beee19047e5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047166 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
-
Tina Wang authored
The official website and posts on the profile card dialog is clickable and navigable. Adding NavigationDelegate interface in c/b/profile_card and implementing it in c/a/profile_card because Tab's dependency. Bug: 1051210 Change-Id: I5443445ac4c1b9b256eb34e9ba05be6dc2447aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047381 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#740856}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a7875dfced8a..9fed47ecfb6f git log a7875dfced8a..9fed47ecfb6f --date=short --first-parent --format='%ad %ae %s' 2020-02-12 bsheedy@chromium.org Fix getservbyname assumption Created with: gclient setdep -r src/third_party/catapult@9fed47ecfb6f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:869557 Tbr: oysteine@google.com Change-Id: Ibeb86ecaa619e71de0b09e2515eacce334ebaee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052393Reviewed-by:
-
