- 06 Jan, 2021 40 commits
-
-
Bartek Nowierski authored
All partitions on 32-bit systems are marked non-scannable, effectively disabling PCScan and preventing address space waste for quarantine bitmaps that would never materialize. Bug: 1159694 Change-Id: I6fea110633ea0a72146beb917810b8b04d603f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601894Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#840457}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/57ea1fcb74d6..854ee85736e3 2021-01-05 csmartdalton@google.com Delete GrTriangulator::Mode If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I39461014ba3a9ef9c27f60d3b712945c2b78df93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611402Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840456}
-
Wenbin Zhang authored
tab_search is added and we need to update the shard map for desktops. Updating the other as well after the holiday season. Bug: chromium:1152598 Change-Id: I9183271ca56babaf79d84ed88eeaf2138276d143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611653 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#840455}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609869437-1a950cb4179e276745ee2e9da68ac232cb554183.profdata to chrome-mac-master-1609890206-97a23ce40eede0995d03d53b562706106b3aa301.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9d5fc3429eef7286b2f92759bb4f976b59fa54a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611400Reviewed-by:
-
Sammie Quon authored
Also updated some DIR_METADATA files. Bug: none Test: builds Change-Id: Ife905c4926ef4d38577fc550ef60f6ca7f7c4f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612031Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#840453}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7e7351226820..ac96016abc40 2021-01-05 vadimsh@chromium.org [cipd] Update CIPD client to 2.5.1. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1163308 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I55bb2628e18a7d75b3aee1068b5131087d6b861d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612156Reviewed-by:
-
Mei Liang authored
Fails to reproduce it locally, even with the swarming bots. This CL re-enable the test. Bug: 1127280 Change-Id: Ibf53ad0a5a0b0d8fda671f45ec7c6b4a2a2f5244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611898Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840451}
-
Joey Arhar authored
Focus rings are rendered differently in dark mode, so we need additional pixel tests for dark mode. Original change: crrev.com/839189 Revert: crrev.com/839445 The original change failed because the trybots didn't have dark mode selected in the system preferences like my machine. I fixed this by removing the "light" option in the meta tag of the test, which makes it ignore the system preferences setting. Fixed: 1067517 Change-Id: I426f70fd376097e75d795470f973ede1a5a43684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600335Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#840450}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609869437-8f3fde660eac6867df6a9ca50d8e63b86cfec419.profdata to chrome-linux-master-1609890206-88ace00cc385e4ef682397c3629935c4bd822382.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1f3b6331ed61ec5daadef77d57f99d1f8aa394be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611397Reviewed-by:
-
David Maunder authored
Protocol buffers do not allow fields to be null so openerAppId is converted to an empty string if it is null on serialize() and then converted back again on deserialize(). Bug: 1161980 Change-Id: Id0cedad8b47b1f40938c934536c18769d874ca71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611899Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#840448}
-
Thomas Guilbert authored
This CL converts sync_file_system::SyncFileCallback to a base::OnceCallback. Bug: 1152272 Change-Id: Ie6d76be751d014664d90e523f899f806e1b97781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606664 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#840447}
-
Kehuang Li authored
Audio packet can be sent after handshake packet, and thus handshake packet must also has a multiple of 4 bytes to ensure alignment of audio data. Merge-With: eureka-internal/509721 Bug: internal: 176167293 Test: Add alignment check on receiver side and audio works fine. Change-Id: I57343bf0238df64de47ec69ed5b64ed4eecd0a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607812 Commit-Queue: Kehuang Li <kehuangli@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840446}
-
Victor Costan authored
While here, this CL also marks some IndexedDBContextImpl data members const. No functional changes are introduced. Change-Id: I45d4b887d6a9fcf6a3719cc32e745837594dd4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609904Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#840445}
-
Martin Kreichgauer authored
It's more accurate, since we generally don't care which kind of off-the-record context we're dealing with. (The exception to this is when instantiating platform authenticators, which may be available in Incognito but not Guest mode e.g.). Also change plumbing of the off-the-record bit in AuthenticatorRequestDialogModel to flow with the TransportAvailability struct. Bug: 1157651 Change-Id: I31485c734547b74b7d0e46534e0da5cbe4f1a00f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587503 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#840444}
-
Jeremy Roman authored
Bug: 1007635 Change-Id: I84efa1eb7b59fb8906b94ca6c05d24bbdf565fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600383 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#840443}
-
Xiaoqian Dai authored
They are "MultiDisplayOverviewAndSplitView" and "DragToSnapInClamshellMode". Bug: 1143342, 1143331, 890029, 952461 Change-Id: I62aeb6cd4152170ddc975ebc0fdb556165f423fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599454Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#840442}
-
Chris Lu authored
This change ensures that the default browser fullscreen promo does not present in front of a Crash Restore Infobar, since it is the only opportunity for the user to restore the tabs before the crash. Fixed: 1163089 Change-Id: Ib819a05d8f9f0187716c89c48e04f05f435b2041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612104Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#840441}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f9a1b53d2809..325d666beb8f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib48a4d0eb9f1ec6ae60710020f5930bc764c615e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612146Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I42d194ef136dd2821bdee3dd1dd5ccefe46b7a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611401Reviewed-by:
-
Lukasz Anforowicz authored
This field was written to in LocalFrameClientImpl::BeginNavigation, but was never read from. I believe that this field has been replaced with the `initiator_frame_token` field. Bug: 1059959 Change-Id: Ib41e3719a1f03416274459984bed420e15cb9132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611866 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#840438}
-
Harvey Yang authored
To support uncalibrated DeviceTypes for accelerometer, gyroscope, and magnetometer, add the types in the mojo enum. BUG=b:176276324 TEST=build. Cq-Depend: chromium:2603196 Change-Id: I7a12e65f8ea99799cab26810df93f46f2d275c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610525Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840437}
-
Phillis Tang authored
PWA install icon should be highlighted when its In-Product Help promo is shown, and be de-highlighted when the promo disappears. Bug: 1163235 Change-Id: I29cc0269e4f98f401ad69d1a4e6d620bdbd268be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610938 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#840436}
-
David Bokan authored
This class has a test method that allows storing a closure to be called when this ExtensionFunction is invoked. Since ExtensionFunctions should only call Run() (at most) once, this Closure can be a OnceClosure. We also clean it up to avoid using a pointer. Bug: 1152268 Change-Id: Ie7ebc98ad8569ac31f8b6b553426c2bc40c3ea8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602888Reviewed-by:
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/ca058c06474c4492f0fbd517679793234dde6165..bac5544e9832c65c95283e95062263c79a9a6733 Bug: none Change-Id: I9c1386774a0076f87f397df757a78c73e772315e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611129 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#840434}
-
Joe Downing authored
Change-Id: Id2407083b27e13bd81ffd1872d6e9035f9090957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612107 Auto-Submit: Joe Downing <joedow@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#840433}
-
Yuke Liao authored
This CL adds unit tests for build/chromeos/test_runner.py. Bug: 1158590 Change-Id: I448fe91423e6bcb511a11f27f6409232909875c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605401Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#840432}
-
Kelvin Jiang authored
Was previously (erroneously) restricted to dev. This hotfix fixes that Bug: 1162860 Change-Id: I27e588f9027a36fe9c8e0e8cad8c242dc117f833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612205Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4f509345ab9f..57ea1fcb74d6 2021-01-05 csmartdalton@google.com Convert GrTriangulator to a class 2021-01-05 fmalita@chromium.org [svg] Deferred text position adjustments 2021-01-05 csmartdalton@google.com Don't use the tessellator if caps.avoidStencilBuffers is set 2021-01-05 brianosman@google.com Guard against Inf/NaN when constructing circular blur textures 2021-01-05 johnstiles@google.com Add support for `number(boolean)` and `boolean(number)` casts in SkSL. 2021-01-05 borenet@google.com [infra] Remove jobs for no-longer-existing ChromeOS devices 2021-01-05 mtklein@google.com Stop calling schedule() 2021-01-05 brianosman@google.com Reland "SkRuntimeEffect: Test matrix inverse() intrinsic" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I33728cd6baebaa1a16797c9d4a0e98eb9546e975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611514Reviewed-by:
-
David Black authored
Before: http://shortn/_L6D4o1zrki After: http://shortn/_MuXhA5lF6T Bug: 1163326 Change-Id: Ifed54414f0adfabc289d9f90f665226a7300d099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612050 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#840429}
-
Ben Reich authored
When sharding browser tests they need access to the isolated task directory to ensure no clashing of output when writing out the coverage files. Pass it through as a command line switch when the gn arg use_javascript_coverage=true is passed in. CL:2584416 enables the redirection of coverage files to the supplied path in the Files browser test harness. The browser test harness independently writes out the coverage files to a supplied directory so in the merge_results.py script we ensure the output directory exists before writing the merged files. --devtools-code-coverage=/some/directory Bug: 1113941 Test: browser_test --gtest_filter=*FilesApp* Test: https://chromium-swarm.appspot.com/task?id=5077deb238ad7610 Change-Id: I8bb6d6640e2ce74d9d01805b3746b6303e11a21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584375 Commit-Queue: Ben Reich <benreich@chromium.org> Reviewed-by:Yuke Liao <liaoyuke@chromium.org> Auto-Submit: Ben Reich <benreich@chromium.org> Cr-Commit-Position: refs/heads/master@{#840428}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609869437-3a75c705c558e60abdee705e3f24c9125b018e03.profdata to chrome-win64-master-1609880376-433e631db9acaf4e4400335821e1ac4c51c26057.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iac0a72f926c62400f924a4953de2c3dadbe0bf27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611989Reviewed-by:
-
Xiaoqian Dai authored
The two flags are "drag-to-snap-in-clamshell-mode" and "multi-display-overview-and-split-view". TODO: - clean up the feature flags in the following CL. Bug: 1143342, 1143331 Change-Id: I13739a3856a37af6f33ad0e41632331c2d2c6884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600219Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#840426}
-
Victor Costan authored
Change-Id: I7ab1de6fcc9b6778ce29e1fdd85d3e926dcfe0d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610632Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#840425}
-
Tarun Bansal authored
This code is no longer in use. Change-Id: I2ec05b8b3106b630260e82880cf31d2b8ec7eb1b Bug: 1090417,1159182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599005Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#840424}
-
Pavel Yatsuk authored
This CL addresses a crash in the scenario when the tab is closed while the message is still displayed. In this scenario WebContents gets destroyed before the message is dismissed by auto-dismiss timer. Along with WebContents, SavePasswordMessageDelegate get destroyed. Its dtor fails on the check that the message was dismissed. This CL dismisses all messages on willCloseTab event from TabModel. BUG=1161664 R=lazzzis@chromium.org,twellington@chromium.org Change-Id: Id2b94dfe5d37f17f50ea60356a7edccc524d0778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610365Reviewed-by:
-
Willie Koomson authored
This change adds the DemoModeDelegate interface to ArcClientAdapter. This is used to load the Demo Session apps path for ARCVM. BUG=b:144542975 TEST=ArcDemoModeDelegateImplTest unittests; run Chrome with change and verify that it does not crash Change-Id: I703ac8e4344dc1e78531d94b0c52be576668c2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600076 Commit-Queue: Willie Koomson <wvk@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#840422}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b5675ec0..c8d1d1cb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7618a30190ed7f33756ac7d4ea9ad8c3fb2f8c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611870Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840421}
-
Jeremy Roman authored
flat_map can be more efficiently constructed when it only has to sort once, which can be done by constructing the initial data in a vector (and ideally, as here, by reserving its capacity). Change-Id: Iea865434fe17c7b06a21d62565b447332c521cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605881 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#840420}
-
Jeremy Roman authored
HintsChecker::sequence_checker_ is made effective, which may cause the checker to discover previously unknown sequence bugs if any exist. class contains no non-const data or any other apparent reason to require a sequence checker. DecisionTreePredictionModel: :sequence_checker_ is removed, since that Change-Id: I4c62720d62e2cbb32ea45acfcd9f482406361f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606130 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
-
Xinghui Lu authored
We plan to add referrer to real time URL check and would like to know the latency of obtaining referrer from Safe Browsing navigation observer. We don't plan to preserve these metrics for a long time, so they are set to be expired in three months. Metrics added: SafeBrowsing.NavigationObserver.IdentifyReferrerChainByEventURLTime SafeBrowsing.NavigationObserver.IdentifyReferrerChainByWebContentsTime SafeBrowsing.NavigationObserver.AppendRecentNavigationsTime Bug: 1161342 Change-Id: I1fc9431aa37cfd472bffebdbdda26bcbd352c632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601544 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#840418}
-
