- 15 Oct, 2019 40 commits
-
-
Chris Harrelson authored
This reduces the snapping-related code paths in the referenced bug by about 4x. Bug: 504567 Change-Id: I4a48eef9935dbb9bfb75d7ab2a0b921f3f5b2c8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860403 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#706081}
-
Caleb Rouleau authored
This change https://chromium-review.googlesource.com/c/catapult/+/1839176 makes it so that expectations config is passed to story_filter.py using the project config (sometimes referred to as the "environment"). This change lays the groundwork for that future change. Until that change is committed, this is a no-op change. This change first requires this catapult-side change https://chromium-review.googlesource.com/c/catapult/+/1854882 to make sure that we don't pass an invalid argument to GetRunOptions(). Bug: 985103 Change-Id: Idd53aaf7f84e792b0d7a7d0db6b45ce0562fb5f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854794 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#706080}
-
Garrett Beaty authored
Setting default RBE_PROD backend in some of the builder functions means that any new builders added would use the RBE_PROD backend which might overwhelm the backend if it is triggered often. Instead, require all builders to be explicitly opted in to RBE_PROD backend. The functions for the goma FYI builders were left as-is since they incorporate the information about the backend in their names and its is reasonable that the goma team would be specifically concerned with the backend being set correctly to not accidentally add something using the wrong backend. Change-Id: Ia1ec7ec8d35232f02d503ecc4cec196f94a7f134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862259Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#706079}
-
Olga Gerchikov authored
This CL changes how local time of composited worklet animations is updated on main thread: instead of polling local time on main thread, the local time is posted via animation events by the composited thread to the main thread. Design document: https://docs.google.com/document/d/1vUxaKBLDHQv9ACJUQJH4RXjuQTlWIsSiAFYkMrjccyc/edit?usp=sharing Changes made: - Expanded AnimationEvent to support worklet animation time update event type. - Reused existing mechanism of posting animation events to the main thread to support new event type. - Removed "peek" logic. - Enabled tests that previously failed. Bug: 943787 Change-Id: I2d285506739ea623e292927d21e54910fb7e24bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826872Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706078}
-
George Zhang authored
Currently, nothing in the codebase exists to generate java heap dumps. By adding this, we write heap dumps to file that can be passed to c++ which can be later uploaded and analyzed. Bug: 1012072 Change-Id: I9381b998d3fc98d2efa7f226e3c0b0b25dd4f3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839011 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#706077}
-
Livvie Lin authored
Bug: 1007497 Change-Id: I4498d39cabf4736a697294ad027082a53894a623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857166Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706076}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/260e87e6956a..4ccba5fc7b22 git log 260e87e6956a..4ccba5fc7b22 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 vapier@chromium.org partial_mock: AddCmdResult: switch to stdout/stderr arg names 2019-10-15 saklein@chromium.org portage_util: Add version validation to chromeos_version.sh call. Created with: gclient setdep -r src/third_party/chromite@4ccba5fc7b22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1cc7c13e645d5d594ad71afa2e00b68b027b6feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862243Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706075}
-
David Van Cleve authored
A common task when parsing encoded structs from a network is to read a serialization of an object with (possibly nested) length-prefixed members. //third_party/boringssl's Crypto ByteString bakes support for this in by having a "length-prefixed read" API that initially reads a big-endian length L from the buffer, then constructs and returns a new reader on the L many bytes immediately following the length, skipping the parent reader over this substring. However, this API is C-style and, as a consequence, perhaps not suitable for wide use in Chromium code. This patch adds similar functionality to base::BigEndianReader by adding ReadU8LengthPrefixed and ReadU16LengthPrefixed methods. R=mark Change-Id: Idaf0b04b414a3484099a861ef02501e5f8a83a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860518 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#706074}
-
Konrad Hofbauer authored
Feature: https://webrtc-review.googlesource.com/c/src/+/118936 Bug: 925645 Change-Id: Ifac28cbfb3a9f464f14375a53791418a41cfec2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859992 Auto-Submit: Konrad Hofbauer <hofbauer@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#706073}
-
Toni Barzic authored
Adds ash::features::kHomerviewGesture that will guard implementation for swiping from home screen shelf to overview. Also, hooks up a simple homerview gesture controller to shelf layout manager that starts overview session with no animations (this will change as animation is hooked up). BUG=1005366 Change-Id: I94d0594d99c90235cdc9c36db667187401e61b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857470Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#706072}
-
Sebastien Marchand authored
These tests seem to be failing because they're expecting some exact values for some timestamps, which doesn't work with the recent changes to the mock time fixtures. Bug: 1014181 Change-Id: I47223003524314cd145fc6bfa477386c7e4fc84a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862716 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#706071}
-
Robert Liao authored
Individual classes now extend from Microsoft::WRL::RuntimeClass. BUG=1014283 Change-Id: I2c95a380134ea60756eb5115ba3209ce520b680b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862118 Commit-Queue: Robert Liao <robliao@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#706070}
-
Peter Boström authored
Replaces OnBoundsChanged calls in ActionableView and SystemMenuButton. Removes highlight-path setting in TrayBackgroundView. Bug: chromium:1007546 Change-Id: I62752aa70ffd652db29b5d963854f174376da8bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859638Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#706069}
-
Vladislav Kuzkokov authored
The feature has been released. Bug: 1011028 Change-Id: Iec435ca812e4a6a6aa13336acd70fc348a03c66b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863295 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#706068}
-
Vladimir Levin authored
This patch updates the regex in update_use_counter_css.py to handle the last line in the css_property_id.mojom which may not have a trailing comma. Also refreshing enums.xml with the new script. R=asvitkine@chromium.org Change-Id: I66b884c511ee271e7a6014bc4dca34c22edcbbf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863471 Commit-Queue: vmpstr <vmpstr@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#706067}
-
Peter Boström authored
Bug: chromium:1007546 Change-Id: I72550e299fe27569861c9807d633d779e9616382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861100 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#706066}
-
Aidan Beggs authored
As of right now, the heuristic does nothing when tripped. We will later use the cases where the heuristic is triggered to iterate on, and improve the algorithm. Bug: 1012476 Change-Id: I441abe768701a7c6e1b5a0871be63acb9f948006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853914 Commit-Queue: Aidan Beggs <beggs@google.com> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#706065}
-
John Budorick authored
Having this disabled is causing performance_test_suite to consistently fail on functional test bots b/c it tries to run a shard w/o running tests. Bug: 848900 Change-Id: I05bcef1b3f5b9e42238e533a020a0acaddb6369b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862255 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#706064}
-
Mohammad Refaat authored
Bug: 987646 Change-Id: Ic834aac16e4e78a3da0983d4ec2a2f719315e8db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860107Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#706063}
-
Monica Basta authored
The profile name and avatar icon will not be syncable prefs anymore. We have decided that the user will need to customize their profile once per device if they wish to. We also change the strategy for showing the avatar icon of the profile to the following: * For profiles that are not signed in, on events like sign in or enable sync, Gaia avatar wins. * If the user customizes their profile while having a butter account or a primary account on this device, the customized avatar wins. * If the profile has a butter account A with customized avatar, if the user decides to start syncing with account A, the customized avatar wins. We do not want to change the state of the profile given that it is the same account. * If the profile has a butter account A with customized avatar, if the user decides to start syncing with account B, the Gaia avatar wins. Bug: 1013597 Change-Id: Ic60cca56d31e20a31d010e9f8995a03ca7819623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855968 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#706062}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 6 histograms that show frequent access in the past 90 days. These are the 80% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-04-12. Change-Id: Id3a9f34effe97a5a8d556e9b23621b248eb37a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863199 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#706061}
-
David Tseng authored
In ARC++, we send the entire tree from inside the Android container out to Chrome. As a result, each time the AXTreeSerializer is asked to serialize, we rely upon it to compute the incremental tree update starting at the event target. This can exercise the serializer in various ways not seen on other platforms. In order to ensure we always serve a fresh tree to Chrome OS extensions, that listen on the other end of AXTreeSourceArc, set |node_id_to_clear| on each AXTreeUpdate sent to the extension. This has the advantage of forcing re-computation of unignored child count and index in parent which have been buggy given corner cases of tree update permutations. This change also makes a few cleanups/improvements: - PopulateAXRole gets moved into ArcAccessibilityDataInfoWrapper::Serialize. This was done to ensure tests that only call Serialize get the *entire* serialized AXNodeData. Previously, we were omitting role population due to the special casing of the root node. - removed logic surrounding assigning root node role from AXTreeSourceArc. This was done previously because the tree may or may not contain ancestor windows from ARC++ (i.e. AccessibilityWindowDataInfoWrappers were not being used). We can now safely assume we have windows in the tree. This change also relaxes the role assignment on the root *Node* (not window). We now compute its role as normal as any other node, but still assign it as modal. This is to cover strange cases in in tests where we have just one node in the node tree (one window with a child node). That node might be a staticText, but we were assigning it arbitrarily as a genericContainer. (see test change). Bug: b:142544528 Test: unit_tests --gtest_filter=AXTreeSourceArc*.* Change-Id: I9c14d9c7fdc10cfffd9ce734921276fd503eac33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856830 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#706060}
-
Mikhail Khokhlov authored
The following benchmarks are added: - jetstream2, uses the new AddMeasurement API - octane, uses the old AddHistogram API (but values are also recorded as histograms) - blink_perf.css, a non-press benchmark also using AddMeasurement. output formats for these will now be handled by results processor. Bug: 981349 Change-Id: I08c3cf9c878a32389fa81912020922ff652593f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863293Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#706059}
-
Peter Boström authored
Replaces OnBoundsChanged overrides. While here also replaced GetCenterPoint() implementation to return GetLocalBounds().CenterPoint() instead of using width()/height(). Bug: chromium:1007546 Change-Id: I4e821cd1b9a07c5352b6d34301e9fa0928aafb39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861281Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#706058}
-
Christian Dullweber authored
Record user actions and uma for cookie controls usage. The uma histogram is recorded in addition to ukm to allow measurements for regular+incognito mode. Bug: 967668 Change-Id: Ibbb8a75d7f03c42c824967bfdfd752fa258d10a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855920Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Huanzhong Huang <huanzhong@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#706057}
-
Nate Fischer authored
This changes AwActivityTestRule to use ScalableTimeout instead of hardcoding the timeout. This should have no effect (bots don't appear to set this value), but gives devs the option of scaling the timeout if they use tools like valgrind. Bug: 1013465 Test: N/A Change-Id: I05100f36a96cb21ac989c7c5e1f12abbaca16ffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861048Reviewed-by:
Andrew Luo <aluo@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#706056}
-
Devlin Cronin authored
ExtensionBrowserTests look for paths beginning with "_test_resources" in extension resources being loaded, and redirect them. The original motivation for this was to allow us to re-use common utility files between loaded test extensions. We want to use this in the PDF extension tests. For this, we want to load resources that aren't part of the extension itself as if they were - specifically, for the sake of exercising module code. Beef up the _test_resources handling by: - adding support for subclasses to specify their own parent directory through ExtensionBrowserTest::GetTestResourcesParentDir(). This allows PDF tests to load resources from chrome/test/data/pdf instead of chrome/test/data/extensions. - adding browser test coverage, including the basic case, a component extension case (which the PDF extension is), and the customized resource parent. This is needed to unblock the PDF extension's use of modules, which in turn is needed for the Polymer 2 -> Polymer 3 migration. Bug: 1005029 Change-Id: I8a998eebf38bb680ffde72f512b962d83fe75989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850779 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#706055}
-
Min Qin authored
This is part of on-going modulization effort. Chrome/browser/android/download should be under the download/ feature. BUG=1013759 Change-Id: Ife04a391d22799d8bcdcfa979ea04874b20e4a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857544Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706054}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ac0a4cbbd850..6841d25d45ac git log ac0a4cbbd850..6841d25d45ac --date=short --no-merges --format='%ad %ae %s' 2019-10-15 sprang@webrtc.org Reland "RtpRtcp modules and below: Make media, RTX and FEC SSRCs const" 2019-10-15 srte@webrtc.org Cleanup: Replacing set extension status bool with CHECK. 2019-10-15 saza@webrtc.org AEC3: Add support for logging warnings on delay buffer changes 2019-10-15 sprang@webrtc.org Revert "Reland "RtpRtcp modules and below: Make media, RTX and FEC SSRCs const"" 2019-10-15 phoglund@webrtc.org Put the resources_dir flag into its own target. 2019-10-15 sprang@webrtc.org Reland "RtpRtcp modules and below: Make media, RTX and FEC SSRCs const" Created with: gclient setdep -r src/third_party/webrtc@6841d25d45ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: If46e242a6503e5c750485651b0e3a2b7c14a4d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863071Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706053}
-
Peter Boström authored
Replaces path generation in ::OnBoundsChanged. Bug: chromium:1007546 Change-Id: Icfb148443fe61578953bced671cc8f482fabe9e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861042 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#706052}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8d061254d2f4..12dc10e0278c git log 8d061254d2f4..12dc10e0278c --date=short --no-merges --format='%ad %ae %s' 2019-10-15 dproy@google.com Merge "Larger click target for expanding track groups" Created with: gclient setdep -r src/third_party/perfetto@12dc10e0278c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I76d83ee7780194f27784ed391c3ac2ac5a85d7c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862240Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706051}
-
Akihiro Ota authored
This changes ChromeVox language switching behavior to alert users if we do not have an available voice for the current language, instead of failing silently or butchering pronunciation with a different voice. This change: 1. Adds logic in LanguageSwitching.js to check if there is a matching voice for a language before making a language assignment 2. Modifies the accessibilityPrivate.getDisplayLanguage() api to take an additional parameter (the desired output language) 3. Adds a LanguageSwitchingTest to confirm new behavior. 4. Modifies existing API tests to confirm new behavior. Bug: 1008481 Change-Id: I5537c916a0e6b435c5c833b8e7fe7a9e530df65b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829547 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706050}
-
Eric Robinson authored
This change adds a variable to ChildProcessPriorityLauncher to indicate whether the associated process is only used to run tasks for ad frames (low priority frames). That variable is then used by the RenderProcessHost to background the frame in those cases. Notification happens in the RenderProcessHost via new UpdateFrameWithPriority. Note: Identification of ad frames is done as per the AdTagging project. Frames that have been marked as ads remain ads, and thus the RenderProcessHost will remain low priority if the frame is navigated to any other non-ad URL within the same process (same domain). Currently this is behind a feature which is off by default. We will be experimenting with this to determine its impact on both ads and in the browser as a whole. TBR=dcheng@chromium.org,gab@chromium.org,pbos@chromium.org,jkarlin@chromium.org Bug: 979234 Change-Id: I1acd1b8de7e66f8b2c47564df5e708f9b41f72a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855680 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#706049}
-
Elly Fong-Jones authored
When navigating to the tab as an accessible pane (via F6), focus currently gets dropped at the first tab, which is not as useful as it might be. It is easy to get to the start (via Home) or end (via End) of the strip but not to get to the active tab. As such, focus should land on the active tab by default instead. Bug: 910687 Change-Id: I0d70e171557d5591745c117bdca067f77c4feaec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857303Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#706048}
-
Xing Liu authored
This test is failing on some Android builder. TBR=miu@chromium.org Bug: 1014540 Change-Id: I33aad07c462a892a0b2bd5545bf1a8f1a7f5eae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863552Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#706047}
-
Xing Liu authored
Currently it's failing on an Android O builder. TBR=tbansal@chromium.org Bug: 1014213 Change-Id: I4d22e177e2ffdc76040be0be623883dfd0124a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862248Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#706046}
-
Ahmed Mehfooz authored
This change ensures that the message center collapses to just have the notification bar visible when there is less than kMessageCenterCollapseThreshold space available. Bug: 1002710 Change-Id: Ia0d15b0686788905fd8757366e405227851f1c51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846235 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#706045}
-
Lukasz Anforowicz authored
Casting a raw integer (e.g. an integer deserialized from session restore files, from a protobug, or coming from the other side of JNI boundary) to an enum class value may potentially cause the following problems: - Invalid enum values may cause Chromium code to misbehave. - It is not entirely clear if C++ spec allows such casts (i.e. if such casts may lead to undefined behavior). Because of the above, this CL replaces: static_cast<network::mojom::ReferrerPolicy>(raw_integer) casts with calls to a new content::Referrer::ConvertToPolicy static helper method, which tries to ensure that the cast is done in a safe way. Bug: 1006409 Change-Id: I2a660c4caf961ca52503b084a7c0abe93e9d5eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816134Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#706044}
-
Michael Liao authored
DevTools [Common - Flame Chart]: Making flame chart keyboard accessible in memory and javaScript profiler tool Changes: - Adding keyboard navigability to JavaScript and Memory profiling flame charts - CPUProfileNodes with source links are enter-clickable - Flamechart's focused CPUProfileNodes will turn gray (from blue) when flamechart loses focus CPUProfileNode selected (with and without focus): https://imgur.com/a/e6JkqYW Bug: 963183 Change-Id: Icb00d5b53dab6cd5f83e5602a7d3834afdb7eab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663021Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Michael Liao <michael.liao@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706043}
-
Darwin Huang authored
Bug: 1013400 Change-Id: I1dcdff204890c060ea243d3be846aa211a39e468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859879Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706042}
-