Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 12 May, 2015 27 commits
  3. 11 May, 2015 13 commits
    • dzhioev's avatar
      Unified icon-buttons used in the new GAIA flow. · 38e0418e
      dzhioev authored 
      This CL introduces the 'gaia-icon-button' decorator, which can be applied to any
<button>.
All icon buttons introduced recently are <button is="gaia-icon-button">s now.

BUG=478545,472671
TEST=manual

Review URL: https://codereview.chromium.org/1133733003

Cr-Commit-Position: refs/heads/master@{#329284}
      38e0418e
    • jdduke's avatar
      Reland "[Android] Preserve the front buffer when the activity is paused" · 61c7526b
      jdduke authored 
      This change was reverted in r322170 due to WebView breakage. The
ApplicationStatus dependency has been made optional, allowing
WebView to opt-out of its use. It was speculatively reverted
again in r327092, but that turned out to be a false alarm.

Original description: ----------------------------

Currently, when an activity is stopped, we explicitly hide the
foreground Tab. This is problematic, as current hiding semantics
might clear the visual front buffer before the window is hidden.
This in turn causes an unpleasant flickering during activity
transitions, e.g., when backgrounding Chrome or locking the screen.

Wire Activity onPause/onResume notifications to WindowAndroidObservers,
allowing the foreground tab to preserve its front buffer while hiding
its web content. If the tab is explicitly hidden, or the root window
is lost, the front buffer will be cleared as usual.

BUG=481450,434401

Review URL: https://codereview.chromium.org/1001573003

Cr-Commit-Position: refs/heads/master@{#329283}
      61c7526b
    • blink-deps-roller's avatar
      Roll src/third_party/WebKit ff93a86:38a0fb8 (svn 195201:195205) · 7fd7d99a
      blink-deps-roller authored 
      Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ff93a86..38a0fb8

TBR=yosin@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/1128003004

Cr-Commit-Position: refs/heads/master@{#329282}
      7fd7d99a
    • dalecurtis's avatar
      Partially revert change to not post AttemptRead() every Render(). · 95a43e33
      dalecurtis authored 
      http://crrev.com/328649 changed VideoRendererImpl so that it only
posted AttemptRead() when there was space in the queue.  Unfortunately
this causes more dropped frames for demanding content (H.264 4K in
particular) than always posting since the AttemptRead() call may be
delayed for some time:

AttemptRead() TimeFromPostUntilExecuted: 0.076 ms
AttemptRead() TimeFromPostUntilExecuted: 4.613 ms
AttemptRead() TimeFromPostUntilExecuted: 56.158 ms
AttemptRead() TimeFromPostUntilExecuted: 56.197 ms
AttemptRead() TimeFromPostUntilExecuted: 52.214 ms
AttemptRead() TimeFromPostUntilExecuted: 35.555 ms
AttemptRead() TimeFromPostUntilExecuted: 18.917 ms

At the same time, the performance improvements I saw locally on my
MacBook are not reflected by the performance bots.  I further see the
dropped frame regression locally on Windows, so let's revert.

I considered a couple other solutions to avoid always posting, but
none were very glamorous:
- Release lock before calling AttemptRead(), fixes cases where Render()
was blocked on the lock in FrameReady().
- Checking the end time / ideal render count for the current frame and
posting on when we're almost expired...

In both cases, neither resolved all problem cases and both add more
complexity than just posting.  The task will abort trivially if there
is no work to do, so just revert.

BUG=439548
TEST=telemetry dropped frame count is lower.

Review URL: https://codereview.chromium.org/1135143002

Cr-Commit-Position: refs/heads/master@{#329281}
      95a43e33
    • rnk's avatar
      Roll ASan/Win to LLVM r237003 · 9f05e500
      rnk authored 
      Brings in coverage support for Windows.

Green build with this revision:
http://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%20tester/builds/217/steps/gclient%20runhooks/logs/stdio

TBR=inferno@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1140623002

Cr-Commit-Position: refs/heads/master@{#329280}
      9f05e500
    • estade's avatar
      [autofill] Fix crash due to ClassCastException · cbbbed44
      estade authored 
      BUG=484920

Review URL: https://codereview.chromium.org/1133523004

Cr-Commit-Position: refs/heads/master@{#329279}
      cbbbed44
    • wangxianzhu's avatar
      Remove testRunner.displayAsync() and displayAsyncThen() · bde8d4b6
      wangxianzhu authored 
      Blink tests have been modified to use the new layoutAndPaintAsync()
and layoutAndPaintAsyncThen().

BUG=484706

Review URL: https://codereview.chromium.org/1131803003

Cr-Commit-Position: refs/heads/master@{#329278}
      bde8d4b6
    • sclittle's avatar
      Make DRP bypass logic apply to any proxies that send the DRP via header. · f1234f14
      sclittle authored 
      With this change, the Data Reduction Proxy bypass logic will be applied
to any response that either used one of the currently configured Data
Reduction Proxies, or used a different proxy that sent the Data
Reduction Proxy via header.

BUG=476610

Review URL: https://codereview.chromium.org/1135153002

Cr-Commit-Position: refs/heads/master@{#329277}
      f1234f14
    • ananta's avatar
      Fix a stack overflow in the windows sandbox SpawnTarget function. · a6ddf97a
      ananta authored 
      This was caused by my recent change to allow handles other than STDOUT and STDERR to be shared
with the target. Reason for the crash was copying additional handles to the HANDLE array which had
space for 2 handles only.

Fix is to use scoped_ptr instead and allocate appropriate space for all handles being shared.

BUG=486434
R=cpu

Review URL: https://codereview.chromium.org/1128903006

Cr-Commit-Position: refs/heads/master@{#329276}
      a6ddf97a
    • pedrosimonetti's avatar
      [Contextual Search] Pinch zoom might cause a crash. · ffea7a5b
      pedrosimonetti authored 
      ContextualSearchEventFilter has a complex logic to detect
where to propagate events to, whether the Search Panel or
the Search Content View. Besides that, a single stream of
events (a single gesture) might be forwarded to different
targets depending on a number of factors (whether the
Panel was maximized, whether the gesture was horizontal
or vertical, whether the Search Content View is scrolled
at the top, and so on).

Things can get much more complicated when multiple
pointers are involved, like in gestures with multiple
fingers. If we mess with the order of the events, or
don't properly forward events from all pointers to the
Search Content View it will crash.

This CL fixes the problem by:

1) Forwarding all pointer events when multiple finger
gestures are used.

2) Ignoring multitouch events when forwarding horizontal
gestures to the expanded Panel. In this particular case,
we must ignore multitouch events because the presence of
a second pointer will cause the Search Page to scroll,
which is not supposed to happen in this case. So, now
we are properly ignoring ACTION_POINTER_DOWN and
ACTION_POINTER_UP events, while at the same time,
creating MotionEvents with a single pointer in order
to implement the intended "lock horizontally" behavior.

BUG=485008
BUG=486901
BUG=486902

Review URL: https://codereview.chromium.org/1137003003

Cr-Commit-Position: refs/heads/master@{#329275}
      ffea7a5b
    • khorimoto's avatar
      Convert date_time_page to 0.8. · c1134634
      khorimoto authored 
      While I was at it, I also added the page title as a translated string, as this seems to have been forgotten in the first implementation.

Review URL: https://codereview.chromium.org/1137063002

Cr-Commit-Position: refs/heads/master@{#329274}
      c1134634
    • lambroslambrou's avatar
      Handle exception writing to Chromoting host's stdin. · acfbcb21
      lambroslambrou authored 
      The linux_me2me_host script launches the host process, then writes the
JSON config to the child's stdin. If the host process dies before the
data is written to stdin, an IOError (EPIPE) exception is raised. This
CL handles the exception and retries launching the host, instead of
exiting the script.

To test this, I added a time.sleep(5) call between launching the
host and writing the config to stdin. This allowed me enough time to
simulate the error by killing the host process.

BUG=473441

Review URL: https://codereview.chromium.org/1138613002

Cr-Commit-Position: refs/heads/master@{#329273}
      acfbcb21
    • jbauman's avatar
      Remove CompositorSoftwareOutputDevice · 7e15c6af
      jbauman authored 
      This was only used in tests. In that case there's no reason to send the contents to another process, so we can use the simpler cc::SoftwareOutputDevice instead.

Review URL: https://codereview.chromium.org/1136553004

Cr-Commit-Position: refs/heads/master@{#329272}
      7e15c6af