GitLab

The drive::DownloadHandler was using the assumption that all
non-IN_PROGRESS downloads that are created were restored from history.
This is not a safe assumption.

Instead query the DownloadHistory to determine whether a new download
was restored from history or not.

Depends on https://codereview.chromium.org/230103002/ which adds a
WasDownloadRestoredFromHistory method to DownloadHistory.

BUG=7648

Review URL: https://codereview.chromium.org/230133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271595 0039d316-1c4b-4281-b951-d872f2087c98

Replace the use of struct EncodedAudioFrame and struct EncodedVideoFrame
with a unified struct EncodedFrame throughout src/media/cast.  This
allows for later merging of duplicated code throughout the stack.

The new struct drops the unused codec data member and adds a new data
member, reference_time.  codec is unnecessary because this is known in
all contexts where an EncodedFrame is produced/consumed.  The new
reference_time data member is added because virtually all interfaces
that passed around an EncodedXXXFrame were also passing the frame's
reference_time alongside.

Testing: Updated and ran all cast_unittests, plus manual testing
between multiple Cast sender and receiver implementations.

Review URL: https://codereview.chromium.org/288103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271594 0039d316-1c4b-4281-b951-d872f2087c98

Technically makes a few behavioral changes, but these shouldn't have
any real consequences:

1. When comparing conditional branch statements, the 'false' jump
target is now compared lexicographically before the 'true' jump target
(to reduce redundancy with comparing unconditional branches).  This
affects block ordering slightly, but equality (which is what we really
care about) remains the same.

2. Adds a bit more sanity checking: RET and JMP instructions should
only occur at the end of basic blocks.

Review URL: https://codereview.chromium.org/286063007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271593 0039d316-1c4b-4281-b951-d872f2087c98

DISALLOW_IMPLICIT_CONSTRUCTORS() should be used when we don't want any
implicit functions; but in the cases this CL touches, we just want the
default constructor to be private, not disallowed.

BUG=375000

Review URL: https://codereview.chromium.org/291063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271592 0039d316-1c4b-4281-b951-d872f2087c98

R=cpu@chromium.org
BUG=82385

Review URL: https://codereview.chromium.org/294753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271591 0039d316-1c4b-4281-b951-d872f2087c98

from c/b/e/api

and remove unwanted extensions:: prefix.

R=rdevlin.cronin@chromium.org
BUG=362672

Review URL: https://codereview.chromium.org/280853004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271590 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/287623005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271588 0039d316-1c4b-4281-b951-d872f2087c98

Step 1 to reduce the use of ui::ScaleFactor and
eliminate ui::GetImageScale

BUG=372212
R=ananta@chromium.org, sky@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/293563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271587 0039d316-1c4b-4281-b951-d872f2087c98

Duh. (Ironically, this will lead to a less-helpful error message if you
try "handle<foo.bar>", but in the same way as "handle<123>" doesn't give
a super-helpful error message.)

R=darin@chromium.org

Review URL: https://codereview.chromium.org/296613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271585 0039d316-1c4b-4281-b951-d872f2087c98

The out of process PDF plugin is never a "full-page" plugin because it is
always embedded in an extension. There is a check inside the PDF plugin
to make sure is being loaded in the top frame before calling this function.

BUG=303491
R=jam@chromium.org

Review URL: https://codereview.chromium.org/285373010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271584 0039d316-1c4b-4281-b951-d872f2087c98

This is primarily for Non-SFI NaCl, where leaking FDs would be a
security hole.  For SFI NaCl, this is just for defence in depth.

I've put the check just before enabling the seccomp-bpf sandbox.  This
guards against creation of unusual FDs, e.g. via epoll_create(), which
might happen even after enabling the SUID sandbox (which mostly disables
open()).

BUG=358719
TEST=browser_tests

Review URL: https://codereview.chromium.org/276443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271583 0039d316-1c4b-4281-b951-d872f2087c98

The updater now pulls BUG= lines out of the git log and 
processes/sorts/uniqifies them and prints them for even better 
commit messages.

Picked up changes:
6ef4764 Extend visibility checks to images that are extracted.
6e8c385 Updated Boilerpipe with some more modern tags.
cde81dc Add extract_text_only option
0a31800 filter out invisible elements
82b35ba Fix crash when content extraction fails.

BUG=354157,356336,362085,364356,367243

Review URL: https://codereview.chromium.org/297563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271582 0039d316-1c4b-4281-b951-d872f2087c98

R=reveman@chromium.org
BUG=372765
TEST=visual

Review URL: https://codereview.chromium.org/295713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271580 0039d316-1c4b-4281-b951-d872f2087c98

This first prefix action_names with 'generate' to differentiate them
from the target names.

This also collapses theme_resources_gen into theme_resources as there is
no reason to separate them.

It also removes a second declaration of grit_out_dir variable. We don't need to declare it twice in the same file.

BUG=None
TEST=None
R=thestig@chromium.org
TBR=brettw

Review URL: https://codereview.chromium.org/290773004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271579 0039d316-1c4b-4281-b951-d872f2087c98

When GenericChangeProcessor calls AttachmentService::StoreAttachments
AttachmentService invokes AttachmentUploader to upload attachments.

When attachment gets uploaded AttachmentService invokes
AttachmentService::Delegate::OnAttachmentUploaded.

GenericChangeProcessor implements AttachmentService::Delegate for now.
When attachment is uploaded it call WriteTransaction to update entries
referring this attachment with new attachment id.

R=maniscalco@chromium.org
BUG=371629

Review URL: https://codereview.chromium.org/272043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271578 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374651

Review URL: https://codereview.chromium.org/292853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271577 0039d316-1c4b-4281-b951-d872f2087c98

Disable PrintPreviewTest tests under asan. They started failing after PDF was open sourced. They must not have been doing anything interesting before since the bots didn't have access to the PDF plugin.

BUG=375126
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/293993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271576 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271572 0039d316-1c4b-4281-b951-d872f2087c98

The PDF plugin is now part of the open source project.

R=ericwilligers@chromium.org

Review URL: https://codereview.chromium.org/293983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271570 0039d316-1c4b-4281-b951-d872f2087c98

BUG=318769

Review URL: https://codereview.chromium.org/286353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271569 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/286933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271568 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/286333006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271567 0039d316-1c4b-4281-b951-d872f2087c98

This module still doesn't compile as there are certain dependencies
(mainly random number generator) that need to be replaced first, but
all necessary third_party code should now included.

BUG=165318

Review URL: https://codereview.chromium.org/285263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271566 0039d316-1c4b-4281-b951-d872f2087c98

Removal request as part of chrome-wide flag cleanup. See: https://docs.google.com/a/chromium.org/spreadsheet/ccc?key=0ArH-w4dboLrgdGRqNU5FUm1Za2VieTFHOE91MW9hUVE&usp=sharing#gid=0

BUG=315429

Review URL: https://codereview.chromium.org/291013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271565 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271564 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369973
TEST=ctrl + p does not crash.

Review URL: https://codereview.chromium.org/270553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271563 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174243:174310&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/297483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271562 0039d316-1c4b-4281-b951-d872f2087c98

This sets the standard directory structure for Athena.

BUG=362288

Review URL: https://codereview.chromium.org/287163009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271561 0039d316-1c4b-4281-b951-d872f2087c98

Add a ChromeOS implementation of VideoCaptureDevice that is aware of the rotation of the internal display, and updates the rotation of captured frames to match.

BUG=360048

Review URL: https://codereview.chromium.org/270263008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271560 0039d316-1c4b-4281-b951-d872f2087c98

The PDF plugin is now part of the open source project.

R=ericwilligers@chromium.org

Review URL: https://codereview.chromium.org/299613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271559 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375103
TBR=ncbray@chromium.org

Review URL: https://codereview.chromium.org/292123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271558 0039d316-1c4b-4281-b951-d872f2087c98

A non-exclusive root dependency is always emitted, and parsed
dependencies are ignored. Weights are mapped to existing SPDY
priorities, and vice versa.

BUG=345769

Review URL: https://codereview.chromium.org/287003011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271555 0039d316-1c4b-4281-b951-d872f2087c98

BUG=345769

Review URL: https://codereview.chromium.org/265823019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271554 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271552 0039d316-1c4b-4281-b951-d872f2087c98

When writing to a drive with mounted volumes, Chrome OS will recreate the partition table if it is observe to be missing and the volumes are accessed after writing.  This only occurs when erasing just the partition table because enough of the volume information is still present.

We also expand the amount of data erased when destroying partitions to 8k to account for 4k block sizes.  This has the side effect of overwriting the LBA for 512-byte-block drives, which only increases the effect of destroying partitions.

BUG=284834
BUG=335390

Review URL: https://codereview.chromium.org/282853003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271551 0039d316-1c4b-4281-b951-d872f2087c98

This flag is no longer used.

BUG=352747

Review URL: https://codereview.chromium.org/292683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271550 0039d316-1c4b-4281-b951-d872f2087c98

QuicClientSession::CloseSessionOnErrorInner.

Review URL: https://codereview.chromium.org/284303007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271548 0039d316-1c4b-4281-b951-d872f2087c98

This CL starts to use the new separated gallery without specifying the
file-manager-enable-new-gallery flag.

BUG=358698
TEST=none

Review URL: https://codereview.chromium.org/285373015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271546 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/263643005/ removed the
ExtensionService::ReportExtensionLoadError() method,
but apparently I forgot to remove it from the .h file.

Whoops.

BUG=351891
TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/292893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271545 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/293883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271544 0039d316-1c4b-4281-b951-d872f2087c98