GitLab

https://chromium.googlesource.com/chromiumos/chromite.git/+log/d403a66dc72a..2900d34d5975


git log d403a66dc72a..2900d34d5975 --date=short --no-merges --format='%ad %ae %s'
2019-01-28 saklein@chromium.org build api: Local protobuf version warning
2019-01-28 khmel@google.com chrome_update_extension_cache: use Json user type filter for default app.
2019-01-28 ahassani@chromium.org paygen: Add an unofficial signer
2019-01-28 saklein@chromium.org build api: add autotest HW Test tarball endpoint
2019-01-28 evanhernandez@chromium.org cros branch: Implement local rename.
2019-01-28 evanhernandez@chromium.org cros branch: Bump branch version.


Created with:
  gclient setdep -r src/third_party/chromite@2900d34d5975

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I7b831004791e2d6f2ca251d8a9bcf8df55612e2a
Reviewed-on: https://chromium-review.googlesource.com/c/1440744Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626813}

This reverts commit 544bd17c. In other
words it relands the updateAndCommit() functionality with a fix to
not change the used budget. The accidental change to the strict yielding
budget revealed a use-after-free bug, which is being fixed in a separate
patch.

The original updateAndCommit() description:
"""
This patch adds updateAndCommit() which updates the subtree cooperatively
and then commits.
"""

R=chrishtr@chromium.org

Bug: 882663
Change-Id: Ib62989ee51cd7da143d2f81a9ba674659365a20e
Reviewed-on: https://chromium-review.googlesource.com/c/1440830Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626812}

The bulk of the uncaptured main frame time metrics are due to input
handling and JS callbacks for rAF. This patch add metrics for those
and cleans up the signalling for main frame start.

There's a lot of plumbing here but I tried to go only as deep as
necessary to access the LocalFrameView.

Some metrics will change due to this patch. For example, we will
now include lifecycle update times induced by hit testing for event
handling.

Manually verified that metrics are emitted for the new categories.

Bug: 869966
Change-Id: Ic569b4ad9871c47147bac94bcdea14fa94d691be
Reviewed-on: https://chromium-review.googlesource.com/c/1407629
Auto-Submit: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626811}

This reverts commit 4aec08a8.

Reland changes:

Base to patchset 1 is the original commit.

patchset 2 fixes passthrough_command_buffer_perftests and
validating_command_buffer_perftests

patchset 3 fixes angle_perftests

I checked base_perftests, gpu_perftests, media_perftests,
tracing_perftests, net_perftests, and
load_library_perf_tests, and performance_browser_tests,
and they only run
on chromium.perf, so I didn't change them.

components_perftests and views_perftests and vr_common_perftests
were already fixed.

I checked for functional tests of these by running
src/testing/buildbot$ grep views_perftests . -r -C 4
, etc for other isolate names.

BUG=925750, 920002, 739863, 757933
TBR=jbudorick@chromium.org
TBR reason: reland. Code mostly already reviewed.

Change-Id: I08b658d48806187d2ad78ffc9f30e67e55a00b4e
Reviewed-on: https://chromium-review.googlesource.com/c/1440242Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626810}

https://chromium.googlesource.com/angle/angle.git/+log/4c94788c9c85..0f073667daf0


git log 4c94788c9c85..0f073667daf0 --date=short --no-merges --format='%ad %ae %s'
2019-01-28 jmadill@chromium.org Update docs on wrangling and standalone infra.
2019-01-28 syoussefi@chromium.org Add possibility to track GPU time in perf tests


Created with:
  gclient setdep -r src/third_party/angle@0f073667daf0

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I1dd61fd17aea80b6d5b7037855beee046a6ce228
Reviewed-on: https://chromium-review.googlesource.com/c/1440743Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626809}

Eliminate unnecessary heap allocations and make it easier to reuse in a
different test base.

Bug: 912704
Change-Id: I5bd5fcfcb568d77645a0a7c988953db39689d716
Reviewed-on: https://chromium-review.googlesource.com/c/1366303
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626808}

in OverviewSession::OnKeyEvent

Bug: 925878
Test: covered by unittest
Change-Id: I712acfcc7127e86e30d5d1be3ef8f86831c12368
Reviewed-on: https://chromium-review.googlesource.com/c/1440913Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626807}

The ZX_VM_FLAG_PERM_* names have been deprecated in favour of the
ZX_VM_PERM_* form, and will shortly be removed from the Fuchsia SDK.

Bug: 925597
Change-Id: I61d69877f5af352294669d5ca87d9b4841e03440
Reviewed-on: https://chromium-review.googlesource.com/c/1437998Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626806}

No behavior change if they are not both available.

Test: Tested with espeak and Chrome OS built-in TTS engine. For the latter,
tested both with and without plumbing word start indexes (cl/204334646)

Bug: 815378
Change-Id: I3ad931c6bce6acbf8d76e7272741d7dc07ee9278
Reviewed-on: https://chromium-review.googlesource.com/c/1385846
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626805}

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googltest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

This CL was uploaded by git cl split.

R=ajwong@chromium.org

Bug: 925652
Change-Id: Ic9a957ef55bb0c89f51783af0ad375e2d1d020c7
Reviewed-on: https://chromium-review.googlesource.com/c/1438406
Commit-Queue: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626804}

test: Replace _TEST_CASE_ with _TEST_SUITE_ in /gpu/ipc/common/gpu_memory_buffer_impl_io_surface_unittest.cc.

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googltest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

This CL was uploaded by git cl split.

R=dcastagna@chromium.org

Bug: 925652
Change-Id: I42aa840b81b1c944a02cdeee94408f03aacf6a4c
Reviewed-on: https://chromium-review.googlesource.com/c/1438336
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626803}

JSON manifests are deprecated.

This also converts the test_ws manifest, as it and ash were the last
remaining uses of service_manifest() GN rules' support for packaged
services.

Bug: 895616
Change-Id: I3bd329e4536bc7356e49977299e19944babb77b7
Reviewed-on: https://chromium-review.googlesource.com/c/1437707
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626802}

https://pdfium.googlesource.com/pdfium.git/+log/39cd98cedd91..a482e1f9802d


git log 39cd98cedd91..a482e1f9802d --date=short --no-merges --format='%ad %ae %s'
2019-01-28 tsepez@chromium.org Remove unreachable null checks for CXFA_Document::GetScriptContext().
2019-01-28 tsepez@chromium.org Remove unused gs_XFADefaultFreeData
2019-01-28 thestig@chromium.org Updated libtiff from 4.0.9 to 4.0.10.
2019-01-28 thestig@chromium.org Remove unreachable CJBig2_Context code.
2019-01-28 thestig@chromium.org Remove a parameter from CBC_OneDimWriter::RenderVerticalBars().
2019-01-28 thestig@chromium.org Fix nits in CCodec_JpegModule.


Created with:
  gclient setdep -r src/third_party/pdfium@a482e1f9802d

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I5448bf4e0444a16160d12340fd5719a215c578c5
Reviewed-on: https://chromium-review.googlesource.com/c/1440745Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626801}

This CL implements the App Service SetPermission method.

BUG=916380

Change-Id: Ib2e0f2e199da0c4c060a27055401e0cf803cbe3b
Reviewed-on: https://chromium-review.googlesource.com/c/1436781Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Nigel Tao <nigeltao@chromium.org>
Commit-Queue: Melissa Zhang <melzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#626800}

The notable changes from using the updated ABI are the use of read
fences returned by the framework to synchronize release of resources in
transaction acks.

The current code has some shortcomings in terms of potentially reading
the media buffers from GL (display compositor) and/or the framework
(system compositor). We currently always bind every new buffer to a
texture with an EGL fence wait, which is unnecessary if the buffer will
be passed to the system compositor. On the other end, we always and only
generate a read fence from GL that the AImageReader_deleteasync uses if
the current image has no external refs when a new image is acquired.
Ideally we should wait on read fences from GL and the framework if the
buffer was read by both (possible since the overlay decision could change
every frame), and only generate a read fence from GL if the buffer was
used by the display compositor.

All the above fence synchronization is meant to be correctly handled
using SharedImages, which can handle a buffer being imported by different
consumers and generating/synchronizing read fences bases on which API the
buffer is read by. Ensuring that these cases are handled correctly is left
until media is switched to Shared Images.

TBR=nyquist@chromium.org
R=liberato@chromium.org, piman@chromium.org

Bug: 889328
Change-Id: Ic9f49420540249c06943fd62f6fcba8830c6ccac
Reviewed-on: https://chromium-review.googlesource.com/c/1434918
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626799}

Some methods had only one caller so inline them directly.

Bug: 897226
Change-Id: I654162372223e743adb1d3459c6821f05be821ce
Reviewed-on: https://chromium-review.googlesource.com/c/1347042
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626798}

Bug: 881624
Change-Id: Ic2efd91bbccc891f98c5e5e7563996cd8fd138cc
Reviewed-on: https://chromium-review.googlesource.com/c/1440069Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626797}

This simplifies tests and upstart scripts that check if features are
enabled.

BUG=chromium:915754

Change-Id: I35b5d1fb91a55dbde3e540a3d1dd8321dd12335a
Reviewed-on: https://chromium-review.googlesource.com/c/1440125Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Commit-Queue: Allen Webb <allenwebb@google.com>
Cr-Commit-Position: refs/heads/master@{#626796}

This reverts commit 6296e827.

Reason for revert: don't need this data anymore.

Original change's description:
> URLLoader: add debug info to catch a leak again.
> 
> This time with a DumpWithoutCrashing
> 
> Bug: 901405
> Change-Id: Ie2a075afe384e3dc13fde076a558d5d90591ab92
> Reviewed-on: https://chromium-review.googlesource.com/c/1330076
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Maks Orlovich <morlovich@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606987}

TBR=jam@chromium.org,morlovich@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 901405
Change-Id: I82f5d55758a82a15072ee42b335071da36785521
Reviewed-on: https://chromium-review.googlesource.com/c/1440505Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626795}

Bug=None

Change-Id: Iba56025ce9ba723b9304520059c5ca9ccb0ede89
Reviewed-on: https://chromium-review.googlesource.com/c/1436206Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Commit-Queue: Doug Turner <dougt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626794}

Remove the flag since it is enabled for more than two milestones.

Bug: 774795
Change-Id: I1c3bf8d13bf6a2578bf80bf859a79df64ac61808
Reviewed-on: https://chromium-review.googlesource.com/c/1437518
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626793}

The missing null check caused a crash when there were rem units in use
and the root element display changed to 'none'.

Bug: 925844
Change-Id: Ia83f8e4e43779fabf621f72e2fa3d9a07d9c6d83
Reviewed-on: https://chromium-review.googlesource.com/c/1440781
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Auto-Submit: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626792}

Bug: 894651
Change-Id: I6810720e90876b80197bb2491d14a612012279da
Reviewed-on: https://chromium-review.googlesource.com/c/1440467
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626791}

The function is a general function for probing NGInlineItemsData. Hence,
this patch moves it to NGInlineItemsData, where it better resides.

This patch follows from kojii's comments in crrev.com/c/1436486

Bug: 894651
Change-Id: Icdc625c0dbddb219d484e987f4ea02076045a4c8
Reviewed-on: https://chromium-review.googlesource.com/c/1440501
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626790}

This reverts commit 1367a8cc.

Reason for revert: <INSERT REASONING HERE>
Rolled back upstream.

Original change's description:
> Remove duplicate bluetooth_private externs from chrome_extensions.js
> 
> Change-Id: I7ac749bfa0115479b133e9e9f53390b9ebf4022a
> Reviewed-on: https://chromium-review.googlesource.com/c/1435114
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#626318}

TBR=dtseng@chromium.org,rdevlin.cronin@chromium.org,devlin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I7463eb309c1c63926743c51189abe2df9f10f361
Reviewed-on: https://chromium-review.googlesource.com/c/1440511Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626789}

* Do not apply animation when laying out windows in overview mode
  when rotating the display by applying zero_druation mode.

* Do not re-layout overview grid when resizing due to rotation
  in tablet mode. This code path was O(N^2) because it re-layout
  all windows when one window gets resized.

 No functional change. All tests should pass.

Bug: 923391
Test: Overview rotation animation is smoother.
Change-Id: I4e690cc4e1744f1cc21d37c6ba0fc40ad481c86d
Reviewed-on: https://chromium-review.googlesource.com/c/1439803
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626788}

This wipes out all remaining references to catalog.gni in the tree.
Note that catalog.gni itself is not yet deleted as there are internal
downstream repositories which still depend on it. It will be removed as
soon as those are updated.

Bug: 895616
Change-Id: I262e0ad21e74a585fff5fd80f780aab07d57aef6
TBR: blundell@chromium.org, avi@chromium.org, danakj@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1436880Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#626787}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b19e8dff155d..9f5b861c32e0


git log b19e8dff155d..9f5b861c32e0 --date=short --no-merges --format='%ad %ae %s'
2019-01-28 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@9f5b861c32e0

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I80c57a12b6fd09c62bda433ddf56919e6e108538
Reviewed-on: https://chromium-review.googlesource.com/c/1440164Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626786}

The chronos user already owns the interface so it doesn't need an allow
policy.

BUG=chromium:915754

Change-Id: Id4778dc3f35375ddce033c8d8f515b255c4d0196
Reviewed-on: https://chromium-review.googlesource.com/c/1440741Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Commit-Queue: Allen Webb <allenwebb@google.com>
Cr-Commit-Position: refs/heads/master@{#626785}

This is a reland of 6b54a7e1

Removed some stale header references missed by the original CL

Original change's description:
> Clean up filesystem and leveldb service manifests
>
> Converts their manifests to C++ and removes their unnecessary test
> catalogs in favor of inline manifest lists.
>
> Bug: 895616
> Change-Id: I2c56b96b8b463ab8865dbaef6c2ad39aceb744f1
> Reviewed-on: https://chromium-review.googlesource.com/c/1436398
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Ken Rockot <rockot@google.com>
> Cr-Commit-Position: refs/heads/master@{#626718}

Bug: 895616
Change-Id: Iba9683adb0d31e49a063c9d73435cdbf20bf5401
Reviewed-on: https://chromium-review.googlesource.com/c/1440474
Commit-Queue: Ken Rockot <rockot@google.com>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626784}

This bug was caught by MSan when I inadvertently used this budget in
a different patch. The problem is that this variable is accessed before
being initialized by anything. This patch fixes the problem.

R=chrishtr@chromium.org

Bug: 882663
Change-Id: Ie1091ec668923fe53df095aff009ac054832c769
Reviewed-on: https://chromium-review.googlesource.com/c/1440114
Commit-Queue: vmpstr <vmpstr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Auto-Submit: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626783}

Change-Id: I10dd76c7ec119781c8cf38874cb3d5a9d6193ea2
Reviewed-on: https://chromium-review.googlesource.com/c/1413383Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626782}

Bug: 920056
Change-Id: I36630196e88ea6279d58b34c84a007c40ba280a1
Reviewed-on: https://chromium-review.googlesource.com/c/1440825Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626781}

- Add sync setup cancel dialog for confirming
  the sync cancellation during opt-in.
- This dialog is shown when the user clicks
  the 'Cancel' button in the account control
  or navigates away from the sync page.

Screenshot:
https://drive.google.com/file/d/1TaQbBntf1Or4y4CPOzFDHhKf9qLZWpDI/view?usp=sharing

Bug: 919745
Change-Id: I88de095ce7947cabf9363208579556a6486283a3
Reviewed-on: https://chromium-review.googlesource.com/c/1430016Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626780}

Bug: 923695
Change-Id: I7266b9d08e66b267241c4a2e59b1104b26fa92ef
Reviewed-on: https://chromium-review.googlesource.com/c/1435626
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626779}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6ca723bad79b..45f4b730aae2


Created with:
  gclient setdep -r src-internal@45f4b730aae2

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I5e5511343b26b7c99fe47494bcbf8c0ad1595ce2
Reviewed-on: https://chromium-review.googlesource.com/c/1440601Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#626778}

Bug: 923174
Change-Id: I738cf2b419d70f9cda5df400e945b637b73ce08d
Reviewed-on: https://chromium-review.googlesource.com/c/1440542Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626777}

BUG=925720

Change-Id: Ia7561fd1153408df32509cb96a313cc439193567
Reviewed-on: https://chromium-review.googlesource.com/c/1439924
Commit-Queue: Robert Liao <robliao@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626776}

BUG=925157
Screenshot -> https://screenshot.googleplex.com/UGN90fpgXWp

Change-Id: If04be84914125aed5e3e4908e96d092bd173bbfa
Reviewed-on: https://chromium-review.googlesource.com/c/1431474Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626775}

The janks are really short, but it looks like frequently this code runs
for more than 100ms on main thread.

BUG=891488

Change-Id: Ie195413fe1244cea671f0e77e5defc3faa807f0e
Reviewed-on: https://chromium-review.googlesource.com/c/1427079Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626774}