GitLab

A DCHECK was recently added that revealed that the
tab grid cell is nil sometimes in |-cellForItemAtIndexPath:|.
The cell should never be nil in this method.
This is an issue that was previously went unnoticed, but
adding a DCHECK unsurfaced this existing issue.

This CL removes that DCHECK since it was recently added.
It is replaced with a TODO so that the underlying issue can be fixed.

Bug: 839892
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I85e486786978f992e2b67a7c67b626fbfe97d898
Reviewed-on: https://chromium-review.googlesource.com/1044506Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556089}

Bug: 721408
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I22204e52a27a1431907d284fd32993d727b1435d
Reviewed-on: https://chromium-review.googlesource.com/1043528Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556088}

Conceptually, this is somewhat close to what WorkletAnimation does; the
KeyframeEffect skips (seeks) from point to point driven by the script-provided
local time. More importantly, it means that WorkletAnimations do not terminate
after the duration has expired (which they are not meant to do), and allows us
to remove the ActiveTimeProvider hack (in favour of this one!).

This CL also removes PushPropertiesTo from WorkletAnimation. This method used
to push the local_time_ from cc-main to impl. Doing so was incorrect as cc-main
never gets the output of the mutate call, so always has a zero local time, which
then started to interfere with the other changes made in this CL.

Bug: 779189
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ibb0bdd60753bd24264112e10a1f829d394db27e2
Reviewed-on: https://chromium-review.googlesource.com/1037766
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556087}

This reverts commit 55b083a6.

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=839683#c1
As a guess, key events used to go to SpokenFeedbackEventRewriter then KeyboardDrivenEventRewriter.

Original change's description:
> mash: Move SpokenFeedbackEventRewriter to ash; add mojo delegate
>
> Move the rewriter files to ash, keep the delegate impl in chrome.
> Add a mojo interface for the delegate to receive and return events.
> Ash's controller creates the rewriter, Chrome sets the delegate.
>
> Move, expand, and refine the existing unit tests.
>
> Add TODOs to refine the rewriter/delegate/ChromeVox pattern.
> (the rewriter shouldn't pass events that will need to be reposted)
>
> This should allow Mash to support this rewriter in the future.
> (for now, Ash doesn't get Window Service events sent to Chrome)
>
> Bug: 647781
> Test: No regressions with ChromeVox spoken feedback on Chrome OS.
> Change-Id: I4f7805298156ab9463ca3110a1e957f922c6d82b
> Reviewed-on: https://chromium-review.googlesource.com/1038819
> Commit-Queue: Michael Wasserman <msw@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555867}

TBR=jamescook@chromium.org,dmazzoni@chromium.org,msw@chromium.org,dtseng@chromium.org,tsepez@chromium.org


No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 647781, 839683
Change-Id: I8103916c1df3013d093cc6cdeac5745b6cd051d0
Reviewed-on: https://chromium-review.googlesource.com/1044492Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556086}

This reverts commit 44e2fc52.

Reason for revert: <CL title/description is inaccurate>

Original change's description:
> Make sure kNotificationId and kAppId are mutual exclusive on Windows
> 
> Bug: 734095
> Change-Id: I08275fff11aef97c3265a6832dc1485b4ef19b61
> Reviewed-on: https://chromium-review.googlesource.com/1038432
> Commit-Queue: Xi Cheng <chengx@chromium.org>
> Reviewed-by: Tommy Martino <tmartino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555986}

TBR=tmartino@chromium.org,chengx@chromium.org

Change-Id: I050712e720d65ab5b59ef67752c0c1bd3bbbbe02
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 734095
Reviewed-on: https://chromium-review.googlesource.com/1044569Reviewed-by: Xi Cheng <chengx@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556085}

In this CL, each frame updates its FrameResourceCoordinator with any
updates the lifecycle state. If the main frame lifecycle state is
updated, then the page inherit the new state.

The PageSignalGeneratorImpl then updates the state in TabLifecycleUnit
which is used by the chrome:://discards UI.

The CL also disables freezing a Tab that is already frozen.

Bug: chromium:804976
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iba82286a06af17ccb74a7f6fac18cdb7914c003a
Reviewed-on: https://chromium-review.googlesource.com/942022Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556084}

This reverts commit 6f0b5d97.

Reason for revert: Causing Webkit Linux Trusty Leak to fail
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/

Original change's description:
> [blinkpy] Find manifest items for tests by URL
> 
> When running WPT in web_tests, test names are more like URLs instead of
> file paths (to be precise, the part of a test name after external/wpt is
> a WPT URL), because WPT can generate multiple tests (variations) for a
> single test file (e.g. .any.js, ?run_type).
> 
> Therefore, when asking questions like "is a test slow?", we need to find
> the manifest item for that test by URL instead of by file path; whereas
> if we want to know if a file in external/wpt is a test file, we find
> the manifest item(s) for that file by file path.
> 
> This CL separates the two types of manifest queries, and chooses the
> correct one for each call site. Besides, unit tests are improved to
> cover the WPT variations (.any.js & ?run_type).
> 
> Bug: 831975, 800570
> Change-Id: I230d5ec7df06b7df1387da1b93788d6cae55d153
> Reviewed-on: https://chromium-review.googlesource.com/1043160
> Commit-Queue: Robert Ma <robertma@chromium.org>
> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556043}

TBR=qyearsley@chromium.org,robertma@chromium.org

Change-Id: I5fb2c257967e32d1e4fce4277c10d77635e303d4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 831975, 800570
Reviewed-on: https://chromium-review.googlesource.com/1044567Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556083}

Added the following test cases:
 - testReloadPageAfterServerIsDown
 - testGoForwardAfterServerIsDownAndReload
 - testGoBackFromErrorPage

Bug: 725241
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6a872e6691c66ff6facd100cdb90607488738ff6
Reviewed-on: https://chromium-review.googlesource.com/1043074Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556082}

NOTRY=true

Bug: 817872
Change-Id: I4cacf33aa0411fb648e3396ca047aa0ed8773123
Reviewed-on: https://chromium-review.googlesource.com/1044284Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556081}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ac9b5ca0..e0f6ae79

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I28206da5525c697ceced2275b13895205a99946d
Reviewed-on: https://chromium-review.googlesource.com/1044114Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556080}

Using wpt-import in Chromium 00eb06c3.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16860

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I9845c9f0a0456fbbdb114368aba93a3f41b2686c
Reviewed-on: https://chromium-review.googlesource.com/1044346
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556079}

Updated options page on get started tutorial
and complete sample extension.

Bug: 839545
Change-Id: I13cf017d1bf23e5a9eafe32cf8efe0eda214990f
Reviewed-on: https://chromium-review.googlesource.com/1044274
Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556078}

The scheduler expects balanced callbacks of DidHandleInputEventOnMainThread()
and DidHandleInputEventOnCompositorThread(EVENT_FORWARDED_TO_MAIN_THREAD).
If the expectation is broken, the wrongly-maintained UserModel would produce
an endless loop of UpdatePolicy(), which consumes device power.

Also makes corresponding changes to unit test.

Bug: 837105
Change-Id: Ib5193041728a97f055df757a33680e788dd4c876
Reviewed-on: https://chromium-review.googlesource.com/1032468Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556077}

Previously PatchElementHeader members were ordered by:
  [old_offset, new_offset, old_length, new_length].
This CL changes the order to
  [old_offset, old_length, new_offset, new_length]
to be consistent with PatchHeader's grouping by "old" and "new".

Also improve comments in patch_read_write_unittest.cc, and fix
input value in PatchElementTest.WrongExtraData.

Change-Id: I0dab56b7de1ba99f0a2f686dfebdf422a9d1c3b0
Reviewed-on: https://chromium-review.googlesource.com/1043073
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556076}

https://skia.googlesource.com/skia.git/+log/76c01c930ca4..4824ed05ac12

$ git log 76c01c930..4824ed05a --date=short --no-merges --format='%ad %ae %s'
2018-05-04 skcms-skia-autoroll Roll skia/third_party/skcms cc1799c..02fc32e (1 commits)
2018-05-03 benjaminwagner Remove fCacheKeys from SkImageFilter.
2018-05-03 jvanverth Use MaskFilter to create SDFs for text.
2018-05-03 kjlubick Add Skottie fuzzer (via json input)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: I7aea5cccf09f486a8feb73a9cf6760fb58822c40
Reviewed-on: https://chromium-review.googlesource.com/1044266Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556075}

I disabled the test because it was failing on one builder and blocking
the fix from landing. The test is now adjusted so that the mocked
InputMethod is assigned before Setup.

BUG=839339

Change-Id: I8b6b75337f52eb46f6e57ef4d5133ed5afc444c7
Reviewed-on: https://chromium-review.googlesource.com/1044269Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556074}

https://webrtc.googlesource.com/src.git/+log/9d96e923169d..e6256055e7db

$ git log 9d96e9231..e6256055e --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I06e993b5f5ff05e78d63dabbf803eef4630b42b1
Reviewed-on: https://chromium-review.googlesource.com/1044270
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556073}

A series of HeadlessRenderBrowserTests have been failing. A suspected fix to
some of them has landed.

However HeadlessRenderBrowserTestCookieSetFromJs_NoCookies.RunAsyncTest still
fails. This disables it on Linux until the team can provide a fix.

TEST=HeadlessRenderBrowserTestCookieSetFromJs_NoCookies.RunAsyncTest
TBR=eseckler@chromium.org

Bug: 839747
Change-Id: I526358528bd6b1922afc930db213be183426ae07
Reviewed-on: https://chromium-review.googlesource.com/1044303Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556072}

A typo fix

Bug: 839252
Test: tested on device
Change-Id: Ic56d3324212b23d23d6782bc082e3765f996eedd
Reviewed-on: https://chromium-review.googlesource.com/1043396Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#556071}

This CL does a bit of cleanup I found around while reading the code:
- Forward-declares CanvasDrawListener.
- Reduces a verbose comment.
- Removes _ from a few internal class names (they landed like this
 in crrev.com/c/728340 but usually Chrome derived classes don't
 use _.
- Uses early-break in CanvasResourceProvider::Create() to avoid deep
 indents and use {} for if statements with large conditionals.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib1faf4a2d334e0a9b108c9fa02ebfbeffa0ea8c3
Reviewed-on: https://chromium-review.googlesource.com/1042905Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556070}

Not sure why it was not supported before. We need it for Chrome OS Active
Directory management.

BUG=chromium:837800
TEST=manual

Change-Id: I3fcbe2e86204fcc09de29dba6dc857026aee3760
Reviewed-on: https://chromium-review.googlesource.com/1043747Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556069}

ash_shell_with_content will serve the same purpose.

BUG=none
TEST=none

Change-Id: I0f41c0cf1d25f994f280d7a5492717c8396b14dd
Reviewed-on: https://chromium-review.googlesource.com/1042495Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556068}

Bug: 731436,805257,824593,824594,826895
Change-Id: I93d5a5fb56be9161211e7cd0ba58876d4c702b19
Reviewed-on: https://chromium-review.googlesource.com/1041527Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556067}

Change-Id: I3b2de4b9175daf66cedd63b62474d35b4f185ab4
Reviewed-on: https://chromium-review.googlesource.com/1038614Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556066}

The number of bytes from cache are saved on each request and then
made into a fraction of the total bytes on the page (cache + network).
This fraction is bucketed for privacy sake and then sent in the
pingback.

Also adds connection type, which is also a per-page metric.

Bug: 830949
Change-Id: Ia17242cc9a54acf061a72f03b7f327e141d6f3c8
Reviewed-on: https://chromium-review.googlesource.com/1026522
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556065}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I209953453e1e0e64eb253f1d673c9c6f96c0f493
Reviewed-on: https://chromium-review.googlesource.com/1044268
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556064}

When a GFC arrives, the fling controller doesn't cancel the active fling
immediately. If the user starts a new scroll sequence while the fling
cancellation is deferred, the controller suppresses the GSB/GSU events
till either a new GFS arrives and the current fling gets boosted, or
the controller decides that it is gonna cancel the fling and resume
the new scroll sequence. To resume the new scroll sequence the controller
sends a GSB since the original GSB of the sequence is suppressed.

This cl changes the GSB event to have the timestamp of the last
suppressed event instead of using the current time. This change is
necessary to make sure that the monotonic time of a scroll sequence is
not violated.

Bug: 839051
Change-Id: I295de64deaad4b072ec69a1bbbc192f182577cf4
Reviewed-on: https://chromium-review.googlesource.com/1043017Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556063}

These tests already declare to be slow (long timeout), but due to a bug
we previously didn't parse the manifest correctly so we missed them.
https://crrev.com/c/1043160 fixed the issue so we can now remove these
expectations.

TBR=tkent

Bug: 803943, 818324, 803558, 831975
Change-Id: I8f978d025e026b77dd6f42ade6de8e283886c024
Reviewed-on: https://chromium-review.googlesource.com/1044293Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556062}

Bug: internal b/77653377
Test: on device
Change-Id: If07a4b9af7a97779c08817fbdd4ba7b9740cdd15
Reviewed-on: https://chromium-review.googlesource.com/1043390Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Gaofeng Huang <gfhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556061}

NetworkChangeNotifier::DNSObserver::OnInitialDNSConfigRead()
may not be called if the initial DNS config has been read
prior to the DNSObserver being registered.  HostResolverImpl
accounts for this already, but the test did not.  I've
updated the test and added an API comment to explain this.

Bug: 833659
Change-Id: I0c7eeb296a990fb69c9f0fac58483243079c3481
Reviewed-on: https://chromium-review.googlesource.com/1035222Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556060}

This CL stops using layered windows on Windows 8 and higher. Layered
window provide a way to add transparency effects on HWNDs. This is a
legacy API and DWM natively supports transparency. DWM will always be
there on Windows 8 and higher, so layered windows aren't needed.

Layered windows present GPU sandbox problems with OOP-D. Layered windows
also can't be partial updated, the entire window needs to be updated at
once.

Bug: 826633
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I6d0ab96392ee603b3b6ed680114f9e8a43c6134f
Reviewed-on: https://chromium-review.googlesource.com/1024874
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556059}

This CL uses the "Get more from Chrome" welcome page always when
Desktop Identity Consistency is enabled.

Bug: 837403
Change-Id: Ief4228e57962557373c0e97c1a11f96b35bcbc62
Reviewed-on: https://chromium-review.googlesource.com/1042307Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556058}

This CL enables Dice M2 by default in Chromium that have API keys
configured as those are mandatory for DICE.

It also ensures that unit and browser tests have DICE M2 enabled,
even for builds when the API keys are not configured.

Bug: 829220
Change-Id: I752bf7e9e03da0ddd33841e42ec1c550fcaf91c7
Reviewed-on: https://chromium-review.googlesource.com/1044210
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556057}

This reverts commit 4f02e64d.

Reason for revert: Breaks Nougat Phone Tester:

[FATAL:scoped_gpu_trace.cc(23)] Check failed: fence_->HasCompleted().

https://luci-logdog.appspot.com/v/?s=chromium%2Fandroid%2Fswarming%2Flogcats%2F3d3b6cf0bfd12611%2F%2B%2Flogcat_logcat_org.chromium.chrome.browser.vr_shell.VrShellTransitionTest.testStartActivityTriggersDoffChromeActivity_20180502T205516-UTC_HT73X0204522

Original change's description:
> Add GPU time trace for VrShellGl browser rendering path
> 
> 
> Bug: 837647
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I9c07ca3bfe5df595b9973b6ab0b18d3e629cd6eb
> Reviewed-on: https://chromium-review.googlesource.com/1035208
> Commit-Queue: Biao She <bshe@chromium.org>
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Reviewed-by: Klaus Weidner <klausw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555430}

TBR=bshe@chromium.org,piman@chromium.org,klausw@chromium.org,tiborg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 837647
Change-Id: I3abcf1dd51ea93b81c517ee6b982aa92a218346d
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1043225Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556056}

On Linux Asan DownloadContentTest.CancelResumedDownload is flaky, this disables
the test on that configuration.

TBR=qinmin@chromium.org
TEST=DownloadContentTest.CancelResumedDownload

Bug: 836689
Change-Id: Idc8bba6213e15c1726bbac842d1bf4ed2e01b225
Reviewed-on: https://chromium-review.googlesource.com/1044309Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556055}

Flip flags.
https://chromium-review.googlesource.com/c/chromium/src/+/1042357

Put HasRetransmittableData last in if checks in QuicSentPacketManager because it will become fairly costly when session_decides_what_to_write is true.
Merge internal change: 194716021
https://chromium-review.googlesource.com/c/chromium/src/+/1042209

In QUIC, add received_ack_ranges_for_debugging_ to debug the packets being acked multiple times issue.
Merge internal change: 194562236
https://chromium-review.googlesource.com/c/chromium/src/+/1042208

Fix a bug where a connectivity probing packet is not recognized as so when it is reordered. Protected by existing flag FLAGS_quic_reloadable_flag_quic_enable_server_proxy2.
Merge internal change: 194280190
https://chromium-review.googlesource.com/c/chromium/src/+/1040594/1

Add framer/deframer code for IETF QUIC New Connection ID Frames
Merge internal change: 194271751
https://chromium-review.googlesource.com/c/chromium/src/+/1040473/1

Change name of some IETF-QUIC packet framer/deframer methods
Merge internal change: 194265540
https://chromium-review.googlesource.com/c/chromium/src/+/1040591

Add IETF error code to the RESET_STREAM frame
Merge internal change: 194231167
https://chromium-review.googlesource.com/c/chromium/src/+/1040585/1

Pull apart QuicFramer's IETF Application- and Connection- close methods.
Merge internal change: 194069265
https://chromium-review.googlesource.com/c/chromium/src/+/1040466/1

Deprecate FLAGS_quic_reloadable_flag_quic_respect_http2_settings_frame.
Merge internal change: 193975549
https://chromium-review.googlesource.com/c/chromium/src/+/1040545/1

Deprecate FLAGS_quic_reloadable_flag_quic_remove_redundant_ping.
Merge internal change: 193964291
https://chromium-review.googlesource.com/c/chromium/src/+/1040209/1

Set stream_id to 0 for IETF BLOCKED frames, fix some error message typos.
Merge internal change: 193962014
https://chromium-review.googlesource.com/c/chromium/src/+/1040208/1

In QUIC, declare in flight packets lost via early retransmit, even if the packet has no retransmittable frames. Protected by FLAGS_quic_reloadable_flag_quic_early_retransmit_detects_in_flight_packet_lost.
Merge internal change: 193959628
https://chromium-review.googlesource.com/c/chromium/src/+/1040428/1

Remove flag count of FLAGS_quic_reloadable_flag_quic_fast_is_disjoint.
Merge internal change: 193956066
https://chromium-review.googlesource.com/c/chromium/src/+/1040426/1

Add IETF QUIC STOP_SENDING frame to the QuicFrame.
Merge internal change: 193953297
https://chromium-review.googlesource.com/c/chromium/src/+/1040408/1

Pull IETF QUIC Path Challenge frame into QuicFrame.
Merge internal change: 193948876
https://chromium-review.googlesource.com/c/chromium/src/+/1040407/1

Remove flag count of FLAGS_quic_reloadable_flag_quic_fast_path_on_stream_data.
Merge internal change: 193945925
https://chromium-review.googlesource.com/c/chromium/src/+/1040406/1

Bring IETF Path Response frame into QuicFrame.
Merge internal change: 193944997
https://chromium-review.googlesource.com/c/chromium/src/+/1040405/1

R=rch@chromium.org

Change-Id: Id5cfdbee80b51475fdd3182f17867012c3ca08fb
Reviewed-on: https://chromium-review.googlesource.com/1042218
Commit-Queue: Fan Yang <fayang@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556054}

NOTRY=true
TBR=ashleymarie@chromium.org

Bug: 817872
Change-Id: Ib6b85a069c46e0e1a1f2c03a08dbea95d2ed1d41
Reviewed-on: https://chromium-review.googlesource.com/1044294Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556053}

This CL adds the wiring that finally renders actions as clickable views
into the keyboard accessory.

Bug: 828832
Change-Id: I9aa72cda71843b1d96a8f9fd99969065600954e4
Reviewed-on: https://chromium-review.googlesource.com/1015420
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556052}

https://chromium.googlesource.com/chromium/deps/flac.git/+log/7d0f5b3a173f..af862024c8c8

$ git log 7d0f5b3a1..af862024c --date=short --no-merges --format='%ad %ae %s'
2017-07-26 agable Upload flac reviews to Gerrit by default

Created with:
  roll-dep src/third_party/flac

Change-Id: I0c610ae7e6ed4686cbedee9cd141c07c0ed9670c
Reviewed-on: https://chromium-review.googlesource.com/1044192Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556051}

https://webrtc.googlesource.com/src.git/+log/a1f566b28a69..9d96e923169d

$ git log a1f566b28..9d96e9231 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:None,chromium:None,chromium:839379,chromium:836790,chromium:839351,chromium:637666,chromium:None,chromium:None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Idaf4dcb114cbe96a981c6eba39aab8a3be42c19b
Reviewed-on: https://chromium-review.googlesource.com/1044265
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556050}