GitLab

Review URL: https://codereview.chromium.org/343783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278306 0039d316-1c4b-4281-b951-d872f2087c98

On Android < 4.2, the libkeystore.so ENGINE uses CRYPTO_EX_DATA and is not
added to the global engine list. If all references to it are dropped, OpenSSL
will dlclose the module, leaving a dangling function pointer in the RSA
CRYPTO_EX_DATA class. To work around this, leak an extra reference to the
ENGINE we extract in GetRsaLegacyKey.

This is exacerbated by https://codereview.chromium.org/27500004 which, at least
on 4.1.2, causes the session cache and OpenSSLClientKeyStore to get dumped
every time a client auth prompt comes up (https://crbug.com/381912).

In 4.2, this change avoids the problem:
https://android.googlesource.com/platform/libcore/+/106a8928fb4249f2f3d4dba1dddbe73ca5cb3d61

BUG=381465

Review URL: https://codereview.chromium.org/322533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278305 0039d316-1c4b-4281-b951-d872f2087c98

- restructured existing code to allow some tests to run in only normal mode
- added AddBookmark test to check ChromeVox while adding a bookmark
- switched SendKeyPress to SendKeyPressToWindowSync throughout all tests
- reordered expected ChromeVox messages and reenabled TypeInOmnibox test

BUG=None
TEST=this
R=dmazzoni@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/342773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278304 0039d316-1c4b-4281-b951-d872f2087c98

The previous change (https://codereview.chromium.org/332893004/) wasn't quite right. To avoid errors, we need to only fire focus and load events when the web view itself has focus, not say when the location bar has focus. And because there are transient periods when we can't fire events, we need to keep track of whether we need to fire a focus event with a flag and fire it later.

BUG=368549
NOTRY=true

Review URL: https://codereview.chromium.org/344573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278303 0039d316-1c4b-4281-b951-d872f2087c98

BUG=307323

This change is linked to https://codereview.chromium.org/300873002/

Review URL: https://codereview.chromium.org/319553008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278302 0039d316-1c4b-4281-b951-d872f2087c98

The path to feedback generation scripts has changed. This broke some
feedback reports. This CL updates the command line to generate touch
logs for feedback reports.

BUG=chromium:384454
TEST=file feedback and check submitted system_logs. Don't check
chrome://system, those logs are generated in a different way.

Review URL: https://codereview.chromium.org/335453008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278301 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278300 0039d316-1c4b-4281-b951-d872f2087c98

MSVC lexes L#macro_arg as a single wide string literal after
pre-processing.  Clang and other conforming C preprocessors lex this as
a single 'L' token followed by a normal string literal.  Using
L###macro_arg works with all compilers.  It should be parsed as 'L' '##'
'#' 'macro_arg', where '#' stringizes the macro arg and '##' token
pastes the two tokens together to form a single string literal.

R=dtseng@chromium.org
CC=thakis@chromium.org,hans@chromium.org
BUG=82385

Review URL: https://codereview.chromium.org/342773004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278299 0039d316-1c4b-4281-b951-d872f2087c98

By advancing to revision 272757, we should be able to pick up the GN
Build file that was added in
https://src.chromium.org/viewvc/chrome?view=revision&revision=272757

BUG=None
TEST=green trybots
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/337113004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278298 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370567
BUG=327783
R=jar@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277607

Review URL: https://codereview.chromium.org/321283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278297 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278296 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278295 0039d316-1c4b-4281-b951-d872f2087c98

As of r277056, the gpu memory manager is no longer using
managed memory stats produced. This patch removes the managed
memory stats calculation from the tile manager. As well, this
patch removes ununsed gpu managed memory stats plumbing.

BUG=377065

Review URL: https://codereview.chromium.org/342483007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278294 0039d316-1c4b-4281-b951-d872f2087c98

Before, the hash argument was simply ignored and defaulted to SHA-1. Instead it accepts now all values specified by WebCrypto, i.e. SHA-{1,256,384,512}.

BUG=385085

Review URL: https://codereview.chromium.org/331173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278293 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386246
TEST=unit_tests

Review URL: https://codereview.chromium.org/340703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278292 0039d316-1c4b-4281-b951-d872f2087c98

(minor pixel diffs due to https://skia.googlesource.com/skia/+/f3b50276a4ad71c9e8ba13d752a5db0c073cae2c)

BUG=379147
TBR=reed@google.com

Review URL: https://codereview.chromium.org/342823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278291 0039d316-1c4b-4281-b951-d872f2087c98

Added a colour to the version number and updated the font size to better
match the mocks. Also fixed a small bug in the logic that lays out the
name and version to place the version number on the next line if there
are no links (no webstore or license links) for the app.

Based off CL 335523002.

BUG=385423, 383720

Review URL: https://codereview.chromium.org/336333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278290 0039d316-1c4b-4281-b951-d872f2087c98

BUG=376562
TEST=chromium / chrome official builds fine
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/343693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278289 0039d316-1c4b-4281-b951-d872f2087c98

Context IDs given to DrawQuads to identify when a rendering context
changes, and whether or not a DrawQuad is in a 3D sorting context.

Review URL: https://codereview.chromium.org/332873005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278288 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383100

Review URL: https://codereview.chromium.org/338633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278287 0039d316-1c4b-4281-b951-d872f2087c98

Fixes the case where this code path is executed via sync and an ID has
already been assigned.

BUG=383557

Review URL: https://codereview.chromium.org/334303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278286 0039d316-1c4b-4281-b951-d872f2087c98

Replacing use of TestBrowserThread because it is deprecated and harder
to use correctly.

BUG=

Review URL: https://codereview.chromium.org/340643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278285 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386300
TBR=mnaganov@chromium.org

Review URL: https://codereview.chromium.org/342713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278284 0039d316-1c4b-4281-b951-d872f2087c98

and change the spinner background color to the same as EmbeddedSignin, otherwise user may see flicker.

BUG=385876

Review URL: https://codereview.chromium.org/335193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278283 0039d316-1c4b-4281-b951-d872f2087c98

The string is only used in that block, causing Clang errors when USE_GIO
isn't defined.

BUG=none

Review URL: https://codereview.chromium.org/331223004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278282 0039d316-1c4b-4281-b951-d872f2087c98

Also, flip picture vertically (it was upside down).

BUG=281689

Review URL: https://codereview.chromium.org/340163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278281 0039d316-1c4b-4281-b951-d872f2087c98

All dependent patches have landed and cycled,
remove support for the old format.

BUG=378862

Review URL: https://codereview.chromium.org/326933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278280 0039d316-1c4b-4281-b951-d872f2087c98

This patch checks in chrome/app/address_input_strings.grdp and does not
update it in "gclient runhooks".

BUG=327046

Review URL: https://codereview.chromium.org/337163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278279 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375430

Review URL: https://codereview.chromium.org/341923004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278274 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386254
TEST=Open a non-resizable app such as a calculator. Alt+] should not snap it.

Review URL: https://codereview.chromium.org/342823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278273 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a key_silk_cases page whose content was moved offscreen
on phone-sized Android devices by the addition of a viewport tag
(for triggering GPU rasterization), causing the smoothness
benchmark to fail on these devices.

BUG=381368

Review URL: https://codereview.chromium.org/343633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278272 0039d316-1c4b-4281-b951-d872f2087c98

We want a fixed Clang revision for ASan on Windows because ClusterFuzz
produces archived builds.  We don't want Clang to change underfoot and
produce a bad Chromium build that gets archived.

Long term, when ASan for Windows stabilizes, we should remove this
extra fixed revision and use the mainline Chromium revision.  For now,
we don't build with -Werror with Clang on Windows, so it isn't as
important to be in sync with other platforms.

R=thakis@chromium.org
BUG=82385, 345874
NOTRY=true

Review URL: https://codereview.chromium.org/341963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278271 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386418
TBR=stevenjb@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/340953005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278270 0039d316-1c4b-4281-b951-d872f2087c98

The problem with tests was that spoken feedback was getting enabled just
before loading the test extension. This would cause two extensions being
loaded: ChromeVox extension (which gets loaded when spoken feedback is
enabled) and the test extension. This is situation extension API tests
don't handle well. They wait for the test extension to get loaded by
waiting for any EXTENSION_LOADED notification. If the ChromeVox extension
got loaded before the test extension, the extension api test would continue
running too soon (before the test extension was loaded), and fail when the
test extension could not be found in extension set by its path.

To avoid that, keep spoken feedback disabled at the start of the test
(which should ensure that the ChromeVox extension doesn't get loaded while
the test extension is loading).

BUG=384266

Review URL: https://codereview.chromium.org/331383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278269 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385222
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/346663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278268 0039d316-1c4b-4281-b951-d872f2087c98

This should mean that "/etc/init.d/chrome-remote-desktop restart" will
stop the service and won't try to start it again until the daemon is
killed.

A timeout is used to make sure that system shutdown is not paused
indefinitely if the daemon is unkillable.

Note that, since the daemon is not a child process, os.waitpid() cannot
be used for this. The psutil Python module is used instead. Some other
parts of the script have been updated as well to use psutil methods.
This is slightly safer, as psutil has some PID-reuse detection built in.

BUG=334437

Review URL: https://codereview.chromium.org/335303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278267 0039d316-1c4b-4281-b951-d872f2087c98

Split out from http://crrev.com/265163006.

CQ has issues committing executables, so dcommitting this part.

TBR=tapted@chromium.org

BUG=353047

Review URL: https://codereview.chromium.org/345493004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278266 0039d316-1c4b-4281-b951-d872f2087c98

- DriveAppProvider to map Drive apps to chrome apps or local url apps;
- DriveAppMapping to track the mapped chrome apps;
- DriveServiceBridge to wrap DriveAPIService and DriveAppRegistry to
  provide the user Drive apps info;
- Put feature behind "--enable-drive-apps-in-app-list";

BUG=358791,345066
TEST=DriveAppProviderTest.*:DriveAppMappingTest.*

Review URL: https://codereview.chromium.org/308003005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278265 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386385
TBR=jianli@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/344633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278264 0039d316-1c4b-4281-b951-d872f2087c98

* Use weak pointer for cros settings callback
* Pass weak pointer to the thread pool task so that calling
 back to UI thread is safe.

BUG=349083

Review URL: https://codereview.chromium.org/341713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278263 0039d316-1c4b-4281-b951-d872f2087c98