GitLab

This CL adds AnimationFrameCallback class to update the properties of progress
center items at the correct timing, and ensure it invokes the CSS animation.

Previously, we use setTimeout function to ensure changes of progress items
properties are applied to one by one, but if the number of milliseconds is less
than the frame inteval, it does not work.

BUG=348493
TEST=Make a repro function and call it multiple times.

Review URL: https://codereview.chromium.org/185193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255349 0039d316-1c4b-4281-b951-d872f2087c98

This patch simplifies the code and removed the dependency on mount path, which was redundant after migrating to volume ids and file systems per volume.

TEST=Tested manually, mounted and unmounted a archive and a usb device.
BUG=341263

Review URL: https://codereview.chromium.org/181203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255348 0039d316-1c4b-4281-b951-d872f2087c98

Without CoreAnimation, the bookmark bar buttons got redraw
messages whenever they were damaged (like, moved around,
made visible, etc). With CoreAnimation, the bookmark bar buttons
have their drawn contents cached and therefore need to be
explicitly told to re-draw.

The function BookmarkBarController::layoutSubviews should do
this, but it only iterates through the buttons in the buttons_ array,
which skips the "apps" and "other" bookmark buttons.

This patch adds those two back in. The general question of "where
else is the apps button assumed to be part of the buttons_ array" is
not answered.

BUG=340238
NOTRY=True

Review URL: https://codereview.chromium.org/184273010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255347 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

BUG=264611

Review URL: https://codereview.chromium.org/177113012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255346 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314791

Review URL: https://codereview.chromium.org/187843005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255345 0039d316-1c4b-4281-b951-d872f2087c98

PageTestRunner.GetModernizedTestName was used to support old testnames to be specified, but it is not used anymore. The conversion map in tools/perf/run_measurement
 was already empty.

NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/183893036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255344 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347424

Review URL: https://codereview.chromium.org/185563011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255343 0039d316-1c4b-4281-b951-d872f2087c98

BUG=297480, 331301

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253821

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254432

Review URL: https://codereview.chromium.org/172263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255342 0039d316-1c4b-4281-b951-d872f2087c98

PNaCl is being upgraded to Clang 3.4, which now warns about unused
declarations inside anonymous namespaces.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3757
TEST=none
R=binji@chromium.org

Review URL: https://codereview.chromium.org/180953007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255341 0039d316-1c4b-4281-b951-d872f2087c98

Use MetadataDatabaseIndex as the separate index management class in MetadataDatabase.

BUG=344769
NOTRY=true
TEST=unit_tests --gtest_filter='DriveBackendSyncTest.*:MetadataDatabaseTest.*'

Review URL: https://codereview.chromium.org/177233005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255340 0039d316-1c4b-4281-b951-d872f2087c98

The black screen issue at starting frame was fixed a few months ago(https://codereview.chromium.org/92603002).
But it seems to work only for the initial Shell.
The last patch sets the background color to white, but this value is reset to 0 (black) by the VSyncAdapter after compositing the first frame.
So when a child Shell is newly opened, the black screen comes out again.
To fix this problem, setSurfaceViewBackgroundColor(Color.WHITE) needs to be moved to surfaceCreated() of SurfaceHolder.Callback.

Review URL: https://codereview.chromium.org/188203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255339 0039d316-1c4b-4281-b951-d872f2087c98

Turns out the DACL won't apply in most cases, and may run some
risk of bad interactions with third-party software. It's also
mostly redundant given the existing job and desktop restrictions.

BUG=346586
R=cpu
TBR=cpu

Review URL: https://codereview.chromium.org/186483005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255338 0039d316-1c4b-4281-b951-d872f2087c98

Receiving messages from GCM needed separate object with lifetime tied to
TiclInvalidationService on UI thread. This change is to replace
GCMNetworkChannelDelegateImpl with pair of objects:
GCMInvalidationBridge/Core.
Here is object diagram for this refactoring: http://www.plantuml.com:80/plantuml/png/VPBRQiCm343VynKYZuNs0xgoXsLZ17PZxPwBwwYf5sC7nqiPs_vzbfsB4sWXuDYHZexar8nNh4H8FtBOdGoo8eMV9D67J-GMqftWCbSjaw9WLcYrHTCAZYcm1gpxvc816gvhBFQrDPix8ueIR-7WrvlahoSzPiyFBIhxhhyich60Eu_v8T_Z0uBuPsGLqO5hWmuP9xyPVHGIOw-oRhpMjEG2SDoG63rrttt-6dL_rMszpfo5BqGwC14CpZF55xHdRQhin9H2UOyIIsO3eUWsZd8j9rGBxxE93uW8iFrMF1P_4er5XMQUgaAHVKUceJY8lzR5Sjat4nRGgrMO_tIiiFaTG_r0AB3VTyf46po7dYdJ4-d2j0kP_ICNso1SXmwsLF9Iz3y0

BUG=325020
R=rlarocque@chromium.org

Review URL: https://codereview.chromium.org/186623006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255337 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255336 0039d316-1c4b-4281-b951-d872f2087c98

Chromium base revision: 255230 / bc47f7e0
Old Skia revision: 13662
New Skia revision: 13678
Control CL: https://codereview.chromium.org/188343002

This CL was created by Skia's roll_deps.py script.

Bypassing commit queue trybots:
NOTRY=true
R=rmistry@chromium.org

Review URL: https://codereview.chromium.org/180743024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255335 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255334 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=168581:168617&mode=html

TBR=morrita1

Review URL: https://codereview.chromium.org/180533009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255333 0039d316-1c4b-4281-b951-d872f2087c98

It's ok to remove or add the observers after the onDestroyed is received.

NOTRY=True

Review URL: https://codereview.chromium.org/183853032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255331 0039d316-1c4b-4281-b951-d872f2087c98

Adjusts the call sequences in cc::ResourceProvider::MapImage to map image first and then call GetStride.

Current call sequences may get wrong stride for the on-going SurfaceTexture-based GpuMemoryBuffer for Android.

BUG=347890

Review URL: https://codereview.chromium.org/184233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255330 0039d316-1c4b-4281-b951-d872f2087c98

R=nduca@chromium.org
BUG=348875,347802
NOTRY=True

Review URL: https://codereview.chromium.org/188013005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255329 0039d316-1c4b-4281-b951-d872f2087c98

This CL implemented part of chrome power profiler, including the service, data provider and observer base.

BUG=337138

Review URL: https://codereview.chromium.org/187063007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255328 0039d316-1c4b-4281-b951-d872f2087c98

Export the API CreateJavaBitmap to be utilized from other places instead of
using the BitmapHelper class.

Review URL: https://codereview.chromium.org/183023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255327 0039d316-1c4b-4281-b951-d872f2087c98

Revert of HttpServerProperties - Implement MRU for AlternateProtocolMap. Persist (https://codereview.chromium.org/182383016/)

Reason for revert:
Broke compile on a bunch of bots:
Chromium Linux Builder (valgrind)
Chromium OS Builder (valgrind)
Chromium Windows Builder (DrMemory)
Linux Builder (TSan v2)

Log:
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20Builder%20%28valgrind%29/builds/73182/steps/compile/logs/stdio


Original issue's description:
> HttpServerProperties - Implement MRU for AlternateProtocolMap. Persist
> only the most recently used 200 entries. In memory keep all the entries.
> 
> BUG=258189
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255323

TBR=rch@chromium.org,rtenneti@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=258189

Review URL: https://codereview.chromium.org/188663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255326 0039d316-1c4b-4281-b951-d872f2087c98

No intended behavior change.

dex_action.gypi didn't pass its input_paths variable to dex.py,
but that was only set in a single place, and only to a single file there.
It was only used in java_apk.gypi which does manual threading of
stamp files to order actions (since it's a gypi, it can't easily use type
none targets with dependencies). Since dex.py doesn't look at this
stamp file at all, the it doesn't need to rerun when the stamp file disappears.

To make this a bit more obvious, remove dex_action.gypi's input_paths
variable and set 'inputs' directly in the one place with the stamp file.
(dex.py will still rerun if the name of the stamp file changes, due to
regular timestamp handling.)

BUG=177552
NOTRY=true

Review URL: https://codereview.chromium.org/183883024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255325 0039d316-1c4b-4281-b951-d872f2087c98

BUG=285976

Review URL: https://codereview.chromium.org/183993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255324 0039d316-1c4b-4281-b951-d872f2087c98

only the most recently used 200 entries. In memory keep all the entries.

BUG=258189

Review URL: https://codereview.chromium.org/182383016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255323 0039d316-1c4b-4281-b951-d872f2087c98

Start is deferred in relation to Stop, and when they're both called
within the Start interval, the end result was started.

BUG=347887
TEST=unit_tests --gtest_filter=ThreadWatcherList*

Review URL: https://codereview.chromium.org/183063007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255322 0039d316-1c4b-4281-b951-d872f2087c98

This resolves two problems regarding the right-click context menu for Flash fullscreen widgets.  First, the WebContentsViewDelegate implementations (for Views and Cocoa) were assuming the event target for the context menu click is always the widget provided by WebContentsView.  Flash fullscreen is actually a separate widget.  Second, the renderer was trying to be "too smart" by computing the screen coordinates of the context menu itself.  This is fixed by removing the offset calculation, which allows the coordinates to be cleanly translated by the windowing toolkit, browser-side.

BUG=348965
TEST=Repro steps in bug 348965 result in expected behavior.

Review URL: https://codereview.chromium.org/183973027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255321 0039d316-1c4b-4281-b951-d872f2087c98

BUG=345614,347822,346311

Review URL: https://codereview.chromium.org/187043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255320 0039d316-1c4b-4281-b951-d872f2087c98

this one file was lifted from https://codereview.chromium.org/184743002/ and then modified to erase the bitmap when it is not marked as opaque. This restores the previous behavior when we were explicitly creating SkBitmapDevice.

NOTRY=True

Review URL: https://codereview.chromium.org/187893004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255319 0039d316-1c4b-4281-b951-d872f2087c98

We're moving towards 'benchmark' being only for traces that
are actually read by benchmarks, rather that part of
benchmarks. This changes several to 'input'. One is read by a
benchmark, so that is now 'input,benchmark'.

BUG=344765

Review URL: https://codereview.chromium.org/180723007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255318 0039d316-1c4b-4281-b951-d872f2087c98

LogoutButtonTray uses and owns LogoutConfirmationDialogView, a dialog that
asks the user to confirm or deny logout. This CL generalizes the dialog
and moves its ownership to a LogoutConfirmationController accessible via
ash::Shell, allowing other classes to show the same dialog.

BUG=278247
TEST=Updated unit tests

Review URL: https://codereview.chromium.org/178183005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255316 0039d316-1c4b-4281-b951-d872f2087c98

switch and field trial.

BUG=346708

Review URL: https://codereview.chromium.org/183923021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255315 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343921

Review URL: https://codereview.chromium.org/178803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255314 0039d316-1c4b-4281-b951-d872f2087c98

> Add VP9 encode support to the remoting host.
> 
> BUG=260879,349862 
> 
> Review URL: https://codereview.chromium.org/28183002

TBR=wez@chromium.org

Review URL: https://codereview.chromium.org/188563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255313 0039d316-1c4b-4281-b951-d872f2087c98

> Move TranslateManager unit tests out of the browser_tests target.
> 
> These are unit tests so they should be in the unit_tests target. A
> TODO says this did not work before, but they appear to pass as unit
> tests now, so this is just a code move.
> 
> R=sky
> BUG=270918
> 
> Review URL: https://codereview.chromium.org/186063007

TBR=danakj@chromium.org

Test is failing on Linux memory bot. If this is passing on main waterfall, it may be due to sharding
and this test may have some global state that previous test didn't cleanup

TranslateManagerRenderViewHostTest.FetchLanguagesFromTranslateServer: 
Xlib:  extension "RANDR" missing on display ":9".
../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:319: Failure
Value of: fetcher != NULL
Actual: false
Expected: true
../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:319: Failure
Value of: fetcher != NULL
Actual: false
Expected: true
../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:662: Failure
Value of: current_supported_languages.size()
Actual: 54
Expected: server_languages.size() - 1
Which is: 7
../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:671: Failure
Expected: (current_supported_languages.end()) != (std::find(current_supported_languages.begin(), current_supported_languages.end(), lang)), actual: 8-byte object <A0-1F 23-17 00-00 00-00> vs 8-byte object <A0-1F 23-17 00-00 00-00>
../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:675: Failure
Value of: is_alpha
Actual: true
Expected: TranslateDownloadManager::IsAlphaLanguage(lang)
Which is: false
../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:671: Failure
Expected: (current_supported_languages.end()) != (std::find(current_supported_languages.begin(), current_supported_languages.end(), lang)), actual: 8-byte object <A0-1F 23-17 00-00 00-00> vs 8-byte object <A0-1F 23-17 00-00 00-00>
../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:671: Failure
Expected: (current_supported_languages.end()) != (std::find(current_supported_languages.begin(), current_supported_languages.end(), lang)), actual: 8-byte object <A0-1F 23-17 00-00 00-00> vs 8-byte object <A0-1F 23-17 00-00 00-00>
../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:671: Failure
Expected: (current_supported_languages.end()) != (std::find(current_supported_languages.begin(), current_supported_languages.end(), lang)), actual: 8-byte object <A0-1F 23-17 00-00 00-00> vs 8-byte object <A0-1F 23-17 00-00 00-00>
../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:671: Failure
Expected: (current_supported_languages.end()) != (std::find(current_supported_languages.begin(), current_supported_languages.end(), lang)), actual: 8-byte object <A0-1F 23-17 00-00 00-00> vs 8-byte object <A0-1F 23-17 00-00 00-00>
../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:675: Failure
Value of: is_alpha
Actual: true
Expected: TranslateDownloadManager::IsAlphaLanguage(lang)
Which is: false
../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:671: Failure
Expected: (current_supported_languages.end()) != (std::find(current_supported_languages.begin(), current_supported_languages.end(), lang)), actual: 8-byte object <A0-1F 23-17 00-00 00-00> vs 8-byte object <A0-1F 23-17 00-00 00-00>

Review URL: https://codereview.chromium.org/188553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255312 0039d316-1c4b-4281-b951-d872f2087c98

Linux is unaffected. All changed code already is inside sandbox.

BUG=348692

Review URL: https://codereview.chromium.org/185293014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255311 0039d316-1c4b-4281-b951-d872f2087c98

Paint views::Textfield drag images with views::Labels.
Makes the drag image fit the size of the selected text.
(not as wide as the origin Omnibox/textfield itself)
Use an offset for the image similar to the Unity desktop.

This changes the appearance of split-selection BiDi text.
(doesn't show blank area between the visually split text)
See before/after pictures at http://crbug.com/349105

Remove now unused RenderText::DrawSelectedTextForDrag.

BUG=349105
TEST=Linux Aura and ChromeOS text drag images look good.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/177683005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255310 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349589

Review URL: https://codereview.chromium.org/188023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255309 0039d316-1c4b-4281-b951-d872f2087c98

R=tedchoc@chromium.org

Review URL: https://codereview.chromium.org/185223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255308 0039d316-1c4b-4281-b951-d872f2087c98