- 09 Jan, 2020 40 commits
-
-
Hiroki Nakagawa authored
This test consistently results in Timeout/Pass on Win/Mac/Linux bots. Bug: 1040270 Change-Id: I0759ee1f83b002465fcd6c19aaeef7e25ea8ecda Tbr: nhiroki@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990890Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#729614}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fbc5981eaf58..72cd27a20441 Created with: gclient setdep -r src-internal@72cd27a20441 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:790886 Tbr: jbudorick@google.com Change-Id: I345cc86dc35551759c1e917cab338959421fdd66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992737Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729613}
-
rbpotter authored
isOSSettings is now always true for this page, so remove logic handling the case where it is false. Bug: 986596 Change-Id: I0845f716db9d9617c505eb7a41e668abbd416895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992357Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#729612}
-
Maggie Chen authored
Based on the histogram GPU.WatchdogThread.WaitTime on Linux Dev, increasing Linux GPU watchdog timeout from 10 seconds to 15 seconds will reduce ~48% of the crashes caused by the GPU watchdog kill. Record GpuWatchdogTimeoutEvent::kContinueOnNonHostServerTty histogram only for the time there is a change to a non-host X11 server TTY Bug: 949839 Change-Id: If59c2f952168ff9f1f332a6531fb30e70a937ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987279Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#729611}
-
Gabriel Marin authored
BUG=b:147388116 Change-Id: I561f29c477f5b1c048574bd2de7adf6166f969cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992018Reviewed-by:
George Burgess <gbiv@chromium.org> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#729610}
-
James Forshaw authored
This CL removes the NOTREACHED check from the function as it doesn't provide any value and just causes unexpected crashes in the browser process during debug builds. Bug: 1029073 Change-Id: I14de816b9fd4415238fa4244316baa4c06fcdc15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992167Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#729609}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9b2712456fe6..c3609d224afd git log 9b2712456fe6..c3609d224afd --date=short --first-parent --format='%ad %ae %s' 2020-01-08 enga@chromium.org Reland "Use Swiftshader by default when fuzzing" Created with: gclient setdep -r src/third_party/dawn@c3609d224afd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I50253c9d0afebf09b2116515caac774bfe0736a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992727Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729608}
-
Demetrios Papadopoulos authored
Incorrect: <if expr="not is_chromeos"> Correct: <if expr="not chromeos"> Unfortunately such typos don't produce a build time error since grit considers undefined variables as False. Bug: None Change-Id: I7152c95b2f2ed2c57173eaca3f63657f1af39cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992808 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#729607}
-
Ryan Sturm authored
This was causing some test crashes when turning on the feature. We should merge it back if possible. Also, treat occluded visibility state as hidden. Bug: 1040306 Change-Id: I407bf00d43e7e0df5f5bd00b00764aebb285391b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992806 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#729606}
-
Chris Cunningham authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/252792a1ff65..bcc5d9fec0a3 $ git log 252792a1f..bcc5d9fec --date=short --no-merges --format='%ad %ae %s' 2020-01-08 chcunningham RELAND: lavf/isom: support for demuxing and remuxing of MPEG-H 3D Audio in MP4 2020-01-09 chcunningham Revert "lavf/isom: support for demuxing and remuxing of MPEG-H 3D Audio in MP4" 2020-01-06 chcunningham lavf/isom: support for demuxing and remuxing of MPEG-H 3D Audio in MP4 2020-01-06 chcunningham lavc: add MPEG-H 3D Audio codec id 2020-01-06 chcunningham lavc/codec_desc: introduce AV_CODEC_PROP_INTRA_ONLY flag to audio codec Created with: roll-dep src/third_party/ffmpeg R=tguilbert@chromium.org Bug: 1039444d Change-Id: I8a98c50734298d30c949579c407215e27869274d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992013 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#729605}
-
Antonio Gomes authored
... and use the corresponding WTF::CrossThreadBind constructions. BUG=787254 R=haraken@chromium.org Change-Id: I7d4cc231cf19adeb9d21b7e47e934ed4857e8bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991407 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#729604}
-
Kurt Horimoto authored
The value is set when an OverlayRequest is added to a queue. This allows the WebState to be accessed from request callbacks. Will be used when one request's completion callback needs to enqueue an additional request with a different ConfigType into the WebState's queue. Bug: 1030357 Change-Id: I08fee42f2da58f8451d83d5f0e417374a5b1c5ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989912 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#729603}
-
Jared Saul authored
Change-Id: I60c326d0e44376a13ff1ebceaaf53e3de415bdc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991499 Auto-Submit: Jared Saul <jsaul@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#729602}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bd26a09fd13c..52175631d301 git log bd26a09fd13c..52175631d301 --date=short --first-parent --format='%ad %ae %s' 2020-01-08 rmhasan@google.com Revert "[Typ] Allow typ expectations parser to escape the '*' character" Created with: gclient setdep -r src/third_party/catapult@52175631d301 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1036130,chromium:1038130 Tbr: oysteine@google.com Change-Id: Iaa236420306a8726e0a25b9aca2f0ad3d8264a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992736Reviewed-by:
-
jonross authored
It is not desired to have --fuzzy-diff be the default for blink_web_tests on Linux. This had originally been done as a part of SkiaRenderer's development. This change: - removes --fuzzy-diff as the default. - updates the Linux port to disable SkiaRenderer - changes non_skia_renderer_swiftshader_blink_web_tests to be skia_renderer_swiftshader_blink_web_tests with SkiaRenderer reenabled and fuzzy-diff re-added for just this configuration. - Updates TestExpectations for current failures. The update to TestExpectations is temporary, it will allow us to land the non-fuzzy tests. We will be triaging the failures, and landing rebaselines as needed separately. Or filing more specific bugs for the failures. non_skia_renderer_swiftshader_blink_web_tests was used to keep an eye on regressions for the non-SkiaRenderer case while SkiaRenderer rolled out. We will return it to that once we can re-enable SkiaRenderer by default for blink_web_tests. We will be following this up by triaging all failures that occur with SkiaRenderer on and fuzzy-diff off. Then rebaselining/addressing bugs as needed. TEST= blink_web_tests skia_renderer_swiftshader_blink_web_tests Bug: 1039401 Change-Id: Ia4f88e41e6288947135eb6f19a0290f1a0d090a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989866 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#729600}
-
Sergey Ulanov authored
Cleared flag was not set when importing GpuMemoryBuffer to a SharedImageBacking. As result SharedImageRepresentationSkia::BeginScopedReadAccess() was returning nullptr when trying to render video frames on Fuchsia, as result video content wasn't rendered properly. Fixed ExternalVkImageBacking::CreateFromGMB() to call SetCleared(), since imported GMBs are supposed to have the content initialised when they are imported. Bug: 1040250 Change-Id: I324e902418956e631e4da6ad7f723992b2074f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992595 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#729599}
-
yilkal authored
This cl does the following: 1. Adds PrefChangeRegistrar to AppTimeController to enable it to be notified when user policy has changed. 2. Enables prefs::kPerAppTimeLimitsWhitelistPolicy policy to be used in WebtimeLimitEnforcer. Bug: 1015661 Change-Id: Ifd5e0ddc3df9f564ffb018244e652c8b88586865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946936 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#729598}
-
Brandon Jones authored
Test was producing a minor image diff, has been triaged. Bug: 1040202 Change-Id: Iae6dd08ea4b97d7f4975971b8abbb948d97867d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992564Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#729597}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/99c274baf503..c431d59626e1 git log 99c274baf503..c431d59626e1 --date=short --first-parent --format='%ad %ae %s' 2020-01-08 jmadill@chromium.org Add Serial to all GL resources. Created with: gclient setdep -r src/third_party/angle@c431d59626e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: Ib329ead2b78c6f15d93ae16939165eb60049a1ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991837Reviewed-by:
-
Brandon Wylie authored
I verified this is no longer flaking with 500 local runs, I'll continue to monitor in the coming days. TBR=tedchoc@chromium.org Bug: 1020381 Change-Id: I170649506ae0d958ee5e7921b4e11c5d90a548da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992364Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#729595}
-
Weilun Shi authored
Support class type in json_to_struct and use C++ class base::Optional<bool> for is_low_end_device instead of OptionalBool. Bug: 987717 Change-Id: Ica6b475af788bbe9842c8630ef96e2ad6ad7f80c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973491Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#729594}
-
Antonio Gomes authored
... now that it resides out of the Blink API layer. BUG=704136 R=haraken@chromium.org Change-Id: Ibfc613dea5f304c9c29cd96a2465e71cfbe7a7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991404 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Dan Beam authored
R=rbpotter@chromium.org Bug: none Change-Id: I7b149467709f5bb8d80bbc1c933da97675c8799e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992593Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8a7067d88174..77c89ff847b6 git log 8a7067d88174..77c89ff847b6 --date=short --first-parent --format='%ad %ae %s' 2020-01-08 bclayton@google.com Build: Verify that we're compiling with C++14. 2020-01-08 bclayton@google.com Build: Move from using C++11 to C++14. 2020-01-08 bclayton@google.com Kokoro: Update from GCC 4.8 to GCC 7. Created with: gclient setdep -r src/third_party/swiftshader@77c89ff847b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I44c6a9a3bf6e334124c9fb7716b746c23eef1288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992720Reviewed-by:
-
Ahmed Mehfooz authored
This change ensures that the tray remains expanded or collapsed when opened after being previously expanded or collapsed by the user. Change-Id: I66f5547e36f7f245f75eabfa74fb63e021bbe20f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992168 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#729590}
-
Arthur Wang authored
Bug: 1021309 R=harringtond@chromium.org Change-Id: I785b5adb86041f554e13966377e35532aead0d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992681 Commit-Queue: Arthur Wang <wuwang@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#729589}
-
yilkal authored
This cl adds kPerAppTimeLimitWhitelist child user policy. The policy specifies the always allowed URLs and applications that will not get blocked. The whitelist policy overrides settings configured by PerAppTimeLimit. Support for whitelisting URLs, for example, is required because there are certain crucial access requests to URLs that should not be blocked even though the PerAppTimeLimit policy's set time limit on chrome has been reached. Examples of these URLs are chrome://*, file://* and support.google.com. Bug: 1022093 Change-Id: Ic625ca5e301bd742925bc88af06395a05b39337c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929086 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
-
rbpotter authored
Bug: 967861 Change-Id: I9fca173ca4b364066ed669ba5fc888114e96d640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992683Reviewed-by:
-
Nicolas Zea authored
zea@ is leaving Chrome, removing from OWNERS files Change-Id: I4df1ad4b3545cca91489ab7f26f1c0edf0b99bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986245 Commit-Queue: Nicolas Zea <zea@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#729586}
-
Oksana Zhuravlova authored
This change adds traces under BrowserMainLoop::CreateThreads:PreMainMessageLoopRun(). Bug: 1019793 Change-Id: I89577b30b797af78e19cf6afc0079a264fc1df97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986906Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#729585}
-
Antonio Gomes authored
... down to renderer/platform/mediastream, and also rename it to webaudio_destination_consumer.h. BUG=919392, 704136 R=haraken@chromium.org Change-Id: I1592af19495c729ab7911036c1a6858e610822f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991403Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I08583b374f6ac6fc688730cba2ab91ee4688cf3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992724Reviewed-by:
-
Fabrice de Gans-Riberi authored
This reverts commit 71a290c2. Reason for revert: Suspected cause of failures in WizardController* tests on chromeos: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/1413 https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/16312 https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/33460 Original change's description: > Reland "Squash top level error code returned from host resolver." > > This is a reland of 834f2092 > > Original change's description: > > Squash top level error code returned from host resolver. > > > > If the host resolution process fails, the top level error code should > > now be only ERR_NAME_NOT_RESOLVED. A more specific error code (e.g. > > ERR_CONNECTION_REFUSED if a secure mode DoH server was offline) may be > > found in ResolveErrorInfo. > > > > Bug: 1016325 > > Change-Id: I9f5f857fffd71be6485d05280239cd0b649d7a8f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974678 > > Commit-Queue: Katharine Daly <dalyk@google.com> > > Reviewed-by: Matt Menke <mmenke@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Eric Orth <ericorth@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#728725} > > Bug: 1016325, 1039639 > Change-Id: Ifcf5d1c8d3e5558e81b9efc784d234d034ee9a52 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990249 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Katharine Daly <dalyk@google.com> > Cr-Commit-Position: refs/heads/master@{#729518} TBR=jam@chromium.org,mmenke@chromium.org,ericorth@chromium.org,dalyk@google.com Change-Id: If09e8178659f5d47503ccee5cb8919d099b2330a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1016325, 1039639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992812Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#729582}
-
Matt Reynolds authored
A single physical device may expose multiple HID interfaces. Each interface is represented by a HidDeviceInfo object. To allow HidDeviceInfo objects to be grouped by physical device, a |physical_device_id| member is added that will be used to identify the physical device. This CL adds the new member and updates callsites to provide a value for the physical device ID when constructing a HidDeviceInfo. The platform logic to construct the ID will be added in a followup CL. BUG=1011499 Change-Id: I0f821de0693d625a5279f057b9986dc71923ccda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987113 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#729581}
-
Sam Fortiner authored
We plan to start experimenting with preferring compositing over LCDText in the next couple weeks (tracked via https://crbug.com/984346). This histogram will help provide insight into the impact on text quality and needs extended to cover the experimentation timeframe. Bug: 1036860 Change-Id: I8612404f727604b0f94211c1bbfa5233c2d9acf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990259Reviewed-by:
-
Alex Cooper authored
vr_pixeltests were failing on Windows 7, so they were disabled for all windows platforms, though the evidence is that they were fine on other platforms. Given that VR is not supported on Win7, only disable these tests on that platform. Fixed: 1035767 Change-Id: Ic97593f9b324c30111ec1465ae3da41de7aa2c78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985126Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#729579}
-
Gang Wu authored
https://cs.chromium.org/chromium/src/skia/ext/image_operations.cc?g=0&l=408 The first parameter should be the source of image, not the destination. Bug: 1039791 Change-Id: Ib0fc4cc2b3a15143b4ceb3de7ca558e0d279e3ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990206 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#729578}
-
Kent Tamura authored
If a radio button is connected or owned by a form, radio button groups are managed by RadioButtonGroupScope in order to complete various operations for a group in O(1). Otherwise, we did not assume a radio button belonged to any groups. It didn't conform to the HTML standard, and was not interoperable with Firefox. After this CL, such radio buttons are grouped without RadioButtonGroupScope's help. We iterate over the tree including the target radio buttons to find a checked button in the group or |required| attribute in the group. Bug: 883723 Change-Id: I56185559592dff6b0254655aeb499ed6ac29df64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988087 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Ross Zwisler authored
We will need this flag until we have completed the uprev of SKL-Y and SKL-U Chrome OS systems to their new kernels. It's unclear exactly when this will be done, but my best guess right now is around M87. Also, remove Jon from the flag contacts as he's moved on to other adventures. BUG=b:144308685 Change-Id: I7675b7542b8f73a82f958bb50dfc9bd64a91486a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991723Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: Ross Zwisler <zwisler@google.com> Auto-Submit: Ross Zwisler <zwisler@google.com> Cr-Commit-Position: refs/heads/master@{#729576}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I8082fccac2a20d00e916f9e6d2abeb88de8e1ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991983Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#729575}
-
