- 11 Dec, 2017 40 commits
-
-
Peiyong Lin authored
It's very important to understand how much IPC volume GRC needs to handle. This patch adds an IPCVolumeReporter to report IPC count for frame, page and process every minute. The histogram uses a maximum count of 100 with 10 buckets. BUG=776118, 790680 Change-Id: Id11ffa4480f7d066f140cf6daba1dedc744e311e Reviewed-on: https://chromium-review.googlesource.com/815280Reviewed-by:
Zhen Wang <zhenw@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: lpy <lpy@chromium.org> Cr-Commit-Position: refs/heads/master@{#523249}
-
Ned Nguyen authored
Bug:793609 NOTRY=true TBR=dpranke@chromium.org Change-Id: I770559876a6dd6b7de0a3575e02a1b854858a414 Reviewed-on: https://chromium-review.googlesource.com/820939Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#523248}
-
Erik Luo authored
Console will remember - User text typed in the input filter - Whether the sidebar was open, consistent with Sources and the drawer - Which top level sidebar filter was selected Bug: 787620, 734088 Change-Id: Iab109fbf1f459b0c64974c7414dcf3fd24739f11 Reviewed-on: https://chromium-review.googlesource.com/810090 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523247}
-
Xiaohan Wang authored
Today we always write and read from the DataPipe asynchronously. This might introduce unnecessary latency since the DataPipe might already be readable/writable when we schedule the read/write. This also indirectly contributes to out-of-order dispatch of Decode() and Reset() calls in some MojoDecoderBufferConverter clients, e.g. MojoAudioDecoderService, MojoVideoDecoderService, MojoDecryptorService. See BUG for more details. Unit tests are added to cover this issue. Note that this CL does not completely fix the BUG. A follow up CL will come next, with more tests added. BUG=792281 TEST=More tests added. Change-Id: Ia6dc25f8621cca2a041b6299b104de2074c06a02 Reviewed-on: https://chromium-review.googlesource.com/818329 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#523246}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9e68ea0b. With Chromium commits locally applied on WPT: d857d94a "Handle display:contents while creating counter nodes." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/7457 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I2c7430b2fc8ddeeab76dac9f922f70cacccff341 Reviewed-on: https://chromium-review.googlesource.com/820193 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523245}
-
Ryan Landay authored
Gboard's voice input feature repeatedly calls InputConnection#setComposingText() with the in-progress text composition. If you say "new paragraph", it inserts a pair of newlines into the text. We currently don't handle this case properly because InputMethodController::SetComposition() calls TypingCommand::InsertText() (through InsertTextDuringCompositionWithEvents()) with the TypingCommand::kSelectInsertedText flag (which causes InsertText() to leave the newly-inserted text selected). InsertText() doesn't actually implement this behavior properly if the text being composed has a newline in it. It processes the text in multiple "runs," inserting line breaks in between. Currently, it inserts the first run, leaving it selected, then inserts a line break, replacing the first run of text (and then proceeds similarly for subsequent runs of text). There's currently a (quite old) FIXME in the code to fix this behavior. I'm taking a slightly different approach from the one suggested there, and selecting the inserted text all at once in TypingCommand::InsertText() instead of trying to modify InsertTextCommand and InsertParagraphSeparatorCommand so they can extend the current selection. I was inspired by the implementation of AdjustSelectionAfterIncrementalInsertion() to use a plain text offset from the start of the editable region to determine the start of the final selection. This approach is robust to whitespace normalization (this was a problem I ran into trying to use a DOM range). Note that with this fix, we no longer need the fix in https://chromium-review.googlesource.com/c/chromium/src/+/783770 to change the ending selection in InputMethodController::SetComposition(), as we're no longer setting the problematic ending selection in TypingCommand::InsertText(). Bug: 784039 Change-Id: I4b0bb95d1ecf8a979f15b3494f57a0b23e6e2459 Reviewed-on: https://chromium-review.googlesource.com/801979Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#523244}
-
Scott Graham authored
Bug: 793956 Change-Id: I8c1fe8a4e77b754a03e0d257f944c0ce5037fb72 Reviewed-on: https://chromium-review.googlesource.com/820853 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#523243}
-
Chris Cunningham authored
The VideoSampleEntry box includes a scoped_refptr<BitstreamConverter> regardless always, but we were only building the BitstreamConverter cc/h files when proprietary_codecs=true. This CL includes the BitstreamConverter interface defintion in all builds. Proprietary bitsream conversion logic (e.g. AVCBitstreamConvter) is still only included if proprietary_codecs = true. BUG: 793702 Change-Id: I8720b6547ca2e0af47d64ae594e86850da0e84b5 Reviewed-on: https://chromium-review.googlesource.com/819978 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#523242}
-
Koji Ishii authored
The CL[1] disabled skipping inks for characters of IsCJKIdeographOrSymbol(). This does not cover all characters in CJK. This patch adds other CJK characters from Unicode blocks, in the same way as WebKit does. [1] https://codereview.chromium.org/2598393002 Bug: 793762 Change-Id: I20e10588adc988399c900b336d0c22ad984bb011 Reviewed-on: https://chromium-review.googlesource.com/820210 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#523241}
-
Charles Harrison authored
The upper %iles of SB2.Delay can be high (especially on Android). This is most concerning for main frame resources, since it is in the critical path of PLT. Bug: None Change-Id: Ia7df3082d5d34bc04e6696f900084e2e8c31acab Reviewed-on: https://chromium-review.googlesource.com/803951Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#523240}
-
Marti Wong authored
1. Prevent the folder icons from showing on a bookmark cells when loading favicons. 2. When creating new folder, add the new table cell to the tableView manually using insertRowsAtIndexPaths (so to skip reloadData) to shorten the icon blinking time. (before this change, it could take ~0.1s to load favicons after reloadData because icon loading, table scrolling and keyboard appearing all happen at the same time after tapping on 'New Folder'.) Bug: 792409 Change-Id: I6675dc4ea332ac2c095d5da4abec8c63e55de1c3 Reviewed-on: https://chromium-review.googlesource.com/817454Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Marti Wong <martiw@chromium.org> Cr-Commit-Position: refs/heads/master@{#523239}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia2d24601f998d384deb9bd0474ee00f19570cfac Reviewed-on: https://chromium-review.googlesource.com/820716Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#523238}
-
Tom Anderson authored
The tests are flaky when run in random order. Example failures: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65460 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65456 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65449 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65433 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65431 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65424 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65404 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65373 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65279 BUG=664858 TBR=qyearsley@chromium.org Change-Id: I9871947f69860d308c4b2765f9e23dabbae3c3d4 Reviewed-on: https://chromium-review.googlesource.com/820100 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#523237}
-
Reilly Grant authored
This new tests fails with the Network Service enabled just as other PDFExtensionTests do. Lumping this in with issue 705114. Bug: 705114 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I6da8f21354e7f809e8b86a3f57b3f6723e57e386 Tbr: jam@chromium.org No-Try: true No-Tree-Checks: true No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/820810Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#523236}
-
Yuzhu Shen authored
Bug: 793480 Change-Id: I02c9ae70759be31af025e5787a5683cd76bffc57 Reviewed-on: https://chromium-review.googlesource.com/818452Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#523235}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/bc4dbea81177..92c8b1a07b01 $ git log bc4dbea81..92c8b1a07 --date=short --no-merges --format='%ad %ae %s' 2017-12-11 thestig Initialize FDE_TEXTEDITPIECE. 2017-12-11 thestig Get rid of default ctors for CPDF_Action and CPDF_AAction. 2017-12-11 thestig Clarify some function names in CPDF_NameTree. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2e5b2499388ec4f71f8cdf2dd8df713a6fe7186f Reviewed-on: https://chromium-review.googlesource.com/820099 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523234}
-
Mitsuru Oshima authored
Separated window state change methods into ShellSurface and ClientControlledShellSurface Bug: 809488 Change-Id: Ifec29e7a7ce2df0dd3b3c4a606479682d9f60dc2 Reviewed-on: https://chromium-review.googlesource.com/814835 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523233}
-
Eugene But authored
This method will be user for reporting Download.IOSDownloadPassKitResult UMA metric. Bug: 789735 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic39d5ea1869dfb4e7f45e0ffa2902829a2e09a6d Reviewed-on: https://chromium-review.googlesource.com/817950 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#523232}
-
Brandon Jones authored
Bug: 670510 Change-Id: I4f135d13ac44ac6214b74eb03eb7734d6786a737 Reviewed-on: https://chromium-review.googlesource.com/817976Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#523231}
-
Tim Brown authored
For supported distros, group the versions together so that we can more easily see them together (include some spare ID range for each distro too). Also add in a couple of future versions so that we don't have to keep on updating the metrics. Downside is that the old histogram values are deprecated and will take a while to settle on the new values as newer versions roll out. Bug: 724244 Change-Id: I74f1c704529856ccb946178f035e8baed5212ecc Reviewed-on: https://chromium-review.googlesource.com/818203 Commit-Queue: Tim Brown <timbrown@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#523230}
-
Edward Jung authored
on iOS Bug: 792872 Change-Id: Ic0b840843a75d35fc0447300f9882a156d434d5b Reviewed-on: https://chromium-review.googlesource.com/819691Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#523229}
-
Morten Stenshorne authored
This test was expected to clip overflow, but the current version of the spec says that column boxes should not clip overflow [1]. This contradicts older versions of the spec, where we were supposed to clip at column gaps. But even with such an old version of the spec, the final "c" letter would not get clipped, because there's no adjacent column gap there, since it's in the last column. So just wrap everything inside the multicol container inside an overflow:hidden DIV. [1] https://www.w3.org/TR/css-multicol-1/#overflow-inside-multicol-elements Bug: 788337 Change-Id: I9b7382bf40a0c2aeb0fb2c6b9b309e9c334c534f Reviewed-on: https://chromium-review.googlesource.com/817994Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#523228}
-
Jared Saul authored
Bug: Change-Id: Id0d9ed21f5a602e39d00e642971f18a305ad245f Reviewed-on: https://chromium-review.googlesource.com/818387 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#523227}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/c2efefbc3625..cb82b102c366 $ git log c2efefbc3..cb82b102c --date=short --no-merges --format='%ad %ae %s' 2017-12-11 simonhatch Dashboard - Add traceback to exceptions in /add_histograms Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Icda153fcbe465a3ac0b377cf20ee22266948db0f Reviewed-on: https://chromium-review.googlesource.com/820108 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523226}
-
Steven Bennetts authored
Bug: 793431 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I83a7333fba300174f17814daa4606bbc66f2a2ff Reviewed-on: https://chromium-review.googlesource.com/820355Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#523225}
-
rbpotter authored
https://crrev.com/c/804178 added one too many DCHECKs, and it fails on Windows. Bug: 793850 Change-Id: I1e61cd3253dce2dadb84f40b4c873ac2978219e7 Reviewed-on: https://chromium-review.googlesource.com/818494 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#523224}
-
Henrique Nakashima authored
The "left" param was ignored because it was applied before the zoom, and the page still fit in the window at 1x zoom. Scrolling on x was non-op at this zoom level. Bug: 319910,64309 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7b476c018f9972f2b1e0075e933e6489f12e6974 Reviewed-on: https://chromium-review.googlesource.com/817690 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#523223}
-
Wez authored
Stripping binaries entirely before shipping them to swarming clients to be run prevents us from symbolizing stack traces. Since the effect on binary & bootfs size is not all that great for Release, nor for Debug component builds, disable stripping entirely for now. Bug: 792521 Change-Id: Ie9031e26dcd9f77ee17e5bb3648f0ad13839f61f Reviewed-on: https://chromium-review.googlesource.com/818505Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#523222}
-
Daniel Bratell authored
There is two identical methods named PP_HardwareAccelerationCompatible and I'm not sure what is a good place to deduplicate them so this patch only renames them to unblock jumbo work in content/renderer. The methods with the same name clashes in jumbo builds where many cc files are compiled in the same translation unit. Bug: 746953 Change-Id: I12361f3226bdc7a3c6113201183ec26b263917f4 Reviewed-on: https://chromium-review.googlesource.com/819950Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#523221}
-
David Reveman authored
The image that will be discarded can be either a photo or a video. Bug: 793741 Change-Id: Ie26ebc793b945730142e93cfb0bd02aa20dabfd9 Reviewed-on: https://chromium-review.googlesource.com/820414Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523220}
-
Alexander Pisarev authored
There is a special case in line clamp logic when a line has enough free space at the end. In this situation, a line has no truncation but still has an ellipsis. But all other logic didn't count on it. This false assumption of truncation for ellipsis was removed from the code. And fix braces in if's for 2+ lines bodies to be able to commit it. Bug: 788141 Change-Id: I06893d47533031f79c610bd6f5258f7359f541f5 Reviewed-on: https://chromium-review.googlesource.com/787590Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#523219}
-
Carlos IL authored
If a seed fetch over HTTP fails, Variations Service will now retry the fetch over HTTP, encrypting the If-none-match header, and not including the restrict parameter. Bug: 769154 Change-Id: Ief7fd92a691110719cda5396b3bfd9c4cd402fde Reviewed-on: https://chromium-review.googlesource.com/777723 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#523218}
-
Chris Hamilton authored
CF_HTML formatted strings aren't always null-terminated, so the explicitly provided size should be used. BUG=790697 Change-Id: Ieaef24625f42aaa9b6c452b3484fe99354e821e3 Reviewed-on: https://chromium-review.googlesource.com/803798 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#523217}
-
Eric Karl authored
This lets it be used outside of ScopedImageFlags. OOP raster will use this more generally during serialization. Bug: 777628 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ie1bd3dda646d6094601050263560578d4a96b09f Reviewed-on: https://chromium-review.googlesource.com/815897Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#523216}
-
Dave Schuyler authored
This CL replaces the slower i18n() code with $i18nPolymer replacements and reduces usage if I18nBehavior. Bug: 677338 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I324e5d148e71cd4abc0cfa028d5b48fbc1cefaf2 Reviewed-on: https://chromium-review.googlesource.com/812571Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#523215}
-
Dianna Hu authored
A *temporary* server-side change landed and was effectively reverted, but the code it touched in the interim had previously diverged from Chromium. This minor change reduces such divergence. This CL lands server change 177456734 by sbenza. BUG=488484 Change-Id: I871a2db6313dd9901785c2e8b02d20b2332e5746 Reviewed-on: https://chromium-review.googlesource.com/818745 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#523214}
-
Daniel Bratell authored
In jumbo builds, the three different ReleaseOriginalFrame methods in content/renderer/media ended up in the same translation unit and then Bind() didn't know which one to use Bug: 746953 Change-Id: I584df28230d29bbc80d9d6cd2884300b7a3d9409 Reviewed-on: https://chromium-review.googlesource.com/819611Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#523213}
-
Dave Tapuska authored
We didn't support setting keyCode/charCode from the KeyboardEventInit which other vendors did. Approved intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/wEm8WWPpxU4/S4sLZgQNBgAJ BUG=679439 Change-Id: I2f817fa71ec09f80650ec458edfffe6ab328eb02 Reviewed-on: https://chromium-review.googlesource.com/793989 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#523212}
-
Jiaquan He authored
Bug: 785523 Change-Id: If05a0ec3164e402c9f475280ef6e6851eeb70d07 Reviewed-on: https://chromium-review.googlesource.com/798156Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#523211}
-
Isha Bobra authored
For the elements where a click listener is present in its ancestry chain, a default action verb "click-ancestor" is used. So for android this CL makes sure that such elements are not marked as clickable. Bug: 645167 Change-Id: I0ce047e8bf619bb6eaa3c77bc4bec4d2d999e203 Reviewed-on: https://chromium-review.googlesource.com/804202 Commit-Queue: Isha Bobra <ibobra@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#523210}
-