GitLab

It was possible to show it in media query listener.

BUG=714849

Review-Url: https://codereview.chromium.org/2845273002
Cr-Commit-Position: refs/heads/master@{#467941}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2838213002
Cr-Commit-Position: refs/heads/master@{#467940}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f20a4f79..63f6c513

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2846173003
Cr-Commit-Position: refs/heads/master@{#467939}

BUG=none

Review-Url: https://codereview.chromium.org/2844383003
Cr-Commit-Position: refs/heads/master@{#467938}

BUG=

Review-Url: https://codereview.chromium.org/2849493002
Cr-Commit-Position: refs/heads/master@{#467937}

Validating a qualified name should only throw InvalidCharacterError, not NamespaceError,
after:
 https://github.com/whatwg/dom/issues/319
 https://github.com/w3c/web-platform-tests/issues/5161
 https://github.com/whatwg/dom/issues/423

Latest spec:
 https://dom.spec.whatwg.org/#validate

Webkit Patch:
 http://trac.webkit.org/changeset/215701/webkit

BUG=702077

Review-Url: https://codereview.chromium.org/2841393003
Cr-Commit-Position: refs/heads/master@{#467936}

Adds the IPH that points to the data saver preview infobar.  This
includes three main changes:
- Adding support for determining which kind of infobar is showing in
Java.
- Hooking up the info bar show code to log an event saying it was shown.
- Hooking up the info bar show code to a function which can pick (if
any) a feature and string to show which will point to that infobar.

BUG=710648

Review-Url: https://codereview.chromium.org/2815653003
Cr-Commit-Position: refs/heads/master@{#467935}

Before this CL we used V8PrivateProperty to avoid
cyclic references between V8 and Blink. Now we have
trace wrapper and DOM object can have a reference to
V8 objects. Use trace wrapper for CustomEvent

BUG=501866,700680

Change-Id: I9089d9cf0828bb979467cc5bd859e460847b6c28
Reviewed-on: https://chromium-review.googlesource.com/484162
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467934}

BUG=None

Review-Url: https://codereview.chromium.org/2850453002
Cr-Commit-Position: refs/heads/master@{#467933}

There is callback map in extension function dispatcher, which store
pointers on callback wrappers. But it force to remember to delete
wrapper after erase from map. This may lead to memory leak.
To prevent it, raw pointer in map was replaced by unique_ptr (like in
other callback map in same class).

BUG=None
R=finnur

Review-Url: https://codereview.chromium.org/2850533002
Cr-Commit-Position: refs/heads/master@{#467932}

We check the content's MIME type. If it is not meant for HTML page,we
route to DownloadManager.

BUG=673635

Review-Url: https://codereview.chromium.org/2841823004
Cr-Commit-Position: refs/heads/master@{#467931}

Simple improvements to make the throttle work in a more expected way.
- Calling any method to update the underlying contents of the throttle
will allow the all queued updates to flush.
- Calling updates infrequently will not queue.  Instead we track the
time since the last update and don't queue if the time has been long
enough.
- Hook the throttle into the JNI bridge for the Android
OfflineContentProvider.

BUG=715669

Review-Url: https://codereview.chromium.org/2835323005
Cr-Commit-Position: refs/heads/master@{#467930}

In Java persisting the ContentId required it to be a guid.  This removes
that dependency.  Note that legacy downloads still have their own checks
for requiring the id to be a guid, but if the download isn't associated
with a legacy download the checks should not occur.

BUG=691805

Review-Url: https://codereview.chromium.org/2843073002
Cr-Commit-Position: refs/heads/master@{#467929}

Update the comment with spec link
http://www.ecma-international.org/ecma-262/6.0/#sec-arraybuffer-constructor

BUG=701391

Review-Url: https://codereview.chromium.org/2847873003
Cr-Commit-Position: refs/heads/master@{#467928}

This is a speculative attempt to fight memory regression after
recent overlay refactoring. I suspect that InspectorOverlayAgent
is retained either by InspectorOverlayHost or InspectorPageOverlayDelegate.

This patch tries to clean them up in Dispose and ensure that
nothing will be created after that point (disposed_ field).

BUG=715266

Review-Url: https://codereview.chromium.org/2850623002
Cr-Commit-Position: refs/heads/master@{#467927}

TEST=run_compiler
BUG=636289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2852633003
Cr-Commit-Position: refs/heads/master@{#467926}

WebContents might not be loaded in some case, i.e. tab switcher.
We need to check for that.

BUG=715751

Review-Url: https://codereview.chromium.org/2847863003
Cr-Commit-Position: refs/heads/master@{#467925}

R16_EXT is supported on desktop core profile (OSX and Linux), and via
OpenGL ES 3.1 GL_EXT_texture_norm16 extension (including ANGLE on Windows).

Update khronos headers to get GL_R16_EXT definition.

It is not exposed through WebGL but only used internally.

Brings significant performance improvement, cutting the time spent on
WebGL TexImage2D from ~1.2ms to ~0.2ms - see https://crbug.com/624436.

BUG=624436
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2767063002
Cr-Commit-Position: refs/heads/master@{#467924}

BUG=716118
R=eugenis@chromium.org

Review-Url: https://codereview.chromium.org/2851493005
Cr-Commit-Position: refs/heads/master@{#467923}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/47389137..f20a4f79

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2843173004
Cr-Commit-Position: refs/heads/master@{#467922}

Revert of Build browser tests on all gpu release bots (patchset #1 id:1 of https://codereview.chromium.org/2841833003/ )

Reason for revert:
I don't think this CL is still needed after my fix for crbug.com/714976.

Original issue's description:
> Build browser tests on all gpu release bots
>
> Work-around as browser_tests are erroneously not rebuilt properly on
> gpu bots.
>
> BUG=chromium:714976
> TBR=kbr@chromium.org,fjhenigman@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> NOTRY=true
>
> Review-Url: https://codereview.chromium.org/2841833003
> Cr-Commit-Position: refs/heads/master@{#467292}
> Committed: https://chromium.googlesource.com/chromium/src/+/1d0ceecfb8153cce088d62bf28d9c94c6601de91

TBR=fjhenigman@chromium.org,kbr@chromium.org,hablich@chromium.org,phajdan.jr@chromium.org,machenbach@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:714976

Review-Url: https://codereview.chromium.org/2846883004
Cr-Commit-Position: refs/heads/master@{#467921}

Peek() always takes a reference to an existing slot in a table. Therefore,
Peek() does not take a nullptr_t value, since nullptr_t is not stored in
the backing buffer.

BUG=715430
R=tzik@chromium.org

Review-Url: https://codereview.chromium.org/2844583004
Cr-Commit-Position: refs/heads/master@{#467920}

Intent to remove: https://groups.google.com/a/chromium.org/d/msg/Blink-dev/ZD3NWqkk-bo/1txGi7hiBgAJ
Spec: https://w3c.github.io/webcrypto/Overview.html#crypto-interface

BUG=641526

Review-Url: https://codereview.chromium.org/2838603002
Cr-Commit-Position: refs/heads/master@{#467919}

BUG=687375

Review-Url: https://codereview.chromium.org/2844103002
Cr-Commit-Position: refs/heads/master@{#467918}

There were circular deps between file_manager_commands and file_manager.
This change removes dependency from file_manager_commands to
file_manager by extracting an interface from FileManager needed for
file_manager_commands to compile.
Also inlined some simple methods in FileManager, which are used
only from file_manager_commands.

BUG=636289
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2846163002
Cr-Commit-Position: refs/heads/master@{#467917}

BUG=703848
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2811643002
Cr-Commit-Position: refs/heads/master@{#467916}

CMAA will be triggered by every readPixels call, even content does not be  changed or committed.

BUG=535198

TEST=conformance/readinging/fbo-remains-unchanged-after-read-pixels.html

Review-Url: https://codereview.chromium.org/2597933002
Cr-Commit-Position: refs/heads/master@{#467915}

This code was used in our old BLE protocol, which is now obsolete.

Review-Url: https://codereview.chromium.org/2843443003
Cr-Commit-Position: refs/heads/master@{#467914}

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2852573002
Cr-Commit-Position: refs/heads/master@{#467913}

- Removed dependency from file_transfor_controller to CommandHandler by
registering the needed function from FileManager to
FileTransferController as a constructor parameter.
- Added drop_effect_and_label to compile target.

BUG=636289
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2830223003
Cr-Commit-Position: refs/heads/master@{#467912}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/9c9ac13a2b02..778079b344c8

$ git log 9c9ac13a2..778079b34 --date=short --no-merges --format='%ad %ae %s'
2017-04-27 cywang [shared_page_state] Fix unit test

Created with:
  roll-dep src/third_party/catapult
BUG=714803


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ic1b8f579e35bc46cd6673b97b780404f11552abc
Reviewed-on: https://chromium-review.googlesource.com/489669
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467911}

Using UpdateUIState() is insufficient because it does not have the
mechanism to change 'add button disabled' state back to 'not disabled'. We
should explicitly call UpdateAddButtonStatus().

BUG=411618

Review-Url: https://codereview.chromium.org/2850723002
Cr-Commit-Position: refs/heads/master@{#467910}

This is a follow up from https://codereview.chromium.org/2807073002

This patch removed a generated instance of a PassRefPtr object being
copied into a RefPtr object.

All instances of PassRefPtr objects being copied into RefPtr objects
need to be wrapped in std::move to avoid introducing ref churn in
future changes when all PassRefPtr objects will be replaced with RefPtr
objects. In this case creating a local RefPtr just to copy the
PassRefPtr argument into, a std::move wrap doesn't make sense as it
would result in a final state where a RefPtr argument is moved into a
local RefPtr for no reason. So to handle this cases I have converted
the PassRefPtr argument to RefPtr in advance, and removed the local
RefPtr argument, instead using the passed RefPtr in the
method.

This patch
- Changed the argument passed from PassRefPtr to RefPtr
- Removed the logic for creating a local RefPtr argument
- Changed the naming logic to name RefPtr arguments as rpParamTypeName
- Removed the self.value variable and used self.name instead, as
  self.value was only used to store the name of the local RefPtr
  variable separate from the PassRefPtr argument
- Removed the comment in the header about PassRefPtr parameters
- Removed the base_name variable in build_param_name as this was
  causing a presubmit error from clashing with the global base_name

Changes to generated files:
https://gist.github.com/BugsNash/595ec7b86ce850d676aa8722f68abbf8/revisions

BUG=494719

Review-Url: https://codereview.chromium.org/2846723003
Cr-Commit-Position: refs/heads/master@{#467909}

This is split from https://codereview.chromium.org/2840523002/

This CL introduces "pending tasks struct" concept defined in the Worklet spec:
https://drafts.css-houdini.org/worklets/#pending-tasks-struct

The pending tasks struct is used as a kind of barrier closure: when
Worklet::addModule() is called, multiple WorkletGlobalScopes associated with the
Worklet may start module loading. The struct waits until they all are completed
and then resolves a promise. If one of them is failed, the struct immediately
rejects a promise and ignores following completions.

This CL also removes WorkletObjectProxy and the request id mechanism in
MainThreadWorklet using the pending tasks struct.

BUG=627945

Review-Url: https://codereview.chromium.org/2839123003
Cr-Commit-Position: refs/heads/master@{#467908}

To align with the spec, and also this is needed for inline module
scripts because NotifyNewSingleModuleFinished() is not called for
inline scripts.

This CL also makes DummyModulator to ignore RegisterModuleScript()
calls where it is not tested explcitly, because this CL makes
an additional RegisterModuleScript() call for CreateForTest() which is
not coupled with NotifyNewSingleModuleFinished().

This CL doesn't change the non-test behavior, because in the non-test
code ModuleScript::Create() is always coupled with
NotifyNewSingleModuleFinished() and thus this CL just makes
RegisterModuleScript() a little earlier.

BUG=594639, 715369

Review-Url: https://codereview.chromium.org/2850673002
Cr-Commit-Position: refs/heads/master@{#467907}

They are not used by anyone.

BUG=None

Review-Url: https://codereview.chromium.org/2846793002
Cr-Commit-Position: refs/heads/master@{#467906}

In Source/web/ there are many cyclic dependencies. These cycles make it very
difficult to discretely move class implementation from web/ to either core/ or
modules/.

An example cycle is WebViewImpl and WebLocalFrameImpl. Each refer to the other,
rather than the least derived types of WebView and WebLocalFrame (or WebFrame).
It is impossible to use the least derived type as methods have been added to the
*Impl class definitions that are consumed by other classes in Source/web.

To break the cycle we introduce the class WebViewBase, so that the inheritance
hierarchy is now WebView <- WebViewBase <- WebViewImpl (<- = implements).

Methods that were defined in WebViewImpl are made pure virtual in WebViewBase,
and now classes that were taking a dependency on WebViewImpl instead now take a
dependency on WebViewBase. This breaks the dependency chain and allows us to
start moving these classes out of Source/web into new homes in modules or core.
Note: WebViewBase is defined in core/exported/WebViewBase.h as is implements
public/web/WebView.h. Once this refactoring is complete WebViewBase will be
removed and these changes effectively reverted.

This CL moves the first portion of classes to use WebViewBase rather than
WebViewImpl, a followup CL will complete this move.

BUG=712963

Review-Url: https://codereview.chromium.org/2848513002
Cr-Commit-Position: refs/heads/master@{#467905}

Review-Url: https://codereview.chromium.org/2844253002
Cr-Commit-Position: refs/heads/master@{#467904}

The "Open" button was calling SendBannerAccepted, which made the
assumption that the app was being installed. Removed this call and
documented the method's semantics.

BUG=716313

Review-Url: https://codereview.chromium.org/2848703005
Cr-Commit-Position: refs/heads/master@{#467903}

Updates of message, proxy and agent are needed to forward capturer id to the
network process and eventually to the client.

BUG=chromium:679523, chromium:650926

Review-Url: https://codereview.chromium.org/2848753002
Cr-Commit-Position: refs/heads/master@{#467902}