- 26 Jun, 2020 40 commits
-
-
Mike Dougherty authored
Use proper compile guard to check for building with Xcode 12. Bug: None Change-Id: I782c101380565ca87b82bf574492422a57d70b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269763 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#782888}
-
Takashi Sakamoto authored
Use the first 16bytes region of the allocated memory for tag. So both data region, and PartitionCookie region will be moved by +16bytes. This behavior is disabled behind ENABLE_CHECKED_PTR. Change-Id: I09a0241f61ca1b186b239097601ea498f6d9f00c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263417 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#782887}
-
Koji Ishii authored
This patch renames a few functions for the consistency: - IsVisibleToHitTest - FragmentVisibleToHitTestRequest - VisibleToHitTestRequest The last one is a sipmle shorthand that doesn't help to save much. Removed to clarify which fragment it tests. This patch has no behavior changes, in preparation to adjust the hit-test conditions for <crbug.com/1007900>. Bug: 1007900 Change-Id: If2718ffb862253aebbff582a153d819b98424192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269818 Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#782886}
-
Kent Tamura authored
Bug: 1040826, 1061823 Change-Id: I987fb8b9a55cb6ef3e99047f92ed04ec789c259e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269620 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/6069b8345ecb..89b8527eceaf 2020-06-26 thestig@chromium.org Remove Mac-specific includes from fx_system.h. 2020-06-26 thestig@chromium.org Remove unused header from fx_system.h. 2020-06-25 thestig@chromium.org Clean up star drawing code. 2020-06-25 tsepez@chromium.org Dismiss exceptions while setting properties/elements from JS handlers. 2020-06-25 vmiklos@collabora.co.uk Add FPDF_GetSignatureCount() API 2020-06-25 thestig@chromium.org Do one assignment per line in CXFA_Rectangle. 2020-06-25 thestig@chromium.org Fix some nits in string tests. 2020-06-25 thestig@chromium.org Test invalid arguments for some FPDFLink_* APIs. 2020-06-25 thestig@chromium.org Remove PRIuS define from fx_system.h. 2020-06-25 thestig@chromium.org Get rid of _FX_PLATFORM_APPLE_. 2020-06-25 thestig@chromium.org Get rid of _FX_PLATFORM_WINDOWS_. 2020-06-25 thestig@chromium.org Split tiling pattern rendering code into its own file. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1098213 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I73703255550202f21093b55c1b8e91875791dd78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269838 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782884}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1b047a2d37d8..82270c608217 2020-06-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2ab50cb522eb8774c1a8df065aa264aee99b18e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269735Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593129542-eae571d99fb364561b81bf0410208d0db84ed4e4.profdata to chrome-mac-master-1593151085-57fe35f0746eacbd2632836a414f4d24425341a7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I2a3e107a81e3db5a918c9a1fd0dc478e5975fbf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269736Reviewed-by:
-
Hitoshi Yoshida authored
This CL fixes following two compile errors in new code generator. - v8::Null() returns Local<v8::Primitive>, and the conditional operator (A?B:C) requires return values to have the same type. - Returning a value parameter in a function assumes to call std::move() implicitly as the first candidate. Thus explicit call of std::move() is redundant. https://en.cppreference.com/w/cpp/language/return Bug: 839389 Change-Id: I92aef911d7764033222797a41a8e24669fe98e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269601 Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#782881}
-
Eero Häkkinen authored
This is a reland of 6536130a with restored DirectShow device filter creation logic in VideoCaptureDeviceFactoryWin. The logic was unintentionally changed by https://chromium-review.googlesource.com/c/chromium/src/+/2247797. Original change's description: > [PTZ] Add mocking points to VideoCaptureDeviceFactoryWin > > This CL refactors video capture device creation on Windows, removes some > code duplications related to DirectShow device enumeration and adds > mocking points for unit testing. This CL has no functional changes. > > Bug: 934063 > Change-Id: I2df08b3a361ffd702761bd9d6b400f4418390c99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247797 > Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> > Auto-Submit: Eero Häkkinen <eero.hakkinen@intel.com> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781357} Bug: 934063, 1098633 Change-Id: I0456912298eb538fbf51ec2fd92b561e71f843e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263812Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Cr-Commit-Position: refs/heads/master@{#782880}
-
My Nguyen authored
This CL connects SetAutocorrectRange API in https://crrev.com/c/2230404 to the implementation in blink in https://crrev.com/c/2249405 Bug: 1096212, 1091088 Change-Id: Ifb7eeec29b00bce2740ab902af3a69094930ba8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255927Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#782879}
-
charleszhao authored
Bug: 1072547 Change-Id: Iab8bc626086e75c832426ccdb3ccd6a5adf0b8f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268758Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#782878}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5eb778ad40e1..7be9918fef15 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC meredithl@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: meredithl@google.com Change-Id: Ia1b5743bb011a8e06ede8f72fe1f9c8a3358ad57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269724Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782877}
-
Jimmy Gong authored
- Includes cancel print job and clear all button. - Update delete icon in the clear all button to reflect the enabled or disabled state. - Also fixes a bug where the color of the clear all button text did not represent the button's disabled state. Bug: 1055841 Change-Id: Ibdecc4057824e41946ad355eda71b9e267250dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265419 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#782876}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7dda50943c49e71a9073ff14637792a90f35f929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269732Reviewed-by:
-
Victor Hugo Vianna Silva authored
This CL adds missing flush() calls to the tests, especially after calls to setIsOptedInForAccountStorageAndNotify(). It also removes unnecessary calls from other sites, as well as fixes a build dependency for chrome/test/data/webui/settings/passwords_and_autofill_fake_data.js. Bug: 1090931 Change-Id: I53e152a2aa7655c1961b638d3e3d9095504588fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267038Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#782874}
-
Mario Sanchez Prada authored
By the time that an AXTreeData structure is received in the browser process after being sent from a renderer, we should already be able to retrieve the AXTreeID of its parent AXTreeData just by navigating the frame tree, that is, by calling GetAXTreeID() over the parent RFHI of the RFHI that received the message in the browser process. Thus, we can remove the code in BlinkAXTreeSource setting the parent frame's routingID along with the code in RFHI that would translate it into the AXTreeID of the parent AXTreeData, simplifying the code and helping towards the goal of using the EmbeddingToken as AXTreeID by removing one more piece in the renderer what would otherwise need to be migrated as well. Last, this adds a new private method RFHI::ResolveAXParentTreeID() in preparation for the future removal of AXContentTreeDataToAXTreeData(), which is where the |parent_tree_id| was currently being set until now. Bug: 1094150 Change-Id: I5e1d204e1d30d29c6bde952846195779694aa111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254025 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#782873}
-
Maksim Sisov authored
Currently, Ozone/X11 defines gfx::AcceleratedWidget as int32_t whereas non-Ozone/X11 defines that as x11::Window or uint32_t. To fix the inconsistency and allow use_x11 && use_ozone builds, make non-Ozone/X11 uses Ozone's definition of gfx::AcceleratedWidget. Also adds missing includes. Bug: 1098267 Change-Id: If9e98dd440c5d077990e390a0a10855723676b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260554Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#782872}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I2599d76d6ec898d26429d8dfd6323e01f9c49911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269479Reviewed-by:
-
Christopher Cameron authored
SkiaOutputDeviceBufferQueue currently holds the assumption that there always exists a primary plane. It may be that a frame's damage won't change that plane's contents, but the plane will always be there. On macOS, this is not the case. Frames will alternate between having only the primary plane (when not all content can be represented as a CALayer tree) and having no primary plane (when all content is represented by the overlay CALayer tree). Inform SkiaOutputDeviceBufferQueue when there is no primary plane for the current frame, by making the call to SchedulePrimaryPlane be unconditional, but with a base::Optional argument. The functions SwapBuffers, PostSubBuffer, and CommitOverlayPlanes are responsible for updating SkiaOutputDeviceBufferQueue::current_image_ and submitted_image_. Add an if-case for those functions when there no primary plane was scheduled. Update OverlayProcessorMac to always report full damage to the SurfaceAggregator. All quads are needed, every frame, to construct the CALayer tree. Bug: 894929 Change-Id: Id67f58eeb22a0e92f050f37be900bd6cfa5a7845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268478 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#782870}
-
Xiyuan Xia authored
Replace FpsCounter with ThroughputTracker for overview metrics. Bug: 1021774 Change-Id: I4ae1dcf01ba092d55a46aa2d4d9f6c7ce3a9534f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264939 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#782869}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I664f8326da545e6ff69fa9e43ee44b8846d5c149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269760Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6ee18c2d01f6..c81da1c809fe 2020-06-26 syoussefi@chromium.org Vulkan: Avoid double-copy when generating mipmap If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I4a7f7cc9ed730387e9b44ea244a422a4880670de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269717Reviewed-by:
-
Hajime Hoshi authored
Change-Id: Ic329268bc74bd59a9bd52211563d24613202aa85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266412Reviewed-by:
-
David Bertoni authored
This test is no longer flaky. Any failures are infra/bot issues not related to this test. Bug: 1035620 Change-Id: I5bd4ddb0c4f870523d709fd1a93d0ee82459ecf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265098Reviewed-by:
Archana Simha <archanasimha@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#782865}
-
Xiyuan Xia authored
Bug: 1021774 Change-Id: I3e725eba1e129980470b1d361791d4eee099b682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266902Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#782864}
-
Yuki Yamada authored
NewLinkedHashSet needs to support HeapNewLinkedHashSet<WeakMember> to replace previous implementation LinkedHashSet by itself. The main points of this CL are: 1. Register custom weak callback in VectorBackedLinkedList to remove nodes which have reference to dead objects 2. Make iterator of NewLinkedHashSet have reference to HashMap value_to_index_ to strongify stored WeakMembers if there is an iterator Related tests: third_party/blink/renderer/platform/wtf/linked_hash_set_test.cc third_party/blink/renderer/platform/heap/test/heap_test.cc third_party/blink/renderer/platform/heap/test/incremental_marking_test.cc third_party/blink/renderer/platform/heap/test/weakness_marking_test.cc Rough note: https://docs.google.com/document/d/1zEr-V1zZC1I5kGyNbi1toCCDQlqdNh4vrwkHx8qsL34/edit?usp=sharing Bug: 1095525 Change-Id: Ic3a71aa45dccbd3ac276d21b43fcb2498320e8e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246014 Commit-Queue: Yuki Yamada <yukiy@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Ramin Halavati authored
BrowsingHistoryBridge is updated to receive profile object instead of |isIncognito| boolean, so that it would be properly initialized for all OffTheRecord profiles. Bug: 1060940 Change-Id: I1700ca45c08f6df8298d2456ebc774b2c80140e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260692Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#782862}
-
Mikel Astiz authored
There is no actual pre-USS datatype running and the code related to syncable::Directory is dead. Some of these concepts had leaked into higher layers in sync/driver, so this patch deletes them prior to deleting the functionality within the sync engine. In order to achieve this, SyncManagerImpl now takes ownership of UserShare and NigoriHandler, but this should cause no behavioral differences. Change-Id: I56f7f325f87206b985c064bb1c5e97acb7b05980 Bug: 923287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264432 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#782861}
-
My Nguyen authored
Implement according to spec at http://go/e14s-emoji-addition-mock Pressing down will still move to the next candidate, pressing number after that will accept the number emoji. Bug: 1098692 Change-Id: Iad1cd39efa0f2ed5ccfad875b8018058cc3d63ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263692 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#782860}
-
Francois Beaufort authored
This CL makes sure pan, tilt, and zoom constraints set in getUserMedia are applied when internal image capture is created. This allows web developers to set pan, tilt, zoom at the creation of the video track. Change-Id: I7e6a747b24ffa27aaa266f900406bb1f81abf966 Bug: 934063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254280 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Charlie Reis authored
This CL revises navigation.md and splits out navigation_concepts.md for describing several concepts that are important for understanding the navigation logic. BUG=1015882 Change-Id: I0397d2906aec9c24a658d96cf67123dc6bd7c3af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225745 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#782858}
-
John Delaney authored
What: Add an origin trial config for the Conversion Measurement API. This separates the base::Feature kConversionMeasurement from the runtime enabled feature. This allows the conversion storage layer to be setup without enabling the features in blink. The storage layer needs to be setup for all users regardless of the OT so that reports for conversions can be sent when the user is no longer on the site. This also moves the ConversionMeasurement runtime feature to experimental, and updates the about flags description to account for this. Change-Id: I534b6726b80146e90123b3116158d79872c00e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264767 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Charlie Reis authored
This CL adds special_case_urls.md to explain some of the interesting or unexpected corner cases that can occur for certain types of URLs, which may affect how other features are designed and implemented. BUG=1015882 Change-Id: I311d1c4c5b4962dba8b842c20200c344eacb46d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225374 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
-
Saho Kobayashi authored
Send kAriaAttributeChanged event when state description change is sent from non range widget. AXTreeSourceArcTest.StateDescriptionChangedEvent Bug: b:154433831 Test: ArcAccessibilityUtilTest.FromContentChangeTypesToAXEvent Change-Id: I676dda6d6322375db2286510ab4759a5f4bc2fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262159 Commit-Queue: Saho Kobayashi <sahok@chromium.org> Reviewed-by:Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#782855}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c55849a7826f..1b047a2d37d8 2020-06-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic5e0122d1e1a1e413f8cb286b068ef703d1a7604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269720Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/f318b72e2035..a926fdc3321e 2020-06-26 jophba@chromium.org Disable certificate utils unittests in Chrome 2020-06-26 jophba@chromium.org [Hotfix] Fix presubmit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1098562 Tbr: jophba@chromium.org Change-Id: I7df19c29290ce11549a28f316623a0572bba9f2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269719Reviewed-by:
-
My Nguyen authored
This is described in http://go/e14s-emoji-addition-mock for emoji and http://go/personal-info-suggestion-mock for personal info suggestion. Bug: 1098057 Change-Id: Idb66d47db2f60c9da7344fffc68ab771c981a80e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257659Reviewed-by:
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: I74d024362f09a2a3878ed6b6278c5a8b356b9c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257402Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#782851}
-
Julie Jeongeun Kim authored
This CL removes RenderWidgetHostOwnerDelegate::GetFocusedFrame and GetFocusedFrame from RenderViewHostImpl inherited from RenderWidgetHostOwnerDelegate since it could get the FrameTree from RenderWidgetHostDelegate::GetFrameTree() introduced on [1]. [1] https://crrev.com/c/2245450 Bug: 1094841 Change-Id: I7c427942d4ce2b93cde70ed19946d7411799cc85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253598 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This CL converts PrerenderMsg_SetIsPrerendering to ChromeRenderFrame Mojo message, and pass the message to chromePluginPlaceholder from ChromeRenderFrameObserver via PrerenderObserver. Bug: 798712 Change-Id: Id84240d8f16fc811df56fc05a734a4ee539c2a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246015Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#782849}
-
